--- Day changed Mon Dec 07 2020 00:27 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 00:28 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 246 seconds] 01:04 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 02:34 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has joined #bitcoin-core-pr-reviews 02:44 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 02:46 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-pr-reviews 03:01 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 03:18 -!- Gladyce34Stanton [~Gladyce34@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:23 -!- Gladyce34Stanton [~Gladyce34@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 260 seconds] 03:25 -!- joelklabo [~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net] has quit [Read error: Connection reset by peer] 03:28 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has joined #bitcoin-core-pr-reviews 03:48 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 03:50 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has joined #bitcoin-core-pr-reviews 05:02 -!- prayank [~andr0irc@2409:4053:2e13:900f:d41e:b11b:ed95:2493] has quit [Ping timeout: 260 seconds] 05:04 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-yslbdkfqtjhgwjcu] has quit [Ping timeout: 264 seconds] 05:05 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-ulqcremawialdixq] has joined #bitcoin-core-pr-reviews 05:26 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer] 05:28 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-pr-reviews 05:34 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer] 05:34 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-pr-reviews 05:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 05:35 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 05:35 -!- vasild_ is now known as vasild 05:37 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has quit [Quit: ZNC - http://znc.in] 05:40 -!- prayank [~andr0irc@2409:4053:2e13:900f:d41e:b11b:ed95:2493] has joined #bitcoin-core-pr-reviews 05:43 -!- prayank [~andr0irc@2409:4053:2e13:900f:d41e:b11b:ed95:2493] has quit [Read error: Connection reset by peer] 05:53 -!- prayank [~andr0irc@2409:4053:2e13:900f:d41e:b11b:ed95:2493] has joined #bitcoin-core-pr-reviews 05:55 < michaelfolkson> Some clarifications courtesy of harding on CLEANSTACK and script execution if anyone was confused (like me) after Wednesday's PR review club https://bitcoin.stackexchange.com/questions/100413/for-a-redeem-script-to-satisfy-the-conditions-of-a-script-what-must-it-leave-on 05:58 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 06:44 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has joined #bitcoin-core-pr-reviews 07:17 -!- prayank [~andr0irc@2409:4053:2e13:900f:d41e:b11b:ed95:2493] has quit [Remote host closed the connection] 07:18 -!- prayank [~andr0irc@2409:4053:2e13:900f:d41e:b11b:ed95:2493] has joined #bitcoin-core-pr-reviews 07:38 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:42 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 08:06 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 08:09 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 08:13 -!- belcher_ is now known as belcher 08:45 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 08:47 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 272 seconds] 08:55 -!- belcher_ is now known as belcher 09:15 < pinheadmz> i need a dummy check on something: if i create a 1in/1out tx and sign SIGHASHSINGLE -- does that mean anyone (miners) can add additional outputs to that TX? Of course they would only be able divert a portion of the miner fee leftover from the original in/out value difference but still ...? 09:22 -!- glozow [uid453516@gateway/web/irccloud.com/x-ismhzanbxqycgvwi] has joined #bitcoin-core-pr-reviews 09:48 < wumpus> pinheadmz: that's an interesting question, i don't know why it wouldn't be possible to add another output, the inputs cross-sign each other (except sequence number) and their corresponding output; but if there's more outputs than inputs, it seems no input covers them 09:50 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 09:51 < pinheadmz> except sequence number ? 09:53 < wumpus> yes, it's set to 0 before signing https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L1331 09:54 < pinheadmz> oh just for single? huh TIL... what is the purpose of that ? does that have to do with whatever satoshi thought sequence would be useable for > 09:54 < pinheadmz> ? 09:58 < sipa> probably 10:00 < pinheadmz> so if i create a tx with 2 inputs, and i sign the input 0 with SINGLE, I can still change the sequence of input 1 without invalidating that signature. But of course cannot change the prevout (unless ANYONECANPAY is also set) 10:12 -!- prayank [~andr0irc@2409:4053:2e13:900f:d41e:b11b:ed95:2493] has quit [Ping timeout: 260 seconds] 10:13 -!- ja [janus@anubis.0x90.dk] has joined #bitcoin-core-pr-reviews 10:14 < ja> dhruvm: the two last links on https://bitcoincore.reviews/20477 are broken 10:19 < jnewbery> ja: thanks! I'll fix up those links. The author force-pushed to the PR branch, which is what broke the links. 10:19 < jonatack> ja: thanks for the warning. those links need to be updated after the force push. 10:42 < jnewbery> ja: fixed! 10:57 < jonatack> tested ack, thanks! 11:43 -!- jonasschnelli [~jonasschn@static.239.36.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 12:05 -!- jonasschnelli [~jonasschn@static.239.36.216.95.clients.your-server.de] has quit [Changing host] 12:05 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has joined #bitcoin-core-pr-reviews 12:08 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has quit [Quit: ZNC - http://znc.in] 12:09 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has joined #bitcoin-core-pr-reviews 12:09 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has quit [Remote host closed the connection] 12:09 -!- jonasschnelli [~jonasschn@static.239.36.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 12:09 -!- jonasschnelli [~jonasschn@static.239.36.216.95.clients.your-server.de] has quit [Remote host closed the connection] 12:10 -!- jonasschnelli [~jonasschn@static.239.36.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 12:11 -!- jonasschnelli [~jonasschn@static.239.36.216.95.clients.your-server.de] has quit [Changing host] 12:11 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has joined #bitcoin-core-pr-reviews 12:12 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:16 -!- davterra [~davterra@static-198-54-131-92.cust.tzulo.com] has quit [Remote host closed the connection] 12:20 -!- davterra [~davterra@static-198-54-131-92.cust.tzulo.com] has joined #bitcoin-core-pr-reviews 14:02 -!- Netsplit *.net <-> *.split quits: jesseposner, midnight, dergoegge, awesome_doge 14:23 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #bitcoin-core-pr-reviews 14:30 -!- dergoegge [sid453889@gateway/web/irccloud.com/x-cpuxjdlyceersvau] has joined #bitcoin-core-pr-reviews 14:30 -!- jesseposner [~jp@2601:643:8980:bfd2:1401:d5c:a187:3181] has joined #bitcoin-core-pr-reviews 14:33 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-witaeypfsoxnjlkc] has joined #bitcoin-core-pr-reviews 15:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 16:03 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 16:15 -!- jonatack [~jon@213.152.161.170] has quit [Quit: jonatack] 16:16 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 16:17 -!- seven_ [~seven@cpe-90-157-197-248.static.amis.net] has quit [Ping timeout: 272 seconds] 16:18 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-pr-reviews 16:27 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 16:27 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 17:17 -!- glozow [uid453516@gateway/web/irccloud.com/x-ismhzanbxqycgvwi] has quit [Quit: Connection closed for inactivity] 17:24 -!- tryphe_ is now known as tryphe 17:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 17:35 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 17:35 -!- vasild_ is now known as vasild 18:00 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 18:00 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 18:08 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has quit [Quit: ZNC - http://znc.in] 18:10 -!- jonasschnelli [~jonasschn@2a01:4f9:2a:2510::2] has joined #bitcoin-core-pr-reviews 18:19 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:54a5:5132:6498:c2e9] has joined #bitcoin-core-pr-reviews 18:48 -!- davterra [~davterra@static-198-54-131-92.cust.tzulo.com] has quit [Quit: Leaving] 20:28 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 20:28 -!- davterra [~davterra@static-198-54-131-124.cust.tzulo.com] has joined #bitcoin-core-pr-reviews 20:30 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds] 21:01 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:54a5:5132:6498:c2e9] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:23 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:54a5:5132:6498:c2e9] has joined #bitcoin-core-pr-reviews 22:32 -!- musdom [~Thunderbi@202.184.212.139] has joined #bitcoin-core-pr-reviews 23:22 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 256 seconds] 23:26 -!- jonasschnelli [~jonasschn@2a01:4f9:2a:2510::2] has quit [Changing host] 23:26 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has joined #bitcoin-core-pr-reviews 23:53 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 23:54 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 23:54 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 23:54 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews