--- Day changed Tue Dec 29 2020 00:06 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 00:06 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 03:18 -!- Earnestine36West [~Earnestin@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:23 -!- Earnestine36West [~Earnestin@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 246 seconds] 03:42 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 03:57 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 04:25 < michaelfolkson> How do you build the latest release candidate without the Taproot code? 04:27 -!- StallDown [7c94ad88@124-148-173-136.dyn.iinet.net.au] has joined #bitcoin-core-pr-reviews 04:27 < michaelfolkson> Or any branch that includes the Taproot code (but not build it with the Taproot code) for that matter 04:28 -!- StallDown [7c94ad88@124-148-173-136.dyn.iinet.net.au] has quit [Remote host closed the connection] 04:36 < jonatack> What is your goal (define "without")... maybe git checkout the commit before taproot was merged 04:38 < michaelfolkson> Looking at this https://github.com/bitcoin/bitcoin/pull/20354 04:39 < jonatack> (offhand i don't see an option when grepping ./configure -h) 04:40 < michaelfolkson> When Marco says "disabling the new consensus code at runtime" does he mean before this PR you'd disable it by git checkout(ing) the commit before Taproot was merged 04:40 < michaelfolkson> Or commenting out all Taproot code :) 04:41 < jonatack> oh, using the -vbparams config option 04:42 < jonatack> that's regtest-only: ./src/bitcoind -help-debug | grep -A2 vbparams 04:44 < michaelfolkson> That requires you to give a start and end time "for specified version bits deployment" 04:46 < jonatack> hm, putting that PR on my review list to understand it better 04:48 < michaelfolkson> It adds a feature_taproot.py --previous_release test but I don't understand how that test is triggered. Presumably this test is triggered when the consensus code is disabled at runtime 04:50 < michaelfolkson> But it is potentially disabled at runtime using -vbparams. Thanks 05:05 -!- jeremyrubin [~jr@2601:645:c200:14:346f:5d3:a503:bdf1] has quit [Ping timeout: 260 seconds] 05:22 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:f414:9b65:b890:9d87] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 05:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 05:36 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 05:36 -!- vasild_ is now known as vasild 05:47 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:f414:9b65:b890:9d87] has joined #bitcoin-core-pr-reviews 05:58 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:f414:9b65:b890:9d87] has quit [Ping timeout: 264 seconds] 06:09 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has quit [Ping timeout: 256 seconds] 06:26 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:750f:83e8:c56e:b09f] has joined #bitcoin-core-pr-reviews 06:34 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:750f:83e8:c56e:b09f] has quit [Ping timeout: 260 seconds] 07:04 -!- seven_ [~seven@cpe-90-157-197-248.static.amis.net] has joined #bitcoin-core-pr-reviews 07:05 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:750f:83e8:c56e:b09f] has joined #bitcoin-core-pr-reviews 07:19 -!- Dread2 [~dre@2.154.216.137.dyn.user.ono.com] has joined #bitcoin-core-pr-reviews 07:19 < Dread2> Verry good BitCoin Miner https://cryptotabbrowser.com/16879401 it pays 100% For Crypto Miners 07:28 < michaelfolkson> There is no Taproot code in the wallet currently. So why is the functional test feature_taproot.py skipped when compiling Core without the wallet? 07:44 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:750f:83e8:c56e:b09f] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:47 -!- jonatack [~jon@213.152.162.10] has quit [Quit: jonatack] 07:48 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:750f:83e8:c56e:b09f] has joined #bitcoin-core-pr-reviews 07:50 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-pr-reviews 07:50 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 07:50 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 07:57 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-pr-reviews 08:01 < MarcoFalke> because no one has rewritten the wallet parts to use the python MiniWallet 08:01 < MarcoFalke> See https://github.com/bitcoin/bitcoin/pull/20688 for an example on how to do that 08:03 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 256 seconds] 08:09 < michaelfolkson> Thanks for this ^ 08:10 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-pr-reviews 08:16 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 265 seconds] 08:17 -!- jonatack [~jon@213.152.161.30] has joined #bitcoin-core-pr-reviews 08:19 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:750f:83e8:c56e:b09f] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 09:03 -!- jeremyrubin [~jr@2601:645:c200:14:346f:5d3:a503:bdf1] has joined #bitcoin-core-pr-reviews 09:17 -!- pinheadmz [~pinheadmz@71.190.30.138] has quit [Ping timeout: 256 seconds] 09:21 -!- pinheadmz [~pinheadmz@68.161.139.178] has joined #bitcoin-core-pr-reviews 09:37 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 09:58 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has joined #bitcoin-core-pr-reviews 10:04 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 10:05 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 10:26 -!- jonatack [~jon@213.152.161.30] has quit [Quit: jonatack] 10:49 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-pr-reviews 10:54 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 260 seconds] 10:55 -!- jonatack [~jon@213.152.161.211] has joined #bitcoin-core-pr-reviews 11:01 -!- Dread2 [~dre@2.154.216.137.dyn.user.ono.com] has quit [Ping timeout: 260 seconds] 11:07 -!- pinheadmz [~pinheadmz@68.161.139.178] has quit [Read error: Connection reset by peer] 11:08 -!- pinheadmz [~pinheadmz@68.161.139.178] has joined #bitcoin-core-pr-reviews 11:19 -!- Dread2 [~dre@2.154.216.137.dyn.user.ono.com] has joined #bitcoin-core-pr-reviews 11:23 -!- Dread2 [~dre@2.154.216.137.dyn.user.ono.com] has quit [Ping timeout: 260 seconds] 11:42 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Quit: Leaving] 11:43 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 11:44 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 11:45 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 11:45 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 240 seconds] 11:45 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Ping timeout: 240 seconds] 11:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 11:57 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-pr-reviews 11:58 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 12:00 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:00 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 12:00 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Remote host closed the connection] 12:01 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-pr-reviews 12:02 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-pr-reviews 12:24 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Remote host closed the connection] 12:24 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-pr-reviews 12:33 -!- glozow [uid453516@gateway/web/irccloud.com/x-lmeqnzvygzjbdlnu] has joined #bitcoin-core-pr-reviews 12:57 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-pr-reviews 13:05 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has quit [Ping timeout: 246 seconds] 13:06 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has joined #bitcoin-core-pr-reviews 13:17 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 13:20 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 13:23 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 13:24 -!- jessepos_ [~jp@2601:645:200:162f:c9e2:a1fa:f83e:4f65] has joined #bitcoin-core-pr-reviews 13:27 -!- jesseposner [~jp@2601:645:200:162f:b96c:c368:5345:d4e5] has quit [Ping timeout: 264 seconds] 13:29 -!- felixweis [sid154231@gateway/web/irccloud.com/x-curwonbkjuaxtcmu] has quit [Ping timeout: 264 seconds] 13:29 -!- felixweis [sid154231@gateway/web/irccloud.com/x-jtweehemopgkzarw] has joined #bitcoin-core-pr-reviews 13:37 -!- duke7553 [49bef86b@c-73-190-248-107.hsd1.ga.comcast.net] has joined #bitcoin-core-pr-reviews 13:40 -!- duke7553 [49bef86b@c-73-190-248-107.hsd1.ga.comcast.net] has quit [Remote host closed the connection] 13:40 -!- FreeCake [~IceChat95@5.181.234.180] has joined #bitcoin-core-pr-reviews 13:40 -!- duke7553 [49bef86b@c-73-190-248-107.hsd1.ga.comcast.net] has joined #bitcoin-core-pr-reviews 13:42 -!- duke7553 [49bef86b@c-73-190-248-107.hsd1.ga.comcast.net] has quit [Remote host closed the connection] 13:42 -!- duke7553 [49bef86b@c-73-190-248-107.hsd1.ga.comcast.net] has joined #bitcoin-core-pr-reviews 13:43 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 13:44 -!- lukeb_ [~lukeb@2601:100:817f:1730:78ab:d45d:4c5b:f951] has joined #bitcoin-core-pr-reviews 13:47 -!- duke7553 [49bef86b@c-73-190-248-107.hsd1.ga.comcast.net] has quit [Remote host closed the connection] 13:47 -!- lukeb_ is now known as duke7553 13:50 -!- duke7553 [~lukeb@2601:100:817f:1730:78ab:d45d:4c5b:f951] has quit [Quit: Leaving] 13:50 -!- FreeCake [~IceChat95@5.181.234.180] has left #bitcoin-core-pr-reviews [] 13:51 -!- duke7553 [~lukeb@2601:100:817f:1730:78ab:d45d:4c5b:f951] has joined #bitcoin-core-pr-reviews 13:51 -!- duke7553 [~lukeb@2601:100:817f:1730:78ab:d45d:4c5b:f951] has quit [Client Quit] 14:38 -!- pinheadmz [~pinheadmz@68.161.139.178] has quit [Quit: pinheadmz] 16:01 -!- pinheadmz [~pinheadmz@68.161.139.178] has joined #bitcoin-core-pr-reviews 16:15 -!- pinheadmz [~pinheadmz@68.161.139.178] has quit [Quit: pinheadmz] 16:30 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:750f:83e8:c56e:b09f] has joined #bitcoin-core-pr-reviews 16:38 -!- pinheadmz [~pinheadmz@68.161.139.178] has joined #bitcoin-core-pr-reviews 16:53 -!- pinheadmz [~pinheadmz@68.161.139.178] has quit [Quit: pinheadmz] 17:18 -!- pinheadmz [~pinheadmz@68.161.139.178] has joined #bitcoin-core-pr-reviews 17:36 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 17:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 17:36 -!- vasild_ is now known as vasild 17:42 -!- joelklabo [~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 246 seconds] 17:48 -!- pinheadmz [~pinheadmz@68.161.139.178] has quit [Quit: pinheadmz] 18:06 -!- pinheadmz [~pinheadmz@68.161.139.178] has joined #bitcoin-core-pr-reviews 18:20 -!- glozow [uid453516@gateway/web/irccloud.com/x-lmeqnzvygzjbdlnu] has quit [Quit: Connection closed for inactivity] 18:28 -!- jeremyrubin [~jr@2601:645:c200:14:346f:5d3:a503:bdf1] has quit [Quit: Konversation terminated!] 18:41 -!- seven_ [~seven@cpe-90-157-197-248.static.amis.net] has quit [Ping timeout: 240 seconds] 19:07 -!- musdom [~Thunderbi@202.184.0.102] has quit [Ping timeout: 265 seconds] 20:18 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 20:19 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 20:19 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 20:20 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 20:23 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-pr-reviews 20:23 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 21:07 -!- rjected [~weechat-h@natp-128-119-202-13.wireless.umass.edu] has quit [Ping timeout: 272 seconds] 21:09 -!- rjected [~weechat-h@128.119.202.13] has joined #bitcoin-core-pr-reviews 21:50 -!- illlicit_ is now known as illest101 22:44 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-ulqcremawialdixq] has quit [Ping timeout: 260 seconds] 22:47 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-cfnxwtjlejejrkke] has joined #bitcoin-core-pr-reviews