--- Day changed Sat Feb 13 2021 00:29 -!- seven_ [~seven@cpe-90-157-197-248.static.amis.net] has joined #bitcoin-core-pr-reviews 00:34 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer] 00:38 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 00:47 -!- Netsplit *.net <-> *.split quits: m2020 00:49 -!- Netsplit *.net <-> *.split quits: willcl_ark, gwillen, schmidty, pierre_rochard, dergoegge, Landryl, MarcoFalke, valwal_, meshcollider, hebasto, (+14 more, use /NETSPLIT to show all of them) 00:52 -!- Netsplit over, joins: dburkett, schmidty, valwal_, dergoegge, queip, hebasto, jakesyl, nehan, gleb, pierre_rochard (+2 more) 00:52 -!- Netsplit over, joins: gwillen, willcl_ark, Zenton, dhruvm, Landryl, TheRec_ 00:52 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-rnsccjsdeotbttyd] has quit [Ping timeout: 244 seconds] 00:53 -!- queip [~queip@unaffiliated/rezurus] has quit [Max SendQ exceeded] 00:53 -!- jamesob [sid180710@gateway/web/irccloud.com/x-zrkgoizuznjfbmdh] has quit [Ping timeout: 264 seconds] 00:54 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-bcawxvbklvxyzwdd] has quit [Ping timeout: 265 seconds] 00:56 -!- jamesob [sid180710@gateway/web/irccloud.com/session] has joined #bitcoin-core-pr-reviews 00:56 -!- Netsplit over, joins: sanketcell, troygior1hev 00:56 -!- jamesob [sid180710@gateway/web/irccloud.com/session] has quit [Changing host] 00:56 -!- jamesob [sid180710@gateway/web/irccloud.com/x-pzwbgahsafxohxhq] has joined #bitcoin-core-pr-reviews 00:57 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-pr-reviews 01:00 -!- harrigan- [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 01:01 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-euyphuspntddllnf] has joined #bitcoin-core-pr-reviews 01:01 -!- thrasher` [~thrasher@173.209.42.7] has joined #bitcoin-core-pr-reviews 01:01 -!- MarcoFalke [~none@198.12.116.246] has joined #bitcoin-core-pr-reviews 01:02 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 240 seconds] 01:27 -!- sunon [duncandean@gateway/shell/matrix.org/x-hiokyglniptwtpoq] has joined #bitcoin-core-pr-reviews 01:34 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-ocblcwesgcklpyal] has joined #bitcoin-core-pr-reviews 01:34 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-oxastgasszlqmlqv] has joined #bitcoin-core-pr-reviews 01:42 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-oxastgasszlqmlqv] has quit [Ping timeout: 240 seconds] 01:43 -!- sunon [duncandean@gateway/shell/matrix.org/x-hiokyglniptwtpoq] has quit [Ping timeout: 244 seconds] 01:43 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-ocblcwesgcklpyal] has quit [Ping timeout: 258 seconds] 02:01 -!- harrigan- [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer] 02:03 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 02:25 -!- Mugisha [~Mugisha@154.70.198.175] has joined #bitcoin-core-pr-reviews 02:27 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 02:27 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 02:27 -!- vasild_ is now known as vasild 02:30 -!- rjected [~weechat-h@natp-128-119-202-10.wireless.umass.edu] has quit [Ping timeout: 246 seconds] 02:32 -!- rjected [~weechat-h@natp-128-119-202-10.wireless.umass.edu] has joined #bitcoin-core-pr-reviews 02:38 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-ygwwwiqyielnmezr] has joined #bitcoin-core-pr-reviews 02:41 -!- Mugisha [~Mugisha@154.70.198.175] has quit [Ping timeout: 240 seconds] 02:43 -!- m2020 [rm@4691.irradiated.haggis.org] has joined #bitcoin-core-pr-reviews 02:50 -!- sunon [duncandean@gateway/shell/matrix.org/x-lxqmglllgiducprb] has joined #bitcoin-core-pr-reviews 02:54 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-fbpgallnldigntmy] has joined #bitcoin-core-pr-reviews 03:11 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 03:20 -!- Mugisha [~Mugisha@154.70.198.176] has joined #bitcoin-core-pr-reviews 03:20 -!- Mugisha is now known as Guest37066 03:23 -!- Guest37066 [~Mugisha@154.70.198.176] has quit [Client Quit] 03:40 -!- jadi [~jadi@213.207.193.58] has joined #bitcoin-core-pr-reviews 03:46 -!- jadijadi [~jadi@213.207.193.58] has joined #bitcoin-core-pr-reviews 03:49 -!- jadi [~jadi@213.207.193.58] has quit [Ping timeout: 272 seconds] 04:48 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 05:13 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 268 seconds] 05:21 -!- jadijadi [~jadi@213.207.193.58] has quit [Read error: Connection reset by peer] 05:23 -!- jadi [~jadi@213.207.193.58] has joined #bitcoin-core-pr-reviews 05:27 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 05:33 -!- harrigan- [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 05:34 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 246 seconds] 06:04 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 06:04 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 06:09 < michaelfolkson> This is a good blog post on code review best practices https://medium.com/palantir/code-review-best-practices-19e02780015f 06:11 < michaelfolkson> Corporation orientated but I think a lot applies to open source too 06:13 -!- jonatack [~jon@37.164.198.87] has joined #bitcoin-core-pr-reviews 06:18 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 06:35 -!- jadi [~jadi@213.207.193.58] has quit [Remote host closed the connection] 06:41 < michaelfolkson> I'll try answering this before Wednesday if no one else does. sipa answers some of it earlier in this channel https://bitcoin.stackexchange.com/questions/102582/what-problem-set-is-the-minisketch-library-designed-for-what-is-it-currently-us 06:42 -!- musdom [~Thunderbi@202.184.0.102] has joined #bitcoin-core-pr-reviews 06:42 -!- musdom [~Thunderbi@202.184.0.102] has quit [Client Quit] 06:51 -!- jonatack [~jon@37.164.198.87] has quit [Read error: Connection reset by peer] 06:51 -!- jonatack [~jon@37.164.198.87] has joined #bitcoin-core-pr-reviews 07:32 -!- kcalvinalvin [~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com] has quit [Quit: ZNC 1.7.4 - https://znc.in] 07:33 -!- tralfaz [uid458765@gateway/web/irccloud.com/x-cimbsdwgmuaexqlf] has joined #bitcoin-core-pr-reviews 07:36 -!- kcalvinalvin [~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com] has joined #bitcoin-core-pr-reviews 08:08 -!- harrigan- [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer] 08:09 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 08:24 -!- jonatack [~jon@37.164.198.87] has quit [Ping timeout: 256 seconds] 08:27 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer] 08:29 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has joined #bitcoin-core-pr-reviews 08:33 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 08:38 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has quit [Ping timeout: 272 seconds] 08:41 -!- jonatack [~jon@37.164.198.87] has joined #bitcoin-core-pr-reviews 08:47 -!- jonatack [~jon@37.164.198.87] has quit [Ping timeout: 256 seconds] 08:47 -!- jonatack [~jon@37.164.198.87] has joined #bitcoin-core-pr-reviews 08:50 -!- kcalvinalvin [~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com] has quit [Quit: ZNC 1.7.4 - https://znc.in] 08:52 -!- kcalvinalvin [~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com] has joined #bitcoin-core-pr-reviews 09:23 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer] 09:26 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 09:32 -!- jadi [~jadi@178.131.153.237] has joined #bitcoin-core-pr-reviews 09:36 -!- jadi [~jadi@178.131.153.237] has quit [Ping timeout: 240 seconds] 10:41 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer] 10:42 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 11:16 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer] 11:20 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 11:53 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 11:54 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 12:27 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer] 12:32 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 12:33 -!- tralfaz [uid458765@gateway/web/irccloud.com/x-cimbsdwgmuaexqlf] has quit [Quit: Connection closed for inactivity] 12:37 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Quit: Leaving] 13:13 -!- jonatack_ [~jon@37.164.57.52] has joined #bitcoin-core-pr-reviews 13:16 -!- jonatack [~jon@37.164.198.87] has quit [Ping timeout: 256 seconds] 13:26 -!- prayank [~Prayank@2409:4053:10:1e6e:f4a9:ce50:495f:9508] has joined #bitcoin-core-pr-reviews 13:29 < prayank> Looking for some help. Where this this mentioned in the code that "labelled" change address will not remain a change address anymore? What should I search for? Also wanted to know the reason for doing this but even if I could find those lines it can help. 13:29 < prayank> Context: https://github.com/bitcoin/bitcoin/issues/20795#issuecomment-770267178 13:32 < prayank> wallet.cpp or it can be somewhere else too? 13:45 < prayank> I guess only "labelled" addresses belong to address book in bitcoin core wallet 13:47 < prayank> And according to Cwallet::IsChange, payment to a script that is ours, but is not in the address book is "change address" 14:24 -!- prayank1 [~Prayank@49.15.234.141] has joined #bitcoin-core-pr-reviews 14:25 -!- prayank1 [~Prayank@49.15.234.141] has left #bitcoin-core-pr-reviews [] 14:26 -!- prayank [~Prayank@2409:4053:10:1e6e:f4a9:ce50:495f:9508] has quit [Ping timeout: 264 seconds] 14:31 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 268 seconds] 14:31 -!- jonatack_ [~jon@37.164.57.52] has quit [Quit: jonatack_] 14:32 -!- jonatack [~jon@37.164.57.52] has joined #bitcoin-core-pr-reviews 14:32 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 14:48 -!- jonatack [~jon@37.164.57.52] has quit [Read error: Connection reset by peer] 14:48 -!- jonatack_ [~jon@37.164.57.52] has joined #bitcoin-core-pr-reviews 14:56 -!- jonatack_ [~jon@37.164.57.52] has quit [Read error: Connection reset by peer] 14:56 -!- jonatack__ [~jon@37.164.57.52] has joined #bitcoin-core-pr-reviews 14:59 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 15:03 -!- jonatack__ [~jon@37.164.57.52] has quit [Quit: jonatack__] 15:03 -!- jonatack [~jon@37.164.57.52] has joined #bitcoin-core-pr-reviews 15:09 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer] 15:10 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 15:34 -!- jonatack [~jon@37.164.57.52] has quit [Read error: Connection reset by peer] 15:36 -!- jonatack [~jon@37.164.57.52] has joined #bitcoin-core-pr-reviews 15:37 -!- jonatack [~jon@37.164.57.52] has quit [Read error: Connection reset by peer] 15:37 -!- jonatack_ [~jon@37.164.57.52] has joined #bitcoin-core-pr-reviews 15:42 -!- jonatack_ [~jon@37.164.57.52] has quit [Read error: Connection reset by peer] 15:43 -!- jonatack_ [~jon@37.164.57.52] has joined #bitcoin-core-pr-reviews 16:00 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Read error: Connection reset by peer] 16:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Write error: Connection reset by peer] 16:00 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Write error: Connection reset by peer] 16:00 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Read error: Connection reset by peer] 16:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Read error: Connection reset by peer] 16:04 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 16:05 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 16:06 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 16:06 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-pr-reviews 16:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 16:17 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 16:26 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 268 seconds] 16:27 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-pr-reviews 16:27 -!- jonatack__ [~jon@37.164.57.52] has joined #bitcoin-core-pr-reviews 16:28 -!- jonatack_ [~jon@37.164.57.52] has quit [Read error: Connection reset by peer] 16:28 -!- jonatack__ [~jon@37.164.57.52] has quit [Client Quit] 16:29 -!- jonatack [~jon@37.164.57.52] has joined #bitcoin-core-pr-reviews 16:39 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 16:49 -!- musdom [~Thunderbi@202.184.0.102] has joined #bitcoin-core-pr-reviews 17:50 -!- musdom1 [~Thunderbi@202.184.0.102] has joined #bitcoin-core-pr-reviews 17:52 -!- musdom [~Thunderbi@202.184.0.102] has quit [Ping timeout: 240 seconds] 17:52 -!- musdom1 is now known as musdom 17:58 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Read error: Connection reset by peer] 17:58 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 18:01 -!- musdom [~Thunderbi@202.184.0.102] has quit [Quit: musdom] 18:02 -!- musdom [~Thunderbi@202.184.0.102] has joined #bitcoin-core-pr-reviews 18:03 -!- musdom [~Thunderbi@202.184.0.102] has quit [Client Quit] 18:03 -!- musdom [~Thunderbi@202.184.0.102] has joined #bitcoin-core-pr-reviews 18:05 -!- musdom [~Thunderbi@202.184.0.102] has quit [Client Quit] 18:05 -!- musdom1 [~Thunderbi@202.184.0.102] has joined #bitcoin-core-pr-reviews 18:07 -!- musdom1 is now known as musdom 18:11 -!- musdom [~Thunderbi@202.184.0.102] has quit [Quit: musdom] 21:25 -!- jonatack [~jon@37.164.57.52] has quit [Ping timeout: 264 seconds] 22:49 -!- jadi [~jadi@178.131.153.237] has joined #bitcoin-core-pr-reviews