--- Day changed Thu Mar 11 2021 00:00 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has quit [Remote host closed the connection] 00:23 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 00:44 -!- jonatack [~jon@37.171.231.252] has joined #bitcoin-core-pr-reviews 01:28 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Quit: reboot to spoil a 104 days uptime] 01:31 -!- jonatack_ [~jon@37.164.238.119] has joined #bitcoin-core-pr-reviews 01:34 -!- jonatack [~jon@37.171.231.252] has quit [Ping timeout: 272 seconds] 01:36 -!- jonatack_ [~jon@37.164.238.119] has quit [Quit: jonatack_] 01:36 -!- jonatack [~jon@37.164.238.119] has joined #bitcoin-core-pr-reviews 02:01 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 02:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 02:27 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 260 seconds] 02:41 -!- ivanacostarubio [~ivan@189.172.199.173] has quit [Ping timeout: 276 seconds] 02:51 -!- jonatack [~jon@37.164.238.119] has quit [Ping timeout: 245 seconds] 02:51 -!- jonatack [~jon@37.166.157.61] has joined #bitcoin-core-pr-reviews 02:55 -!- mol [mol@gateway/vpn/protonvpn/molly] has joined #bitcoin-core-pr-reviews 02:55 -!- molz_ [mol@gateway/vpn/protonvpn/molly] has quit [Ping timeout: 245 seconds] 03:10 -!- jadi [~jadi@62.102.137.156] has quit [Remote host closed the connection] 03:18 -!- Mikayla80Heller [~Mikayla80@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:24 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 03:32 -!- mol_ [mol@gateway/vpn/protonvpn/molly] has joined #bitcoin-core-pr-reviews 03:35 -!- mol [mol@gateway/vpn/protonvpn/molly] has quit [Ping timeout: 245 seconds] 03:37 -!- belcher_ is now known as belcher 03:48 -!- Mikayla80Heller [~Mikayla80@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 246 seconds] 05:02 -!- _0x0ff- [~potatoe@2001:bc8:47b0:123::1] has joined #bitcoin-core-pr-reviews 05:05 -!- sanketcell_ [~sanketcel@ec2-100-24-255-95.compute-1.amazonaws.com] has joined #bitcoin-core-pr-reviews 05:05 -!- dr_orlovsky [~dr-orlovs@31.14.40.19] has joined #bitcoin-core-pr-reviews 05:05 -!- rich| [rich@2600:3c00::f03c:92ff:fe8e:dce6] has joined #bitcoin-core-pr-reviews 05:06 -!- Nebraskka_ [~Nebraskka@51.83.249.56] has joined #bitcoin-core-pr-reviews 05:06 -!- aj_ [aj@cerulean.erisian.com.au] has joined #bitcoin-core-pr-reviews 05:07 -!- matt2 [~matt@178.128.230.221] has joined #bitcoin-core-pr-reviews 05:07 -!- _0x0ff [~potatoe@unaffiliated/0x0ff/x-1210984] has quit [Ping timeout: 256 seconds] 05:07 -!- sanketcell [~sanketcel@ec2-100-24-255-95.compute-1.amazonaws.com] has quit [Ping timeout: 256 seconds] 05:07 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 256 seconds] 05:07 -!- Nebraskka [~Nebraskka@51.83.249.56] has quit [Ping timeout: 256 seconds] 05:07 -!- matt1 [~matt@178.128.230.221] has quit [Ping timeout: 256 seconds] 05:07 -!- aj [aj@139.162.42.226] has quit [Ping timeout: 256 seconds] 05:07 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has quit [Ping timeout: 256 seconds] 05:07 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 256 seconds] 05:07 -!- rich [~rich@shindig.notmandatory.org] has quit [Ping timeout: 256 seconds] 05:07 -!- ariard [~ariard@167.99.46.220] has quit [Ping timeout: 256 seconds] 05:07 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 05:07 -!- ariard [~ariard@167.99.46.220] has joined #bitcoin-core-pr-reviews 05:23 -!- scedastik [~scedastik@c-68-58-168-96.hsd1.mi.comcast.net] has joined #bitcoin-core-pr-reviews 05:50 -!- awesome_doge [~Thunderbi@1-162-108-41.dynamic-ip.hinet.net] has joined #bitcoin-core-pr-reviews 05:51 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 05:52 -!- awesome_doge [~Thunderbi@1-162-108-41.dynamic-ip.hinet.net] has quit [Remote host closed the connection] 06:01 -!- jonatack [~jon@37.166.157.61] has quit [Ping timeout: 264 seconds] 06:04 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 06:05 -!- molz_ [mol@gateway/vpn/protonvpn/molly] has joined #bitcoin-core-pr-reviews 06:07 -!- mol_ [mol@gateway/vpn/protonvpn/molly] has quit [Ping timeout: 245 seconds] 06:23 -!- jonatack [~jon@37.166.157.61] has joined #bitcoin-core-pr-reviews 06:39 -!- mol [mol@gateway/vpn/protonvpn/molly] has joined #bitcoin-core-pr-reviews 06:41 -!- molz_ [mol@gateway/vpn/protonvpn/molly] has quit [Ping timeout: 245 seconds] 07:20 -!- scedastik [~scedastik@c-68-58-168-96.hsd1.mi.comcast.net] has quit [Quit: scedastik] 07:51 -!- jadi [~jadi@62.102.137.156] has quit [Remote host closed the connection] 08:01 -!- Nebraskka_ [~Nebraskka@51.83.249.56] has quit [Quit: Good day old chaps] 08:02 -!- Nebraskka [~Nebraskka@51.83.249.56] has joined #bitcoin-core-pr-reviews 08:10 -!- Nebraskka [~Nebraskka@51.83.249.56] has quit [Quit: Good day old chaps] 08:11 -!- Nebraskka [~Nebraskka@51.83.249.56] has joined #bitcoin-core-pr-reviews 08:21 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 08:23 -!- jadi [~jadi@62.102.137.156] has quit [Remote host closed the connection] 08:53 -!- mol_ [mol@gateway/vpn/protonvpn/molly] has joined #bitcoin-core-pr-reviews 08:53 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 08:54 -!- molz_ [mol@gateway/vpn/protonvpn/molly] has joined #bitcoin-core-pr-reviews 08:56 -!- mol [mol@gateway/vpn/protonvpn/molly] has quit [Ping timeout: 245 seconds] 08:57 -!- mol_ [mol@gateway/vpn/protonvpn/molly] has quit [Ping timeout: 245 seconds] 08:59 -!- jadi [~jadi@62.102.137.156] has quit [Ping timeout: 256 seconds] 09:17 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-pr-reviews 09:23 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 09:23 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 09:53 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-pr-reviews 10:03 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 10:04 -!- jadi [~jadi@62.102.137.156] has quit [Remote host closed the connection] 10:10 -!- molz_ [mol@gateway/vpn/protonvpn/molly] has quit [Read error: Connection reset by peer] 10:10 -!- molz_ [mol@gateway/vpn/protonvpn/molly] has joined #bitcoin-core-pr-reviews 10:35 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 10:36 -!- jadi [~jadi@62.102.137.156] has quit [Remote host closed the connection] 10:45 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 10:45 -!- jejune [~clara@154.6.19.4] has joined #bitcoin-core-pr-reviews 10:53 -!- aj_ is now known as aj 10:59 -!- scedastik [~scedastik@c-68-58-168-96.hsd1.mi.comcast.net] has joined #bitcoin-core-pr-reviews 11:04 -!- jonatack [~jon@37.166.157.61] has quit [Read error: Connection reset by peer] 11:06 -!- jonatack [~jon@37.166.157.61] has joined #bitcoin-core-pr-reviews 11:06 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 11:08 -!- jadi [~jadi@62.102.137.156] has quit [Remote host closed the connection] 11:14 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 11:14 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 11:21 -!- jejune [~clara@154.6.19.4] has quit [Quit: "What are you trying to say? That I can dodge bullets?" "No Neo, what I'm trying to say, is that when you are ready.....you won't have to"] 11:22 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 276 seconds] 11:27 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 11:37 -!- valwal_ [sid334773@gateway/web/irccloud.com/x-afzpjvgfuispbzys] has quit [] 11:38 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 11:44 -!- jadi [~jadi@62.102.137.156] has quit [Ping timeout: 260 seconds] 11:52 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Quit: Leaving] 11:53 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 246 seconds] 12:01 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 12:03 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:04 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 12:09 -!- cguida1 [~Adium@2806:2f0:51c1:5cee:353c:5aa6:d1:8499] has joined #bitcoin-core-pr-reviews 12:11 -!- cguida2 [~Adium@2806:2f0:51c1:5cee:1c07:c0c1:510f:7111] has joined #bitcoin-core-pr-reviews 12:12 -!- cguida [~Adium@2806:2f0:51c1:5cee:111d:a146:4654:4a12] has quit [Ping timeout: 272 seconds] 12:13 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 12:14 -!- jadi [~jadi@62.102.137.156] has quit [Remote host closed the connection] 12:15 -!- cguida1 [~Adium@2806:2f0:51c1:5cee:353c:5aa6:d1:8499] has quit [Ping timeout: 265 seconds] 13:11 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 13:12 -!- jadi [~jadi@62.102.137.156] has quit [Remote host closed the connection] 14:08 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 14:13 -!- jadi [~jadi@62.102.137.156] has quit [Ping timeout: 260 seconds] 14:17 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 14:18 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 14:19 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 268 seconds] 14:25 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 14:26 -!- jadi [~jadi@62.102.137.156] has quit [Remote host closed the connection] 14:53 -!- jonatack [~jon@37.166.157.61] has quit [Ping timeout: 246 seconds] 14:54 -!- scedastik [~scedastik@c-68-58-168-96.hsd1.mi.comcast.net] has quit [Quit: scedastik] 14:57 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 15:03 -!- jadi [~jadi@62.102.137.156] has quit [Ping timeout: 260 seconds] 16:34 < cguida2> I have some questions about conducting a review 16:37 < cguida2> First of all, does Github display the commits in a PR in reverse order from how they usually appear? The most recent commit in this PR is 71b7cdb, but 6a69dd2 appears on top: https://github.com/bitcoin/bitcoin/pull/20664/commits 16:38 < cguida2> i'm looking at the feature branch, and the commit appear in the opposite order: https://github.com/jonasschnelli/bitcoin/commits/2020/12/filterblocks_rpc 16:39 < sipa> if you look at the commits in a branch, it shows the more recent ones on top 16:39 < cguida2> so, if I were to comment on this PR, i'd want to use 71b7cdb, even though it appears on the bottom of the PR commit list, correct? 16:39 < sipa> it'd be very uninteresting to show just commits from 2009 16:39 < aj> generally you should review the code locally rather than on github; avoids github being weird/buggy, and gives you the opportunity to compile/test, or make changes and see what that does, or see other parts of the code, or use other tools 16:40 < sipa> and needing to scroll down 100s of pages to show recent ones 16:40 < cguida2> haha yeah. i was just getting confused since the PR page shows the commits in reverse order to how they appear on the branch 16:41 < cguida2> aj: yeah, I am reviewing it locally, i've checked out 71b7cdb, but just trying to make sure that's actually what the PR is pointing to 16:42 < cguida2> sipa: sure, but it would also be relatively simple to just show the most recent commit on top, right? there must be some reason they do it this way, though 16:42 < cguida2> sipa; just like they do when displaying the commits in a branch 16:43 -!- robot-dreams_ [sid463268@gateway/web/irccloud.com/x-wnikwgjzholebypf] has quit [] 16:43 < aj> cguida2: in docs/productivity there's a "upstream-pull" snippet for github, so you can run "git checkout upstream-pull/20664/HEAD" or so to get to the right commit 16:43 -!- robot-dreams [sid463268@gateway/web/irccloud.com/x-vtjjttxnfjdjkctb] has joined #bitcoin-core-pr-reviews 16:43 < cguida2> aj: oh cool, i'll try that 16:45 < cguida2> my next questions are specific to this pr: does anyone know how close this PR is to merging? What's left to get done before it gets merged? If jonasschnelli is in the middle of an overhaul I don't want to put noise on the PR 16:45 < cguida2> but it would be awesome to see it merged soon. I tested it, and it works great 16:47 < cguida2> i have just one nit haha 16:51 < cguida2> actually i had another general question, which is that i changed a file and rebuilt everything but the change does not seem to be reflected. i definitely saved my changes and i definitely ran `make clean` and `make` all over again, but there was no change 16:58 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 16:59 -!- jadi [~jadi@62.102.137.156] has quit [Remote host closed the connection] 16:59 < sipa> cguida2: that's very strange 17:00 < sipa> what change specifically? 17:00 < cguida2> i'm trying to modify src/rpc/blockchain.cpp, which i'm assuming, perhaps incorrectly, controls the function of `bitcoin-cli help` 17:02 < sipa> for the functions implemented in that file, yes 17:04 < sipa> did you restart bitcoind? 17:05 < cguida2> i didn't, i can try that. the help stuff isn't contained inside the bitcoin-cli executable? 17:06 < cguida2> i guess that would do it 17:06 < sipa> ./bitcoin-cli is an RPC client; it just sends commands to a running bitcoind 17:07 < sipa> if you bitcoin-cli help, it sends the "help" command to bitcoind and prints the response 17:07 < cguida2> yep, there it is. i'm dumb haha 17:07 < cguida2> thanks sipa 17:08 < sipa> if you want the help for the CLI client itself, use bitcoin-cli --help 17:09 < cguida2> ahh yes, i did know about that command 17:09 < cguida2> thanks 17:12 -!- jesseposner [~jp@2601:645:200:162f:d38:a5c2:980:75b0] has left #bitcoin-core-pr-reviews ["Textual IRC Client: www.textualapp.com"] 17:30 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 17:31 -!- jadi [~jadi@62.102.137.156] has quit [Remote host closed the connection] 17:39 < cguida2> does `make check` run the python tests? 17:40 < sipa> no 17:40 < cguida2> ah ok. what's the command for that? just execute the python file? 17:41 < sipa> you can run them all using 17:41 < sipa> ./test/functional/test_runner.py 17:41 < cguida2> awesome, thanks! 17:47 < cguida2> What's the ACK for "I reviewed, ran tests, and also tested manually"? 17:48 < cguida2> I guess just ACK 17:49 < sipa> ideally "ACK. " 17:49 < sipa> there is no reason to be limited to 3 characters of feedback 17:49 < cguida2> haha cool 18:01 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 18:02 -!- jadi [~jadi@62.102.137.156] has quit [Remote host closed the connection] 18:33 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 18:34 -!- jadi [~jadi@62.102.137.156] has quit [Remote host closed the connection] 18:37 -!- seven__ [~seven@cpe-90-157-197-248.static.amis.net] has quit [Read error: Connection reset by peer] 18:46 -!- shafiunmiraz0 [~shafiunmi@103.220.205.190] has joined #bitcoin-core-pr-reviews 18:46 -!- shafiunmiraz0 [~shafiunmi@103.220.205.190] has quit [Client Quit] 19:05 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 19:06 -!- jadi [~jadi@62.102.137.156] has quit [Remote host closed the connection] 19:07 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer] 19:09 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 19:37 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 19:38 -!- jadi [~jadi@62.102.137.156] has quit [Remote host closed the connection] 19:41 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 19:42 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 19:47 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 264 seconds] 19:47 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 19:57 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 19:59 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds] 20:09 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 20:10 -!- jadi [~jadi@62.102.137.156] has quit [Remote host closed the connection] 20:22 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has joined #bitcoin-core-pr-reviews 20:33 -!- molz_ [mol@gateway/vpn/protonvpn/molly] has quit [Read error: Connection reset by peer] 20:34 -!- mol [mol@gateway/vpn/protonvpn/molly] has joined #bitcoin-core-pr-reviews 20:41 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 20:42 -!- jadi [~jadi@62.102.137.156] has quit [Remote host closed the connection] 20:44 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has quit [Ping timeout: 256 seconds] 20:47 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 20:48 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-pr-reviews 20:48 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 20:48 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 21:13 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 21:17 -!- jadi [~jadi@62.102.137.156] has quit [Ping timeout: 246 seconds] 21:34 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has joined #bitcoin-core-pr-reviews 21:48 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has quit [Ping timeout: 246 seconds] 21:52 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds] 21:52 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 21:59 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has joined #bitcoin-core-pr-reviews 22:09 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews 22:41 -!- cguida2 [~Adium@2806:2f0:51c1:5cee:1c07:c0c1:510f:7111] has quit [Read error: No route to host] 22:41 -!- cguida [~Adium@2806:2f0:51c1:5cee:1c07:c0c1:510f:7111] has joined #bitcoin-core-pr-reviews 23:24 -!- jadi [~jadi@62.102.137.156] has quit [Remote host closed the connection] 23:32 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 23:48 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-pr-reviews 23:51 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 268 seconds] 23:55 -!- jadi [~jadi@62.102.137.156] has joined #bitcoin-core-pr-reviews