--- Log opened Thu Jun 10 00:00:33 2021
00:43 -!- duderonomy [~duderonom@c-73-158-190-156.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews
02:07 -!- davterra [~davterra@178.128.106.205] has quit [Ping timeout: 268 seconds]
02:18 -!- belcher_ is now known as belcher
04:00 -!- duderonomy [~duderonom@c-73-158-190-156.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
05:31 -!- davterra [~davterra@178.128.106.205] has joined #bitcoin-core-pr-reviews
06:11 -!- raj_ [~raj_@103.77.139.47] has joined #bitcoin-core-pr-reviews
06:41 < raj_> Hello. regarding the PR we reviewed yesterday, can someone explain me what this `txiter` thing is here https://github.com/bitcoin/bitcoin/blob/ef8f2966ac8e486f622f9803f24bd4021c6ff9ed/src/txmempool.cpp#L184?
06:41 -!- Hernan [~hernanmar@OL121-235.fibertel.com.ar] has joined #bitcoin-core-pr-reviews
06:41 < raj_> How should i think about it? Is it iterator over the ancestors of a transaction? 
06:54 -!- evanlinjin [~evanlinji@218-35-179-62.cm.dynamic.apol.com.tw] has joined #bitcoin-core-pr-reviews
07:02 -!- evanlinjin [~evanlinji@218-35-179-62.cm.dynamic.apol.com.tw] has quit [Ping timeout: 245 seconds]
07:08 -!- reez [~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net] has joined #bitcoin-core-pr-reviews
07:34 -!- Hernan [~hernanmar@OL121-235.fibertel.com.ar] has quit [Read error: Connection reset by peer]
09:15 < jnewbery> it's an iterator into the boost multi-index container that the mempool uses to store its transactions: https://github.com/bitcoin/bitcoin/blob/1704bbf2263f16c720604cfab4ccb775315df690/src/txmempool.h#L568
09:17 < jnewbery> in this function specifically, we're walking up the graph of ancestors and using staged_ancestors and setAncestors to ensure that we're not visiting each ancestor more than once
09:44 -!- raj_ [~raj_@103.77.139.47] has quit [Quit: Leaving]
09:44 -!- raj_ [~raj_@103.77.139.47] has joined #bitcoin-core-pr-reviews
09:45 < raj_> jnewbery, thanks for the clarification. Close to what I have guessed. 
09:45 -!- raj_ [~raj_@103.77.139.47] has quit [Client Quit]
10:02 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews
10:18 -!- dhruv [~dhruv@165.227.49.220] has quit [Remote host closed the connection]
10:20 -!- dhruv [~dhruv@165.227.49.220] has joined #bitcoin-core-pr-reviews
10:41 -!- Crypt9a2e [~Crypt9a2e@157.51.21.223] has joined #bitcoin-core-pr-reviews
11:46 -!- reez [~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
12:13 -!- Crypt9a2e [~Crypt9a2e@157.51.21.223] has quit [Ping timeout: 268 seconds]
12:13 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:19 -!- powerjungle [~powerjung@h081217087223.dyn.cm.kabsi.at] has joined #bitcoin-core-pr-reviews
13:05 -!- duderonomy [~duderonom@c-73-158-190-156.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews
13:06 -!- powerjungle [~powerjung@h081217087223.dyn.cm.kabsi.at] has quit [Ping timeout: 272 seconds]
13:09 -!- powerjungle [~powerjung@h081217087223.dyn.cm.kabsi.at] has joined #bitcoin-core-pr-reviews
13:11 -!- powerjungle [~powerjung@h081217087223.dyn.cm.kabsi.at] has quit [Client Quit]
13:35 -!- reez [~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net] has joined #bitcoin-core-pr-reviews
13:50 -!- reez [~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
13:52 -!- jonatack [jonatack@user/jonatack] has quit [Quit: Connection closed]
14:02 -!- powerjungle [~powerjung@h081217087223.dyn.cm.kabsi.at] has joined #bitcoin-core-pr-reviews
14:42 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews
15:00 -!- duderonomy [~duderonom@c-73-158-190-156.hsd1.ca.comcast.net] has quit [Quit: Textual IRC Client: www.textualapp.com]
16:34 -!- Guest99 [~textual@cpe-174-102-106-83.columbus.res.rr.com] has joined #bitcoin-core-pr-reviews
17:51 -!- dongcarl [~dongcarl@96.224.58.144] has quit [Quit: The Lounge - https://thelounge.chat]
17:52 -!- dongcarl [~dongcarl@96.224.58.144] has joined #bitcoin-core-pr-reviews
18:02 -!- dongcarl [~dongcarl@96.224.58.144] has quit [Quit: The Lounge - https://thelounge.chat]
18:03 -!- dongcarl [~dongcarl@96.224.58.144] has joined #bitcoin-core-pr-reviews
18:34 -!- evanlinjin [~evanlinji@218-35-179-62.cm.dynamic.apol.com.tw] has joined #bitcoin-core-pr-reviews
18:38 -!- evanlinjin [~evanlinji@218-35-179-62.cm.dynamic.apol.com.tw] has quit [Ping timeout: 252 seconds]
20:00 -!- jacob72 [~jacob@37.19.195.10] has joined #bitcoin-core-pr-reviews
20:01 -!- jacob72 [~jacob@37.19.195.10] has quit [Client Quit]
20:22 -!- prusnak[m] [~stickmatr@2001:470:69fc:105::98c] has quit [Ping timeout: 244 seconds]
20:36 -!- Crypt9a2e [~Crypt9a2e@2409:4072:301:9da3:dd1a:701:893d:eef1] has joined #bitcoin-core-pr-reviews
21:33 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-core-pr-reviews
21:37 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 252 seconds]
22:21 -!- Crypt9a2e [~Crypt9a2e@2409:4072:301:9da3:dd1a:701:893d:eef1] has quit [Ping timeout: 245 seconds]
22:57 -!- Crypt9a2e [~Crypt9a2e@2409:4072:301:9da3:dd1a:701:893d:eef1] has joined #bitcoin-core-pr-reviews
23:56 -!- Crypt9a2e [~Crypt9a2e@2409:4072:301:9da3:dd1a:701:893d:eef1] has quit [Remote host closed the connection]
23:56 -!- Crypt9a2e [~Crypt9a2e@157.51.3.28] has joined #bitcoin-core-pr-reviews
--- Log closed Fri Jun 11 00:00:35 2021