--- Log opened Mon Aug 16 00:00:40 2021 00:23 -!- stick[m] [~stickmatr@2001:470:69fc:105::98c] has joined #bitcoin-core-pr-reviews 00:24 -!- babasancheti [~babasanch@43.249.232.30] has quit [Quit: Client closed] 01:00 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 01:19 -!- babasancheti [~babasanch@43.249.232.30] has joined #bitcoin-core-pr-reviews 02:24 -!- aitorjs [~aitorjs@184.76.76.188.dynamic.jazztel.es] has joined #bitcoin-core-pr-reviews 02:29 -!- aitorjs [~aitorjs@184.76.76.188.dynamic.jazztel.es] has quit [Client Quit] 02:58 -!- emzy [~quassel@user/emzy] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 03:57 -!- belcher_ is now known as belcher 04:30 < babasancheti> Which PR will be discussed in this weeks review meeting? 05:14 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has joined #bitcoin-core-pr-reviews 05:27 < michaelfolkson> babasancheti: [19:02:46] next week we have a special meeting on testing the v22 release candidate, hosted by josibake. It'll be a good one! 05:38 < babasancheti> You mean this week right? day after tom? 05:52 < josibake> babasancheti: correct! ill have the post up shortly 06:04 -!- pinheadmz [~pinheadmz@hns-contributor.dev] has joined #bitcoin-core-pr-reviews 06:13 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 258 seconds] 06:14 -!- emzy [~quassel@user/emzy] has joined #bitcoin-core-pr-reviews 06:15 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-pr-reviews 06:18 < jnewbery> babasancheti: apologies for the slow update of the website. We should have notes up later today. We'll be discussing v22 release candidate testing. 06:21 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 245 seconds] 06:38 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-pr-reviews 06:42 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-pr-reviews 06:43 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 240 seconds] 06:47 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-pr-reviews 06:47 -!- lukedashjr [~luke-jr@user/luke-jr] has quit [Ping timeout: 258 seconds] 06:49 < babasancheti> jnewbery No worries.. Appreciate the quick response :) 06:53 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-pr-reviews 06:53 -!- lukedashjr [~luke-jr@user/luke-jr] has quit [Read error: Connection reset by peer] 06:54 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-pr-reviews 06:56 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 245 seconds] 06:57 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-pr-reviews 06:59 -!- lukedashjr [~luke-jr@user/luke-jr] has quit [Ping timeout: 240 seconds] 07:51 < josibake> notes are up! https://bitcoincore.reviews/v22-rc-testing 07:52 < josibake> if you don't already have a HW, i would recommend following the instructions for setting up a HW emulator before the meeting as it is a little involved 08:27 -!- meshcollider [meshcollid@user/meshcollider] has quit [Remote host closed the connection] 08:44 -!- meshcollider [meshcollid@meshcollider.jujube.ircnow.org] has joined #bitcoin-core-pr-reviews 09:44 -!- babasancheti [~babasanch@43.249.232.30] has quit [Quit: Client closed] 09:53 < laanwj> josibake: great! 10:33 < jnewbery> josibake: thanks! 12:25 -!- raj [~raj_@2409:4061:28c:fa97:22d0:ec36:363c:bb08] has joined #bitcoin-core-pr-reviews 12:27 -!- muhblockchain [~muhblockc@user/muhblockchain] has quit [Ping timeout: 272 seconds] 12:30 < raj> Hello. I was stepping through the `p2p_compactblocks_blocksonly.py` test and am facing some doubts. What is mechanism to decide HB and LB mode of BIP152? The BIP isn't seem very clear, or I am lost. 12:31 < raj> The BIP says, it decides by "setting the first boolean to 1". Which boolean is that? https://github.com/bitcoin/bips/blob/master/bip-0152.mediawiki#intended-protocol-flow 12:33 < raj> Also in the test there are `msg_sendcmpct`s of version 1 and 2. But the BIP only describes Version 1. and it says the `version` bytes of the message to be set at 1 by all nodes. https://github.com/bitcoin/bips/blob/master/bip-0152.mediawiki#sendcmpct 12:35 < sipa> raj: the sendcmpct message has a payload of two arguments (a boolean, and an integer) that first boolean is whether or not hb mode is requested 12:35 < sipa> and regarding v2: https://github.com/bitcoin/bips/blob/master/bip-0152.mediawiki#specification-for-version-2 12:36 < raj> @sipa, thanks, eh I missed that.. 12:40 < raj> Hmm I think i got confused in "announcement" flag and HB and LB mode. So it seems the only difference between HB and LB is announce=true/false? 12:41 < raj> So it means the node wont proactively send compact blocks to its peers. Is that correct way to put it? 12:41 < sipa> yes, HB means the node is allowed to (and should, in general) announce using cmpctblock; LB means only pre-compactblock announcements can be used (sendheaders etc) 12:43 < sipa> one way of seeing it is that the normal flow is sending headers, responding with getdata MSG_CMPCTBLOCK, sending compactblock, and then possibly requesting missing transactions and getting those 12:43 < sipa> and in HB mode the sender may skip the first step, immediately sending the cmpctblock 12:45 < raj> corollary question. In my debug steps I am seeing the first sendcmpct message a node sends upon connecting to an outbound is sendcmpct(announce=false, version=1). Then upon recieving a block from the peer it again sends another sendcmpct(announce=true, version=2). Why dont its start with announce=false? and what causes the switch? 12:45 < raj> *why don't it starts with announce=true? 12:45 < sipa> iirc the policy is that the last 3 compactblock-captable peers which have succesfully relayed a block to us are chosen as HB peers 12:46 < sipa> which peers that we've just connected to don't qualify for, for obvious reasons 12:47 < raj> Ah ok. Ya i think thats also there in the BIP. makes sense.. 12:48 < raj> Thanks @sipa for clearing rooky questions.. :) 12:48 < sipa> np! 12:59 < raj> Ah one more thing. The node also changed its version flag after receiving a block. What triggered the version change? or in HB mode we always ask for version 2? 13:03 < sipa> version 1 = pre-segwit, version 2 = segwit 13:03 < sipa> unsure why it starts off with v1, perhaps that's early compatibility code 13:07 < raj> The BIP says "it must be currently set to 1". point 3 of https://github.com/bitcoin/bips/blob/master/bip-0152.mediawiki#sendcmpct 13:31 -!- raj [~raj_@2409:4061:28c:fa97:22d0:ec36:363c:bb08] has quit [Read error: Connection reset by peer] 13:47 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 13:52 -!- notmandatory [~notmandat@shindig.notmandatory.org] has quit [Ping timeout: 240 seconds] 13:52 -!- notmandatory [~notmandat@shindig.notmandatory.org] has joined #bitcoin-core-pr-reviews 14:59 -!- jnewbery [~john@user/jnewbery] has quit [Ping timeout: 276 seconds] 15:00 -!- jnewbery [~john@user/jnewbery] has joined #bitcoin-core-pr-reviews 17:32 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has quit [Quit: Connection closed for inactivity] 18:17 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-core-pr-reviews 18:21 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 256 seconds] 19:21 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 245 seconds] 19:25 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-pr-reviews 22:10 -!- reallll [~belcher@user/belcher] has joined #bitcoin-core-pr-reviews 22:11 -!- belcher_ [~belcher@user/belcher] has quit [Ping timeout: 245 seconds] 23:10 -!- reallll is now known as belcher 23:51 -!- raj [~raj_@2409:4061:28c:fa97:1397:4171:6289:f64] has joined #bitcoin-core-pr-reviews --- Log closed Tue Aug 17 00:00:42 2021