--- Log opened Thu Oct 28 00:00:16 2021 01:40 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-pr-reviews 02:06 -!- Zenton [~user@user/zenton] has quit [Read error: Connection reset by peer] 02:08 -!- Zenton [~user@user/zenton] has joined #bitcoin-core-pr-reviews 02:33 -!- ishi_ [~ishi@49.207.195.252] has joined #bitcoin-core-pr-reviews 02:36 -!- ishi [~ishi@49.207.220.27] has quit [Ping timeout: 260 seconds] 02:40 -!- ishi__ [~ishi@49.207.212.194] has joined #bitcoin-core-pr-reviews 02:42 -!- ishi_ [~ishi@49.207.195.252] has quit [Ping timeout: 265 seconds] 02:46 -!- ishi_ [~ishi@49.207.214.63] has joined #bitcoin-core-pr-reviews 02:49 -!- ishi__ [~ishi@49.207.212.194] has quit [Ping timeout: 268 seconds] 02:58 -!- ishi__ [~ishi@49.207.219.76] has joined #bitcoin-core-pr-reviews 03:01 -!- ishi_ [~ishi@49.207.214.63] has quit [Ping timeout: 245 seconds] 03:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a443:99fa:7edf:26be] has joined #bitcoin-core-pr-reviews 04:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a443:99fa:7edf:26be] has quit [Quit: Client closed] 04:16 < glozow> larryruane: it's so that i could use an `unordered_set` instead of a (ordered) `set`. the performance difference is pretty minimal but idk 🤷 it's what i've been using for quick txid lookups. `SaltedTxidHasher` is provided as the hash function used by the container to assign elements into buckets 04:16 < glozow> i don't think it needs to be salted, at least not for this use case 04:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a443:99fa:7edf:26be] has joined #bitcoin-core-pr-reviews 05:42 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te7aswxjyf8efmc.ipv6.telus.net] has quit [Read error: Connection reset by peer] 05:43 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te3s45p0yfmdisb.ipv6.telus.net] has joined #bitcoin-core-pr-reviews 05:44 < jnewbery> no harm in adding 🧑‍🍳 05:45 < jnewbery> *no harm in adding salt 06:24 -!- yonson [~yonson@2600:8801:d900:7bb:1e69:7aff:fea2:4e85] has quit [Remote host closed the connection] 06:24 -!- yonson [~yonson@2600:8801:d900:7bb:1e69:7aff:fea2:4e85] has joined #bitcoin-core-pr-reviews 06:55 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 246 seconds] 06:56 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-pr-reviews 07:28 < larryruane> glozow: jnewbery: Thanks, usually I think of salt as being needed for cryptographic security, and it seemed to me that this use of hashing doesn't require such. But as John said, does no harm. I just wanted to check my understanding. 07:32 < sipa> larryruane: hashtables with attacker-provided contents are vulnerable to an attack where the entries are chosen to all land in the same bucket 07:33 < sipa> the general solution to that is using salted hashers 07:34 < sipa> and siphash is actually specifically designed for this; it's a "cryptographic" hash function with 64-bit output 07:34 < larryruane> sipa: TIL, thanks! 07:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a443:99fa:7edf:26be] has quit [Quit: Client closed] 08:03 -!- glix_ is now known as glix 08:03 -!- glix [~glix@152.67.8.183] has quit [Changing host] 08:03 -!- glix [~glix@user/glix] has joined #bitcoin-core-pr-reviews 08:15 -!- stickies-v [~stickies-@84-45-243-170.static.enta.net] has joined #bitcoin-core-pr-reviews 08:16 -!- darius27 [~darius27@c-24-130-243-152.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 08:17 -!- Clint35 [~Clint@68-255-237-145.lightspeed.hstntx.sbcglobal.net] has joined #bitcoin-core-pr-reviews 08:18 -!- Clint35 [~Clint@68-255-237-145.lightspeed.hstntx.sbcglobal.net] has quit [Client Quit] 08:22 -!- stickies-v [~stickies-@84-45-243-170.static.enta.net] has quit [Quit: Computer going to sleep.] 08:43 -!- darius27 [~darius27@c-24-130-243-152.hsd1.ca.comcast.net] has quit [Quit: Ping timeout (120 seconds)] 08:48 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-pr-reviews 08:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a443:99fa:7edf:26be] has joined #bitcoin-core-pr-reviews 09:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a443:99fa:7edf:26be] has quit [Quit: Client closed] 09:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a443:99fa:7edf:26be] has joined #bitcoin-core-pr-reviews 09:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:a443:99fa:7edf:26be] has quit [Client Quit] 10:00 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 10:50 -!- tralfaz [~davterra@143.198.56.186] has joined #bitcoin-core-pr-reviews 10:50 -!- davterra [~davterra@143.198.56.186] has quit [Read error: Connection reset by peer] 10:59 -!- z9z0b3t11 [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-pr-reviews 11:01 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 260 seconds] 12:02 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:06 -!- ishi_ [~ishi@49.207.194.197] has joined #bitcoin-core-pr-reviews 12:09 -!- ishi__ [~ishi@49.207.219.76] has quit [Ping timeout: 260 seconds] 13:20 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene] 15:08 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-pr-reviews 15:11 -!- z9z0b3t11 [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 268 seconds] 15:27 < pinheadmz_> Funny how BIP-118 ended up with a much lower number than the taproot BIPs 15:27 < pinheadmz_> sipa you dont think the update is enough to call it a "new idea" and warrant a new number? 15:45 < sipa> which idea? 15:46 < pinheadmz_> https://github.com/bitcoin/bips/pull/943 15:53 < luke-jr> BIPs are not sequentially numbered in the first place.. 15:56 < sipa> pinheadmz_: err why do you ask me? 15:57 < pinheadmz_> sipa mmmm sorry its because i think in reference to "fixing" bip125 ive heard you say a few times recently that bips assign numbers to ideas and if an idea is different enough it should get a new number 16:05 < sipa> oh, i see 16:05 < sipa> i think there is a bit of difference in how much the bip is used 16:07 < pinheadmz_> ooh that makes sense. I was looking for a NOINPUT/ANYPREVOUT PR and dont see an implementation even proposed yet 16:07 < luke-jr> in the case of PR 943, it's a rebase of the same idea 16:08 < pinheadmz_> yeah a rebase ok I like that 17:31 -!- ishi__ [~ishi@49.207.222.168] has joined #bitcoin-core-pr-reviews 17:33 -!- ishi_ [~ishi@49.207.194.197] has quit [Ping timeout: 268 seconds] 19:14 -!- z9z0b3t11 [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-pr-reviews 19:16 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 260 seconds] 21:38 -!- yonson [~yonson@2600:8801:d900:7bb:1e69:7aff:fea2:4e85] has quit [Remote host closed the connection] 21:38 -!- yonson [~yonson@2600:8801:d900:7bb:1e69:7aff:fea2:4e85] has joined #bitcoin-core-pr-reviews 21:53 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te3s45p0yfmdisb.ipv6.telus.net] has quit [Remote host closed the connection] 21:54 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te6x6s0dgnjb8r1.ipv6.telus.net] has joined #bitcoin-core-pr-reviews 21:59 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te6x6s0dgnjb8r1.ipv6.telus.net] has quit [Ping timeout: 258 seconds] 22:12 -!- ishi_ [~ishi@49.207.207.136] has joined #bitcoin-core-pr-reviews 22:15 -!- ishi__ [~ishi@49.207.222.168] has quit [Ping timeout: 260 seconds] 22:15 -!- Kaizen_Kintsugi [~Kaizen_Ki@node-1w7jr9yi65te6x6s0dgnjb8r1.ipv6.telus.net] has joined #bitcoin-core-pr-reviews 22:27 -!- larryruane [sid473749@uxbridge.irccloud.com] has quit [Ping timeout: 264 seconds] 22:27 -!- lightlike [sid521075@user/lightlike] has quit [Ping timeout: 264 seconds] 22:30 -!- fjahr [sid374480@uxbridge.irccloud.com] has quit [Ping timeout: 264 seconds] 22:30 -!- pg2 [sid518209@hampstead.irccloud.com] has quit [Ping timeout: 264 seconds] 22:30 -!- dergoegge [sid453889@lymington.irccloud.com] has quit [Ping timeout: 264 seconds] 22:31 -!- lightlike [sid521075@user/lightlike] has joined #bitcoin-core-pr-reviews 22:31 -!- pg2 [sid518209@id-518209.hampstead.irccloud.com] has joined #bitcoin-core-pr-reviews 22:32 -!- larryruane [sid473749@id-473749.uxbridge.irccloud.com] has joined #bitcoin-core-pr-reviews 22:33 -!- fjahr [sid374480@id-374480.uxbridge.irccloud.com] has joined #bitcoin-core-pr-reviews 22:33 -!- dergoegge [sid453889@id-453889.lymington.irccloud.com] has joined #bitcoin-core-pr-reviews 22:59 -!- ishi_ [~ishi@49.207.207.136] has quit [Ping timeout: 260 seconds] 23:17 -!- Cory [~Cory@user/pasha] has joined #bitcoin-core-pr-reviews 23:36 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-pr-reviews 23:39 -!- z9z0b3t11 [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 260 seconds] 23:40 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 246 seconds] --- Log closed Fri Oct 29 00:00:17 2021