--- Log opened Sat Dec 25 00:00:11 2021
00:04 -!- Yihen [~textual@103.138.75.117] has quit [Remote host closed the connection]
00:04 -!- Yihen [~textual@103.138.75.117] has joined #bitcoin-core-pr-reviews
00:07 -!- Yihen [~textual@103.138.75.117] has quit [Remote host closed the connection]
00:08 -!- Yihen [~textual@103.138.75.117] has joined #bitcoin-core-pr-reviews
01:25 -!- Talkless [~Talkless@m83-176-229-235.cust.tele2.lt] has joined #bitcoin-core-pr-reviews
01:41 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
01:42 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
02:08 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews
02:30 -!- Yihen [~textual@103.138.75.117] has quit [Remote host closed the connection]
02:30 -!- Yihen [~textual@103.138.75.117] has joined #bitcoin-core-pr-reviews
02:37 -!- Talkless [~Talkless@m83-176-229-235.cust.tele2.lt] has quit [Ping timeout: 256 seconds]
04:43 < pinheadmz> laanwj mentioned to me a while back that sighash SINGLE sets a 0 for the input's sequence and therefore doesn't commit to it. But does that only apply to legacy sighash? Looks like witness sighash always commits to the inputs sequence ?
04:52 < sipa> 1, not 0.
05:01 < pinheadmz> https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L1331
05:01 < pinheadmz> referring to this i think
05:03 < sipa> look on line 1664
05:03 < sipa> eh, 1644
05:05 < pinheadmz> Not referring to "the bug" but how we commit to nsequence
05:05 < sipa> Oh, sorry, I misread.
05:08 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
05:09 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews
05:10 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Client Quit]
05:11 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews
05:12 < sipa> @pinheadmz Line 1331 is the serialization of nSequence values *not* corresponding to the input being signed. The nSequence value of the input being is always included, line 1333.
05:33 < pinheadmz> Thank you sir!
06:39 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
06:40 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
08:22 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews
09:24 -!- jb55 [~jb55@user/jb55] has quit [Ping timeout: 240 seconds]
09:38 -!- tecnecio [~tecnecio_@174.red-2-139-120.dynamicip.rima-tde.net] has quit [Quit: Leaving]
09:52 -!- shaavan [~shaavan@117.199.216.54] has joined #bitcoin-core-pr-reviews
09:54 -!- shaavan [~shaavan@117.199.216.54] has quit [Client Quit]
10:00 -!- jb55 [~jb55@user/jb55] has joined #bitcoin-core-pr-reviews
11:30 < jeremyrubin> pinheadmz: this is also a difference between CTV's digest algo and APO where CTV commits to all other scriptsigs + sequences, APO does not, if you were curious
12:02 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 240 seconds]
12:02 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
12:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
12:10 -!- Yihen [~textual@103.138.75.117] has quit [Remote host closed the connection]
12:10 -!- Yihen [~textual@103.138.75.117] has joined #bitcoin-core-pr-reviews
12:30 -!- Yihen [~textual@103.138.75.117] has quit [Remote host closed the connection]
12:30 -!- Yihen [~textual@103.138.75.117] has joined #bitcoin-core-pr-reviews
13:51 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
14:20 < pinheadmz> jeremyrubin: what's APO? I'm familiar with CTV
15:17 -!- meshcollider [meshcollid@user/meshcollider] has quit [Quit: :wave:]
15:34 < jeremyrubin> Anyprevout / noinput
15:34 -!- meshcollider [meshcollid@meshcollider.jujube.ircnow.org] has joined #bitcoin-core-pr-reviews
16:29 -!- meshcollider [meshcollid@meshcollider.jujube.ircnow.org] has quit [Changing host]
16:29 -!- meshcollider [meshcollid@user/meshcollider] has joined #bitcoin-core-pr-reviews
16:59 -!- gnaf [~pi@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-pr-reviews
17:25 -!- gnaf [~pi@86-91-224-60.opennet.kpn.net] has quit [Quit: Konversation terminated!]
20:30 -!- Yihen [~textual@103.138.75.117] has quit [Remote host closed the connection]
20:31 -!- Yihen [~textual@103.138.75.117] has joined #bitcoin-core-pr-reviews
--- Log closed Sun Dec 26 00:00:12 2021