--- Log opened Wed Jan 05 00:00:22 2022 00:21 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-pr-reviews 00:26 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 256 seconds] 00:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 00:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 00:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 00:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 268 seconds] 00:44 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 01:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 01:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 01:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 01:15 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 01:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 01:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 01:39 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-pr-reviews 01:40 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 01:40 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 01:43 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 240 seconds] 01:50 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-pr-reviews 01:54 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 256 seconds] 01:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 02:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 02:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 02:20 -!- gnusha [~gnusha@user/gnusha] has quit [Ping timeout: 240 seconds] 02:20 -!- gnusha [~gnusha@user/gnusha] has joined #bitcoin-core-pr-reviews 02:20 -!- Topic for #bitcoin-core-pr-reviews: Meeting every Wednesday at 17:00 | See https://bitcoincore.reviews/ for details | This channel is logged 02:20 -!- Topic set by jnewbery [] [Mon May 24 09:24:20 2021] 02:20 [Users #bitcoin-core-pr-reviews] 02:20 [ _0x0ff ] [ emzy ] [ jkczyz ] [ michaelfolkson] [ schmidty ] 02:20 [ ___nick___ ] [ evbo ] [ jnewbery ] [ mutatrum[m] ] [ stick ] 02:20 [ _aj_ ] [ fanquake ] [ johnzwen- ] [ neha ] [ stickies-v] 02:20 [ achow101 ] [ fdov ] [ jonasschnelli_ ] [ nickler ] [ takinbo ] 02:20 [ adiabat ] [ FelixWeis ] [ josibake ] [ notmandatory_ ] [ TheRec ] 02:20 [ ajonas_ ] [ fjahr ] [ jrawsthorne ] [ pg156 ] [ theStack_ ] 02:20 [ amiti ] [ George[m]1 ] [ Kaizen_K_ ] [ pinheadmz ] [ uasf ] 02:20 [ andrewtoth_] [ ghost43 ] [ kanzure ] [ pink_sarco ] [ waxwing ] 02:20 [ avril ] [ glozow ] [ kcalvinalvin ] [ provoostenator] [ willcl_ark] 02:20 [ b10c ] [ gnusha ] [ koolazer ] [ qubenix ] [ windsok ] 02:20 [ b10c_ ] [ grettke ] [ laanwj ] [ r-ush ] [ yakshaver ] 02:20 [ belcher ] [ greypw254 ] [ larryruane ] [ raj ] [ Yihen ] 02:20 [ blkncd ] [ harding ] [ lightlike ] [ robot-dreams ] [ yonson ] 02:20 [ brunoerg ] [ hebasto ] [ livestradamus ] [ RubenSomsen ] [ Zenton ] 02:20 [ Common ] [ Henry151 ] [ luke-jr ] [ ryanofsky ] [ ziggie ] 02:20 [ dergoegge ] [ hugohn ] [ m011 ] [ S3RK ] 02:20 [ djinni` ] [ jarolrod ] [ MarcoFalke ] [ sandipndev123 ] 02:20 [ dongcarl ] [ jb55 ] [ MatrixBot1234510] [ sanket1729 ] 02:20 [ dr_orlovsky] [ jeremyrubin] [ meshcollider ] [ sanket_cell_ ] 02:20 -!- Irssi: #bitcoin-core-pr-reviews: Total of 91 nicks [0 ops, 0 halfops, 0 voices, 91 normal] 02:21 -!- Channel #bitcoin-core-pr-reviews created Wed May 19 12:43:59 2021 02:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 02:23 -!- Irssi: Join to #bitcoin-core-pr-reviews was synced in 180 secs 02:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 02:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 02:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 02:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 02:57 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-pr-reviews 03:19 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 03:22 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 03:25 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 03:25 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 03:36 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Remote host closed the connection] 03:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 03:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 268 seconds] 03:47 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-pr-reviews 04:58 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Remote host closed the connection] 04:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 05:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 268 seconds] 05:04 -!- tarun_ [tarun@gateway/vpn/protonvpn/tarun] has joined #bitcoin-core-pr-reviews 05:04 -!- tarun_ [tarun@gateway/vpn/protonvpn/tarun] has quit [Client Quit] 05:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 05:05 -!- tarun [tarun@gateway/vpn/protonvpn/tarun] has joined #bitcoin-core-pr-reviews 05:07 -!- tarun [tarun@gateway/vpn/protonvpn/tarun] has left #bitcoin-core-pr-reviews [] 05:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Remote host closed the connection] 05:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 05:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Remote host closed the connection] 05:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 06:20 -!- kalpa [~kalpa@5.146.160.32] has joined #bitcoin-core-pr-reviews 06:35 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 06:36 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 06:36 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Client Quit] 06:38 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 06:51 -!- janoside [~janoside@cpe-65-31-20-166.insight.res.rr.com] has joined #bitcoin-core-pr-reviews 07:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Remote host closed the connection] 07:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 07:10 -!- gleb745 [~gleb@178.150.137.228] has joined #bitcoin-core-pr-reviews 07:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 268 seconds] 07:14 -!- jb55 [~jb55@user/jb55] has quit [Ping timeout: 256 seconds] 07:30 -!- Netsplit *.net <-> *.split quits: janoside, jnewbery, George[m]1, johnzwen-, hebasto, jarolrod, jeremyrubin, jonasschnelli_, lightlike, Zenton, (+53 more, use /NETSPLIT to show all of them) 07:31 -!- Netsplit over, joins: gleb745, Kaizen_Kintsugi_ 07:31 -!- Netsplit over, joins: achow101, johnzwen-, George[m]1, larryruane, hugohn, fdov, S3RK, Zenton, ryanofsky 07:31 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 07:32 -!- Netsplit over, joins: jeremyrubin, waxwing, RubenSomsen, belcher, kcalvinalvin, stickies-v, adiabat, avril, m011, josibake (+1 more) 07:32 -!- Netsplit over, joins: uasf, raj, yonson, jarolrod, harding, qubenix, emzy, robot-dreams, jonasschnelli_, mutatrum[m] (+2 more) 07:32 -!- Netsplit over, joins: luke-jr, nickler, michaelfolkson, _aj_, b10c, koolazer, jnewbery, janoside, Common, theStack_ (+1 more) 07:32 -!- Netsplit over, joins: ghost43, _andrewtoth_, fjahr, _0x0ff, windsok, greypw254, kanzure, jrawsthorne, stick, livestradamus (+3 more) 07:33 -!- Netsplit over, joins: sanket1729, MatrixBot1234510, ajonas_, hebasto 07:33 -!- janoside [~janoside@cpe-65-31-20-166.insight.res.rr.com] has quit [Ping timeout: 256 seconds] 07:34 -!- uasf [~uasf@2604:a880:2:d0::1bda:1001] has quit [Remote host closed the connection] 07:35 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 07:35 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-pr-reviews 07:36 -!- uasf [~uasf@2604:a880:2:d0::1bda:1001] has joined #bitcoin-core-pr-reviews 07:36 -!- George[m]1 [~georgezen@2001:470:69fc:105::1:5d4a] has quit [Ping timeout: 250 seconds] 07:36 -!- mutatrum[m] [~mutatrumm@2001:470:69fc:105::1:4f5c] has quit [Ping timeout: 252 seconds] 07:37 -!- koolazer [~koo@user/koolazer] has quit [Ping timeout: 256 seconds] 07:50 -!- koolazer [~koo@user/koolazer] has joined #bitcoin-core-pr-reviews 07:57 -!- George[m]1 [~georgezen@2001:470:69fc:105::1:5d4a] has joined #bitcoin-core-pr-reviews 07:59 -!- mutatrum[m] [~mutatrumm@2001:470:69fc:105::1:4f5c] has joined #bitcoin-core-pr-reviews 07:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 08:00 -!- erik [~erik@181-191-0-203.uplinkx.com.br] has joined #bitcoin-core-pr-reviews 08:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 08:04 -!- seaona [~seaona@93.176.130.246] has joined #bitcoin-core-pr-reviews 08:11 -!- erik [~erik@181-191-0-203.uplinkx.com.br] has quit [Ping timeout: 250 seconds] 08:12 -!- erik [~erik@181-191-0-203.uplinkx.com.br] has joined #bitcoin-core-pr-reviews 08:15 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 08:27 -!- constantin [~constanti@pd9f94abd.dip0.t-ipconnect.de] has joined #bitcoin-core-pr-reviews 08:28 -!- constantin is now known as Guest523 08:28 -!- Guest523 is now known as constantin21 08:42 -!- turkycat [~turkycat@c-67-185-164-184.hsd1.wa.comcast.net] has joined #bitcoin-core-pr-reviews 08:42 -!- b10c__ [uid500648@user/b10c] has joined #bitcoin-core-pr-reviews 08:44 -!- janoside [~janoside@cpe-65-31-20-166.insight.res.rr.com] has joined #bitcoin-core-pr-reviews 08:45 -!- ccdle12 [~ccdle12@243.222.90.149.rev.vodafone.pt] has joined #bitcoin-core-pr-reviews 08:53 -!- kouloumos [~kouloumos@62-10-208.netrun.cytanet.com.cy] has joined #bitcoin-core-pr-reviews 08:53 -!- jb55 [~jb55@user/jb55] has joined #bitcoin-core-pr-reviews 08:54 -!- tim14 [~tim@c-73-217-34-231.hsd1.co.comcast.net] has joined #bitcoin-core-pr-reviews 08:55 -!- Julianmrodri [~Julianmro@r167-61-134-159.dialup.adsl.anteldata.net.uy] has joined #bitcoin-core-pr-reviews 08:57 -!- tarun [tarun@gateway/vpn/protonvpn/tarun] has joined #bitcoin-core-pr-reviews 08:57 -!- tarun [tarun@gateway/vpn/protonvpn/tarun] has quit [Client Quit] 08:58 -!- tarun [tarun@gateway/vpn/protonvpn/tarun] has joined #bitcoin-core-pr-reviews 08:58 -!- rahim [~rahim@c-98-207-69-88.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 08:59 -!- fqxjkdtbwnm5 [~fqxjkdtbw@dslb-178-003-199-224.178.003.pools.vodafone-ip.de] has joined #bitcoin-core-pr-reviews 08:59 -!- svav [~svav@82-69-86-143.dsl.in-addr.zen.co.uk] has joined #bitcoin-core-pr-reviews 09:00 < glozow> #startmeeting 09:00 < glozow> Happy New Year! Welcome to PR review club! 09:00 -!- kodyl [~kodyl@mobile-166-137-175-023.mycingular.net] has joined #bitcoin-core-pr-reviews 09:00 < b10c__> hi (lurking today) 09:00 < glozow> We're looking at PR #23534 today, notes and questions in the usual place: https://bitcoincore.reviews/23534 09:00 < larryruane> hi 09:00 < lightlike> hi 09:00 < kouloumos> hi 09:00 < tarun> hi 09:00 < kalpa> hi 09:00 < erik> hi 09:00 -!- Loris [~Loris@189.4.76.149] has joined #bitcoin-core-pr-reviews 09:00 < kodyl> yo 09:00 < glozow> Feel free to say hi, and let us know if it's your first time 09:01 < svav> Hi 09:01 < kalpa> first time for me 09:01 < rahim> hi (lurking), first time! 09:01 < turkycat> hi, first time. will observe 09:01 < janoside> Hi, first time 09:01 < erik> It's my first time, here 09:01 < stickies-v> hiya 09:01 < kodyl> first time (lurking) 09:01 < Julianmrodri> hi, first time 09:01 < Loris> hi, first time :) 09:01 < glozow> kalpa: rahim: turkycat: janoside: erik: kodyl: Julianmrodri: Loris: Welcome! 09:01 < tim14> first time (lurking) 09:01 < glozow> wow so many first-timers :D 09:01 < fqxjkdtbwnm5> Hi, first time :-) 09:01 < turkycat> just discovered via twitter 09:01 < glozow> Quick poll: have you reviewed the PR or read the notes? y/n? 09:02 < kodyl> y 09:02 < janoside> y 09:02 < rahim> n 09:02 < Loris> n 09:02 < turkycat> y and y 09:02 < kalpa> nn 09:02 < michaelfolkson> hi 09:02 < stickies-v> 0.5y, glossed over it 09:02 < erik> y 09:02 < kouloumos> n 09:02 < glozow> For those of you who reviewed, what was your review approach? 09:02 < tarun> y 09:02 < svav> y read the notes 09:03 < glozow> tim14: fqxjkdtbwnm5: Welcome as well 09:03 -!- og [~og@66.135.146.212] has joined #bitcoin-core-pr-reviews 09:03 < tarun> read the notes reviewed the questions 09:03 -!- sipa [~sipa@user/sipa] has joined #bitcoin-core-pr-reviews 09:03 < sipa> Looks correct to me. 09:03 < glozow> awesome, let's dive into the questions 09:03 < glozow> What does the `subtractFeeFromOutputs` argument do in fundrawtransaction; how do you use it? Why might a user opt to subtract fees from outputs? 09:04 < kouloumos> It subtracts the fee from the outputs. You specify from which outputs you want that fee to be subtracted and it will be equally deducted from the amount of each one. 09:04 -!- og [~og@66.135.146.212] has quit [Client Quit] 09:04 < glozow> kouloumos: yes! 09:04 -!- og5123 [~og5123@66.135.146.212] has joined #bitcoin-core-pr-reviews 09:05 -!- C3P0 [~C3P0@201.211.48.193] has joined #bitcoin-core-pr-reviews 09:05 < erik> It subtracts the fee from the sending amount. It's useful for self transfers, like during wallet migration 09:05 < glozow> Can anyone tell us a use case for this? 09:05 < willcl_ark> hi 09:05 < stickies-v> It is especially useful when sweeping a wallet, because you don't know how much fees you'll have to pay before iterating over all the inputs 09:05 < glozow> erik: right! since the payment amount will be reduced, we'd imagine that you wouldn't use this to pay a merchant for example 09:06 -!- zenlo [~zenlo@172.58.171.24] has joined #bitcoin-core-pr-reviews 09:06 < glozow> stickies-v: yes! what does "sweeping a wallet" mean? 09:06 -!- zenlo [~zenlo@172.58.171.24] has quit [Client Quit] 09:06 < brunoerg> hi 09:07 -!- zenlo [~zenlo@172.58.171.24] has joined #bitcoin-core-pr-reviews 09:07 -!- zenlo [~zenlo@172.58.171.24] has quit [Client Quit] 09:07 < stickies-v> Sending all your UTXOs to one or multiple new addresses. Breaking the piggy bank and putting everything in a shiny new one :) 09:07 -!- Muss1710 [~Muss1710@lfbn-bor-1-1297-121.w193-250.abo.wanadoo.fr] has joined #bitcoin-core-pr-reviews 09:07 -!- zenlo [~zenlo@172.58.171.24] has joined #bitcoin-core-pr-reviews 09:07 -!- zenlo [~zenlo@172.58.171.24] has quit [Client Quit] 09:07 < glozow> stickies-v: perfect 09:08 < glozow> next question: What does it mean for a coin to have negative effective value? Why does it usually not make sense to select negative effective value UTXOs? 09:08 -!- callebtc [~callebtc@i59F7FCBB.versanet.de] has joined #bitcoin-core-pr-reviews 09:08 -!- Carcas [~l@187.107.11.13] has joined #bitcoin-core-pr-reviews 09:08 < larryruane> the fee increase that would be required to include that input is greater than the value of the input 09:09 < kalpa> Do negative effective value UTXOs even exist? 09:09 -!- praveen [~praveen@192.157.127.6] has joined #bitcoin-core-pr-reviews 09:09 -!- Heitor [~Heitor@187.106.32.177] has joined #bitcoin-core-pr-reviews 09:09 < glozow> larryruane: correct 09:09 < brunoerg> the cost to move this coin is greater than its value? 09:09 < glozow> kalpa: yes they do! it also depends on the feerate at which you're trying to construct this transaction 09:09 < glozow> perhaps it would be helpful for someone to tell us what effective value means :) 09:09 < glozow> brunoerg: correct 09:09 < turkycat> utxo value - fee per utxo 09:09 < kalpa> oh ok understood 09:10 < stickies-v> effective value is the nValue of the UTXO minus (tx size * current feerate) 09:11 < callebtc> what's a typical threshold value for a too-small utxo (i.e. negative effective value)? 09:11 < glozow> stickies-v: yep exactly 09:11 -!- Murch [~Murch@pool-173-77-204-199.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 09:11 < glozow> callebtc: good question, i think it'd be a few hundred - a few thousand sats 09:13 < glozow> Alright next question: What does this PR do? What are the advantages of disadvantages of its changes? 09:13 < stickies-v> a 2-input 2-output p2wpkh tx is 208.5 vbytes, at a feerate of 5 sats/vbyte you'd get roughly 1000sats? 09:13 < callebtc> btw, if I understand correctly, the problem would also propagate to the next utxo: if your effective value is just marginally positive, the output (the input of the next tx) could then have a negative effective value, correct? 09:14 < larryruane> stickies-v: "tx size * current feerate" - is it tx size or input size? 09:14 < glozow> callebtc: hm, i don't think anything would propagate to the next utxo. the problem here is, when we spend this output in our transaction (i.e. we create an input that refers to this UTXO), the size of the input * feerate is more than the UTXO's nValue 09:14 < stickies-v> yeah i just realized i've been confusing the two. that should be input size, so my previous example is off too 09:15 < glozow> larryruane: stickies-v: oh you're right, i didn't look closely enough. yes it's the size of the input. 09:15 -!- sipa [~sipa@user/sipa] has quit [Quit: Reconnecting] 09:16 < glozow> yeah so an input to spend a p2wpkh is ~68vB, and at 5sat/vB that's about 340 sats 09:18 < George[m]1> What’s very strange to me is that I joined IRC as the ‘zenlo’ user which shows up here. 09:18 < glozow> are we okay to move on to the next question? 09:18 < erik> Yes 09:19 < brunoerg> y 09:19 < glozow> okay: what does this PR do? 09:19 < callebtc> glozow: > What does this PR do? I think it allows one to spend negative EV utxo's which might be desirable if the user wants to, for example, clear out the entire wallet. 09:20 < kalpa> it allows us to consolidate small UTXO values? 09:20 < glozow> callebtc: yes, it allows us to include the negative effective value UTXOs in a transaction when `subtractFeeFromOutputs` is on 09:20 < glozow> kalpa: yes that's what the effect is! 09:20 < callebtc> Understood! Can I ask, why it wasn't possible in the first place? 09:21 < glozow> stickies-v mentioned sweeping wallets, so let's consider an alternative approach. Why don't we just have a `sweepwallet` RPC? 09:22 -!- seaona [~seaona@93.176.130.246] has quit [Ping timeout: 256 seconds] 09:22 < glozow> callebtc: because selecting negative effective value inputs would mean you're not getting closer to funding your payment amount, just throwing away extra money to fees 09:22 < stickies-v> I don't think it's a very common use case, so maybe no need to clutter the RPC with an extra method when the fundrawtransaction method can already get the job done? 09:22 -!- stick[m] [~stickmatr@2001:470:69fc:105::98c] has joined #bitcoin-core-pr-reviews 09:23 < lightlike> why is it desirable to sweep the wallet when we are actually donating fees to the miners? why not just forget about these utxos instead and move only those coins with a positive effective value? 09:24 < kalpa> well fundrawtransaction is the method to create a transaction so it wouldn't make sense to create another one 09:24 < brunoerg> lightlike: privacy? 09:24 < stickies-v> lightlike yeah that's my number one mystery with this entire PR, not sure why you wouldn't just leave the negative EVs behind 09:24 < m011> I also think fundrawtransaction method gets the job done. This only needs a parameter that use the wallet balance instead of specifying a value. 09:24 < glozow> lightlike: good question. i guess that could make sense to the user, but then we're cluttering the UTXO set. 09:24 < achow101> stickies-v: alternatively, why should we clutter all of the coin selection code with subtractFeeFromOutputs handling when a sweep function would be fairly simple to create. 09:24 < willcl_ark> Sometimes you just wanna use up all UTXOs 09:25 < rahim> lightlike: couldn't a negative effective value input become a "positive" effective value one eventually, assuming price increases? 09:25 -!- ccdle12 [~ccdle12@243.222.90.149.rev.vodafone.pt] has quit [Quit: Client closed] 09:25 < larryruane> basic question: with this sweeping use-case, the user *wants* to spend negative-effective-value UTXOs, even though doing that is uneconomical? If so, I don't see why that's desired 09:25 < lightlike> brunoerg: wouldn't the new solution be actually worse to privacy than just forgetting about the utxos, because it allows third partieds to connects more utxos? 09:25 < willcl_ark> You're also altruistically reducing the UTXO set size 09:25 < glozow> achow101: +1, an extra RPC method is better than complicating the coin selection logic imo 09:25 -!- Murch is now known as Murchin 09:25 < stickies-v> achow101 excellent point, I don't have any counterpoints haha 09:26 < larryruane> (lightlike +1 you beat me to it on that question) 09:26 < kalpa> if btc goes to a million dollars it could make sense to sweep all dust outputs into one now 09:26 < glozow> rahim: good point, if you're able to create very low feerate transactions in the future, they might be positive effective value 09:26 < glozow> but this has nothing to do with the exchange rate with USD 09:27 < fqxjkdtbwnm5> @rahim, I do not think so, because everything written above is in the "unit" sats and correct independent of USD price 09:27 < brunoerg> lightlike: hmmmm, good point. 09:27 < achow101> there is some philosophical questions around whether sweeping should ignore negative ev utxos. imo users would expect that sweeping results in their wallet balance becoming 0, but not spending negative ev utxos means that there will be a non-zero remaining balance 09:27 < larryruane> kalpa: I'm not sure the btc price matters, because wouldnt everything (fees, etc.) scale linearly? 09:27 -!- siv2r[m] [~siv2rmatr@2001:470:69fc:105::fed3] has joined #bitcoin-core-pr-reviews 09:28 < rahim> gotcha; fees are calculated from the tx size and independent of price, right? 09:28 < erik> rahim: feerate is calculated in sats 09:28 < callebtc> Is there a technical reason why there isn't a `sweepwallet` RPC (excluding complexity, bloat, ugliness, etc)? 09:28 < glozow> larryruane: if i'm sweeping a wallet, i'll probably throw away my keys/backups, so i'd prefer not to leave anything behind. i'd also feel like i'm dumping plastic bags into the ocean, just not very eco-friendly to keep those in the UTXO set 09:29 -!- Murch[m] [~murch@user/murch] has joined #bitcoin-core-pr-reviews 09:29 < larryruane> glozow: +1 09:29 -!- merkle_noob[m] [~merklenoo@2001:470:69fc:105::bad0] has joined #bitcoin-core-pr-reviews 09:29 -!- jomat [~jomat@2001:470:69fc:105::21] has joined #bitcoin-core-pr-reviews 09:29 -!- sipa [~sipa@user/sipa] has joined #bitcoin-core-pr-reviews 09:29 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has joined #bitcoin-core-pr-reviews 09:29 -!- secondl1ght[m] [~secondl1g@2001:470:69fc:105::1:4fee] has joined #bitcoin-core-pr-reviews 09:29 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has joined #bitcoin-core-pr-reviews 09:29 < constantin21> achow101: I think it comes down to donating dust to miners or "deflating" bitcoin supply? 09:29 < achow101> callebtc: not in particular 09:29 -!- Murch[m] is now known as Murch 09:30 < glozow> okay we're halfway through the hour so i'll throw out the final conceptual question: Since this is a wallet PR, could this change cause users to pay extreme fees, end up with dust outputs, or leak privacy? Would this be confusing to you as a user if you are using the default settings? 09:30 < svav> Can someone give a simple explanation as to why this PR was felt necessary? If fees make it uneconomical to spend a particular UTXO, why would you ever bother spending it? What is the reason for this existence of this PR? X) 09:30 -!- jb55 [~jb55@user/jb55] has quit [Ping timeout: 256 seconds] 09:30 < glozow> (I included these in the notes as examples of what you might want to ask yourself when reviewing the PR) 09:31 < callebtc> I think it would be helpful to try to find an answer to the "why does this PR even exist?" questions 09:31 < achow101> svav: it is a bug fix for a reported bug where someone was sweeping their entire wallet but got an insufficient funds error. the root cause was found to be that their wallet contained negative ev utxos. 09:32 < glozow> https://github.com/bitcoin/bitcoin/issues/23026 09:32 < achow101> however they were able to sweep with an older version of the software, so this is technically a regression 09:32 -!- Carcas [~l@187.107.11.13] has quit [Ping timeout: 240 seconds] 09:32 < kalpa> consolidating your UTXOs could be a privacy leak but that also happens with other coin selection algorithms 09:32 < constantin21> svav : It enables donating unobtainable dust to miners 09:33 < janoside> glozow: Pay extreme fees: no (changes seem independent of fee rate). End up with dust outputs: no (this will destroy dust outputs). Leak privacy: yes, possibly (history of the dust outputs can now be linked to the spend). 09:33 < glozow> kalpa: i don't think that's caused by this PR, but a side effect of consolidation. 09:33 < kalpa> glozow, of course 09:34 < glozow> janoside: same thing, this does not worsen the privacy of our coin selection implementation, it's always been the case that consolidating UTXOs links them to the same wallet 09:35 -!- ottosch [~l@187.107.11.13] has joined #bitcoin-core-pr-reviews 09:35 -!- jb55 [~jb55@user/jb55] has joined #bitcoin-core-pr-reviews 09:36 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has joined #bitcoin-core-pr-reviews 09:36 < glozow> any further questions about the concept? this discussion has been very lively \o/ 09:36 < svav> If a user was sweeping their wallet, would they currently be adding each input manually? 09:36 < Murch> achow101: that sounds more like an issue of the wallet not distinguishing the balance and spendable balance 09:36 -!- Loris [~Loris@189.4.76.149] has quit [Quit: Connection closed] 09:37 -!- praveen [~praveen@192.157.127.6] has quit [Quit: Connection closed] 09:37 < kalpa> glozow, so this PR does not affect the gui wallet functionality correct? 09:37 < achow101> Murch: the spendable balance depends on the feerate though, and having a balance that constantly changes doesn't sound like good UX 09:37 < lightlike> but I think it does worsen the privacy of that particular transaction - using less utxos (which are not necessary/economical) should improve privacy. 09:37 < m011> Correct. This PR does not affect the GUI 09:38 < svav> Apart from sweeping a wallet, are there any other production circumstances where a coin being able to have a negative effective value would be useful/needed? 09:38 < glozow> kalpa: depends on what you mean. the gui wallet is the same as the wallet, so no. but nothing should change in the gui itself, so yes. 09:38 < glozow> lightlike: ah that is a good point 09:39 < kalpa> glozow, but the gui wallet does not use the fundrawtransaction RPC or does it? or is it supposed to do so in the future? 09:39 < Murch> achow101: Sure, but in the context of building a transaction with a specific feerate, the spendable balance would be stable. 09:40 < achow101> kalpa: the gui, fundrwatransaction, and the send* functions, etc. all end up using the same CreateTransaction function which contains all of the coin selection logic 09:41 -!- kodyl [~kodyl@mobile-166-137-175-023.mycingular.net] has quit [Quit: Connection closed] 09:42 < callebtc> does anyone know how many utxo's out there have negative EV? 09:42 < sipa> that depends on the feerate 09:42 < callebtc> And how many sats they effectively lock away? 09:42 < larryruane> just so everyone's aware, a sophisticated user can also choose the inputs (createrawtransaction) to have complete control (not use the built-in coin selection algorithms) 09:43 < glozow> svav: i can't think of any other use cases, so I'm a proponent of adding a `sweepwallet` RPC that sweeps all UTXOs. i think if this is the expected behavior, users should be able to say they specifically want to sweep 09:43 < callebtc> sipa: isn't a lower bound 1sat/vbyte anyway? 09:43 < sipa> in practice yes 09:44 < sipa> But the answer to the question "how many utxos have negative EV" isn't well defined - it depends on the feerate the spender wants to use. 09:44 < glozow> maybe one day we can lower the min relay feerate 09:44 * glozow ducks 09:44 < callebtc> I see. I'll rephrase: how many UTXO's have negative EV at 1sat/vB fee rate? 09:44 < sipa> Probably very little, because the dust rule prevents such UTXOs from being created. 09:45 < m011> I think adding something like "max"parameter to fundrwatransaction or send RPC can be a better approach. 09:45 < callebtc> I guess I'd have to ask the on chain metrics people... 09:45 < callebtc> sipa: I see 09:45 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 09:45 < stickies-v> sipa but the dust rule is policy right, so non-core clients may not adhere to that? and I don't think the dust policy has always been in place? 09:46 < sipa> Sure, but the minrelayfee of 1 sat/vbyte is also policy. 09:47 < stickies-v> ah, right 09:47 < glozow> stickies-v: non-core clients would be silly not to adhere to policy, since it would make their mempool very unreliable 09:47 < erik> Maybe a few very old utxos from minrelayfee times 09:48 < erik> But may be minor 09:48 < stickies-v> yeah good point - and to be clear i'm not advocating for any of this, just checking boundaries 09:48 < rahim> could the wallet construct the transaction, but not broadcast it until the EV is positive? Simply "waiting" doesn't seem very elegant... 09:48 < sipa> rahim: That's equivalent to just using a lower feerate. 09:48 < glozow> rahim: the feerate of the transaction wouldn't change after you've created it 09:48 < sipa> The feerate is choice by the user. 09:49 < Murch> glozow: Wouldn't they'd just have a few extra transactions below minRelayTxFeeRate? I.e. expect a few more txes to be in a block when it would otherwise not be full? 09:49 < rahim> gotcha, makes sense 09:49 < glozow> but yeah you could just wait until the feerates are low to sweep your wallet 09:49 -!- ottosch [~l@187.107.11.13] has quit [Ping timeout: 256 seconds] 09:49 < glozow> Murch: sorry who's they? 09:49 -!- Guest996 [~Guest996@cpe-74-72-184-104.nyc.res.rr.com] has joined #bitcoin-core-pr-reviews 09:50 < rahim> glozow: Andreas Antonop has talked about that before, right 09:50 < Murch> People with a lower minRelayTxFeerate: how would their Mempool be "unreliable"? 09:50 < glozow> oh. the 1sat/vB floor doesn't change even if your mempool is empty, so if your mempool accepts something under 1sat/vB, that doesn't mean it'll propagate 09:50 < glozow> ideally your mempool is a good indicator of what miners have in their mempools 09:50 -!- ottosch [~l@187.107.11.13] has joined #bitcoin-core-pr-reviews 09:51 < Murch> Ah yes, in that regard they would be unreliable. 09:52 -!- C3P0 [~C3P0@201.211.48.193] has quit [Quit: Connection closed] 09:52 -!- C3P0 [~C3P0@201.211.48.193] has joined #bitcoin-core-pr-reviews 09:52 < glozow> alright i'll just throw out a few of the implementation questions now, since we're running out of time 09:52 < glozow> What is the type of `bnb_result` declared here https://github.com/bitcoin-core-review-club/bitcoin/commit/89d1d6ff4c79b31f4b6849c7ef906833cfd49d85#diff-6e06b309cd494ef5da4e78aa0929a980767edd12342137f268b9219167064d13R410 (and srd_result a few lines below)? How does it resolve as a boolean expression in the if statement? 09:53 < erik> It's std::optional 09:53 < larryruane> it's an optional, which means it can have a value or not, sort of replaces using a null pointer to mean no value 09:53 < glozow> erik: almost there, it's an optional what? 09:53 < stickies-v> SelectionResult 09:53 < glozow> bingo 09:54 < glozow> larryruane: yep, true if there's a `SelectionResult`, false if it's a nullopt 09:54 < glozow> but on that line, why use `auto`? 09:54 < erik> Optional can be used in expressions, if some data is returned it return true, false otherwise 09:54 < larryruane> you can test an optional value as if it's a boolean, but a more explicit way is to call `has_value()` (i think) 09:54 < erik> Like Some() in Rust 09:55 -!- Murchin [~Murch@pool-173-77-204-199.nycmny.fios.verizon.net] has quit [Quit: Connection closed] 09:55 < sipa> Or Just in Haskell. 09:55 < glozow> erik: yeah exactly 09:55 < erik> glozow: Auto instructs the compiler to infer the type 09:55 < erik> With is std::optional 09:55 < erik> *infer based on the assigment 09:55 < glozow> erik: yup 09:56 < glozow> Can you find other examples of this calling pattern in the codebase? We use it quite often 09:56 < kalpa> what does bnb and srd stand for? 09:56 < glozow> kalpa: Branch and Bound, Single Random Draw. coin selection algos 09:56 -!- og5123 [~og5123@66.135.146.212] has quit [Ping timeout: 256 seconds] 09:57 < larryruane> you can use the indirect (*) to fetch the value or you can be more explicit and call the `value()` method 09:57 < sipa> Super pedantic nit: auto isn't "the compiler inferring the type"; it is specified by the language what the type is; just implied by the expression rather than being explicit (I say this because it isn't like compilers that are smarter can be better at this or so). 09:57 < brunoerg> interesting 09:58 < glozow> sipa: right 09:58 < glozow> and you won't accidentally cast something 09:58 < kouloumos> kalpa: good discussion on those at https://bitcoincore.reviews/17526 09:59 < glozow> alrighty the rest of the questions are left as an exercise to the PR reviewer :) thank you all for coming! 09:59 < glozow> #endmeeting 09:59 < tarun> thank you. 09:59 < kalpa> thanks for having us 09:59 < janoside> thank you 10:00 < rahim> thank you! 10:00 < svav> Thanks all 10:00 < lightlike> thanks glozow ! 10:00 < George[m]1> Thank you 10:00 < erik> thaks 10:00 < brunoerg> thanks! 10:00 < larryruane> thanks glozow and everyone else, super informative! 10:00 < erik> thanks* 10:00 < stickies-v> Thanks glozow and achow101 ! 10:00 -!- svav [~svav@82-69-86-143.dsl.in-addr.zen.co.uk] has quit [Quit: Connection closed] 10:01 < Murch> Thanks :) 10:01 -!- janoside [~janoside@cpe-65-31-20-166.insight.res.rr.com] has quit [Quit: Connection closed] 10:02 -!- C3P0 [~C3P0@201.211.48.193] has quit [Quit: Connection closed] 10:05 -!- rahim [~rahim@c-98-207-69-88.hsd1.ca.comcast.net] has quit [Quit: Connection closed] 10:05 -!- og5123 [~og5123@66.135.147.73] has joined #bitcoin-core-pr-reviews 10:06 -!- Guest996 [~Guest996@cpe-74-72-184-104.nyc.res.rr.com] has quit [Quit: Connection closed] 10:07 -!- tim14 [~tim@c-73-217-34-231.hsd1.co.comcast.net] has quit [Quit: Connection closed] 10:08 -!- kalpa [~kalpa@5.146.160.32] has quit [Quit: Leaving] 10:13 -!- fqxjkdtbwnm5 [~fqxjkdtbw@dslb-178-003-199-224.178.003.pools.vodafone-ip.de] has quit [Quit: Leaving] 10:21 -!- jb55 [~jb55@user/jb55] has quit [Ping timeout: 240 seconds] 10:29 -!- og5123 [~og5123@66.135.147.73] has quit [Quit: Connection closed] 10:43 -!- jb55 [~jb55@user/jb55] has joined #bitcoin-core-pr-reviews 10:49 -!- Julianmrodri [~Julianmro@r167-61-134-159.dialup.adsl.anteldata.net.uy] has quit [Quit: Connection closed] 10:55 -!- Heitor [~Heitor@187.106.32.177] has quit [Quit: Connection closed] 11:02 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 11:02 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews 11:12 -!- jb55 [~jb55@user/jb55] has quit [Ping timeout: 240 seconds] 11:16 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 11:43 -!- NackPaddyWack [~NackPaddy@cpe-65-24-249-149.insight.res.rr.com] has joined #bitcoin-core-pr-reviews 11:44 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 11:47 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 11:49 -!- NackPaddyWack [~NackPaddy@cpe-65-24-249-149.insight.res.rr.com] has quit [Quit: Connection closed] 11:50 -!- ottosch [~l@187.107.11.13] has quit [Quit: Konversation terminated!] 12:35 -!- jb55 [~jb55@user/jb55] has joined #bitcoin-core-pr-reviews 12:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Remote host closed the connection] 12:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 12:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 12:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 12:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 12:59 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-pr-reviews 12:59 -!- constantin21 [~constanti@pd9f94abd.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds] 13:03 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 256 seconds] 13:03 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 256 seconds] 13:05 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity] 13:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 13:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 13:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 13:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 13:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 13:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 252 seconds] 13:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 13:38 -!- jb55 [~jb55@user/jb55] has quit [Ping timeout: 256 seconds] 13:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 13:43 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-pr-reviews 13:48 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 256 seconds] 14:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 14:08 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 256 seconds] 14:09 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-pr-reviews 14:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 252 seconds] 14:11 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Excess Flood] 14:12 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-pr-reviews 14:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 14:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 14:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 14:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 14:28 -!- callebtc [~callebtc@i59F7FCBB.versanet.de] has quit [Quit: Connection closed] 14:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 14:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 14:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 14:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 14:54 -!- kouloumos [~kouloumos@62-10-208.netrun.cytanet.com.cy] has quit [Quit: Connection closed] 15:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 15:16 -!- jb55 [~jb55@user/jb55] has joined #bitcoin-core-pr-reviews 15:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 252 seconds] 15:19 -!- no [~no@41.212.27.234] has joined #bitcoin-core-pr-reviews 15:20 -!- no [~no@41.212.27.234] has quit [Client Quit] 15:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 15:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 15:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 15:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 15:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 15:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 15:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 15:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 15:58 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 16:00 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 16:19 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-pr-reviews 16:23 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 240 seconds] 16:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 16:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 16:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 16:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 16:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 16:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 16:52 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 16:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [Ping timeout: 240 seconds] 17:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has joined #bitcoin-core-pr-reviews 17:20 -!- tarun [tarun@gateway/vpn/protonvpn/tarun] has quit [Quit: Konversation terminated!] 17:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:543e:6d61:a966:5292] has quit [] 17:59 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-pr-reviews 18:00 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 256 seconds] 18:00 -!- lukedashjr is now known as luke-jr 18:02 -!- b10c__ [uid500648@user/b10c] has quit [Quit: Connection closed for inactivity] 18:35 -!- Yihen [~textual@114.113.238.18] has quit [Ping timeout: 256 seconds] 18:53 -!- Yihen [~textual@dn.ptr238.ptrcloud.net] has joined #bitcoin-core-pr-reviews 19:47 -!- jb55 [~jb55@user/jb55] has quit [Ping timeout: 256 seconds] 20:13 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 20:16 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 21:06 -!- turkycat [~turkycat@c-67-185-164-184.hsd1.wa.comcast.net] has quit [Quit: Connection closed] 21:35 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 21:36 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews 22:08 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Ping timeout: 256 seconds] 23:01 -!- r-ush [~r-ush@52.187.184.81] has quit [Quit: ZNC 1.7.5+deb4 - https://znc.in] 23:20 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-pr-reviews --- Log closed Thu Jan 06 00:00:22 2022