--- Log opened Tue Jan 25 00:00:40 2022 00:06 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 00:06 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 00:27 -!- panti [~panticlos@7.red-83-50-254.dynamicip.rima-tde.net] has quit [Quit: Connection closed] 01:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:355d:db20:bc40:ab7e] has quit [Ping timeout: 240 seconds] 01:16 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 01:16 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 01:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 02:18 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 02:20 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 02:32 -!- dunxen [~dunxen@gateway/tor-sasl/dunxen] has quit [Remote host closed the connection] 02:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Ping timeout: 250 seconds] 02:52 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-pr-reviews 03:33 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 03:34 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews 03:35 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Remote host closed the connection] 03:47 -!- TheRec [~toto@user/therec] has quit [Read error: Connection reset by peer] 03:49 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-pr-reviews 03:49 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 03:49 -!- TheRec [~toto@user/therec] has joined #bitcoin-core-pr-reviews 03:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 03:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Ping timeout: 268 seconds] 04:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 04:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Remote host closed the connection] 04:38 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-pr-reviews 04:42 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 240 seconds] 04:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 04:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Ping timeout: 268 seconds] 05:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 05:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Ping timeout: 250 seconds] 06:04 -!- ziggie [uid521459@user/ziggie] has joined #bitcoin-core-pr-reviews 06:09 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-pr-reviews 06:13 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 256 seconds] 06:25 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-pr-reviews 06:43 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Remote host closed the connection] 07:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 07:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Ping timeout: 240 seconds] 07:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 07:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Ping timeout: 250 seconds] 08:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 08:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Ping timeout: 240 seconds] 08:37 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-pr-reviews 09:03 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-pr-reviews 09:07 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 240 seconds] 09:27 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 09:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 09:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Ping timeout: 240 seconds] 10:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 10:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Ping timeout: 268 seconds] 10:36 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 11:03 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-pr-reviews 11:03 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 11:04 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 11:05 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Client Quit] 11:06 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 11:07 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 240 seconds] 11:16 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 11:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 11:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Ping timeout: 268 seconds] 12:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 12:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Ping timeout: 240 seconds] 13:03 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 240 seconds] 13:25 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-pr-reviews 13:42 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Remote host closed the connection] 13:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 14:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Remote host closed the connection] 14:35 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-pr-reviews 14:39 < ziggie> Hello, I am preparing for tomorrows review club and was wondering if somebody had also problems compiling PR 24007 ? I rebased it to the current master and it complains about: UpdateTransactionsFromBlock in validation.cpp. Not sure if this is the right time or place to ask ? 14:39 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 240 seconds] 14:40 < ziggie> missing parametes 14:40 < ziggie> ancestor_size_limit and ancestor_count_limit 14:50 < lightlike> ziggie: yes, this is the right place: There was a silent merge conflict with #21464 which just got merged and added mandatory arguments to UpdateTransactionsFromBlock(). This PR calls UpdateTransactionsFromBlock() without these arguments. 14:50 < lightlike> ziggie: you could leave a comment in the PR that it needs rebase because of that. 14:51 < ziggie> will do thanks for the quick answer :) 15:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 15:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Ping timeout: 268 seconds] 15:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 15:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Ping timeout: 240 seconds] 16:34 -!- Kaizen_Kintsugi_ [~Kaizen_Ki@node-1w7jr9yi65te66oclonkh96li.ipv6.telus.net] has quit [Remote host closed the connection] 16:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 16:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Ping timeout: 250 seconds] 17:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 17:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Ping timeout: 268 seconds] 17:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 17:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Ping timeout: 240 seconds] 18:18 < larryruane> I'm working on fixing this now, thanks for catching this ziggie 18:23 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 18:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 18:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Ping timeout: 240 seconds] 18:47 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-pr-reviews 19:00 -!- tralfaz [~davterra@143.198.56.186] has quit [Ping timeout: 240 seconds] 19:11 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-pr-reviews 19:16 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 250 seconds] 19:53 -!- davterra [~davterra@143.198.56.186] has joined #bitcoin-core-pr-reviews 20:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 20:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Ping timeout: 268 seconds] 20:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 20:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Ping timeout: 240 seconds] 20:49 -!- jaonoctus [~jaonoctus@vmi550577.contaboserver.net] has joined #bitcoin-core-pr-reviews 21:00 -!- jaonoctus [~jaonoctus@vmi550577.contaboserver.net] has quit [Quit: Ping timeout (120 seconds)] 21:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews 21:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has quit [Ping timeout: 240 seconds] 21:43 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-pr-reviews 21:48 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 250 seconds] 22:30 -!- gleb74543863 [~gleb@178.150.137.228] has joined #bitcoin-core-pr-reviews 22:31 -!- gleb7454386 [~gleb@178.150.137.228] has quit [Ping timeout: 250 seconds] 22:31 -!- gleb74543863 is now known as gleb7454386 22:33 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-pr-reviews 22:37 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 240 seconds] 23:08 -!- brunoerg [~brunoerg@187.183.47.88] has joined #bitcoin-core-pr-reviews 23:12 -!- brunoerg [~brunoerg@187.183.47.88] has quit [Ping timeout: 250 seconds] 23:17 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 23:49 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-pr-reviews 23:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4178:22ae:f494:3f2] has joined #bitcoin-core-pr-reviews --- Log closed Wed Jan 26 00:00:41 2022