--- Log opened Wed Mar 09 00:00:21 2022 00:07 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 272 seconds] 00:23 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 00:23 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 00:42 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 00:53 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 00:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:932:2bab:ad95:da18] has joined #bitcoin-core-pr-reviews 01:00 -!- George[m] [~georgezen@2001:470:69fc:105::1:5d4a] has quit [Quit: You have been kicked for being idle] 01:00 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 272 seconds] 01:09 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 01:09 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 01:12 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 01:24 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 01:24 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 01:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:932:2bab:ad95:da18] has quit [Ping timeout: 268 seconds] 02:10 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 02:10 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 02:16 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 272 seconds] 02:18 -!- jamesob [~jamesob@45.129.56.197] has quit [Quit: Ping timeout (120 seconds)] 02:18 -!- jamesob [~jamesob@45.129.56.197] has joined #bitcoin-core-pr-reviews 02:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:932:2bab:ad95:da18] has joined #bitcoin-core-pr-reviews 02:29 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 02:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:932:2bab:ad95:da18] has quit [Ping timeout: 250 seconds] 02:32 -!- shesek__ [~shesek@user/shesek] has quit [Ping timeout: 240 seconds] 02:45 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 02:56 -!- da39a3ee5e6b4b0_ [~textual@171.5.29.46] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 02:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:932:2bab:ad95:da18] has joined #bitcoin-core-pr-reviews 03:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:932:2bab:ad95:da18] has quit [Ping timeout: 268 seconds] 03:12 -!- provoostenator [~quassel@user/provoostenator] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 03:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:932:2bab:ad95:da18] has joined #bitcoin-core-pr-reviews 03:53 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 04:04 -!- provoostenator [~quassel@user/provoostenator] has joined #bitcoin-core-pr-reviews 04:05 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 04:09 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 04:19 -!- provoostenator [~quassel@user/provoostenator] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 04:19 -!- provoostenator [~quassel@user/provoostenator] has joined #bitcoin-core-pr-reviews 04:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:932:2bab:ad95:da18] has quit [Ping timeout: 260 seconds] 04:24 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 04:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:932:2bab:ad95:da18] has joined #bitcoin-core-pr-reviews 04:54 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 04:55 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 05:09 < michaelfolkson> Is achow101 hosting today with Covid? 05:29 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 05:40 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 05:40 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 05:41 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 05:43 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:ecfc:ebe1:b77a:f914] has joined #bitcoin-core-pr-reviews 05:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:932:2bab:ad95:da18] has quit [Remote host closed the connection] 05:47 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 05:47 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 06:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:7d1b:7777:3915:b95a] has joined #bitcoin-core-pr-reviews 06:01 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:ecfc:ebe1:b77a:f914] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 06:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:7d1b:7777:3915:b95a] has quit [Ping timeout: 240 seconds] 06:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:7d1b:7777:3915:b95a] has joined #bitcoin-core-pr-reviews 06:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:7d1b:7777:3915:b95a] has quit [Ping timeout: 240 seconds] 06:12 < achow101> michaelfolkson: I'm mostly recovered 06:18 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-pr-reviews 06:27 < michaelfolkson> Cool, good to hear! 06:28 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 06:38 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-pr-reviews 06:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:7d1b:7777:3915:b95a] has joined #bitcoin-core-pr-reviews 06:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:7d1b:7777:3915:b95a] has quit [Ping timeout: 240 seconds] 06:45 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 250 seconds] 06:54 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 06:57 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-pr-reviews 06:59 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 07:03 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 07:07 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:7d1b:7777:3915:b95a] has joined #bitcoin-core-pr-reviews 07:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:7d1b:7777:3915:b95a] has quit [Ping timeout: 252 seconds] 07:17 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 07:22 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 272 seconds] 07:25 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 07:34 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 07:34 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 07:40 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-pr-reviews 07:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:7d1b:7777:3915:b95a] has joined #bitcoin-core-pr-reviews 07:51 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:53 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-pr-reviews 08:16 -!- hernanmarino [~hernanmar@186.127.88.9] has joined #bitcoin-core-pr-reviews 08:29 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 08:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:7d1b:7777:3915:b95a] has quit [Ping timeout: 240 seconds] 08:30 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 08:40 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection] 08:41 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 08:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 08:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 250 seconds] 08:53 -!- Franklin [~Franklin@197.210.79.198] has joined #bitcoin-core-pr-reviews 08:56 -!- sanya [~sanya@178-223-2-115.dynamic.isp.telekom.rs] has joined #bitcoin-core-pr-reviews 08:57 -!- B_1o1 [~B_1o1@187.202.213.90] has joined #bitcoin-core-pr-reviews 08:57 -!- svav [~svav@82-69-86-143.dsl.in-addr.zen.co.uk] has joined #bitcoin-core-pr-reviews 09:00 < achow101> #startmeeting 09:00 < svav> Hi 09:00 -!- bitplebpaul [~bitplebpa@24.225.251.48] has joined #bitcoin-core-pr-reviews 09:00 -!- Franklin [~Franklin@197.210.79.198] has quit [Ping timeout: 256 seconds] 09:00 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has joined #bitcoin-core-pr-reviews 09:01 < achow101> Welcome to PR review club. Today we're looking at #19602 wallet: Migrate legacy wallets to descriptor wallets 09:01 -!- vnprc [~vnprc@136.56.34.9] has joined #bitcoin-core-pr-reviews 09:01 < bitplebpaul> hi 09:01 < B_1o1> hi, all 09:01 < effexzi> Hey every1 09:02 < achow101> did everyone get a chance to review the PR and the notes? y/n 09:02 < svav> Read the notes 09:02 < michaelfolkson> hi 09:03 < larryruane> hi 09:03 < hernanmarino> hi 09:03 < glozow> hi 09:03 < B_1o1> y/y, basic test of new wallet migration 09:03 < Kaizen_Kintsugi_> hi 09:03 < Kaizen_Kintsugi_> n, just gonna lurk 09:03 < michaelfolkson> y 09:03 < glozow> read notes, still reviewing 09:04 < hernanmarino> read notes only 09:04 < michaelfolkson> B_1o1: You generated a legacy-bdb wallet, sent funds to it and then used the migratewallet RPC? 09:05 < svav> Can someone describe the nature of the Berkeley DB dependency? 09:05 < svav> *briefly* XD 09:05 < B_1o1> michaelfolkson: just generated the legacy and migrated, didn't sent funds 09:05 -!- bitplebpaul [~bitplebpa@24.225.251.48] has quit [Quit: Connection closed] 09:06 < glozow> it's an evil, evil dependency that we must dispel 09:06 -!- bitplebpaul [~bitplebpa@24.225.251.48] has joined #bitcoin-core-pr-reviews 09:06 < achow101> svav: It is used as the database system for the legacy wallet. 09:06 < achow101> it's also unmaintained 09:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 09:06 < brunoerg> did I miss it? 09:06 < svav> So what would it be replaced by? 09:06 -!- bitplebpaul [~bitplebpa@24.225.251.48] has quit [Client Quit] 09:06 -!- bitplebpaul4 [~bitplebpa@72.143.215.208] has joined #bitcoin-core-pr-reviews 09:06 < achow101> sqlite 09:06 < svav> ok thx 09:07 < achow101> did anyone try to migrate a legacy wallet? 09:07 < glozow> i found this video to be a nice intro to descriptor wallets https://www.youtube.com/watch?v=xC25NzIjzog 09:08 < michaelfolkson> B_1o1: Cool. I thought to test the migration you'd need to have some funds (testnet/signet maybe) at an address. Otherwise you are migrating an empty wallet to a different empty wallet 09:08 < B_1o1> yeah I migh 09:08 < B_1o1> might try later 09:09 < glozow> or use regtest and generate to an address owned by the wallet 09:09 < michaelfolkson> Is that right achow101? Is there value in testing migration without any funds in that wallet? 09:10 < achow101> michaelfolkson: certainly. the migration deals with keys and scripts, not really transactions. Even without funds you can check that the keys and scripts were migrated correctly 09:11 < michaelfolkson> But keys with no value attributed to them? They were just previously generated but no Bitcoin sent to them? 09:11 < achow101> we must still watch for funds sent to them all the same 09:11 < hernanmarino> you might receive funds in the future, i guess 09:11 < michaelfolkson> Ok cool 09:12 < michaelfolkson> B_1o1: You should definitely comment on the PR with what you tested then :) 09:12 < B_1o1> michaelfolkson: +1 09:13 < achow101> could someone briefly describe the migration process? 09:13 < glozow> Basically pack everything into a `MigrationData` struct - keys, keyids, hd seeds, key origins, scripts, etc 09:14 < svav>  descriptors are computed for everything the legacy wallet would have considered to belong to it 09:14 -!- santimena [~santimena@45.176.89.48] has joined #bitcoin-core-pr-reviews 09:14 < svav> These descriptors are subsequently added to a newly created descriptor wallet with the same name as the original Legacy wallet 09:15 < glozow> and then create a descriptor wallet, generate descriptors using all this stuff 09:16 < glozow> also make a sqlite db and write everything 09:16 < achow101> svav: indeed! 09:16 < achow101> how do we compute everything the legacy wallet would have considered to belong to it? 09:17 < Kaizen_Kintsugi_> GetLegacyScriptPubKeyMan? 09:18 < achow101> Kaizen_Kintsugi_: not quite. That just retrieves the ScriptPubKeyMan object for all the legacy wallet logic 09:18 < B_1o1> if it's able to sign for the script or if the Script is being watched? 09:19 < Kaizen_Kintsugi_> Hmmm m_database->makeBatch? this seems to scoop up all the records in the database 09:19 < larryruane> glozow: "and then write everything" ... If the node crashes at a random time during the migration, are we guaranteed to be okay? Start up the node again and it finishes the migration? 09:19 < glozow> is it everything that isn't ISMINE_NO? 09:19 < achow101> B_1o1: that's part of it 09:20 < achow101> glozow: and how do we determine that? 09:21 < Kaizen_Kintsugi_> ISMINE_No determines if it is a watchonly? 09:22 < glozow> should i be looking at `IsMineInner()` ? 09:22 < achow101> yes 09:23 < achow101> Kaizen_Kintsugi_: ISMINE_NO means that the script does not belong to the wallet. The trick is finding the finite set of scripts that are not ISMINE_NO, as there is an inifinite number of scripts that are. 09:24 < Kaizen_Kintsugi_> good to know 09:24 < glozow> aha. we look at the spk, and depending on the type, see if we have the key/script for it in our `keystore` 09:24 < achow101> glozow: right! and what about multisigs? 09:24 < glozow> we need to own all of the keys involved 09:25 < glozow> https://github.com/bitcoin/bitcoin/blob/47bbd3ff4f5e0c04da4731c5d26d23d97cfa0bf1/src/wallet/scriptpubkeyman.cpp#L187-L192 09:26 < achow101> indeed. so how do we go from IsMineInner to a set of scriptPubKeys? 09:26 < achow101> or rather a set of descriptors 09:28 < Kaizen_Kintsugi_> Is it in APplyMigrationData? 09:28 < achow101> no 09:28 < Kaizen_Kintsugi_> MigrateToDescriptor? 09:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Remote host closed the connection] 09:29 < achow101> it's in GetAllScriptPubKeys 09:29 < achow101> sorry, GetScriptPubKeys 09:30 < michaelfolkson> Ha was gonna say, that isn't in scriptpubkeyman.cpp 09:32 < svav> Get the DescriptScriptPubKeyMans that have the same scriptPubKeys as this LegacyScriptPubKeyMan ?? 09:33 < glozow> ok so here we're going through `mapKeys`, `mapCryptedKeys`, and `mapScripts`, and adding them to spks if `IsMine()` 09:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 09:34 < glozow> er - we only call `IsMine()` for the scripts 09:35 < glozow> and then in `MigrateToDescriptor()`, after we gather this set of spks, we create `desc_spkms` etc 09:36 -!- santimena [~santimena@45.176.89.48] has quit [Quit: Connection closed] 09:36 < achow101> so a related question is why we have to do this at all? what is the difference between LegacyScriptPubKeyMan::IsMine and DescriptorScriptPubKeyMan::IsMine? 09:37 < Kaizen_Kintsugi_> DescriptorScripts seem like they are only spendable? 09:37 < glozow> `DescriptorScriptPubKeyMan` doesn't include watchonly 🤔 09:38 < Kaizen_Kintsugi_> +1 glozow 09:39 < glozow> so the watchonly stuff is put in a different `CWallet`? 09:39 < ls55> I think `DescriptorScriptPubKeyMan` also doesn't include `FillableSigningProvider::mapKeys`. 09:39 < glozow> std::shared_ptr watchonly_wallet{nullptr}; 09:39 < glozow> std::shared_ptr solvable_wallet{nullptr}; 09:39 < achow101> Kaizen_Kintsugi_: kind of, it depends on the wallet type, but Descriptor wallets get rid of the concept of mixed watchonly and spendable. Of course we have to deal with this somehow during migration 09:40 < svav> Descriptor wallets can either have private keys or be watch only, not both ?? 09:40 < achow101> glozow: right 09:40 < achow101> svav: yes 09:40 < michaelfolkson> Why (get rid of this concept)? 09:40 < Kaizen_Kintsugi_> single responsibility pricipal? 09:40 < michaelfolkson> Just cleaner? It isn't descriptor related... 09:41 < glozow> definitely think this is simpler. why were watchonly and owned mixed together before? 09:41 < achow101> michaelfolkson: it really simplifies IsMine. Also separation of funds/duties/etc. 09:41 < Kaizen_Kintsugi_> watchonly wallets wouldn't need to store scripts? 09:41 < achow101> glozow: because it used to not be possible to have different wallet files for different purposes 09:42 < achow101> multiwallet is relatively recent 09:43 < Kaizen_Kintsugi_> This is to help organizational purposes I assume? 09:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Remote host closed the connection] 09:44 < achow101> yes 09:44 < glozow> are there other multiple wallets to separate beyond watchonly and owned? 09:45 < ls55> External Signer ? 09:45 < achow101> glozow: yes. you pointed out watchonly_wallet and solvable_wallet, but solvable_wallet is not the same as the spendable wallet. it's watchonly, but also slightly different 09:45 < Kaizen_Kintsugi_> o rly? I thought solvable and spendable were sonoymous 09:46 < Kaizen_Kintsugi_> I guess that has to do with multisig? where I would have 1 of N keys? I can partially solve but can't spend? 09:47 < michaelfolkson> Kaizen_Kintsugi_: https://bitcoin.stackexchange.com/questions/63198/why-outputs-spendable-and-solvable-are-false 09:47 < achow101> Kaizen_Kintsugi_: solvable means that we would be able to sign if we knew the keys 09:47 < glozow> is spendable a subset of solvable? 09:47 < achow101> but the split between watchonly and solvable actually goes back to LegacyScriptPubKeyMan::IsMine 09:47 < achow101> there's actually a solvable, but not watchonly set of scripts 09:47 < svav> Some background info on Descriptors https://github.com/bitcoin/bitcoin/blob/master/doc/descriptors.md 09:48 < achow101> could anyone describe how that might happen? 09:48 < Kaizen_Kintsugi_> missing script? 09:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 09:49 < achow101> Kaizen_Kintsugi_: missing the script would mean it is not solvable 09:50 < achow101> (this requires looking at SignStep in src/script/sign.cpp) 09:50 < michaelfolkson> glozow: That's my understanding. You can't spend if not solvable. But it can be solvable without you being able to spend 09:51 < ls55> `if scriptPubKey could not be completely satisfied.` ? 09:51 < glozow> multisig but don't know all pubkeys? 09:51 < glozow> wait is that a thing 09:52 < vnprc> does it have to do with standard script types? 09:52 < ls55> ` 09:52 < ls55> case TxoutType::NONSTANDARD: 09:52 < ls55> case TxoutType::NULL_DATA: 09:52 < ls55> case TxoutType::WITNESS_UNKNOWN: 09:52 < ls55> ` 09:52 < Murch> Yeah, achow101: is there a way for an output to be spendable but not solvable? 09:52 < glozow> no 09:52 < achow101> It is not possible for a script to be spendable but not solvable 09:53 < achow101> glozow: I think that might be true 09:53 < michaelfolkson> glozow: As a general concept you do need to know the pubkeys of the multisig to spend from it 09:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 268 seconds] 09:54 < achow101> we could have a multisig script, but not all the keys for it, and also not necessarily be watching the spk 09:54 < michaelfolkson> At least with CHECKMULTISIG, with CHECKSIGADD....same deal?! 09:54 < Kaizen_Kintsugi_> makes sense 09:55 < achow101> michaelfolkson: no, that's taproot so descriptors only 09:55 < michaelfolkson> Indeed, thanks 09:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 09:55 < glozow> okay yeah so if it was a 1 of 2 multisig script, you have a key and it's solvable, but you're not watching the script 09:55 < ls55> Isn't legacy wallet compatible with Taproot ? why ? 09:56 < michaelfolkson> Taproot is only descriptors (as Andrew said). Just design choice 09:56 < achow101> ls55: the legacy wallet does not support taproot. we decided not to implement taproot for it because it will be going away soon(tm) 09:56 < ls55> Ok. Thanks. 09:57 < achow101> related to weird IsMine things, can anyone say what we do with the key for the HD seed? 09:57 < ls55> Will `LegacyScriptPubKeyMan` be removed from codebase ? 09:57 < achow101> ls55: that's the plan 09:57 < svav> What is an HD seed? 09:57 < ls55> Very good. It simplifies the code. 09:58 < hernanmarino> achow101: it gets migrated ? 09:58 < Kaizen_Kintsugi_> seed of an HD wallet 09:58 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 09:58 < ls55> I think not 09:58 < hernanmarino> that was an affirmation not a question . 09:58 < ls55> `Note that we do not ignore the seeds themselves because they are considered IsMine!` 09:58 < Murch> svav: The main secret of a wallet using hierarchical deterministic derivation 09:58 < Murch> See BIP32 09:59 < achow101> ls55: right! what's the implication of that? 09:59 < svav> Thanks Murch: 09:59 < hernanmarino> it is a valid key 09:59 < ls55> A new seed is created in the new descriptor wallet ? 10:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 268 seconds] 10:00 < achow101> hernanmarino: yes, and as a valid key, you could receive Bitcoin to it even though it's corresponding addresses would never be given out 10:00 < hernanmarino> exactly :) 10:01 < Murch> So, we generate one wallet from the seed and another from the descriptor that replaces the derived addresses of the seed? 10:01 -!- bitplebpaul4 [~bitplebpa@72.143.215.208] has quit [Quit: Connection closed] 10:01 < achow101> Murch: the same wallet with multiple descriptors 10:02 < achow101> we're at the top of the hour, so thank you all for coming and for reviewing the pr. 10:02 < achow101> #endmeeting 10:02 < svav> Thanks achow101 and all! 10:02 < Kaizen_Kintsugi_> Thanks for hosting achow101 10:02 < glozow> thanks achow101! 10:02 < Kaizen_Kintsugi_> got a few more wrinkles to unsmooth my brain 10:02 < ls55> thanks achow101. 10:03 < hernanmarino> thanks achow101 ! 10:03 < michaelfolkson> Thanks achow101 (and hope you fully recover from Covid asap!) 10:03 < B_1o1> thank you achow101 and all 10:03 < michaelfolkson> Reminder to post comments on the PR if you've tested and/or reviewed it (I need to get better at doing this more regularly after PR review clubs too) 10:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 10:06 -!- svav [~svav@82-69-86-143.dsl.in-addr.zen.co.uk] has quit [Quit: Connection closed] 10:08 -!- vnprc [~vnprc@136.56.34.9] has quit [Quit: Connection closed] 10:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 10:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 10:18 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 10:18 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 10:19 -!- givanse [~givanse@104.160.131.201] has joined #bitcoin-core-pr-reviews 10:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 10:21 < givanse> On what time zone are the meetings scheduled? 17:00 EST? 10:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 10:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 250 seconds] 10:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 10:37 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 10:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 10:37 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 10:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 10:40 -!- shesek_ [~shesek@user/shesek] has quit [Ping timeout: 240 seconds] 10:40 < michaelfolkson> givanse: 17:00 UTC 10:41 -!- B_1o1 [~B_1o1@187.202.213.90] has quit [Ping timeout: 250 seconds] 10:42 < givanse> Cool, thanks! 10:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 11:00 -!- givanse [~givanse@104.160.131.201] has quit [Quit: Connection closed] 11:01 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 11:01 -!- hernanmarino [~hernanmar@186.127.88.9] has quit [Remote host closed the connection] 11:06 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 252 seconds] 11:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 11:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 11:17 -!- sipa [~sipa@user/sipa] has quit [Quit: Reconnecting] 11:17 -!- sipa [~sipa@user/sipa] has joined #bitcoin-core-pr-reviews 11:19 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 11:22 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 11:24 -!- sanya [~sanya@178-223-2-115.dynamic.isp.telekom.rs] has quit [Quit: Connection closed] 11:34 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 11:34 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 11:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 12:09 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 12:10 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 12:13 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:18 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 12:20 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 12:25 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 12:26 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 12:38 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 12:41 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 12:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Remote host closed the connection] 12:50 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 12:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 12:50 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 12:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 268 seconds] 12:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 13:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 13:03 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 240 seconds] 13:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 13:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 13:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 13:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 13:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 13:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 13:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 13:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Remote host closed the connection] 13:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 13:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 13:54 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 13:55 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 14:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 14:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 250 seconds] 14:25 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:ecfc:ebe1:b77a:f914] has joined #bitcoin-core-pr-reviews 14:31 -!- hashfunce9c [~user@2601:5c0:c280:7090:78e9:5f82:1899:8c96] has joined #bitcoin-core-pr-reviews 14:33 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 14:34 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 14:43 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:ecfc:ebe1:b77a:f914] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 14:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 14:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 268 seconds] 14:59 -!- hashfunce9c [~user@2601:5c0:c280:7090:78e9:5f82:1899:8c96] has quit [Remote host closed the connection] 15:04 -!- hashfunc569 [~user@2601:5c0:c280:7090:78e9:5f82:1899:8c96] has joined #bitcoin-core-pr-reviews 15:32 -!- givanse [~givanse@104.160.131.201] has joined #bitcoin-core-pr-reviews 15:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 15:40 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity] 15:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 260 seconds] 15:48 -!- hashfunc569 [~user@2601:5c0:c280:7090:78e9:5f82:1899:8c96] has quit [Ping timeout: 240 seconds] 15:48 -!- Guest34 [~textual@104.160.131.201] has joined #bitcoin-core-pr-reviews 15:52 -!- givanse [~givanse@104.160.131.201] has quit [Quit: Connection closed] 16:14 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 16:14 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 16:26 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 16:26 -!- da39a3ee5e6b4b0d [~textual@171.5.29.46] has joined #bitcoin-core-pr-reviews 16:40 -!- Guest34 [~textual@104.160.131.201] has quit [Ping timeout: 272 seconds] 16:56 -!- da39a3ee5e6b4b0d [~textual@171.5.29.46] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:56 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 16:57 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:f0a7:d746:8a92:8ad4] has joined #bitcoin-core-pr-reviews 16:58 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection] 16:59 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:f0a7:d746:8a92:8ad4] has quit [Client Quit] 17:00 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 272 seconds] 17:03 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:f0a7:d746:8a92:8ad4] has joined #bitcoin-core-pr-reviews 17:04 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 17:09 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 272 seconds] 17:10 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 17:14 -!- Guest34 [~textual@104.160.131.201] has joined #bitcoin-core-pr-reviews 17:15 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 272 seconds] 17:18 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 17:26 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 17:26 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 17:28 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 250 seconds] 17:31 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:f0a7:d746:8a92:8ad4] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 17:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 17:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 17:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 260 seconds] 17:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 17:54 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:f0a7:d746:8a92:8ad4] has joined #bitcoin-core-pr-reviews 18:06 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 18:23 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 18:24 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-pr-reviews 18:35 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 18:35 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 18:47 -!- Guest34 [~textual@104.160.131.201] has quit [Ping timeout: 250 seconds] 18:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 18:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 19:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 19:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 19:11 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 19:11 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 19:31 -!- Guest34 [~textual@cpe-172-116-62-212.socal.res.rr.com] has joined #bitcoin-core-pr-reviews 19:40 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 250 seconds] 19:47 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 19:50 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 19:50 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 19:52 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 19:55 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 19:59 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 20:01 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 20:06 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 272 seconds] 20:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 260 seconds] 20:18 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 20:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 20:20 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-pr-reviews 20:23 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 20:30 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 20:35 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 20:43 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 20:43 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 20:50 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:f0a7:d746:8a92:8ad4] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 20:51 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-pr-reviews 21:01 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 250 seconds] 21:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 21:36 -!- Guest34 [~textual@cpe-172-116-62-212.socal.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:50 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:f0a7:d746:8a92:8ad4] has joined #bitcoin-core-pr-reviews 22:02 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 22:03 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 22:21 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:f0a7:d746:8a92:8ad4] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 22:23 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:f0a7:d746:8a92:8ad4] has joined #bitcoin-core-pr-reviews 22:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 240 seconds] 22:34 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 22:35 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-core-pr-reviews 22:35 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 22:39 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 256 seconds] 22:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 22:51 -!- timrohde [~timrohde@97-118-240-243.hlrn.qwest.net] has joined #bitcoin-core-pr-reviews 22:55 -!- hashfunc569 [~user@2601:5c0:c280:7090:78e9:5f82:1899:8c96] has joined #bitcoin-core-pr-reviews 23:20 -!- timrohde [~timrohde@97-118-240-243.hlrn.qwest.net] has quit [Quit: Leaving] 23:24 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer] 23:28 -!- sanya [~sanya@178-223-2-115.dynamic.isp.telekom.rs] has joined #bitcoin-core-pr-reviews 23:28 -!- sanya [~sanya@178-223-2-115.dynamic.isp.telekom.rs] has quit [Client Quit] 23:39 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 23:44 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 23:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has quit [Ping timeout: 252 seconds] 23:45 -!- hashfunc569 [~user@2601:5c0:c280:7090:78e9:5f82:1899:8c96] has quit [Ping timeout: 240 seconds] 23:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f899:a022:6555:a189] has joined #bitcoin-core-pr-reviews 23:52 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:d2a9:f0a7:d746:8a92:8ad4] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 23:55 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews --- Log closed Thu Mar 10 00:00:21 2022