--- Log opened Wed Apr 20 00:00:00 2022
00:34 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
00:34 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds]
00:39 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds]
00:45 -!- Common [~Common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-pr-reviews
00:51 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
00:56 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds]
01:09 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
01:14 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds]
01:15 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8991:607e:99a0:6a0e] has quit [Ping timeout: 240 seconds]
01:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8991:607e:99a0:6a0e] has joined #bitcoin-core-pr-reviews
01:22 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
02:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8991:607e:99a0:6a0e] has quit [Ping timeout: 240 seconds]
02:27 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 248 seconds]
02:27 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews
02:41 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
02:46 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds]
02:58 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
03:02 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 250 seconds]
03:14 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
03:17 -!- duderonomy [~duderonom@c-73-158-190-156.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
03:19 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 248 seconds]
03:31 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
03:33 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 240 seconds]
03:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f183:1645:b304:b55a] has joined #bitcoin-core-pr-reviews
04:04 -!- wybpip[m] [~wybpipmat@2001:470:69fc:105::1:f452] has joined #bitcoin-core-pr-reviews
04:04 -!- wybpip[m] [~wybpipmat@2001:470:69fc:105::1:f452] has left #bitcoin-core-pr-reviews []
04:35 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 260 seconds]
04:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f183:1645:b304:b55a] has quit [Ping timeout: 248 seconds]
04:41 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews
04:47 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
04:51 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 250 seconds]
05:04 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
05:06 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
05:08 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
05:10 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds]
05:22 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
05:28 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds]
05:39 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
05:43 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds]
05:56 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
06:10 -!- jonasschnelli [~jonasschn@2a01:4f9:2a:2510::2] has quit [Quit: ZNC - http://znc.in]
06:11 -!- jonasschnelli [~jonasschn@2a01:4f9:2a:2510::2] has joined #bitcoin-core-pr-reviews
07:00 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds]
07:13 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
07:24 -!- sagar7 [~sagar@106.215.21.194] has joined #bitcoin-core-pr-reviews
07:33 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
07:34 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
07:45 -!- sagar7 [~sagar@106.215.21.194] has quit [Quit: Connection closed]
07:49 -!- achow101 [~achow101@user/achow101] has quit [Quit: Bye]
07:50 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-pr-reviews
07:51 -!- Dweezahr [~user@109-175-210-87.ftth.glasoperator.nl] has joined #bitcoin-core-pr-reviews
08:11 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
08:11 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
08:16 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
08:19 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
08:23 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds]
08:32 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
08:36 -!- duderonomy [~duderonom@c-73-158-190-156.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews
09:08 -!- M4rc0 [~M4rc0@186.84.21.96] has joined #bitcoin-core-pr-reviews
09:25 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
09:26 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
09:30 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds]
09:32 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
09:32 -!- rage-proof [~rage-proo@ip5f5bf12d.dynamic.kabel-deutschland.de] has joined #bitcoin-core-pr-reviews
09:36 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer]
09:36 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
09:38 -!- M4rc0 [~M4rc0@186.84.21.96] has quit [Ping timeout: 248 seconds]
09:41 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
09:52 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has joined #bitcoin-core-pr-reviews
09:53 -!- ccdle12 [~ccdle12@243.222.90.149.rev.vodafone.pt] has joined #bitcoin-core-pr-reviews
09:53 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
09:56 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer]
09:57 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
09:58 -!- svav [~svav@82-69-86-143.dsl.in-addr.zen.co.uk] has joined #bitcoin-core-pr-reviews
09:59 -!- Observer30 [~Observer@cpe-23-242-148-67.socal.res.rr.com] has joined #bitcoin-core-pr-reviews
10:00 < glozow> #startmeeting
10:00 < glozow> hi there!
10:00 < stickies-v> hi
10:00 < svav> Hi
10:00 < glozow> Welcome to PR Review Club!
10:00 < lightlike> hi
10:00 < emzy> Hi
10:00 < theStack> hi
10:00 < glozow> We're reviewing a miner bug fix today, "update for ancestor inclusion using modified fees, not base"
10:01 < glozow> Notes: https://bitcoincore.reviews/24538
10:01 < larryruane> hi
10:01 < glozow> Any first-timers?
10:01 -!- ishaanam [~ishaanam@45.15.176.31] has joined #bitcoin-core-pr-reviews
10:01 < Dweezahr> yeah first time for me
10:01 < glozow> welcome Dweezahr!
10:02 < Dweezahr> Thank you
10:02 < glozow> This is our first time looking at the mining code in pr review club (afaik), so hopefully there's something new to learn for everyone
10:02 < svav> Dweezahr where did you hear about this meeting, if you don't mind sharing?
10:02 < glozow> Did y'all get a chance to review the PR or look at the notes? y/n
10:02 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
10:02 < Dweezahr> svav, I found it through the CONTRIBUTING file in the root of bitcoin/bitcoin on github
10:02 < effexzi> Hi every1 
10:03 < lightlike> i read the PR title as "minor bug fix" and thought "how modest!"
10:03 -!- Observer30 [~Observer@cpe-23-242-148-67.socal.res.rr.com] has quit [Client Quit]
10:03 < svav> Ok thanks Dweezahr, and welcome!
10:03 < Dweezahr> I merged the PR into a local git repo and compiled, ran the tests fine, but needed a special flag in ./configure
10:03 < glozow> lightlike: xD
10:03 < theStack> lightlike: heh
10:03 < stickies-v> n, couldn't properly review so I'm here to lurk and learn
10:03 < larryruane> looked at the actual fix (easy!) but trying to puzzle out the test changes
10:03 < Dweezahr> ./configure --enable-experimental
10:03 < emzy> n, just read the notes.
10:03 -!- Observer54 [~Observer@cpe-23-242-148-67.socal.res.rr.com] has joined #bitcoin-core-pr-reviews
10:04 < glozow> larryruane: awesome! did you try reproducing the bug and whatnot?
10:04 < theStack> n
10:04 < svav> I read the notes, but it seems like quite a difficult issue
10:04 -!- JacobFickes [~JacobFick@104.165.250.236] has joined #bitcoin-core-pr-reviews
10:04 < larryruane> i was just going to ask that ... isn't it a good review practice to run any new or modified test without the production code change, and make sure the test fails?
10:04 < larryruane> (sadly i didn't have time to do that)
10:04 < ccdle12> hi - semi reviewed
10:04 < glozow> larryruane: yeah! that's what i'd recommend.
10:04 -!- randomcrow [~randomcro@cpe1033bfa9e0e7-cm1033bfa9e0e5.cpe.net.cable.rogers.com] has joined #bitcoin-core-pr-reviews
10:05 < effexzi> N
10:05 < glozow> Is anybody able to summarize how the mining algorithm works?
10:05 < glozow> (and by mining, i mean block template building)
10:05 < glozow> Hint: we're looking at the code here https://github.com/bitcoin/bitcoin/blob/f3e0ace8ecd84009a23da6b0de47f01d79c45772/src/node/miner.cpp#L303
10:06 < svav> Well, firstly, it works to maximise profit for miner, right?
10:06 < glozow> svav: yes exactly. we want to maximize the total fees of the block.
10:06 < larryruane> because if we don't, miners are encouraged to write their own algorithms, and that disadvatages newcomer miners
10:06 < effexzi> Picks up a bunch of transactions, adds previous header, a nonce and hashes until difficulty is met.
10:07 < glozow> and it needs to be consensus-valid. Here, the most relevant constraints are = maximum block weight and sigops.
10:07 < stickies-v> at a VERY high level: sorting tx packages by their ancestor feerate and picking the highest fee rate ones until the block is full?
10:07 < glozow> stickies-v: yes, great start!
10:07 < glozow> What is ancestor feerate?
10:07 < stickies-v> the combined fee rate of a tx and all of its unconfirmed parents
10:07 < larryruane> i always forget about sigops ... is it common that a block is less than max weight because it's at the max sigops? or is that more of a sanity check?
10:08 < stickies-v> so, all the fees of tx + parents, divided by the weight of tx + parents
10:08 < glozow> effexzi: yeah that's the idea for mining in general. Right now we're specifically talking about the process of picking the transactions.
10:08 < glozow> larryruane: AFAIK, that's very uncommon
10:08 < larryruane> stickies-v: without double-(multiple-) counting, right? so if a tx has 2 parents, and each of those shares a parent, we count that "grandparent" only once?
10:09 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
10:09 < Kaizen_Kintsugi_> hm
10:09 < stickies-v> larryruane good point, yes it should be the unique set of ancestors
10:09 < glozow> stickies-v: not just parents :) parents' parents, parents' parents' parents, etc.
10:09 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews
10:09 < glozow> in other words, a tx's ancestor set is the set of all transactions that it depends upon
10:10 < glozow> larryruane: correct, we don't double count.
10:10 < glozow> why ancestor feerate in particular?
10:10 < larryruane> so when a new block is mined, it's possible for a tx's ancestor fee (and ancestor size) to decrease since some of its ancestors may be included in the new block
10:10 < glozow> Relevant PR: https://github.com/bitcoin/bitcoin/pull/7600
10:10 < svav> Could someone  give a definition for mapTx?
10:11 < glozow> larryruane: yes exactly. a subset of your ancestors may be included without you.
10:11 < larryruane> is that the crazy multimap thing that is essentially the mempool??
10:11 < ccdle12> svav: the main datastructure in the mempool that tracks txs according 5 indexes
10:11 < glozow> larryruane: yes xD it's the multi-index container that stores all mempool entries
10:12 < glozow> here is the definition: https://github.com/bitcoin/bitcoin/blob/094d9fda5ccee7d78a2e3d8b1eec17b8b6a33466/src/txmempool.h#L458-L488
10:13 < svav> and a definition for mapModifiedTx for clarity? Thanks
10:13 < glozow> this transitions nicely into our next question - what is `mapModifiedTx` ?
10:13 < glozow> svav: haha jinx
10:13 < theStack> that is quite some lines of code for a single typedef ^^
10:13 < glozow> here is the typedef for `mapModifiedTx`: https://github.com/bitcoin/bitcoin/blob/094d9fda5ccee7d78a2e3d8b1eec17b8b6a33466/src/node/miner.h#L93-L108
10:14 < glozow> What is `mapModifiedTx` used for?
10:15 < lightlike> so it's kind of a poor man's mempool with just  one index?
10:15 < Dweezahr> like std multimap?
10:16 < Dweezahr> with modified transactions
10:16 < ccdle12> `mapModifiedTx` stores copies of txs in the mempool but only sorted by ancestor fee rate?
10:16 < svav> I am guessing now but ... is mapModifiedTx some sort of snapshot for a "potential" mempool, which has added a given transaction into the mempool to then evaluate total fee rates, and see how this compared to previous mapTx?
10:16 < stickies-v> we want to have a copy of the mempool where we can remove ancestors that have already been selected as part of a package, without actually affecting the mempool, I think?
10:16 < glozow> yes, it's not storing the same information as mapTx. How are they modified? When do we add a transaction to it?
10:17 < glozow> stickies-v: bingo
10:18 < glozow> lightlike: there are 2, you can index by iter and by ancestor feerate
10:18 < lightlike> oh, right
10:18 < lightlike> why do we call UpdatePackagesForAdded() right at the beginning of addPackageTxs() ? what could have been already added at this points so that we might need to change mapModifiedTx?
10:19 -!- furszy [~furszy@186.143.136.210] has joined #bitcoin-core-pr-reviews
10:19 -!- jamesob [~jamesob@cpe-65-189-27-252.cinci.res.rr.com] has joined #bitcoin-core-pr-reviews
10:19 < glozow> lightlike: I'm not sure, I also had the same question
10:20 < glozow> AFAIK you can't pre-populate the template with transactions, but that would have been my guess
10:20 < lightlike> there is a comment talking about "previously added" transactions, but I didn't find any code that does that
10:21 < glozow> maybe it was removed and this wasn't cleaned up? idk
10:21 < glozow> Does everybody understand what `mapModifiedTx` is used for?
10:21 -!- jamesob [~jamesob@cpe-65-189-27-252.cinci.res.rr.com] has quit [Remote host closed the connection]
10:22 < glozow> To summarize, it contains transactions that have not been selected yet, but some subset of their ancestors have. So we can't just use the ancestor feerate cached in their mempool entries.
10:22 -!- jamesob [~jamesob@cpe-65-189-27-252.cinci.res.rr.com] has joined #bitcoin-core-pr-reviews
10:22 < glozow> (We don't modify the actual mempool while selecting transactions)
10:23 -!- a58 [~a@137.97.123.3] has joined #bitcoin-core-pr-reviews
10:23 < svav> So basically it's a mechanism to ensure that fees available from packages are not erroneously counted multiple times?
10:23 < Kaizen_Kintsugi_> that is my understanding
10:23 < glozow> svav: yes, that's another way to look at it
10:23 < larryruane> and when you say some ancestors have been selected, you mean for inclusion in a block that we're creating?
10:24 < glozow> let's give a concrete example and we can use it for the next few questions
10:24 < glozow> Let's say you have tx C. It has parent B, and grandparent A. A <- B <- C
10:24 < glozow> Let's say A is 10sat/vB, B is 5sat/vB, and C is 1sat/vB
10:25 < glozow> mapTx says A's ancestor feerate is 10sat/vB, B's ancestor feerate is 7.5sat/vB, and C's is 5.3sat/vB
10:26 < glozow> A gets selected first. We store B and C in mapModifiedTx. B's new ancestor feerate is 5sat/vB. C's new ancestor feerate is 3sat/vB.
10:26 < glozow> This makes sense yes?
10:26 < glozow> larryruane: yes, selected = included in the block template we're building
10:26 < larryruane> (so we're assuming all tx are the same size)
10:26 < glozow> larryruane: correct. thanks
10:27 < stickies-v> makes sense!
10:27 < theStack> yup, that sounds alright
10:27 < larryruane> so this way, if we don't end up mining the next block, it's very easy to "undo" this
10:27 < glozow> larryruane: yep!
10:28 < larryruane> (we just toss out those entries in mapModifiedTx)
10:28 < glozow> Great. So in this example, what happens next? Which transaction gets selected for inclusion, and how do we update mapModifiedTx?
10:29 < theStack> B gets selected, and C is stored in mapModifiedTx with an ancestor feerate of 1sat/vB?
10:29 < glozow> theStack: exactly!
10:29 < larryruane> oh so C appears in mapModifiedTx twice?
10:30 < theStack> it's just updated i guess?
10:30 < larryruane> yes you're probably right
10:30 < glozow> yes, it's updated. there is only 1 entry.
10:30 < glozow> sorry for the confusion
10:30 < glozow> we update using `update_for_parent_inclusion`: https://github.com/bitcoin/bitcoin/blob/094d9fda5ccee7d78a2e3d8b1eec17b8b6a33466/src/node/miner.h#L115
10:31 < glozow> called here in `UpdatePackagesForAdded`: https://github.com/bitcoin/bitcoin/blob/f3e0ace8ecd84009a23da6b0de47f01d79c45772/src/node/miner.cpp#L258
10:32 < glozow> https://github.com/bitcoin/bitcoin/blob/f3e0ace8ecd84009a23da6b0de47f01d79c45772/src/node/miner.cpp#L251-L259
10:32 < glozow> here shows that it's updated. we have 2 branches: for creating a new entry and for updating an existing one.
10:32 < glozow> This brings us to the next question - notice anything fishy? What's the bug?
10:33 < theStack> so generally it's only ever the size and the fees which are updated separately, and the resulting feerate is calculated later when needed?
10:33 < theStack> (not referring to the bug, just a general question)
10:33 < glozow> theStack: yes
10:33 -!- a58 [~a@137.97.123.3] has quit [Quit: Connection closed]
10:34 < glozow> CFeeRate doesn't remember what the size and amount were, so it's not possible to deduct a transaction from a package feerate that way.
10:34 < glozow> we have to just remember the total fees and total size
10:34 < theStack> ok that makes sense
10:35 < glozow> `CFeeRate` definition: https://github.com/bitcoin/bitcoin/blob/094d9fda5ccee7d78a2e3d8b1eec17b8b6a33466/src/policy/feerate.h#L29
10:36 < glozow> Anyone find the bug?
10:37 < larryruane> https://github.com/bitcoin/bitcoin/blob/f3e0ace8ecd84009a23da6b0de47f01d79c45772/src/node/miner.cpp#L258 passes a closure (function pointer), which is why `update_for_parent_inclusion` has to be written in that operator() style? 
10:37 < glozow> larryruane: good question :) was going to be my bonus question
10:38 -!- ishaanam [~ishaanam@45.15.176.31] has quit [Quit: Connection closed]
10:39 < stickies-v> I suppose the bug is that update_for_parent_inclusion uses GetFee instead of GetModifiedFee?
10:39 < svav> Finding this bug is way beyond my capabilities I'm afraid ;(
10:39 < lightlike>  when adjusting the modified entry, the actual feerate was used, not the modified one. so things would be wrong if miners had prioritised the transaction.
10:39 < glozow> larryruane: I think the answer is simply = this code was written before we used C++11, so you couldn't use lambdas
10:39 < glozow> stickies-v: winner winner
10:40 < stickies-v> it's the only changed line of code that's not in a test file ¯\_(ツ)_/¯
10:40 < glozow> lightlike: exactly
10:40 < glozow> stickies-v: very smart :P
10:40 < theStack> xD
10:40 < larryruane> so _normally_ the two are the same, but if the tx had its feerate modified (using the prioritisetransaction RPC, then it will be wrong without this fix
10:41 -!- furszy [~furszy@186.143.136.210] has quit [Ping timeout: 276 seconds]
10:41 < glozow> larryruane: yeah. I'm not sure how common it is to use prioritisetransaction
10:41 < glozow> we didn't really have test coverage for it
10:41 < lightlike> yes, I was wondering wherther there is evidence/statistics of miners using prioritisetransaction much?
10:42 < larryruane> ok now i have a question, who is the world found this bug?? Oh the PR description (first comment) explains it, the result of an earlier review! that's great
10:42 < glozow> yeah, technically Marco found it
10:42 < stickies-v> oh okay so the "modified" in "GetModifiedFee" has nothing to do with the "modified" in "mapModifiedTx"?
10:43 < theStack> what is the real use case for prioritisetransaction? miners accepting bribes? :)
10:43 < glozow> stickies-v: correct, haha. a bit confusing
10:43 < sipa> or mining their own transactions
10:43 < theStack> (OTOH the mining fee itself is kind of a bribe already)
10:43 < theStack> sipa: makes sense yes
10:43 < glozow> theStack: lightlike: sipa: I think we should just get rid of it. And replace it with an option to force-include transactions in the template
10:43 < glozow> Would save 64b per mempool entry
10:44 < lightlike> or miners censoring transactions, the modification can also be negative
10:44 < randomcrow> marathon would be pleased
10:45 < theStack> lightlike: interesting point!
10:45 < larryruane> prioritysettransaction seems like one of those features that if core didn't implement it, someone else would (so may as well standardize it)
10:45 < glozow> lightlike: indeed. you can censor by prioritising with -MAX_MONEY
10:45 < larryruane> would it be easier to not let the tx into the mempool in the first place?
10:46 < glozow> larryruane: I mostly disagree. If it's a feature that a small fraction of miners (also small fraction of users) use, seems unnecessary.
10:46 < larryruane> really basic question: the mempool gets persisted to disk, right? so if the node goes down, then when we come back up again, we'll have the mempool from before, with all the modifications?
10:47 < glozow> larryruane: modified fees are used in mempool acceptance logic, too. If you prioritise with a negative amount, it'll also not make it into your mempool
10:47 < glozow> code here: https://github.com/bitcoin/bitcoin/blob/094d9fda5ccee7d78a2e3d8b1eec17b8b6a33466/src/validation.cpp#L822
10:48 < larryruane> glozow: :+1
10:48 < theStack> playing devils advocate: maybe prioritisetransaction will be used more once blocks get full regularly in the future (right now they aren't)
10:48 < theStack> not saying that this a strong or good argument to keep it though
10:48 < glozow> larryruane: yes, fee deltas are persisted to disk. code here: https://github.com/bitcoin/bitcoin/blob/094d9fda5ccee7d78a2e3d8b1eec17b8b6a33466/src/validation.cpp#L4729-L4731
10:49 < glozow> theStack: it would be nice if people could fee-bump the normal way :) if people need to pay miners out-of-band, there's something wrong with our fee bumping
10:49 < glozow>  it is a valid argument though ofc
10:50 < theStack> glozow: true! i assume with "normal" you mean both RBF and CPFP?
10:50 < glozow> yep!
10:51 < glozow> we have one more question that we haven't covered from the notes: Why is MAX_CONSECUTIVE_FAILURES necessary? code here: https://github.com/bitcoin/bitcoin/blob/f3e0ace8ecd84009a23da6b0de47f01d79c45772/src/node/miner.cpp#L323
10:51 -!- Observer54 [~Observer@cpe-23-242-148-67.socal.res.rr.com] has quit [Quit: Connection closed]
10:51 < randomcrow> spam
10:53 < Dweezahr> as the first items do no longer fit, it is unlikely that future items will fit as they are decremental
10:53 < theStack> seems to be used to avoid taking too much time building a block which is almost full anyway
10:53 < lightlike> to save time - aborting early instead of trying out the entire mempool when the block is almost full so most transaction won't fit anymore.
10:53 < glozow> yep exactly
10:54 < glozow> like if we only have 5 weight units left, which no transaction will fit
10:54 < glozow> there's no need to try every transaction in the mempool
10:54 < Kaizen_Kintsugi_> so its a probability thing, if we start failing a lot, the liklihood of finding a transaction that does fit drops
10:54 < theStack> i wonder where the magic number 4000 comes from btw... is this derived from a consensus limit on how large the coinbase is allowed to be? (if there is such a limit)
10:54 < larryruane> would you say it's an anti-DOS measure too?
10:55 < glozow> larryruane: not really. nobody can force you to build a block template
10:56 < stickies-v> and you also have your mempool size limit, in case someone wanted to spam you with a trillion transactions
10:57 < glozow> theStack: oh that's a good question. I'm not sure, maybe sipa knows? code added here https://github.com/bitcoin/bitcoin/pull/9868/
10:57 < larryruane> glozow: the code you linked to most recently, `addPackageTxs` ... git blame seems to show it was added 6 years ago, is that accurate? I thought packages were a recent addition (that you mostly implemented)
10:57 < Dweezahr> why was int64_t chosen over uint64_t?
10:57 < glozow> larryruane: nope. I'm adding packages to mempool validation logic. We've had packages in mempool and miner for years!
10:58 < larryruane> ok, TIL ... even though they haven't been used (because not supported by P2P)? Or do I have that wrong?
10:58 < svav> It will be something to do with that it's 4 x 1000
10:58 < svav> The 4 is a conversion factor
10:58 < glozow> Dweezahr: which item are you referring to?
10:59 < Kaizen_Kintsugi_> I think int64_t is parsed by this object that outputs JSON
10:59 < Dweezahr> nConsecutiveFailed
10:59 < theStack> svav: yes, 4000 WU = 1000 vbytes... but then, where do the 1000 come from? :p
10:59 < sipa> glozow theStack My (vague) recollection is that these min/max weight limits on blocks were there before.
10:59 < sipa> Having a max size is useful, in case the exact size of the coinbase isn't known yet.
11:00 < glozow> I guess a max 1000vB coinbase sounds reasonable
11:00 < theStack> indeed
11:00 -!- Observer100 [~Observer@cpe-23-242-148-67.socal.res.rr.com] has joined #bitcoin-core-pr-reviews
11:00 < glozow> Ah we're out of time. Thanks for coming everyone!
11:01 < lightlike> larryruane: I think the package logic has been used, child-pays-for-parent works after all. It's just that the parent currently needs a high enough feerate to make it into the mempool  (even if it's not enough to get mined) 
11:01 < glozow> I'm looking for somebody to host next week, so if you're interested please lmk!
11:01 < glozow> #endmeeting
11:01 < theStack> thanks for hosting glozow! that was fun
11:01 < emzy> Thank you glozow and all!
11:01 < lightlike> thanks glozow !
11:01 < larryruane> glozow: thanks! 
11:02 < glozow> Yeah larryruane: to answer your question about the packages, the nice thing is we've had CPFP for 6 years, but the problem is it only works for transactions already in the mempool.
11:02 < stickies-v> ty glozow  and everyone for the discussion!
11:02 < Kaizen_Kintsugi_> thank you! I learned a lot
11:02 < larryruane> makes sense glozow thanks
11:02 < svav> Thanks glozow and all!
11:03 < glozow> and Dweezahr: not sure why it's a signed integer. really it could just be a uint16
11:04 < effexzi> Thanks every1 
11:04 < Dweezahr> well maybe because processing further expects only trivial types like int64_t for JSON as suggested
11:05 -!- Observer100 [~Observer@cpe-23-242-148-67.socal.res.rr.com] has quit [Client Quit]
11:10 -!- svav [~svav@82-69-86-143.dsl.in-addr.zen.co.uk] has quit [Quit: Connection closed]
11:11 -!- JacobFickes [~JacobFick@104.165.250.236] has quit [Quit: Connection closed]
11:13 -!- randomcrow [~randomcro@cpe1033bfa9e0e7-cm1033bfa9e0e5.cpe.net.cable.rogers.com] has quit [Quit: Connection closed]
11:26 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
11:26 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
11:29 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer]
11:44 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
11:46 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer]
11:49 -!- rage-proof [~rage-proo@ip5f5bf12d.dynamic.kabel-deutschland.de] has quit [Quit: Connection closed]
11:55 -!- Dweezahr [~user@109-175-210-87.ftth.glasoperator.nl] has quit [Remote host closed the connection]
12:00 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
12:05 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 248 seconds]
12:06 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
12:08 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
12:10 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds]
12:11 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
12:13 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 250 seconds]
12:15 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
12:17 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds]
12:22 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:33 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
12:34 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
12:39 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 248 seconds]
12:42 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
12:44 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer]
12:58 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
13:02 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
13:09 -!- ccdle12 [~ccdle12@243.222.90.149.rev.vodafone.pt] has quit [Quit: Connection closed]
13:14 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
13:19 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 260 seconds]
13:24 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
13:29 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds]
13:32 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
13:48 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
13:48 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
15:57 -!- jesseposner_ [~jesse@c-24-5-105-39.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews
15:58 -!- jesseposner [~jesse@user/jesseposner] has quit [Ping timeout: 276 seconds]
16:01 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity]
16:14 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
16:15 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
16:19 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
16:31 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
16:36 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
16:45 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
16:48 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
16:49 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 250 seconds]
17:27 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
17:28 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
17:32 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
17:36 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
17:38 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
17:40 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds]
17:42 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
17:42 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
17:50 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Remote host closed the connection]
17:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f183:1645:b304:b55a] has joined #bitcoin-core-pr-reviews
17:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f183:1645:b304:b55a] has quit [Ping timeout: 240 seconds]
18:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f183:1645:b304:b55a] has joined #bitcoin-core-pr-reviews
18:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f183:1645:b304:b55a] has quit [Ping timeout: 260 seconds]
18:08 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews
18:12 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 246 seconds]
18:17 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
18:18 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
18:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f183:1645:b304:b55a] has joined #bitcoin-core-pr-reviews
18:22 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
18:23 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
18:26 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
18:28 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds]
18:32 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
18:34 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
18:40 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 250 seconds]
19:09 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-pr-reviews
19:27 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
19:28 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
19:32 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds]
19:43 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
19:54 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
19:55 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
19:59 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
19:59 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
20:03 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
20:04 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 260 seconds]
20:07 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
20:20 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
20:25 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds]
20:31 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
20:32 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
20:33 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
20:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f183:1645:b304:b55a] has quit [Ping timeout: 250 seconds]
20:41 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
20:42 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
20:44 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer]
20:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f183:1645:b304:b55a] has joined #bitcoin-core-pr-reviews
20:46 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
20:50 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 246 seconds]
21:01 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
21:39 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
21:40 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
21:41 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection]
21:42 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
21:45 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer]
21:59 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
22:02 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
22:03 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds]
22:06 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds]
22:08 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
22:13 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds]
22:23 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
22:28 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds]
22:29 -!- livestradamus [~quassel@user/livestradamus] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
22:30 -!- livestradamus [~quassel@user/livestradamus] has joined #bitcoin-core-pr-reviews
22:40 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
22:42 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer]
22:56 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
22:59 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer]
23:01 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 250 seconds]
23:03 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-pr-reviews
23:12 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews
23:16 -!- hashfunc5e9 [~user@2601:5c0:c280:7090:9579:409b:7ea2:ebdc] has joined #bitcoin-core-pr-reviews
--- Log closed Thu Apr 21 00:00:02 2022