--- Log opened Fri Jun 10 00:00:48 2022 00:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c477:ce89:7499:43e0] has joined #bitcoin-core-pr-reviews 00:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c477:ce89:7499:43e0] has quit [Ping timeout: 248 seconds] 00:32 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 00:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c477:ce89:7499:43e0] has joined #bitcoin-core-pr-reviews 00:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c477:ce89:7499:43e0] has quit [Ping timeout: 244 seconds] 01:04 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 01:05 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 01:06 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Client Quit] 01:08 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 01:10 -!- gleb745438685 [~gleb@178.150.137.228] has joined #bitcoin-core-pr-reviews 01:10 -!- gleb74543868 [~gleb@178.150.137.228] has quit [Ping timeout: 256 seconds] 01:26 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 01:31 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 276 seconds] 02:02 -!- __gotcha [~Thunderbi@79.132.235.103] has joined #bitcoin-core-pr-reviews 02:02 -!- __gotcha [~Thunderbi@79.132.235.103] has quit [Client Quit] 02:03 -!- __gotcha [~Thunderbi@79.132.235.103] has joined #bitcoin-core-pr-reviews 02:03 -!- __gotcha [~Thunderbi@79.132.235.103] has quit [Client Quit] 02:04 -!- __gotcha [~Thunderbi@79.132.235.103] has joined #bitcoin-core-pr-reviews 02:19 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 02:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c477:ce89:7499:43e0] has joined #bitcoin-core-pr-reviews 02:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c477:ce89:7499:43e0] has quit [Ping timeout: 248 seconds] 02:54 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 02:57 -!- evbo [~bosats@2601:47:4285:c7f0:8d2e:fcba:f6aa:bec2] has quit [Ping timeout: 255 seconds] 02:58 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 248 seconds] 03:02 -!- evbo [~bosats@c-73-233-120-249.hsd1.pa.comcast.net] has joined #bitcoin-core-pr-reviews 03:02 -!- amirreza [~amirreza0@2.177.35.24] has joined #bitcoin-core-pr-reviews 03:38 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 03:38 -!- martinus [~martinus@2001:4bc9:824:1751:ce4:a0d6:761e:4] has joined #bitcoin-core-pr-reviews 03:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c477:ce89:7499:43e0] has joined #bitcoin-core-pr-reviews 03:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c477:ce89:7499:43e0] has quit [Remote host closed the connection] 03:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c477:ce89:7499:43e0] has joined #bitcoin-core-pr-reviews 03:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c477:ce89:7499:43e0] has quit [Ping timeout: 248 seconds] 04:22 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 04:26 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 246 seconds] 04:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c477:ce89:7499:43e0] has joined #bitcoin-core-pr-reviews 05:00 -!- __gotcha [~Thunderbi@79.132.235.103] has quit [Ping timeout: 248 seconds] 05:16 -!- __gotcha [~Thunderbi@79.132.235.103] has joined #bitcoin-core-pr-reviews 05:22 -!- amirreza [~amirreza0@2.177.35.24] has quit [Quit: Leaving] 05:26 -!- brokenprogrammer [~brokenpro@178-221-174-173.dynamic.isp.telekom.rs] has joined #bitcoin-core-pr-reviews 05:28 < brokenprogrammer> Is this channel only for the review club? I'm a new bitcoin contributor and was wondering how the review process works in terms of what gets reviewed and merged when 05:31 < pinheadmz_> brokenprogrammer as a matter of fact, i love this channel as a great place to ask questions any time about bitcoin 05:31 < pinheadmz_> a few of the most prolific contirbutors are here and its not #bitcoin (really spammy) or #bitcoin-core-dev (people are working in there) 05:32 < brokenprogrammer> Oh okay so this is a better channel to talk in for open source contributors? 05:32 < pinheadmz_> i think so ;-) 05:32 < pinheadmz_> https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md 05:32 < pinheadmz_> https://bitcoinacks.com/ 05:33 < pinheadmz_> some links to get you started 05:33 < sipa> To be clear, the review club is a weekly event where people together go over specific pull requests. This is not the place where the actual code review process happens. 05:34 < brokenprogrammer> Thank you for the links and for the clairification. I already submitted two pull requests and one of them recieved a review saying concept ACK, what does that mean? 05:34 < sipa> But outside of that weekly event, this channel is probably more appropriate to ask questions about the codebase, especially if they are beginner ones. 05:34 < brokenprogrammer> https://github.com/bitcoin/bitcoin/pull/25320 05:35 < sipa> @brokenprogrammer That is in fact explained in the CONTRIBUTING.md link given above. 05:35 < brokenprogrammer> Oh I missed that part, thank you. Sorry about that 05:51 < brokenprogrammer> Is it okay to ask for reviews or should I just wait while potentially reviewing other PRs ? 05:59 < jonatack> brokenprogrammer: you might find these articles helpful: https://jonatack.github.io/articles as well as this one https://unchained.com/blog/contributing-bitcoin-core-patience/ 06:00 < brokenprogrammer> jonatack Thank you! 06:00 < jonatack> sometimes a PR can take months or years to be merged, and sometimes it is very quick... it's not always predictable which will be which :) 06:17 -!- brokenprogrammer [~brokenpro@178-221-174-173.dynamic.isp.telekom.rs] has quit [Quit: Client closed] 06:30 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-pr-reviews 06:38 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 06:47 -!- amirreza79 [~amirreza0@2.177.38.35] has joined #bitcoin-core-pr-reviews 06:55 -!- amirreza79 [~amirreza0@2.177.38.35] has quit [Ping timeout: 255 seconds] 07:18 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-pr-reviews 07:53 -!- brunoerg_ [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 07:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:c477:ce89:7499:43e0] has quit [Read error: Connection reset by peer] 08:11 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 08:17 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-pr-reviews 08:33 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 08:48 < lightlike> brokenprogrammer: if the PR is recent and already has had review as 25320, waiting is best in my opinion. I'd start thinking about asking reviewers only after a week or more (depending on how large and complicated the PR is). 08:49 -!- jtrag [~jtrag@user/jtrag] has joined #bitcoin-core-pr-reviews 09:44 -!- __gotcha [~Thunderbi@79.132.235.103] has quit [Ping timeout: 248 seconds] 10:05 -!- brokenprogrammer [~brokenpro@178-221-174-173.dynamic.isp.telekom.rs] has joined #bitcoin-core-pr-reviews 10:28 < pinheadmz_> sipa, crazy question but in feature_taproot.py is `bigmulti` the only test case where more than one sighash flag is used in the same input? 10:29 < pinheadmz_> i.e. (ctx, "sighash") is mutated 10:58 < sipa> That sounds plausible. 11:51 -!- brokenprogrammer [~brokenpro@178-221-174-173.dynamic.isp.telekom.rs] has quit [Quit: Client closed] 12:20 -!- brunoerg_ [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Remote host closed the connection] 12:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 12:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 258 seconds] 13:04 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 248 seconds] 13:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 13:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 240 seconds] 13:31 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 13:33 -!- Talkless [~Talkless@mail.dargis.net] has quit [Client Quit] 13:34 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 13:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 13:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 272 seconds] 13:46 -!- hashfuncae8 [~user@2601:5c0:c280:7090:30da:f74b:fc0a:7f05] has joined #bitcoin-core-pr-reviews 13:59 -!- hashfuncae8 [~user@2601:5c0:c280:7090:30da:f74b:fc0a:7f05] has quit [Remote host closed the connection] 14:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 14:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 255 seconds] 14:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 14:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 260 seconds] 14:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 14:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 250 seconds] 14:53 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 14:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 15:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 248 seconds] 15:07 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 15:11 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 256 seconds] 15:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 15:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 255 seconds] 15:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 15:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 258 seconds] 16:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 16:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 248 seconds] 16:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 16:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 244 seconds] 16:25 -!- evbo [~bosats@c-73-233-120-249.hsd1.pa.comcast.net] has quit [Ping timeout: 248 seconds] 16:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 16:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 255 seconds] 17:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 17:12 -!- davterra [~davterra@static-198-54-131-86.cust.tzulo.com] has joined #bitcoin-core-pr-reviews 17:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 258 seconds] 17:14 -!- davterra [~davterra@static-198-54-131-86.cust.tzulo.com] has quit [Client Quit] 17:20 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 17:26 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 276 seconds] 17:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 17:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 248 seconds] 17:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 17:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 272 seconds] 18:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 18:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 248 seconds] 18:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 18:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 244 seconds] 18:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 18:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 258 seconds] 18:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 19:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 255 seconds] 19:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 19:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 244 seconds] 19:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 19:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 248 seconds] 19:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 19:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 244 seconds] 19:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 19:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 248 seconds] 19:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 20:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 272 seconds] 20:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 20:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 260 seconds] 20:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 20:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 244 seconds] 20:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 20:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 255 seconds] 20:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 20:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 248 seconds] 20:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 21:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 244 seconds] 21:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 21:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 255 seconds] 21:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 21:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 258 seconds] 21:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 21:25 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 255 seconds] 21:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 21:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 258 seconds] 21:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 21:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 272 seconds] 21:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 21:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 248 seconds] 22:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 22:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 244 seconds] 22:32 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-pr-reviews 22:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 22:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 272 seconds] 23:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has joined #bitcoin-core-pr-reviews 23:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9843:7882:cb5f:7354] has quit [Ping timeout: 260 seconds] --- Log closed Sat Jun 11 00:00:50 2022