--- Log opened Wed Jul 06 00:00:13 2022 00:00 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 00:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 00:04 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 00:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 276 seconds] 00:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 00:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 240 seconds] 00:14 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 00:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 00:18 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 00:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 264 seconds] 00:21 -!- __gotcha [~Thunderbi@ldd29-1-78-210-28-87.fbx.proxad.net] has joined #bitcoin-core-pr-reviews 00:31 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 00:36 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 00:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 00:38 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 00:38 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews 00:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 276 seconds] 00:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 00:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 240 seconds] 00:48 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 00:52 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 00:59 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 00:59 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews 01:05 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 01:07 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 244 seconds] 01:08 -!- __gotcha [~Thunderbi@ldd29-1-78-210-28-87.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 01:10 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 01:10 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 255 seconds] 01:14 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 240 seconds] 01:15 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 01:21 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 01:23 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 01:24 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-pr-reviews 01:25 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 240 seconds] 01:27 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 01:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 01:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 276 seconds] 01:39 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 01:43 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 01:44 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 01:44 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 01:48 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 256 seconds] 01:48 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 01:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 01:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 276 seconds] 01:54 -!- Common [~Common@096-033-221-075.res.spectrum.com] has quit [Ping timeout: 255 seconds] 02:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 02:01 -!- Zenton [~user@user/zenton] has joined #bitcoin-core-pr-reviews 02:01 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 02:04 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer] 02:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 240 seconds] 02:06 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 02:10 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 240 seconds] 02:18 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 02:22 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 264 seconds] 02:35 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 02:38 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 02:40 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 02:42 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 244 seconds] 02:51 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 02:55 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 02:57 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 02:57 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 03:00 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 276 seconds] 03:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 03:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 276 seconds] 03:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 03:09 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 03:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 240 seconds] 03:13 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 03:17 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 03:21 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 240 seconds] 03:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 03:24 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 03:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 255 seconds] 03:29 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 03:41 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 03:43 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer] 03:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 03:51 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 03:55 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 03:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 276 seconds] 04:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 04:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 244 seconds] 04:07 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 04:12 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds] 04:18 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 04:23 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 04:23 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 272 seconds] 04:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 04:27 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 04:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 244 seconds] 04:39 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 04:40 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 04:43 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 264 seconds] 04:44 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 276 seconds] 04:45 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 04:45 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 264 seconds] 04:51 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 04:53 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 255 seconds] 04:56 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 255 seconds] 04:57 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 04:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 05:02 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 05:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 276 seconds] 05:03 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 05:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 05:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 244 seconds] 05:14 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 05:18 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 05:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 05:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 276 seconds] 05:32 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 05:36 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 05:40 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 05:49 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 05:53 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 06:00 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 06:04 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 06:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Read error: Connection reset by peer] 06:05 -!- evanlinjin [~root@gateway/tor-sasl/evanlinjin] has quit [Read error: Connection reset by peer] 06:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews 06:06 -!- evanlinjin [~root@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-pr-reviews 06:18 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 06:23 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 06:35 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 06:39 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 06:51 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 07:00 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 264 seconds] 07:11 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 07:16 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 07:29 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 07:34 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds] 07:37 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 07:41 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 07:53 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 07:58 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 08:11 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 08:15 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 08:19 -!- Common [~Common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-pr-reviews 08:27 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 08:29 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 08:31 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 08:33 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 08:33 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 08:37 -!- Common [~Common@096-033-221-075.res.spectrum.com] has quit [Ping timeout: 240 seconds] 08:38 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds] 08:39 -!- Common [~Common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-pr-reviews 08:49 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 08:55 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 08:57 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 08:58 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 08:58 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews 09:00 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Remote host closed the connection] 09:00 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 09:00 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 09:01 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 09:02 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 09:04 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer] 09:05 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 09:09 -!- Amirreza [~Amirreza7@93.119.86.14] has joined #bitcoin-core-pr-reviews 09:09 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds] 09:13 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 09:14 < MacroFake> we'll get started in about 40 minutes 09:14 -!- amirreza79 [~Amirreza7@89.219.83.216] has joined #bitcoin-core-pr-reviews 09:17 -!- Amirreza [~Amirreza7@93.119.86.14] has quit [Ping timeout: 276 seconds] 09:17 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 09:18 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds] 09:22 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 272 seconds] 09:28 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 09:30 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 09:32 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 255 seconds] 09:33 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer] 09:33 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 09:37 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 255 seconds] 09:45 < michaelfolkson> Anyone else having trouble building Marco's branch --with-sanitizers=thread? Getting a Clang error 09:46 < MacroFake> What is the error and what is clang --version ? 09:47 -!- otech [~otech@80.251.179.171] has joined #bitcoin-core-pr-reviews 09:48 < michaelfolkson> I'll let you know after, I'm trying without --with-sanitizers=thread to see if it was related to the sanitizer on MacOS 09:49 < michaelfolkson> Apple clang version 12.0.5 (clang-1205.0.22.9) 09:49 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 09:51 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has joined #bitcoin-core-pr-reviews 09:52 < michaelfolkson> Built fine without --with-sanitizers=thread 09:53 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 09:56 -!- Zenton [~user@user/zenton] has quit [Ping timeout: 276 seconds] 09:58 -!- paul_c [~paul_c@pool-74-96-221-100.washdc.fios.verizon.net] has joined #bitcoin-core-pr-reviews 09:58 -!- afmencken [~afmencken@138.199.43.82] has joined #bitcoin-core-pr-reviews 10:00 -!- svav [~svav@82-69-86-143.dsl.in-addr.zen.co.uk] has joined #bitcoin-core-pr-reviews 10:00 < MacroFake> It may be that Apple clang doesn't have the thread sanitizer 10:00 < MacroFake> #startmeeting 10:00 < MacroFake> hi everyone and welcome to today's review club 10:00 < MacroFake> Let's give everyone a chance to say hi 10:00 < afmencken> hi 10:00 < paul_c> Hey everybody 10:00 < svav> Hi 10:00 < MacroFake> Anyone here for the first time? 10:01 < michaelfolkson> hi 10:01 -!- amirreza97 [~Amirreza7@188.209.75.200] has joined #bitcoin-core-pr-reviews 10:01 -!- nassersaazi [~nassersaa@154.0.128.44] has joined #bitcoin-core-pr-reviews 10:02 < michaelfolkson> (ld: symbol(s) not found for architecture x86_64 10:02 < michaelfolkson> clang: error: linker command failed with exit code 1 (use -v to see invocation)) 10:02 -!- jojo [~jojo@69.12.27.194] has joined #bitcoin-core-pr-reviews 10:02 < michaelfolkson> ignore for now :) 10:02 < MacroFake> You also may indicate whether you reviewed the pull request (y/n) 10:02 < amirreza97> Hello, y 10:03 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 10:03 < paul_c> y 10:03 < jojo> hello, n 10:03 -!- Lov3r_Of_Bitcoin [~Lov3r_Of_@45-27-31-99.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-pr-reviews 10:03 -!- nassersaazi [~nassersaa@154.0.128.44] has quit [Client Quit] 10:03 < MacroFake> Ok, let's jump right in with the first question. 10:03 < michaelfolkson> y 10:03 < afmencken> y 10:03 < Lov3r_Of_Bitcoin> y 10:03 -!- amirreza79 [~Amirreza7@89.219.83.216] has quit [Ping timeout: 244 seconds] 10:03 < MacroFake> 2. Which two threads cause the data race fixed in this pull request? What is their purpose? Refer to the traceback in the pull request description. 10:04 < otech> y 10:05 < effexzi> Hi every1 10:05 < otech> is b-loadblk one of the threads? 10:05 < MacroFake> otech: yest 10:05 < MacroFake> *yes 10:05 < otech> cs_main is the other? 10:06 < MacroFake> cs_main is a Mutex, not a thread 10:06 < amirreza97> checking where the tip is null or not. The thread which starts at init.cpp 10:06 -!- Marcus54 [~Marcus@190.79.217.224] has joined #bitcoin-core-pr-reviews 10:06 < amirreza97> whether* 10:06 -!- nassersaazi [~nassersaa@154.0.128.44] has joined #bitcoin-core-pr-reviews 10:07 < otech> Just called the "main" thread I guess 10:07 < MacroFake> Ok, so one thread is the b-loadblk thread, created at https://github.com/bitcoin/bitcoin/blob/aeab1b42e67cc8146bfc7d127d15633bd652fe60/src/init.cpp#L1671 10:07 < MacroFake> Another thread is the "main thread", created by the C++ main() "entry function" at https://github.com/bitcoin/bitcoin/blob/aeab1b42e67cc8146bfc7d127d15633bd652fe60/src/bitcoind.cpp#L259 10:07 < MacroFake> What is the purpose of each thread? 10:07 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 264 seconds] 10:07 < amirreza97> AppInitMain 10:08 < otech> Just FYI a list of documented threads can be found here: https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#threads 10:08 -!- Marcus54 [~Marcus@190.79.217.224] has quit [Client Quit] 10:08 -!- jojo [~jojo@69.12.27.194] has quit [Quit: Connection closed] 10:09 -!- sanya [~sanya@79-101-168-189.dynamic.isp.telekom.rs] has joined #bitcoin-core-pr-reviews 10:10 < amirreza97> I think the first one is to load blocks from blk???.dat files. 10:10 < MacroFake> amirreza97: correct. Also, it loads the mempoo.dat (if one exists) 10:11 < MacroFake> The main thread will run during the whole program duration, no fancy answer here :) 10:11 < michaelfolkson> "Responsible for starting up and shutting down the application" from otech's link 10:12 < MacroFake> 3. How is the data race fixed in the pull request? (Hint: First describe how it happens) 10:12 < amirreza97> So why these two starts at the same time? Isn't the first thread (reading from blk???.dat files) precondition for running the main thread? 10:13 < amirreza97> I mean reading from files is just at the first time AFAIK. So why not let it be finished and then start the main thread. 10:13 < MacroFake> amirreza97: The threads never start at the same time. loadblk is started by the main thread. 10:14 < amirreza97> So I mean simultaneously. 10:15 < MacroFake> As explained by michaelfolkson, main() will lead the init and shutdown process of the application. 10:16 < MacroFake> loading the blocks is one part of the init process. (Other things include loading the wallets and starting the net and p2p interfaces) 10:17 -!- amirreza79 [~Amirreza7@2.177.69.171] has joined #bitcoin-core-pr-reviews 10:18 < MacroFake> Let's dissect question 3 a bit more. What is the call-stack (functions) for each thread where the race happens 10:18 < MacroFake> ? 10:19 < MacroFake> Hint: In the traceback in the pull reqeust description, this is included 10:19 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 10:20 < MacroFake> It is the first item in each line 10:20 < otech> Difficult to parse but something to do with `is_move_assignable` and `is_move_assignable` logic? 10:20 < MacroFake> We are looking at the sections "Write of size 8 ..." and "Previous read of size 8" 10:21 < otech> `is_move_constructible` * 10:21 < MacroFake> otech: Good point. Some function names are increadibly hard to parse as they include the full typenames 10:21 -!- amirreza97 [~Amirreza7@188.209.75.200] has quit [Ping timeout: 244 seconds] 10:21 < MacroFake> We are only interested in the Bitcoin Core functions, not the std:: ones 10:22 < larryruane> modifying the chain tip (correctly, with cs_main): ActivateBestChain calls ActivateBestChainSetp calls ConnectTip calls SetTip ... reading the chain tip (without lock): AppInitMain calls ActiveTip calls Tip 10:22 < larryruane> (reading tip is being done to get the argument to RPCNotifyBlockChange) 10:23 < MacroFake> larryruane: Correct. The write happens here: "node::ThreadImport -> CChainState::ActivateBestChain -> CChainState::ActivateBestChainStep -> CChainState::ConnectTip -> CChain::SetTip" 10:24 < MacroFake> The read happens here: "main -> AppInit -> AppInitMain -> ChainstateManager::ActiveTip() -> CChain::Tip()" 10:24 < glozow> so the b-loadblk thread is writing in `SetTip()`while main thread is reading in `Tip()` ? 10:24 < MacroFake> glozow: Correct 10:25 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 10:25 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 255 seconds] 10:25 < MacroFake> (Still with question 3), next step: Which lock is supposed to be held? 10:26 < paul_c> could we use a single mutex to remove the data race between the read from and write to? 10:26 < afmencken> cs_main is supposed to be held 10:26 < MacroFake> paul_c: Yes 10:26 < MacroFake> paul_c: The lock already exists, and is supposed to be cs_main 10:26 < MacroFake> afmencken: Correct 10:27 < MacroFake> (Still q 3), next step: Why is cs_main not held? 10:28 < MacroFake> Hint: The implemenation of ActiveTip: https://github.com/bitcoin/bitcoin/blob/aeab1b42e67cc8146bfc7d127d15633bd652fe60/src/validation.h#L914-L918 10:28 -!- nassersaazi [~nassersaa@154.0.128.44] has quit [Quit: Connection closed] 10:29 < MacroFake> And the implementation of ActiveChainState: https://github.com/bitcoin/bitcoin/blob/aeab1b42e67cc8146bfc7d127d15633bd652fe60/src/validation.cpp#L5157 10:29 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 10:29 < michaelfolkson> Why was cs_main not held before this PR? Is that the question, sorry 10:29 < larryruane> "Why is cs_main not held?" -- is it anything more than that it's an oversight? Ah I think I see, those first 3 methods you linked to don't scquire the lock 10:30 < glozow> cs_main is released at the end of `ActiveChainState()` ? 10:30 < MacroFake> michaelfolkson: Yes, that is the question 10:30 -!- nassersaazi [~nassersaa@154.0.128.44] has joined #bitcoin-core-pr-reviews 10:30 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 10:31 < michaelfolkson> Because it is held by a different thread? 10:31 < larryruane> (like `ActiveChainState` does... they should be similar in their locking behavior) 10:31 < MacroFake> glozow: Correct. The cs_main Mutex will only be held until the scope is closed. The scope in this case is the function body {...} 10:32 < MacroFake> michaelfolkson: If a mutex is acquired by a different thread, it can not be acquired by this thread. However, if the thread *wants* to acquire it, it will wait until it can 10:32 < lightlike> is there still a "race", just not one with UB? After the fix, loadblk still does its thing and possible changes the ActiveTip() several times, and at some point the main thread takes the cs_main and calls RPCNotifyBlockChange() with whatever is the current tip at this point - could that vary from run to run? 10:32 < MacroFake> michaelfolkson: If the thread does not want to acquire it, it will simply continue 10:33 < larryruane> ignore if this is too detailed, but "... it will wait until it can" -- does it spin-wait, or sleep-wait? Or spin for a short time and then "give up" and sleep (let other threads run)? 10:33 < MacroFake> lightlike: Good point. I think not, because RPCNotifyBlockChange doesn't care about the exact block, but I should double-check. 10:34 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 10:35 < MacroFake> larryruane: I am not familiar with low level primitives, but I'd guess that the thread will be put to sleep and woken when the lock is ready to be picked up 10:35 < sipa> larryruane: In Linux these days, locks are implemented using a mechanism called "futexes" (which have their own wikipedia article) 10:35 < larryruane> MacroFake: sipa: thanks 10:35 < MacroFake> (final part of q 3): How is the data race fixed in the pull request? 10:36 < MacroFake> sipa: Thanks! 10:36 < sipa> IIRC the basic idea is to use atomic CPU instructions to quickly check if the lock is contended or not, and if it is, make a kernel call that gets woken up when needed 10:36 < larryruane> fixed by: https://github.com/bitcoin/bitcoin/pull/25077/files#diff-b1e19192258d83199d8adaa5ac31f067af98f63554bfdd679bd8e8073815e69dR1856 10:37 < larryruane> (holding cs_main while calling `ActiveTip`) 10:37 < sipa> (re futexes: ha, apparently rusty is listed as one of the inventors) 10:37 < michaelfolkson> Were people aware of this data race already (if they built with the thread sanitizer) or did you discover it through doing something specific MacroFake? 10:38 -!- amirreza79 [~Amirreza7@2.177.69.171] has left #bitcoin-core-pr-reviews [Leaving] 10:38 < larryruane> i do see futex often in stack traces for idle threads 10:38 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has joined #bitcoin-core-pr-reviews 10:38 < michaelfolkson> sipa: Lol 10:39 < MacroFake> michaelfolkson: Data races are had to reproduce, especially if they only happen once per process lifetime (init), so I try to keep an eye on intermittent failures 10:39 < MacroFake> This one was found by Cirrus CI on a completely unrelated change: https://cirrus-ci.com/task/5612886578954240?logs=ci#L4868 10:40 < MacroFake> *hard to reproduce 10:41 < michaelfolkson> Intermittent build error messages or failing to build? (what you keep an eye on?) 10:41 < lightlike> Does the previous change in "AppInitMain" by this PR (before loadblk is started) also fix something, or is it a precautionary measure? 10:41 < MacroFake> michaelfolkson: The functional test fails 10:41 < michaelfolkson> Gotcha 10:41 < MacroFake> michaelfolkson: I copied the traceback from the Cirrus CI log 10:42 < MacroFake> ( Unrelated: A similar find was https://github.com/bitcoin/bitcoin/pull/18742 ) 10:42 < MacroFake> lightlike: Good question. I don't think it fixes anything as no other threads are running at this point 10:42 < MacroFake> (I think) 10:42 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 244 seconds] 10:43 < MacroFake> Yes, you'll see that ThreadImport starts only 30 lines *later* 10:43 < MacroFake> However, I added annotations to the Active* function to force cs_main at every call site 10:43 < MacroFake> as belt-and-suspenders 10:44 < larryruane> it would be nice if there was a "race" or "thread-safety" PR label 10:44 < MacroFake> Ok, next question 10:44 < MacroFake> 4. What is the other issue fixed by the change? Why is it impossible to detect that issue with a thread sanitizer that detects data races? 10:45 < MacroFake> (hint: It is described in the pull request description) 10:45 < michaelfolkson> The corrupt REST response. Not sure how you found that either :) 10:45 < larryruane> maybe found by static analysis (annotations)? 10:45 < larryruane> it's not possible because that rest code is part of the client and it's single-threaded (?) 10:45 < larryruane> it's a separate executable 10:46 < MacroFake> michaelfolkson: I think it can only be found manually, unless there is a test that specifically checks this and for some reason fails 10:46 < michaelfolkson> So you just spotted it through your own eyes? 10:46 < MacroFake> larryruane: Nope. rest is delivered by the same bitcoind process 10:46 < larryruane> can we assert lock is held? 10:46 < larryruane> oh okay thanks 10:46 < MacroFake> michaelfolkson: Yes 10:47 < michaelfolkson> Wow ok 10:47 < larryruane> oh i was thinking of bitcoin-chainstate, that's a separate exe I think 10:47 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 10:47 < MacroFake> larryruane: Correct 10:47 < MacroFake> Anyone knows the answer to q 4? :) 10:48 < afmencken> In the case of the corrupt REST response, there is no data race to detect, is that correct? 10:48 < MacroFake> afmencken: Yes 10:49 < MacroFake> Hint: The REST interface calls chainman.ActiveChain().Height() and then chainman.ActiveChain().Tip()->GetBlockHash() separately 10:49 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 10:50 < MacroFake> Hint: Is the cs_main lock held over both calls? 10:50 < afmencken> The problem is not that the lock isn't held, but that different pieces of data that the lock is guarding are read during different reads. 10:50 < afmencken> i.e. different "holdings" of the lock. 10:50 < afmencken> So the reads are inconsistent with eachother. 10:50 < MacroFake> afmencken: Correct 10:51 < paul_c> Is it impossible to detect that issue with a thread sanitizer that detects data races because it can't automatically find bugs in the program or suggest ways to fix the data-races found? 10:51 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 10:51 < MacroFake> paul_c: Hmmm. Think a bit more about what exactly a thread sanitizer detects 10:52 -!- z9z0b3t1_ [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-pr-reviews 10:52 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Client Quit] 10:52 < MacroFake> Surely it detects "bugs in the program", but of what kind? 10:53 < larryruane> UBs, (undefined), like 2 threads reading and writing the same memory at the same time? 10:53 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 10:54 < larryruane> (or also, 2 threads writing) ... so not really locking? (but the fix is usually locking) 10:54 < MacroFake> larryruane: Yes, so getting the lock and getting thing_1, then releasing the lock, then taking it again and getting thing_2 is not UB (a data-race detectable by a sanitizer) 10:54 < lightlike> I think in this case there would be no UB, just a rest response that would consist of parts that don't fit together (because the parts correspond to different chain tips) 10:55 < MacroFake> lightlike: Yes 10:55 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Ping timeout: 255 seconds] 10:55 < MacroFake> I am not sure if a word exists for that. I just called it "logical" race 10:55 < MacroFake> 5. How is the “logical race” fixed in the pull request? 10:55 < larryruane> yes higher-level race, maybe 10:56 < larryruane> get the height and tip hash from within the lamba, while `cs_main` is held? 10:56 < afmencken> The logical race is fixed by moving all of the reads into a single critical section. 10:56 < MacroFake> larryruane: afmencken: Correct 10:56 < MacroFake> 4 minutes left for the last question and any of your questions 10:56 < larryruane> MacroFake: I was wondering if you considered returning those two values from the lambda? 10:56 < MacroFake> 6. Do you agree with the direction of the change to introduce a GetMutex() alias for the ::cs_main mutex? 10:57 < paul_c> y 10:57 < larryruane> yes! it paves the way for finer-grain locking (chainman level) instead of using cs_main for so much 10:57 < MacroFake> larryruane: Yes, but that would mean more code 10:58 < MacroFake> larryruane: The lambda is called in two different places, but if the variables are set via capturing, then only one location would need to change 10:59 < larryruane> MacroFake: can you tell us why `::cs_main` instead of just `cs_main`? I know the double-colon means global scope, but is there a danger that some class will implement a `cs_main` variable? (Or do they already?) 10:59 < afmencken> I'm not sure I understand what is gained from adding GetMutex 10:59 < larryruane> is it just to emphasize that it's a global? (make it slightly uglier so we have more motivation to get rid of it? :) ) 10:59 < MacroFake> larryruane: It doesn't matter fro ::cs_main, but for other globals that do not start with our g_ prefix (style guide), it could cause issues 11:00 < MacroFake> *for 11:00 < MacroFake> #endmeeting 11:00 < larryruane> afmencken: it's a method function 11:00 < MacroFake> Thanks everyone for the input and discussion! 11:00 < larryruane> thanks MacroFake this was great! 11:00 < Lov3r_Of_Bitcoin> thanks that was awesome! 11:00 < lightlike> thanks MacroFake! 11:00 < otech> thanks a lot MacroFake 11:00 -!- Lov3r_Of_Bitcoin [~Lov3r_Of_@45-27-31-99.lightspeed.sntcca.sbcglobal.net] has quit [Quit: Connection closed] 11:01 < paul_c> Thank you! Have a good week, everyone 11:01 < svav> Thanks MacroFake and all 11:01 -!- nassersaazi [~nassersaa@154.0.128.44] has left #bitcoin-core-pr-reviews [] 11:02 < afmencken> I see the comment on it, but I'm not sure how it forces callers to think any harder about how long they are holding the mutex than they would if they were accessing cs_main directly. 11:02 < MacroFake> afmencken: GetMutex is a member function, meaning that (one day far into the future) cs_main (the global) can become a member of the same class that has the member funciton 11:02 < MacroFake> afmencken: It doesn't make code any safer 11:02 < MacroFake> GetMutex is only there to make future code changes easier 11:03 < larryruane> MacroFake: does it make the annotations easier or safer or something? 11:03 < michaelfolkson> Thanks MacroFake! 11:03 < MacroFake> GetMutex does not make anything safer 11:03 -!- paul_c [~paul_c@pool-74-96-221-100.washdc.fios.verizon.net] has left #bitcoin-core-pr-reviews [] 11:03 < MacroFake> :: (for the global scope) makes it easier for devs to parse the code and find globals 11:04 < otech> if there are any resources/docs explaining the differences between `LOCK_RETURNED`, `EXCLUSIVE_LOCKS_REQUIRED`, `WITH_LOCK` and `LOCK` would love to understand that all better 11:04 < larryruane> ok thanks ... just wondering, to be a helpful reviewer for a PR like this, would it be good to see if the annotation build fails? or is that wasted effort? 11:04 < afmencken> MacroFake: thanks, that was a good session 11:04 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection] 11:05 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 11:05 < MacroFake> otech: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html 11:05 < otech> ty 11:05 < otech> 🙏 11:05 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has quit [] 11:05 < MacroFake> larryruane: Actually it already broke twice due to intermittent merges, so doign a rebase on master and checking might be helpful 11:06 < MacroFake> *doing 11:06 < larryruane> +1 11:07 < larryruane> MacroFake: what about running a tsan build? is that something useful, do you do that often? 11:08 < MacroFake> larryruane: I haven't done one for a few years now. Only in CI settings :( 11:08 < larryruane> thanks 11:08 < MacroFake> I think it has something to do with my bdb version, which complains about races 11:09 < MacroFake> Luckily we'll remove bdb soon (TM), so this will become easier 11:09 < larryruane> "TM" LOL 11:09 < MacroFake> Maybe I could try with --disable-wallet 11:11 < larryruane> does that config option disable only BDB wallet? Or the new sqlite ones too? 11:12 < MacroFake> both 11:16 -!- otech [~otech@80.251.179.171] has quit [Quit: Client closed] 11:18 -!- sanya [~sanya@79-101-168-189.dynamic.isp.telekom.rs] has quit [Quit: Connection closed] 11:34 -!- sanya [~sanya@79-101-168-189.dynamic.isp.telekom.rs] has joined #bitcoin-core-pr-reviews 11:35 -!- sanya [~sanya@79-101-168-189.dynamic.isp.telekom.rs] has quit [Client Quit] 12:16 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:21 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity] 12:54 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 13:03 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 240 seconds] 13:33 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection] 13:34 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 13:38 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 13:38 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection] 13:38 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 13:40 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 14:01 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Remote host closed the connection] 14:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 14:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 244 seconds] 14:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 14:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 276 seconds] 14:24 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 14:29 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 240 seconds] 14:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 14:31 -!- stargur [~stargur@47.156.139.163] has joined #bitcoin-core-pr-reviews 14:31 -!- stargur [~stargur@47.156.139.163] has quit [Client Quit] 14:48 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Remote host closed the connection] 14:49 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 14:53 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 14:56 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 14:58 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 15:01 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 15:03 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 15:04 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 264 seconds] 15:08 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 15:19 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 15:24 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 15:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 276 seconds] 15:35 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 15:39 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 15:44 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-pr-reviews 15:51 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 15:56 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds] 15:59 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 16:02 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer] 16:16 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 16:20 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 16:21 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 16:25 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 16:25 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 16:32 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds] 16:35 < pinheadmz> https://github.com/bitcoin/bitcoin/blob/ec0a4ad67769109910e3685da9c56c1b9f42414e/src/net_processing.cpp#L2544-L2549 16:35 < pinheadmz> I see this logic has been removed in v22 16:35 < pinheadmz> but in previous versions, why was it written this way? it will send two `sendcmpct` messages? 16:35 < pinheadmz> and the second sendcmcpt will ask for non-witness ? 16:39 < sipa> See BIP152, under "sendcmpct", rule 6 16:39 < sipa> Upon receipt of a "sendcmpct" message with the second integer set to something other than 1, nodes MUST treat the peer as if they had not received the message (as it indicates the peer will provide an unexpected encoding in cmpctblock, and/or other, messages). This allows future versions to send duplicate sendcmpct messages with different versions as a part of a version handshake for future versions. See Protocol Versioning section, below, for more 16:39 < sipa> info on the specifics of the version-negotiation mechanics. 16:40 < sipa> See it was sending "I support v1!" and "I support v2!". 16:40 < sipa> (v1 being pre-segwit, v2 post-segwit) 16:43 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 16:47 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 16:49 -!- svav [~svav@82-69-86-143.dsl.in-addr.zen.co.uk] has quit [Quit: Connection closed] 16:51 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 16:55 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 16:59 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 17:04 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 17:06 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 17:10 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 17:11 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 17:14 -!- evanlinjin [~root@gateway/tor-sasl/evanlinjin] has quit [Remote host closed the connection] 17:14 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 17:15 -!- evanlinjin [~root@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-pr-reviews 17:15 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews 17:15 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 17:15 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 17:20 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 272 seconds] 17:32 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 17:36 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 17:37 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 17:39 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 17:40 -!- Kaizen___ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 17:41 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 17:43 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 17:44 -!- Kaizen___ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 17:49 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 17:51 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 255 seconds] 17:55 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 18:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 18:07 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 18:10 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer] 18:11 -!- Zenton [~user@user/zenton] has joined #bitcoin-core-pr-reviews 18:12 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 18:16 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 18:19 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 18:23 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 264 seconds] 18:36 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 18:40 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 18:40 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 18:45 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds] 18:56 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 19:02 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 19:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 276 seconds] 19:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 19:13 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 19:17 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 19:30 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 19:33 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Read error: Connection reset by peer] 19:47 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 19:50 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 19:51 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 19:54 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 19:59 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 20:00 -!- greypw254600 [~greypw254@grey.pw] has quit [Remote host closed the connection] 20:01 -!- greypw254600 [~greypw254@grey.pw] has joined #bitcoin-core-pr-reviews 20:02 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 20:04 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds] 20:05 -!- greypw254600 [~greypw254@grey.pw] has quit [Remote host closed the connection] 20:05 -!- greypw254600 [~greypw254@grey.pw] has joined #bitcoin-core-pr-reviews 20:06 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 20:10 -!- greypw254600 [~greypw254@grey.pw] has quit [Remote host closed the connection] 20:10 -!- greypw254600 [~greypw254@grey.pw] has joined #bitcoin-core-pr-reviews 20:15 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 244 seconds] 20:19 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 20:23 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 20:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has joined #bitcoin-core-pr-reviews 20:35 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 20:39 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 20:50 -!- ishaanam[m] [~ishaanamm@2001:470:69fc:105::2:4078] has joined #bitcoin-core-pr-reviews 20:52 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 20:57 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 21:00 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 21:05 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 21:05 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 276 seconds] 21:09 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 21:19 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 21:24 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 21:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:fd94:2eea:e891:860b] has quit [Ping timeout: 276 seconds] 21:35 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 21:40 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 272 seconds] 21:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:89ff:4710:1dc:aa30] has joined #bitcoin-core-pr-reviews 21:51 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 21:55 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 22:02 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 22:08 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 22:20 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 22:24 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds] 22:38 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 22:43 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 22:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:89ff:4710:1dc:aa30] has quit [Ping timeout: 276 seconds] 22:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:89ff:4710:1dc:aa30] has joined #bitcoin-core-pr-reviews 22:54 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 23:02 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 23:15 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 23:21 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds] 23:33 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-pr-reviews 23:52 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 244 seconds] 23:52 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:89ff:4710:1dc:aa30] has quit [Ping timeout: 244 seconds] 23:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:89ff:4710:1dc:aa30] has joined #bitcoin-core-pr-reviews --- Log closed Thu Jul 07 00:00:13 2022