--- Log opened Fri Aug 19 00:00:55 2022 00:40 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 00:41 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 01:41 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 248 seconds] 01:45 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 01:46 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 02:05 -!- __gotcha [~Thunderbi@94.105.116.67.dyn.edpnet.net] has joined #bitcoin-core-pr-reviews 02:14 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 02:57 -!- __gotcha [~Thunderbi@94.105.116.67.dyn.edpnet.net] has quit [Ping timeout: 248 seconds] 03:57 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 248 seconds] 05:13 < stickies-v> if anyone was somewhat confused by some of the move semantics of the previous PR (#25665), this SO answer might help clear things up a bit: https://stackoverflow.com/a/51706522/734612 06:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:cd40:9d86:a58c:d8c3] has joined #bitcoin-core-pr-reviews 07:10 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 07:12 < stickies-v> 7:54 PM but we'd still allocate memory for the failure type even if the ErrorInfo only contained errors and warnings I think? which perhaps could be improved? 07:15 < stickies-v> furszy michaelfolkson: just looked at this again - I think it's fine the way it is. each call site decides on the types of both the result and failure type. if in the unhappy path there won't be a failure value, it'll just define its return type as `Result` and then `ErrorInfo` will be instantiated with `std::monostate` as the type for `failure`. so no unnecessary allocation there 09:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:cd40:9d86:a58c:d8c3] has quit [] 09:46 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 10:25 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 10:27 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 10:27 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Client Quit] 10:29 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 11:44 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds] 12:55 -!- MacroFake [~none@72.5.34.65] has joined #bitcoin-core-pr-reviews 13:04 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Ping timeout: 268 seconds] 13:13 -!- __gotcha [~Thunderbi@94.105.116.67.dyn.edpnet.net] has joined #bitcoin-core-pr-reviews 14:49 -!- __gotcha [~Thunderbi@94.105.116.67.dyn.edpnet.net] has quit [Ping timeout: 256 seconds] 15:41 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 15:58 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 16:20 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 17:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 17:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews 19:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 19:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews 19:27 -!- sanket_cell [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has quit [Quit: ZNC 1.8.2 - https://znc.in] 19:27 -!- sanket1729 [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has quit [Quit: ZNC 1.8.2 - https://znc.in] 19:29 -!- sanket_cell [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has joined #bitcoin-core-pr-reviews 19:29 -!- sanket_cell [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has quit [Remote host closed the connection] 19:30 -!- sanket_cell [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has joined #bitcoin-core-pr-reviews 19:31 -!- sanket1729 [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has joined #bitcoin-core-pr-reviews 19:45 -!- evanlinj1 [~root@gateway/tor-sasl/evanlinjin] has quit [Remote host closed the connection] 19:45 -!- evanlinj1 [~root@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-pr-reviews 23:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 23:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews 23:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 23:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews 23:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 23:11 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews 23:12 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 23:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews 23:21 -!- hashfunc [~user@2601:5c0:c280:7090:655e:9576:ffdc:417b] has joined #bitcoin-core-pr-reviews 23:34 -!- hashfunc [~user@2601:5c0:c280:7090:655e:9576:ffdc:417b] has quit [Remote host closed the connection] --- Log closed Sat Aug 20 00:00:56 2022