--- Log opened Fri Sep 23 00:00:27 2022
00:19 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews
01:01 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
01:03 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
01:04 -!- Cory [~Cory@068-187-125-109.res.spectrum.com] has quit [Changing host]
01:04 -!- Cory [~Cory@user/pasha] has joined #bitcoin-core-pr-reviews
01:40 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
01:40 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
01:52 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
01:52 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
02:16 -!- ziggie [uid521459@user/ziggie] has joined #bitcoin-core-pr-reviews
02:21 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews
02:24 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds]
02:32 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 258 seconds]
02:34 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
02:37 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds]
02:49 -!- kouloumos [uid539228@id-539228.tinside.irccloud.com] has joined #bitcoin-core-pr-reviews
03:58 -!- __gotcha [~Thunderbi@94.105.116.67.dyn.edpnet.net] has joined #bitcoin-core-pr-reviews
04:18 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
04:19 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
05:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
05:04 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
05:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 258 seconds]
05:20 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
05:32 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 258 seconds]
05:33 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews
05:34 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
05:42 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
05:42 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
07:18 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
07:19 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
07:23 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
07:23 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
07:27 -!- kevkevin [~kevkevin@2601:243:197e:8f10:e8c6:5010:3f9f:fe22] has quit [Remote host closed the connection]
07:28 -!- kevkevin [~kevkevin@2601:243:197e:8f10:9970:f483:ea70:9abf] has joined #bitcoin-core-pr-reviews
07:33 -!- kevkevin [~kevkevin@2601:243:197e:8f10:9970:f483:ea70:9abf] has quit [Remote host closed the connection]
07:33 -!- kevkevin [~kevkevin@2601:243:197e:8f10:9970:f483:ea70:9abf] has joined #bitcoin-core-pr-reviews
07:38 < NorrinRadd> i have the same issue with bitcoin-core-dev
07:39 < NorrinRadd> i'm registered so that doesn't seem to be it. someone should check the channel settings for modes and see if some bot or person has been quieting people.
08:08 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
08:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 258 seconds]
08:19 -!- kevkevin [~kevkevin@2601:243:197e:8f10:9970:f483:ea70:9abf] has quit [Remote host closed the connection]
08:19 -!- kevkevin [~kevkevin@2601:243:197e:8f10:9970:f483:ea70:9abf] has joined #bitcoin-core-pr-reviews
08:44 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
08:55 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
08:59 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
08:59 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
09:26 < pinheadmz_> I'm playing with an anyone can spend test. p2wsh where the script is just OP_TRUE. The witness stack is [<empty>, <raw script>]
09:26 < pinheadmz_> what i get is a CLEANSTACK error, which confuses me
09:26 < pinheadmz_> seems like the <empty> witness item still counts as a witness item, leaving 2 items on the stack?
09:28 < pinheadmz_> is the shortest possible valid script/stack pair OP_VERIFY with stack 0x01 ?
09:28 < pinheadmz_> Or is there a "anyone can spend" with an actual empty stack from the witness ?
09:54 < pinheadmz_> ok i think i figured it out, you can actually p2wsh a completely empty script, and redeem it with OP_TRUE
10:01 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews
10:03 -!- adam2k [~adam2k@216.54.50.106] has joined #bitcoin-core-pr-reviews
10:08 -!- larryruane_ is now known as LarryRuane
10:12 < instagibbs> you shouldn't be passing <empy> in witness stack?
10:13 < instagibbs> if there's no inputs, you just give it [<raw_script>]
10:13 < pinheadmz_> instagibbs but then witness only has 1 item and wont be v0 p2wsh, right?
10:13 < pinheadmz_> or am i mistaken about that
10:13 < instagibbs> https://github.com/bitcoin/bips/blob/master/bip-0141.mediawiki#witness-program
10:13 < instagibbs> read the spec
10:14 < pinheadmz_> yeah so
10:14 < pinheadmz_> "The witness must consist of an input stack to feed to the script, followed by a serialized script (witnessScript)."
10:15 < pinheadmz_> so even if your script is just OP_TRUE you still need to pass it something
10:15 < pinheadmz_> and even if that something is `0x00` (empty) its not a valid spend
10:15 < instagibbs> ahhhh english ambiguity
10:16 < instagibbs> it's saying put an element in the stack per input
10:16 < instagibbs> not "serialize all the inputs and put them into a single element"
10:16 < instagibbs> [input1, input2, input3, <serialized script>]
10:17 < instagibbs> not [[input1, input2, input3], <serialized_script>]
10:17 < pinheadmz_> yeah i know that
10:17 < instagibbs> ok then I don't understand
10:17 < pinheadmz_> i guess the question is "can i p2wsh where the script is just OP_TRUE?"
10:17 < instagibbs> yes
10:17 < pinheadmz_> ok then what does the witness look like?
10:18 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
10:18 < instagibbs> [serialized_script<OP_TRUE>]
10:18 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
10:18 < pinheadmz_> so witness stack with only one item
10:18 < instagibbs> yes
10:18 < pinheadmz_> meaning after script is popped off, witness stack has zero items
10:18 < instagibbs> no inputs required, because no inputs are required
10:18 < pinheadmz_> that wont throw SCRIPT_ERR_WITNESS_PROGRAM_WITNESS_EMPTY ?
10:19 -!- adam2k [~adam2k@216.54.50.106] has quit [Quit: Client closed]
10:19 < instagibbs> thats the interpreter stack
10:19 < instagibbs> not the witness stack
10:19 < instagibbs> witness stack is just bytes
10:19 < instagibbs> actually let me read more
10:20 < instagibbs> ok no, this is witness stack, but its checking size before popping off the script
10:20 < instagibbs> so yes, it is size 1 in this case
10:20 < instagibbs> you have to supply at least one element, the serialized script
10:21 < pinheadmz_> https://gist.github.com/pinheadmz/a3fccd1e327577780ed0f5599d9fecb0
10:21 < pinheadmz_> ah yeah, passes
10:22 < pinheadmz_> i guess i didnt realize a witness spending from p2wsh could get away with a single item witness
10:22 < pinheadmz_> but makes sense
10:22 < pinheadmz_> whats confusing is that an empty witness item counts as a stack item during script execution, at least for clean stack
10:23 < instagibbs> in interpreter land it will be counted as "0", so it makes sense
10:23 < pinheadmz_> :+1:
10:24 < instagibbs> this fact is also useful for CTV/APO for basic "commit to hash" style covenants
10:25 < instagibbs> no inputs for those, just revealing the transaction that matches that hash really
10:32 < LarryRuane> amovfx: glozow: _aj_: Thanks, I registered with NickServ, also I was able to change my nick (as you can see). But I don't know if I can post in #bitcoin-core-dev (I don't want to spam it with a test message) ... I'll try saying "hi" next week at the start of the meeting
10:59 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has quit [Remote host closed the connection]
10:59 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has joined #bitcoin-core-pr-reviews
11:04 < amovfx> LarryRuane: Ill keep an eye out
11:14 < theStack> pinheadmz_: fwiw, our functional tests's simple wallet implementation (MiniWallet, found in ./test/functional/test_framework/wallet.py) uses the taproot variant of anyone-can-spend outputs with OP_TRUE by default, maybe that could also be interesting for you
11:31 -!- adam2k [~adam2k@216-24-66-90.access.naxs.com] has joined #bitcoin-core-pr-reviews
11:49 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
11:49 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
12:31 -!- kouloumos [uid539228@id-539228.tinside.irccloud.com] has quit [Quit: Connection closed for inactivity]
12:42 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has quit [Remote host closed the connection]
12:43 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has joined #bitcoin-core-pr-reviews
12:48 < stickies-v> kouloumos is hosting Wednesday's review club to go over his v24 RC Testing Guide. Join us for an hour of hands-on testing and helping ensure v24 ships without bugs! Notes are up on https://bitcoincore.reviews/v24-rc-testing
12:50 -!- adam2k [~adam2k@216-24-66-90.access.naxs.com] has quit [Quit: Client closed]
12:57 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has quit [Remote host closed the connection]
12:58 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has joined #bitcoin-core-pr-reviews
12:58 < amovfx> AutonomyMasteryPurpose!1
13:10 -!- adam2k [~adam2k@ip24-254-208-245.hr.hr.cox.net] has joined #bitcoin-core-pr-reviews
13:14 -!- adam2k [~adam2k@ip24-254-208-245.hr.hr.cox.net] has quit [Client Quit]
13:14 < sipa> amovfx: I suggest changing your password now.
13:15 < brunoerg> lol
13:20 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
13:20 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
13:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
13:22 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
13:25 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews
13:28 -!- brunoerg [~brunoerg@187.183.43.178] has quit []
14:07 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
14:08 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
14:45 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
14:47 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has quit [Remote host closed the connection]
14:48 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has joined #bitcoin-core-pr-reviews
15:46 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
16:33 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has quit [Remote host closed the connection]
16:33 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has joined #bitcoin-core-pr-reviews
16:44 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has quit [Remote host closed the connection]
16:45 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has joined #bitcoin-core-pr-reviews
18:06 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has quit [Read error: Connection reset by peer]
18:06 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has joined #bitcoin-core-pr-reviews
18:21 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has quit [Remote host closed the connection]
18:22 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has joined #bitcoin-core-pr-reviews
19:33 -!- hashfunc [~user@2601:5c0:c280:7090:390e:42fb:86a3:2177] has joined #bitcoin-core-pr-reviews
19:42 -!- kevkevin [~kevkevin@2601:243:197e:8f10:9970:f483:ea70:9abf] has quit [Ping timeout: 252 seconds]
20:51 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 258 seconds]
20:52 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
23:28 -!- hashfunc [~user@2601:5c0:c280:7090:390e:42fb:86a3:2177] has quit [Ping timeout: 244 seconds]
23:40 -!- hashfunc [~user@2601:5c0:c280:7090:4dd6:c550:51b4:6d0a] has joined #bitcoin-core-pr-reviews
23:46 -!- hashfunc [~user@2601:5c0:c280:7090:4dd6:c550:51b4:6d0a] has quit [Ping timeout: 264 seconds]
23:48 -!- hashfunc [~user@2601:5c0:c280:7090:4dd6:c550:51b4:6d0a] has joined #bitcoin-core-pr-reviews
23:52 -!- hashfunc [~user@2601:5c0:c280:7090:4dd6:c550:51b4:6d0a] has quit [Remote host closed the connection]
23:52 -!- hashfunc [~user@2601:5c0:c280:7090:4dd6:c550:51b4:6d0a] has joined #bitcoin-core-pr-reviews
23:57 -!- hashfunc [~user@2601:5c0:c280:7090:4dd6:c550:51b4:6d0a] has quit [Remote host closed the connection]
23:57 -!- hashfunc [~user@2601:5c0:c280:7090:4dd6:c550:51b4:6d0a] has joined #bitcoin-core-pr-reviews
--- Log closed Sat Sep 24 00:00:29 2022