--- Log opened Wed Sep 28 00:00:32 2022
00:00 -!- NorrinRadd [~me@188.215.95.220] has joined #bitcoin-core-pr-reviews
03:12 -!- NorrinRadd [~me@188.215.95.220] has quit [Ping timeout: 260 seconds]
03:15 -!- __gotcha [~Thunderbi@85.234.220.238] has joined #bitcoin-core-pr-reviews
03:37 -!- NorrinRadd [~me@188.215.95.91] has joined #bitcoin-core-pr-reviews
03:42 -!- jonatack3 [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
03:42 -!- Zenton [~user@user/zenton] has quit [Read error: Connection reset by peer]
03:45 -!- Zenton [~user@user/zenton] has joined #bitcoin-core-pr-reviews
04:04 -!- amovfx_ [amovfx@gateway/vpn/protonvpn/amovfx] has quit [Ping timeout: 248 seconds]
04:06 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has joined #bitcoin-core-pr-reviews
04:18 < kouloumos> This week's PR Review Club meeting starts in ~6h, 17:00 UTC. Today we are going to be testing Bitcoin's upcoming 24.0 release with an entertaining (hopefully) 1h walkthrough of the testing guide.
04:18 < kouloumos> It is recommended to go through the “Preparation” steps ahead of the meeting, especially if you want to compile from source.
04:18 < kouloumos> The testing guide is divided into five sections, "Observing the new headers pre-synchronization phase during IBD", "Testing the GUI", "Testing transient addresses for I2P outbound connections", "Migrating Legacy Wallets to Descriptor Wallets", "Testing watch-only support for Miniscript descriptors".
04:19 < kouloumos> I believe that it's important to have context around what we are testing, therefore the testing guide sections include the gist of each change and if needed a few extra details to get a better grasp of the subject. There are external links to dive into any subject you want to explore further. 
04:19 < kouloumos> You can find the guide here https://bitcoincore.reviews/v24-rc-testing
04:20 < kouloumos> If you decide to go through the guide ahead of the meeting, please bring up any questions (regarding the guide or a specific change) and problems that might arise.
04:23 -!- jonatack3 [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews
04:57 -!- NorrinRadd [~me@188.215.95.91] has quit [Ping timeout: 265 seconds]
05:11 -!- NorrinRadd [~me@188.215.95.91] has joined #bitcoin-core-pr-reviews
05:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d9f9:9a28:ba2a:f9b3] has joined #bitcoin-core-pr-reviews
05:59 -!- jonatack3 [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds]
06:07 -!- NorrinRadd [~me@188.215.95.91] has quit [Ping timeout: 252 seconds]
06:21 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
06:25 -!- NorrinRadd [~me@154.6.21.240] has joined #bitcoin-core-pr-reviews
06:34 -!- jonatack3 [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews
07:32 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
07:33 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
07:48 -!- adam2k [~adam2k@ip24-254-208-245.hr.hr.cox.net] has quit [Quit: Client closed]
07:50 -!- pablomartin [~pablomart@185.199.100.63] has joined #bitcoin-core-pr-reviews
09:00 < kouloumos> T-minus 1 hour for our meeting! If you haven't gone through the "Preparation" section, you still have time to do so.👨‍💻
09:01 < kouloumos>  Depending on your number of CPUs, you might have time to compile from source😎 otherwise pre-compiled binaries is the way!
09:04 < kouloumos> Also, the best idea of other things we can test is eligible for 100.000 sats
09:17 -!- chipxxx [~chip@pop.92-184-123-139.mobile.abo.orange.fr] has joined #bitcoin-core-pr-reviews
09:17 -!- chipxxx [~chip@pop.92-184-123-139.mobile.abo.orange.fr] has quit [Remote host closed the connection]
09:18 -!- chipxxx [~chip@pop.92-184-123-139.mobile.abo.orange.fr] has joined #bitcoin-core-pr-reviews
09:18 -!- randomsats [~randomsat@cpe1033bfa9e0e7-cm1033bfa9e0e5.cpe.net.cable.rogers.com] has joined #bitcoin-core-pr-reviews
09:28 -!- ccdle12 [~ccdle12@243.222.90.149.rev.vodafone.pt] has joined #bitcoin-core-pr-reviews
09:29 -!- nerd2ninja [~nerd2ninj@52.249.240.64] has joined #bitcoin-core-pr-reviews
09:35 -!- stacie [uid563966@id-563966.uxbridge.irccloud.com] has joined #bitcoin-core-pr-reviews
09:36 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
09:38 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 258 seconds]
09:47 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews
09:54 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has joined #bitcoin-core-pr-reviews
09:54 -!- adam2k [~adam2k@ip24-254-208-245.hr.hr.cox.net] has joined #bitcoin-core-pr-reviews
09:55 -!- hernanmarino [~hernanmar@190.16.216.111] has joined #bitcoin-core-pr-reviews
09:56 -!- Juls [~Juls@201.231.198.198] has joined #bitcoin-core-pr-reviews
09:56 -!- cypherchabon [~cyphercha@181.92.18.53] has joined #bitcoin-core-pr-reviews
09:56 < cypherchabon> hi!
09:56 < Juls> Hi Everyone!
09:57 < kouloumos> hi cypherchabon and Juls, meeting is starting in ~3 minutes
09:58 -!- sanya [~sanya@109-93-2-111.dynamic.isp.telekom.rs] has joined #bitcoin-core-pr-reviews
10:00 < kouloumos> #startmeeting
10:00 < brunoerg> hi! 
10:00 < kouloumos> Hello everyone! Welcome to another special edition of the Bitcoin PR Review Club.
10:00 < kouloumos> Today we are going to be testing Bitcoin's upcoming 24.0 release by going through some of its changes. 
10:00 < kouloumos> Feel free to say hi to let people know you are here 
10:00 < stacie> hello!
10:00 < glozow> hi!
10:00 < yashraj> hi
10:00 -!- Luc58 [~Luc@95.56.113.78.rev.sfr.net] has joined #bitcoin-core-pr-reviews
10:01 < kouloumos> To help us along, we will be following this guide: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Candidate-Testing-Guide
10:01 < theStack> hi
10:01 < LarryRuane> hi
10:01 < hernanmarino> Hi everyone 
10:01 < pablomartin> hi all!
10:01 < stickies-v> hi!
10:01 -!- alecc [~alecc@s-25-172.flex.volo.net] has joined #bitcoin-core-pr-reviews
10:01 < cypherchabon> hi everyone!
10:01 < kouloumos> Hello to everyone!
10:01 < kouloumos> For starters, is this anyone's first time?
10:02 < Luc58> Hell everyone, first time for me :)
10:02 < Juls> Hi Kouloumos! It is my first time
10:02 -!- asi0 [~asi0@static-176-191-113-38.ftth.abo.bbox.fr] has joined #bitcoin-core-pr-reviews
10:02 < kouloumos> welcome!
10:02 < kouloumos> For the newcomers (and just as a reminder), its encouraged to just blurt out questions! no need to ask for permission first or worry about if you're interrupting another question.
10:02 < cypherchabon> first time here
10:03 < NorrinRadd> Hello!
10:03 < alecc> Hi!
10:03 -!- arthur [~arthur@172.56.58.72] has joined #bitcoin-core-pr-reviews
10:03 < NorrinRadd> Brandon
10:04 < NorrinRadd> yes first time
10:04 < kouloumos> Welcome to all the newcomers!
10:04 < cypherchabon> thanks!
10:04 < arthur> this where we learn how to do contribute into bitcoin ?
10:05 -!- blop [~blop@84.65.239.218] has joined #bitcoin-core-pr-reviews
10:05 < kouloumos> As mentioned in the beginning, today we are going to be testing Bitcoin's upcoming 24.0
10:05 < nerd2ninja> I think I saw that visual scripting was added? Is this true or is that a misinterpretation of an image I saw?
10:05 < kouloumos> Therefore, open the testing guide and prepare for an hour of testing, knowledge and entertainment! 👨‍💻🤯🕺🏻
10:05 -!- blop [~blop@84.65.239.218] has quit [Client Quit]
10:06 < stacie> 🤩
10:06 < kouloumos> nerd2ninja: I am not sure about what you are referring to, a link would be useful
10:06 < kouloumos> It was suggested to go through the “Preparation” section ahead of the meeting. If you haven't, this is the time to grab the release candidate pre-compiled binary for your system, as per https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Candidate-Testing-Guide/#preparation
10:06 < arthur> yes... link would be usefuel
10:06 < LarryRuane> arthur: in case you haven't seen this yet https://unchained.com/blog/contributing-bitcoin-core-patience/
10:06 < kouloumos> arthur: To help us along with testing, we will be following this guide: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Candidate-Testing-Guide
10:06 < kouloumos> Compiling is also an option, but it can take some time depending on the machine. 
10:06 < kouloumos> We'll give a few minutes for people to get their release candidate, but there is no need to wait on everyone else if you'd like to start working through the sections or have questions.
10:07 < glozow> LarryRuane: indeed, the best way to contribute right now is to test the release candidate
10:07 < kouloumos> I would like to emphasize that this guide is meant to be the *starting point* to get you started with testing. 
10:07 < kouloumos> Most of the individual changes are well tested during the review phase, when the code is introduced to the codebase. What's more complicate to test is how everything behave together on different configurations and different user patterns. Therefore it's encouraged to do your own testing and experimentations.
10:07 < yashraj> I already have 23.0 production installed, do I have to uninstall it?
10:08 < stickies-v> nerd2ninja: I think what you mean is the miniscript.fun visualisation website of miniscript scripts. Bitcoin Core doesn't allow any visual scripting directly, but it supports miniscript to some extent
10:08 < arthur> will there be a video or something or are we supposed to go through the link on our own
10:08 < kouloumos> No, PR Review Club meetings are text-based only on IRC
10:08 < hernanmarino> yashraj: no need to uninstall , just follow the instructions , il will work
10:08 < nerd2ninja> stickies-v Got it
10:09 < stacie> As I go through the guide, I'm logging what I've tested and what my results are. Even if things are all good, would it be valuable to share that somewhere? Is there one place where the QA is getting aggregated? If not I'll probably just upload it as a gist or something for my own future reference
10:09 < kouloumos> nerd2ninja: Hopefully we will manage to work our way to the fun of miniscript.fun
10:09 < stacie> I understand there is an open issue for bugs that are uncovered
10:09 < LarryRuane> I decided to test using `signet` so I could do some transactions ... I'm kind of currently testing the testing guide, I'll make some suggestions to it, I'm behind, on section 5 https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Candidate-Testing-Guide#5-testing-with-a-signet-faucet it needs some improvements
10:10 < glozow> stacie: awesome :) i'm sure a link to your gist on https://github.com/bitcoin/bitcoin/issues/26175 would be appreciated
10:10 < kouloumos> I'll also remind you in the end, but yes stacie, it's encouraged to report your findings at the v24.0 testing issue: https://github.com/bitcoin/bitcoin/issues/26175
10:10 -!- Luc60 [~Luc@95.56.113.78.rev.sfr.net] has joined #bitcoin-core-pr-reviews
10:11 -!- francismars [~Francis@2001:8a0:fa4c:901:2510:4bbb:b238:f] has joined #bitcoin-core-pr-reviews
10:11 < kouloumos> Thank you LarryRuane, suggestions are appreciated
10:11 < stacie> ooo that issue is just what I was looking for! ty glozow and kouloumos!
10:11 < kouloumos> Before we start, could you please share which OS you're using and whether you'll be compiling from source or using the pre-compiled binaries?
10:11 < LarryRuane> just to make sure everyone saw this, there's a link near the top to an issue to give feedback on the testing guide itself https://github.com/bitcoin/bitcoin/issues/26092
10:11 < kouloumos> I'm on NixOS 21.11, compiled from source 
10:11 < stickies-v> macOS 12.4, compiled from source
10:12 < brunoerg> I'm on MacOS 10.0
10:12 < stacie> Ubuntu 22.04, compiled from source
10:12 < alecc> macOS 12.6, pre-compiled binary
10:12 < LarryRuane> ubuntu 22.04.1 LTS, both building from src and downloading binary
10:12 < yashraj> brunoerg: good man, I'm on 12.3 installing from binary
10:13 < kouloumos> Does everyone have a copy of the current release candidate?
10:13 < kouloumos> The testing guide has five main sections highlighting some of the major changes of the upcoming 24.0 release: "Observing the new headers pre-synchronization phase during IBD", "Testing the GUI", "Testing transient addresses for I2P outbound connections", "Migrating Legacy Wallets to Descriptor Wallets", "Testing watch-only support for Miniscript descriptors".
10:13 < LarryRuane> i've got a myNode (RPi) which is arm, and i think i'll build from source and test download binary there too
10:14 < kouloumos> As you go through each section, please bring up any questions or problems that arise.
10:14 -!- Luc58 [~Luc@95.56.113.78.rev.sfr.net] has quit [Ping timeout: 268 seconds]
10:14 < kouloumos> Also just repeating something for people that joined later: its encouraged to just blurt out questions! no need to ask for permission first or worry about if you're interrupting another question.
10:15 < stacie> Does it matter if we test with signet or mainnet? I understand some scenarios may be easier to set up on signet. Is it generally better to test with mainnet (when reasonable)?
10:15 < LarryRuane> I already mentioned I ran into problems in section 5, I tried to use `getcoins.py` but the guide doesn't tell you how to generate an address.. and before that you need to create a wallet
10:15 < LarryRuane> stacie: I decided on signet so I could have some coins to test with
10:15 < LarryRuane> also of course the IBD is much faster!
10:16 < LarryRuane> but i think mainnet testing is good too!
10:16 < stacie> LarryRuane I noticed the signet section doesn't mention the command for address creation :) So I skipped it for now and was like I'll deal with that later haha Glad you saw that too
10:16 < LarryRuane> (i'll submit some suggestions to improve section 5, I worked through all the problems)
10:17 < stacie> awesome!
10:17 < hernanmarino> If the script doesn work, you can get signet coins on https://signet.bc-2.jp/
10:17 < kouloumos> Also https://signetfaucet.com/
10:17 < LarryRuane> kudos to @theStack for writing the `getcoins.py` tool, very nice! (the problems I ran into weren't with the tool itself, only how to invoke it)
10:18 < LarryRuane> (oh sorry I think @theStack only improved it, didn't write it initially)
10:18 < theStack> oh it was not written by me, but thanks anyways :)
10:18 < kouloumos> That getcoins.py was a last minute change, apologies for the issues. If anyone has issues when it's time for signet coins, please write it here
10:19 < Juls> getcoins.py does not work with python 3, right?
10:19 < kouloumos> Reminder: You don't have to be a command-line wizard. The "Testing the GUI" section is especially for people not comfortable with the command line. That said, by using the integrated RPC console (Window->Console), you can go through all of the sections of this guide. If you have any issues with that, ask questions.
10:19 < Juls> I got an error
10:19 < theStack> as for generating a new address to receive coins to, this should be as simple as running the `getnewaddress` RPC? (i.e. $ bitcoin-cli getnewaddress)
10:20 < glozow> stacie: would be good to test that you can sync the mainnet chain (even just headers is enough) given that we have some PoW-centric IBD changes in this release. but otherwise most functionality is equivalent
10:20 < kouloumos> That signet faucet section was meant to be linked from later in the guide, so if you have problems with it now (creating wallets, deriving addresses etc.) better leave it to when you reach a section that needs coins
10:20 < LarryRuane> to successfully run `getcoins.py` you must first do something like `cli createwallet mytestwallet` and then (as @theStack said) `getnewaddress`
10:20 < kouloumos> So, I think it's time to try and go though the testing sections!
10:20 < stickies-v> and since we want to make sure everyone is able to use the GUI, even if you're usually a cli user, it's still very helpful to test the GUI too!
10:20 < kouloumos> The goal with this meeting is to get more people involved with testing and help address any issues people might have while working through the guide. It's unlikely we will get through all of it in one hour. But you can always come back to this channel and ask questions while working through the guide or testing in general. You can find 24/7 logs of this channel here: https://gnusha.org/bitcoin-core-pr-reviews/
10:21 < NorrinRadd> kouloumos i'm on MacOS 12.6 arm64 running the arm64 binary of the rc from the rc page you linked 
10:21 < kouloumos> Let's start with observing the new headers pre-synchronization phase during IBD: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Candidate-Testing-Guide#observing-the-new-headers-pre-synchronization-phase-during-ibd
10:22 < kouloumos> This is a pretty interesting change that deals with a potential DoS attack. You can test this with or without the GUI, just make sure that you are using an empty datadir (new node).
10:22 < kouloumos> Note that if you run this on signet (cc stacie), the blockheaders sync usually happens very fast so you might not be able to observe anything interesting.
10:23 < kouloumos> The guide mentions 3 ways that you can observe this new behavior (debug.log, real-time logging from the terminal, using the `getpeerinfo` RPC ). If you are using the GUI, you can also see real-time logging from the terminal using the `-printtoconsole` flag.
10:23 < stacie> glozow that makes sense, thanks! I may even try to test full sync on mainnet then if I have time
10:23 < LarryRuane> i also had to `sudo apt install imagemagick` then i could `contrib/signet/getcoins.py -c $BINARY_PATH/bitcoin-cli -a myaddress -- -signet -datadir=$DATA_DIR` ... that worked for me
10:25 < kouloumos> Does anyone looking at the pre-syncing phase yet?
10:26 < kouloumos> If anyone has stuck at initial setup, please let us know. This is the place for questions.
10:26 < LarryRuane> yes I see the `Pre-synchronizing blockheaders` messages, followed by the `Synchronizing blockheaders` messages (on signet) all looks correct
10:26 < kouloumos> If we are "lucky" and new blocks are found during pre-sync, you might also see the behavior that I'm describing in the "Observe Further" subsection: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Candidate-Testing-Guide#observe-further
10:27 -!- vnprc [~vnprc@136.56.39.155] has joined #bitcoin-core-pr-reviews
10:28 < stickies-v> tested on mainnet, all seems correct to me too, both bitcoind and qt (although on gui the progress bar jumps around a bit, and I think since we know have a presync, maybe we can stop saying "Unknown" number of blocks left in headers sync phase?
10:28 -!- newbiexra [~newbiexra@ip-109-43-50-138.web.vodafone.de] has joined #bitcoin-core-pr-reviews
10:29 < theStack> started a mainnet IBD on OpenBSD 7.1 amd64 yesterday with rc1, also saw the "Pre-synchronizing blockheaders" and "Synchronizing blockheaders" message, everything worked fine so far (still syncing though due to rather slow hw)
10:29 < LarryRuane> does everyone know to `tail -f $DATA_DIR/signet/debug.log` ... (remove the "signet" if you're using mainnet) ... I find that very helpful
10:29 < LarryRuane> (do that in a separate shell window)
10:29 -!- newbiexra [~newbiexra@ip-109-43-50-138.web.vodafone.de] has quit [Client Quit]
10:30 < theStack> my impression was that the headers-only phase took significantly longer (like 5-10x) than it used to be... is that expected (didn't look into any detail of the changes yet), or did i maybe just have a slow connection or alike
10:30 < kouloumos> stickies-v: I wanted to better understand where that "Unknown" comes from, but never looked into the code yet.
10:30 < LarryRuane> it's interesting that if the headers sync gets interrupted (peer disconnected) it starts over from scratch (IIUC)
10:30 < LarryRuane> (but it's okay since that phase is very fast)
10:30 < stacie> I tested the new headers pre sync phase using mainnet just before this meeting (that was as far as I got into the guide). The logs for pre sync and sync look good, and the watch command for the getpeerinfo call shows what I expect it to for the peer involved in the pre-sync/sync. Left a comment on the testing feedback issue for a tiny nit in the instructions
10:31 < _aj_> LarryRuane: do you know you can do `less .bitcoin/signet/debug.log` and press G (to go to the end) and then F (to follow additions, equivalent of tail -f), but then you can press ^C and scroll around
10:31 < kouloumos> theStack: If new blocks are announced to you while you are in the headers sync phase, your node downloads headers from more peers at the same time. Therefore taking more time.
10:31 < glozow> LarryRuane: yes it starts from scratch if you had no other peers you were presyncing with
10:31 < LarryRuane> _aj_: that's a great suggestion
10:31 < hernanmarino> stickies-v : good point
10:31 -!- newbiexra [~newbiexra@ip-109-43-50-138.web.vodafone.de] has joined #bitcoin-core-pr-reviews
10:32 < theStack> kouloumos: okay
10:32 -!- newbiexra73 [~newbiexra@ipbcc0db7f.dynamic.kabel-deutschland.de] has joined #bitcoin-core-pr-reviews
10:32 < kouloumos> Also, regarding theStack's observation, can anyone explain what would happen in previous Bitcoin Core versions if a new block was announced to our node during the headers synchronization phase? 
10:33 -!- newbiexra73 [~newbiexra@ipbcc0db7f.dynamic.kabel-deutschland.de] has quit [Client Quit]
10:34 -!- newbiexra12 [~newbiexra@ipbcc0db7f.dynamic.kabel-deutschland.de] has joined #bitcoin-core-pr-reviews
10:34 -!- newbiexra12 [~newbiexra@ipbcc0db7f.dynamic.kabel-deutschland.de] has quit [Client Quit]
10:34 < glozow> theStack: it should take 2x longer but not 5-10x longer 🤔
10:34 -!- newbiexra12 [~newbiexra@ipbcc0db7f.dynamic.kabel-deutschland.de] has joined #bitcoin-core-pr-reviews
10:34 < kouloumos> Right now, with v24.0, we are initiating sync with the first peer that will announce the new block to us. So if 3 blocks are found during our blockheaders sync phase, that will result  to simultaneously do header-sync with 4 peers instead of 1, thus the process will take further
10:35 < kouloumos> Let's briefly move to the "Testing the GUI" section! (but always feel free to continue on previous points)
10:35 < kouloumos> "Testing your localized GUI" is more of an accessibility test, no critical bugs can arise from it. Still, it's a great way to explore your localized GUI while helping for a better user experience.
10:36 < LarryRuane> kouloumos: all the peers that announced the block to us (which is probably all of them) would start sending us headers (i mean, we would ask them for headers)
10:36 -!- newbiexra [~newbiexra@ip-109-43-50-138.web.vodafone.de] has quit [Ping timeout: 265 seconds]
10:36 -!- francismars [~Francis@2001:8a0:fa4c:901:2510:4bbb:b238:f] has quit [Ping timeout: 268 seconds]
10:37 < kouloumos> Correct! What LarryRuane described is the previous behavior. This was changed with PR#25720, if anyone wants to further look into this change, it was covered in a previous Review Club meeting: https://bitcoincore.reviews/25720
10:37 < glozow> LarryRuane: https://bitcoincore.reviews/25720
10:37 < glozow> kouloumos +1
10:38 < kouloumos> So! For the GUI testing session, focus on testing the restore wallet option and the unification of settings between bitcoind and the GUI.
10:38 < kouloumos> Any ideas on other ways we could test the persistent settings between the GUI and bitcoind?
10:40 < kouloumos> How are the rest of the people in the meeting doing? cypherchabon, Juls, yashraj, pablomartin, Luc58, NorrinRadd?
10:40 < theStack> glozow: have to add that i ran the test on a newly instated remote server (new location, new hw), so with nothing compare my observation was probably not very meaningful. will try on the same machine without the ibd-patch and then compare again
10:41 < kouloumos> Hopefully people did not run away yet🏃‍♂️
10:42 < kouloumos> GUI is boring for some, lets move to another important p2p change.
10:42 < kouloumos> Anybody that has done/currently doing the I2P setup in order to test the transient addresses for I2P outbound connections?
10:42 < LarryRuane> kouloumos: running bitcoin-qt
10:43 < stickies-v> LarryRuane: good observation re headers sync starting over. I did some more testing and it seems when a new peer is selected, it always starts pre-sync starting from the last non-pre-sync header received from the previous peer. 
10:43 < yashraj> I decided to IBD from UI since I don't know cli. But my Core started up in testnet where I was already pretty much synced, so changed over to signet. I saw the presyncing headers thing. Now I'm synced.
10:44 -!- asi0 [~asi0@static-176-191-113-38.ftth.abo.bbox.fr] has quit [Quit: Connection closed]
10:44 < yashraj> Can/should I move to cli? I don't know what I'm really doing lol
10:44 < kouloumos> No, If you are not comfortable with the command line, please continue with the GUI
10:45 < kouloumos> That goes for everyone, I am just trying to move through sections to add a bit of extra context but always feel free to continue and report on previous points.
10:46 -!- giabertu [~giabertu@147.12.250.63] has joined #bitcoin-core-pr-reviews
10:46 < Juls> Hernan is helping us with the unification of bitcoind and GUI config
10:46 < hernanmarino> koulomos: i2p is setup and running correctly, I'm waiting for the rest to test it together
10:47 < alecc> hey, should the gui/bitcoin generally compiled with gui work on M1 macs? my computer would just kill the pre-build binaries immediately once they started, and i just tried compiling from source and ran into some errors referring to unknown symbols for arm64 (prev when compiling without gui its worked) figured i'd ask
10:47 < stacie> still working through understanding the headers sync changes. I understand that if a block is received during headers sync, one of the peers that announced the block is added for headers sync. Does that mean (1.) my node will do a full headers sync with that new peer, meaning I'll be doing syncing headers twice, or (2) going forward, I'll now be using two peers for headers sync?
10:48 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
10:49 < kouloumos> alecc: unfortunately I can't answer that. Maybe someone else with M1 mac can help on that (stickies-v ?) . If not this sound like something that you can report at the v24 testing issue
10:49 < pablomartin> koulomos: done with the i2p test, all good 
10:49 < glozow> alecc: the answer to "should the gui compiled on M1 work" is yes
10:49 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
10:49 < LarryRuane> apparently you can't submit `bitcoin-cli` commands to a running `bitcoin-qt` ... is there a way to enable that?
10:50 < kouloumos> LarryRuane: You can use bitcoin-cli to talk to bitcoin-qt by starting bitcoin-qt with the -server option.
10:50 < yashraj> alecc: I'm using an M1 Mac and successfully installed from the binary.
10:50 < cypherchabon> I am using M1 and I had no problems
10:51 < cypherchabon> see https://github.com/bitcoin/bitcoin/blob/24.x/doc/build-osx.md
10:51 < alecc> oh hm alright I'll go back over the guides maybe i'm just missing some step
10:51 < glozow> stacie: yes you'll sync from multiple peers until you hit a chain with enough work
10:51 < lightlike> stacie: it's 1): You do two parallel header syncs that don't really influence each other once started.
10:52 < yashraj> alecc: If you Mac refuses to let you run it, you have to provide permission from System Preference > Security & Privacy.
10:52 < LarryRuane> kouloumos: thanks, also i found under Settings -> Options -> Main, there's an Enable RPC server checkbox .. that works too
10:52 < kouloumos> stacie: if the second peer is faster, you might first finish the sync with that one.
10:52 -!- b_101 [~robert@189.236.15.135] has joined #bitcoin-core-pr-reviews
10:52 < kouloumos> LarryRuane: great! another tip to add to the guide
10:53 -!- b_1o1 [~b_1o1@189.236.15.135] has joined #bitcoin-core-pr-reviews
10:53 < kouloumos> We can start the migration section, although I am not sure that we will finish it in time. But we can try! Feel free to hang around longer if you've not finished with the guide.  The Miniscript section is also fun
10:53 < stacie> ahhhh, that explains the balance between robustness, and bandwidth that I'm reading about in the testing guide. ty :) glozow lightlike kouloumos
10:54 < kouloumos> Legacy wallets will soon be unsupported and a migration mechanism is now in place.
10:54 < kouloumos> If you are not familiar with descriptors, the testing guide section gives a bit of an inside as well as what to expect after the migration:    https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Candidate-Testing-Guide#migrating-legacy-wallets-to-descriptor-wallets
10:55 < kouloumos> The guide gets into details in order to cover all the categories of scripts (non-HD, watch-ony, solvable) that a legacy wallet can have. 
10:55 < kouloumos> You can test the migratewallet RPC either by creating a new legacy wallet and then migrating it or by using an existing legacy wallet.
10:56 < kouloumos> Using existing wallets is a great way to strengthen this migration mechanism by helping testing again different wallet configurations. Although the migration process creates a backup before migrating, feel free to use the backupwallet RPC beforehand. 
10:57 -!- newbiexra12 [~newbiexra@ipbcc0db7f.dynamic.kabel-deutschland.de] has quit [Quit: Connection closed]
10:57 < glozow> interesting. if i migratewallet, and then migratewallet again, the error is "This wallet already uses SQLite" instead of something like "this is already a descriptor wallet"
10:58 -!- newbiexra12 [~newbiexra@ipbcc0db7f.dynamic.kabel-deutschland.de] has joined #bitcoin-core-pr-reviews
10:58 < LarryRuane> glozow: good catch!
10:59 < LarryRuane> i see a PR in your future
10:59 < b_101> glozow:+1
10:59 < LarryRuane> apparently `bitcoin-qt` won't create a legacy wallet for you
11:00 < kouloumos> isn't here an option in the beginning?
11:00 < kouloumos> and, we are out of time!
11:00 < kouloumos> #stopmeeting
11:00 < kouloumos> Thank you everyone for joining this meeting and taking time to help with testing Bitcoin Core! Feel free to hang around longer if you've not finished with the guide!
11:00 < kouloumos> Also don't be shy about leaving a comment even if everything worked as expected! Look at the last section for how to report your findings: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Candidate-Testing-Guide#testing-watch-only-support-for-miniscript-descriptors
11:00 < LarryRuane> kouloumos: thanks, great meeting!
11:00 < glozow> LarryRuane: you mean it won't by default, or it won't at all?
11:01 < stacie> Thank you for hosting kouloumos, time flew by!
11:01 < stickies-v> thank you very much for making the testing guide kouloumos, this was really helpful! wish we had more than the hour indeed haha
11:01 < LarryRuane> won't at all, at least i don't see an option for creating one (but i'm not a gui expert!)
11:01 < kouloumos> LarryRuane: I see a "Descriptor Wallet" tick-box which is selected by default
11:02 < alecc> thanks kouloumos!
11:02 < LarryRuane> kouloumos: oh yes i had missed that ... but it's grayed out, i can't unselect it
11:02 -!- alecc [~alecc@s-25-172.flex.volo.net] has quit [Quit: Connection closed]
11:02 < glozow> thank you kouloumos! for hosting and for the excellent guide
11:02 < b_101> thanks kouloumos!
11:02 < kouloumos> I will be around for another hour or more if people want to continue with the guide. And I'll also be around in this channel until the final release if people going through the guide have questions.
11:03 < LarryRuane> oh i bet i know what the problem is ... i didn't build with the BDB database
11:03 < glozow> https://github.com/bitcoin/bitcoin/issues/20160 for descriptor timeline. it should still let you until 2 releases from now
11:03 < glozow> hahaha that'll do it
11:03 < LarryRuane> glozow: yes sorry, my mistake
11:03 < glozow> no problem, i've done it too
11:04 < kouloumos> And thanks everyone that gave feedback on the testing guide today! Feel free to continue giving feedback at https://github.com/bitcoin/bitcoin/issues/26092
11:04 < yashraj> Wallet Restore worked for me :D
11:05 < kouloumos> yashraj: Great! What's next? You can also test the migration process using the GUI, by using the integrated RPC console
11:05 < b_101> sorry I was late to the meeting, simple question, is there a way in git to checkout this release?
11:06 < yashraj> yup, reading that section. Your guide looks great kouloumos!
11:06 < glozow> b_101: fetch, then git checkout v24.0rc1
11:06 -!- newbiexra12 [~newbiexra@ipbcc0db7f.dynamic.kabel-deutschland.de] has quit [Quit: Connection closed]
11:06 < b_101> thanks glozow
11:07 -!- arthur [~arthur@172.56.58.72] has quit [Quit: Connection closed]
11:07 < adam2k> Here's the tag page as well https://github.com/bitcoin/bitcoin/releases/tag/v24.0rc1
11:09 < kouloumos> Appreciate the comments about the guide, I also have to give credits to stickies-v. This is mostly a team effort as I was building on previous testing guides
11:09 < kouloumos> Anyone still standing?
11:10 < yashraj> I've sitting this whole time, but how do I create a legacy wallet from RPC console?
11:11 < LarryRuane> kouloumos: the guide is very good, thanks to you and stickies-v for creating it, I'll be adding a few suggestions to https://github.com/bitcoin/bitcoin/issues/26092
11:11 < glozow> #endmeeting
11:12 < kouloumos> yashraj:  You can create a legacy wallet using the GUI, do you see the preselcted "Descriptor wallets" option? Just untick that
11:12 < glozow> ^(doesn't mean anything. just for log parsing)
11:12 < kouloumos> glozow: I though it was stopmeeting 😅
11:12 < LarryRuane> yashraj: if you're doing linux https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#ubuntu--debian ... note "Berkeley DB is required for the legacy wallet"
11:13 < yashraj> I thought I was being kicked out lol
11:14 -!- adam2k [~adam2k@ip24-254-208-245.hr.hr.cox.net] has quit [Ping timeout: 252 seconds]
11:14 < kouloumos> LarryRuane: thank you, I'll also do some changes to that signet faucet section
11:15 < hernanmarino> thanks koulomos ! Will keep testing
11:15 < stacie> I haven't made it very far but I want to say I love the aliases (bitcoind, cli, qt) that the guide has you set up and the little code facts like "What is nMinimumChainWork". That one in particular helped me understand a PR I was looking at a few weeks ago but didn't  have the context to fully get. So far it's very thorough too! Appreciate the plethora of examples and screenshots
11:15 < yashraj> kouloumos: I got the same error "Error: This wallet already uses SQLite (code -4) "
11:16 < _aj_> oh, what's the bublina.eu.org faucet?
11:16 < kouloumos> yashraj: are you sure that you created a legacy wallet?
11:17 < kouloumos> stacie: I am really glad you like it! I believe it's important to have context around what we are testing, therefore I've tried to include the gist of each change and if needed a few extra details to get a better grasp of the subject. 
11:17 < yashraj> I did uncheck the Descriptor Wallet checkbox
11:17 < stacie> kouloumos: I saw that within the last day or so you removed the ./configure --with-gui=yes --with-squlite=yes --enable-suppress-external-warnings  command from the "Compile Release Candidate" section. I can understand why, because most people have other flags they want to include, but as a newcomer I will say having that command available to copy and paste was really handy! Glad I did that step before it was removed 
11:17 < stacie> :) 
11:18 < kouloumos> yashraj: So, you've created a wallet with that option unchecked, and then you run `migratewallet` using the integrated RPC console and you got that error?
11:18 < b_101> stacie:+1
11:19 < yashraj> Yes
11:19 -!- adam2k [~adam2k@ip24-254-208-245.hr.hr.cox.net] has joined #bitcoin-core-pr-reviews
11:19 < yashraj> Do I have to specify anything after migratewallet in the console?
11:20 < kouloumos> stacie, b_101: so I got this feedback comment https://github.com/kouloumos/rc24-guide-feedback-repo/pull/1#discussion_r979280900 and I though that it was the better choice to remove that.
11:21 < kouloumos> But maybe there is ground for its resurrection
11:21 < kouloumos> yashraj: do you have more than one wallets open?
11:22 < kouloumos> If you see a dropdown in upper right corner then you have more than one open
11:22 -!- Juls [~Juls@201.231.198.198] has quit [Quit: Connection closed]
11:22 < yashraj> Don't think I have more than one open
11:23 < yashraj> I tried to migratewallet again...now its stuck at Executing...
11:23 < _aj_> kouloumos: where'd you find signet.bublina.eu.org, linked via "return your coins to a faucet in need" ?
11:24 < _aj_> kouloumos: (people doing real signet things shouldn't need to beg)
11:24 < kouloumos> _aj_: in the previous testing guide: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/23.0-Release-Candidate-Testing-Guide#testing-the-gui 
11:24 < stacie> kouloumos: that makes sense, and as the comment suggests, compiling core is almost a side quest that the reader must do on their own. there's no way you can (or should) succinctly summarize all possible build instructions in the testing guide 👍
11:26 < kouloumos> _aj_: but I've changed it to https://signetfaucet.com/ because that one didn't have coins. But because it had a return address, I thought of including that one as a return faucet.
11:26 < kouloumos> yashraj: I'll now try to replicate your situation
11:27 < _aj_> aha, it used to be bublina both ways, now it's signetfaucet one way and bublina the other
11:28 < kouloumos> yes, do you think it's unnecessary? Or something that confuses the reader?
11:28 < yashraj> thanks kouloumos, I decided to restart Core and try it again but it won't quit lol
11:29 < kouloumos> yashraj: you can always try force quiting
11:29 < kouloumos> Anyone else battling through the testing guide?
11:31 < yashraj> yup, did that restarted Core. My IBD got deleted lol...anywho
11:31 < kouloumos> I really wanted to go through the Miniscript section😁. If anyone decided to dive into it, please let me know if the notes were helpful. 
11:32 < hernanmarino> testing the i2p conections on mainnet gives me a lot of errors when connecting to peers 
11:33 < kouloumos> hernamarino, I've also observed that. I think it has to do with the connectivity of the nodes in the seeds.
11:33 < _aj_> kouloumos: no, it just confused me. sent it some more funds so it should have plenty
11:33 -!- sanya [~sanya@109-93-2-111.dynamic.isp.telekom.rs] has quit [Quit: Connection closed]
11:34 < hernanmarino> koulomos: ok . I did succeed in getting one incoming connection though
11:34 < yashraj> hey kouloumos, I repro-ed the error.
11:34 < yashraj> 14:33:38
11:34 < yashraj> 
11:34 < yashraj> Executing command using "legacy" wallet
11:34 < yashraj> 14:33:38
11:34 < yashraj> 
11:34 < yashraj> migratewallet
11:34 < yashraj> 14:33:38
11:34 < yashraj> 
11:34 < yashraj> Error: This wallet already uses SQLite (code -4)
11:36 < yashraj> 14:35:45
11:36 < yashraj> 
11:36 < yashraj> Executing command using "legacy" wallet
11:36 < yashraj> 14:35:45
11:36 < yashraj> 
11:36 < yashraj> getaddressinfo $legacy
11:36 < yashraj> 14:35:45
11:36 < yashraj> 
11:36 < yashraj> Not a valid Bech32 or Base58 encoding (code -5)
11:36 < yashraj> Just to confirm it is a legacy wallet indeed.
11:37 < kouloumos> afaik there are 4 types of wallets: legacy-bdb, legacy-sqlite, descriptor-bdb, and descriptor-sqlite. I am not sure but maybe it creates a legacy-bdb format? I have to look a bit into the code, I am not so familiar with that part.
11:39 < kouloumos> yashraj: I'll probably have to confirm and then specify this in the guide, but I think that the variables that I am using in the guide (e.g. $legacy) cannot be used in the integrated RPC console
11:39 < kouloumos> I am also trying to reproduce your issue, I've ran the `migratewallet` command, and It's now executing. I
11:40 < kouloumos> I've seen reports that this takes a bit of time and it is sometimes confusing because at the moment there is no progress bar
11:40 -!- pablomartin [~pablomart@185.199.100.63] has quit [Quit: Leaving]
11:41 < hernanmarino> Disconecting now, thanks kouloumos, see you next time
11:41 < kouloumos> hernanmarino: Thank you for coming! If you continue testing, please keep reporting here with questions, issues or progress
11:43 < kouloumos> Just for the record, in my I2P testing I've seen ~8 outgoing connections, but I don't remember about incoming 
11:43 < b_101> kouloumos: how can you specify the type of wallet if there are 4 types? particularly descriptor-bdb
11:43 < kouloumos> yashraj: I've managed to migrate an empty legacy wallet on macOS 10.15.7
11:44 < yashraj> hmm thanks (and damnit) what am I doing wrong?
11:44 < kouloumos> b_101: That I don't know, I only saw that mentioned here (read 2nd paragraph): https://github.com/bitcoin/bitcoin/issues/20160
11:46 < kouloumos> yashraj: Is your wallet also empty? Have you generated addresses or anything? Also try running getwalletinfo in the integrated RPC console, and send the result 
11:47 < yashraj> yes my legacy wallet is empty. Actually ALL of them are lol but that's beside the point.
11:48 < yashraj> format is sqlite
11:48 -!- sanya [~sanya@109-93-2-111.dynamic.isp.telekom.rs] has joined #bitcoin-core-pr-reviews
11:49 < kouloumos> If format is sqlite then it's not a legacy wallet. If you are indeed not selecting "Descriptor wallet" in the wallet's creation window, then something is wrong
11:49 < b_101> tx kouloumos, not clear particularly the descriptot-bdb type
11:50 < kouloumos> b_101: My understanding is that those formats are supported, but we are not actually creating those formats
11:50 < yashraj> fuck let me try again, will report back.
11:50 < b_101> kouloumos: understood
11:51 < kouloumos> During the migration process, what happens is that, initially all the records of the legacy (BDB) wallet are moved into sqlite. So I guess, that at this point, you have a legacy-sqlite wallet.  
11:53 < yashraj> descriptors: false means it is a legacy wallet right?
11:54 < kouloumos> yes
11:54 < kouloumos> what about format?
11:54 < kouloumos> Anyone else still here?
11:55 < kouloumos> b_101: are you going through the guide?
11:55 < b_101> yes but I will do it along the rest of the afternoon
11:56 < yashraj> {
11:56 < yashraj>   "walletname": "legacy",
11:56 < yashraj>   "walletversion": 169900,
11:56 < yashraj>   "format": "sqlite",
11:56 < yashraj>   "balance": 0.00000000,
11:56 < yashraj>   "unconfirmed_balance": 0.00000000,
11:56 < yashraj>   "immature_balance": 0.00000000,
11:56 < yashraj>   "txcount": 0,
11:56 < yashraj>   "keypoolsize": 0,
11:56 < yashraj>   "keypoolsize_hd_internal": 0,
11:56 < yashraj>   "paytxfee": 0.00000000,
11:56 < yashraj>   "private_keys_enabled": true,
11:56 < yashraj>   "avoid_reuse": false,
11:56 < yashraj>   "scanning": false,
11:56 < yashraj>   "descriptors": false,
11:56 < yashraj>   "external_signer": false
11:56 < yashraj> }
11:58 < kouloumos> interesting,  and this is a wallet you just created? Because you've mentioned a previous migration attempt that got stucked.
11:59 < yashraj> Then when I do migratewallet I get the sqlite error 4 thing...yes this is the wallet with previous failed migration attempt
11:59 < kouloumos> b_101: send here if you need anything, I'll read the messages async. 
11:59 < yashraj> Maybe I force quit Core when it was halfway done lol
12:00 < yashraj> Trying again with another legacy wallet I just created
12:00 < kouloumos> yashraj: that's what I am thinking, look at what I previously said about formats. You've probably got stucked at a legacy-bdb format.
12:00 -!- btc_noob [~btc_noob@cpe-76-85-79-117.tx.res.rr.com] has joined #bitcoin-core-pr-reviews
12:01 < kouloumos> Which is also interesting. I'll later check the PR (https://github.com/bitcoin/bitcoin/pull/19602) to see if anyone else reported this kind of behavior. I think that this is also something that you could report. Stucking with a wallet that you cannot migrate is also an issue.
12:04 < b_101> tx :kouloumos 
12:07 -!- Luc60 [~Luc@95.56.113.78.rev.sfr.net] has quit [Quit: Connection closed]
12:16 -!- sanya [~sanya@109-93-2-111.dynamic.isp.telekom.rs] has quit [Quit: Connection closed]
12:16 -!- vnprc [~vnprc@136.56.39.155] has quit [Quit: Connection closed]
12:18 < yashraj> yeah you were right :kouloumos. update: just repro-ed your successful migration lol, now format is sqlite and descriptors is true. 
12:19 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:24 < kouloumos> I'll also try to reproduce that failed migration on GUI and bitcoind. The issue began from the moment that you thought that is was stuck at Executing, but the reality was that is was doing the migration, it just don't have a way yet to show progress
12:26 < yashraj> yup. At least maybe add a note saying: Executing... this takes a long time so don't be idiots and force-quit
12:26 -!- adam2k [~adam2k@ip24-254-208-245.hr.hr.cox.net] has quit [Ping timeout: 252 seconds]
12:27 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
12:28 < yashraj> thanks kouloumos: you are a legend with your patience and that documentation.
12:28 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
12:31 < kouloumos> My pleasure, hopefully it was useful to better navigate and understand the changes. Also don't forget that this is just to get you started, so as you build familiarity with testing , try to also do some testing scenarios of your own.
12:37 < kouloumos> I have to go, but for anyone reading this, either now or later, your testing efforts are appreciated as well as your feedback on the testing guide. The testing guide is not only for this meeting, we still have time until the final release is ready. To ensure that users don’t experience issues with the new software, it’s essential that the RCs are thoroughly tested, and this guide is a way to start with 
12:37 < kouloumos> testing, especially if you don't know from where to start. 
12:39 < kouloumos> Questions for the testing guide are appreciated and I'll be around to try and answer them.
12:49 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has quit [Remote host closed the connection]
12:49 -!- giabertu [~giabertu@147.12.250.63] has quit [Quit: Connection closed]
12:52 -!- __gotcha1 [~Thunderbi@85.234.220.238] has joined #bitcoin-core-pr-reviews
12:53 -!- __gotcha [~Thunderbi@85.234.220.238] has quit [Ping timeout: 265 seconds]
12:53 -!- __gotcha1 is now known as __gotcha
12:53 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
12:54 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
12:57 -!- cypherchabon [~cyphercha@181.92.18.53] has quit [Quit: Connection closed]
13:00 -!- ccdle12 [~ccdle12@243.222.90.149.rev.vodafone.pt] has quit [Ping timeout: 252 seconds]
13:13 -!- nerd2ninja [~nerd2ninj@52.249.240.64] has quit [Quit: Connection closed]
13:21 -!- chipxxx [~chip@pop.92-184-123-139.mobile.abo.orange.fr] has quit [Read error: Connection reset by peer]
13:30 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
13:31 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
13:41 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
14:13 -!- francismars [~Francis@2001:8a0:fa4c:901:8df0:34a3:7e60:697] has joined #bitcoin-core-pr-reviews
14:15 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
14:17 -!- chipxxx [~chip@pop.92-184-123-139.mobile.abo.orange.fr] has joined #bitcoin-core-pr-reviews
14:24 -!- francismars [~Francis@2001:8a0:fa4c:901:8df0:34a3:7e60:697] has quit [Ping timeout: 268 seconds]
15:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:d9f9:9a28:ba2a:f9b3] has quit []
15:16 -!- francismars [~Francis@2001:8a0:fa4c:901:c16d:b6ca:5476:911c] has joined #bitcoin-core-pr-reviews
15:38 -!- francismars [~Francis@2001:8a0:fa4c:901:c16d:b6ca:5476:911c] has quit [Quit: Konversation terminated!]
15:44 -!- chipxxx [~chip@pop.92-184-123-139.mobile.abo.orange.fr] has quit [Quit: Leaving]
15:44 -!- chipxxx [~chip@pop.92-184-123-139.mobile.abo.orange.fr] has joined #bitcoin-core-pr-reviews
16:02 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
16:02 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
16:03 -!- NorrinRadd [~me@154.6.21.240] has quit [Ping timeout: 268 seconds]
16:04 -!- NorrinRadd [~me@188.215.95.53] has joined #bitcoin-core-pr-reviews
17:30 -!- hernanmarino [~hernanmar@190.16.216.111] has quit [Quit: Leaving]
18:34 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has quit [Remote host closed the connection]
18:35 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has joined #bitcoin-core-pr-reviews
19:04 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has quit [Remote host closed the connection]
19:04 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has joined #bitcoin-core-pr-reviews
19:36 -!- randomsats [~randomsat@cpe1033bfa9e0e7-cm1033bfa9e0e5.cpe.net.cable.rogers.com] has quit [Quit: Connection closed]
22:02 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
22:03 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
23:13 -!- __gotcha1 [~Thunderbi@85.234.220.238] has joined #bitcoin-core-pr-reviews
23:17 -!- __gotcha [~Thunderbi@85.234.220.238] has quit [Ping timeout: 252 seconds]
23:17 -!- __gotcha1 is now known as __gotcha
23:22 -!- __gotcha [~Thunderbi@85.234.220.238] has quit [Ping timeout: 268 seconds]
23:25 -!- Iddu [~Iddu@95.56.113.78.rev.sfr.net] has joined #bitcoin-core-pr-reviews
23:28 -!- Iddu [~Iddu@95.56.113.78.rev.sfr.net] has quit [Client Quit]
23:42 -!- __gotcha [~Thunderbi@85.234.220.238] has joined #bitcoin-core-pr-reviews
23:46 -!- __gotcha [~Thunderbi@85.234.220.238] has quit [Ping timeout: 260 seconds]
--- Log closed Thu Sep 29 00:00:34 2022