--- Log opened Fri Sep 30 00:00:35 2022
00:35 < kouloumos> b_101: That signet faucet section needs some changes, as also pointed out during the meeting. I'm planning to fix it today.
01:28 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 250 seconds]
02:23 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews
03:57 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews
04:51 -!- chipxxx [~chip@pop.92-184-118-79.mobile.abo.orange.fr] has joined #bitcoin-core-pr-reviews
05:03 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Remote host closed the connection]
05:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has joined #bitcoin-core-pr-reviews
05:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has quit [Ping timeout: 244 seconds]
05:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has joined #bitcoin-core-pr-reviews
05:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has quit [Ping timeout: 246 seconds]
05:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has joined #bitcoin-core-pr-reviews
05:24 < willcl_ark> I did get it to work with: `./contrib/signet/getcoins.py -c $BINARY_PATH/bitcoin-cli -a tb1qrmd2jjzjjdrarnegh4mhhlgc4f9ajc4z6nsfj3 -- --datadir=/tmp/24.0rc1/ -signet`
05:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has quit [Ping timeout: 250 seconds]
05:24 < willcl_ark> a single dash for `-signet` and two for `--datadir`
05:25 < willcl_ark> (I used a different datadir though, so don't copy/paste)
05:26 < willcl_ark> I also found that because I was using python 3.6.12, I needed to amend the script like so: https://github.com/bitcoin/bitcoin/pull/26212/commits/be59bd17ec753af7cc763474f2432d12bfc88c2f
05:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has joined #bitcoin-core-pr-reviews
05:46 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 258 seconds]
05:51 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
05:58 < kouloumos> Thank you willcl_ark for taking the time to explore the issue. As well as LarryRuane for coming up with a solution during the meeting. I ended up reverting that section back to using the website to avoid added complexity, especially for the non-technical crowd. I might later re-evaluate the script and add it as an alternative.
06:35 -!- furszy [~furszy@104.128.239.93] has quit [Changing host]
06:35 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-pr-reviews
06:59 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 250 seconds]
07:35 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
07:36 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
08:11 -!- chipxxx [~chip@pop.92-184-118-79.mobile.abo.orange.fr] has quit [Read error: Connection reset by peer]
09:23 < stacie> I'm trying to verify the descriptors after wallet migration and my legacy wallet has two combo descriptors for the hd seed. What's interesting is one of them has `"timestamp": 1`. Is this expected? The guide leads me to believe I should only see one, but I ran through this test case twice and got two (combo descriptors for hd seed) both times.
10:42 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
10:42 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
10:43 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
10:43 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
10:48 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews
11:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
11:21 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
11:22 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
11:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
11:51 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 258 seconds]
11:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has quit [Remote host closed the connection]
11:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has joined #bitcoin-core-pr-reviews
11:57 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
12:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has quit [Ping timeout: 268 seconds]
12:07 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews
12:12 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 260 seconds]
12:20 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
12:22 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
12:23 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews
12:28 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 252 seconds]
12:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has joined #bitcoin-core-pr-reviews
12:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has quit [Ping timeout: 260 seconds]
12:37 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has quit [Remote host closed the connection]
12:37 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has joined #bitcoin-core-pr-reviews
12:45 -!- amovfx_ [~amovfx@d75-156-179-9.abhsia.telus.net] has joined #bitcoin-core-pr-reviews
12:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has joined #bitcoin-core-pr-reviews
12:48 -!- amovfx [amovfx@gateway/vpn/protonvpn/amovfx] has quit [Ping timeout: 252 seconds]
12:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has quit [Ping timeout: 246 seconds]
13:08 < willcl_ark> Is the second combo not the imported key from `importprivkey`?
13:09 < willcl_ark> Perhaps you can share some output? The results of my run are here (along with an empty wallet "legacy2" I also migrated for reference) https://bpa.st/TJMA
13:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has joined #bitcoin-core-pr-reviews
13:15 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews
13:16 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
13:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 258 seconds]
13:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has quit [Ping timeout: 244 seconds]
13:18 < willcl_ark> We should be expecting two descriptors generated from one master seed though I think, one internal (change) and one external (receive).
13:19 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
13:19 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
13:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has joined #bitcoin-core-pr-reviews
13:20 -!- amovfx_ [~amovfx@d75-156-179-9.abhsia.telus.net] has quit [Remote host closed the connection]
13:21 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has joined #bitcoin-core-pr-reviews
13:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has quit [Ping timeout: 248 seconds]
13:28 < willcl_ark> The migration codepath for a legacy wallet is here FWIW https://github.com/bitcoin/bitcoin/blob/v24.0rc1/src/wallet/scriptpubkeyman.cpp#L1715-L1965
13:30 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews
13:35 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 252 seconds]
13:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has joined #bitcoin-core-pr-reviews
13:43 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has quit [Remote host closed the connection]
13:43 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has joined #bitcoin-core-pr-reviews
13:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has quit [Ping timeout: 260 seconds]
13:51 -!- meshcollider [meshcollid@user/meshcollider] has quit [Ping timeout: 240 seconds]
13:52 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
13:52 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
13:52 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has joined #bitcoin-core-pr-reviews
13:53 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
13:54 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
13:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has quit [Ping timeout: 246 seconds]
13:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has joined #bitcoin-core-pr-reviews
14:07 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has quit [Remote host closed the connection]
14:08 -!- meshcollider [meshcollid@jujube.rpblc.net] has joined #bitcoin-core-pr-reviews
14:08 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has joined #bitcoin-core-pr-reviews
14:15 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
14:22 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has quit [Remote host closed the connection]
14:22 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has joined #bitcoin-core-pr-reviews
14:23 < stacie> @willcl_ark thank you for sharing your results! My results look like yours and can be found here: https://github.com/satsie/bitcoin-notez/blob/master/v24.0rc1-testing.md#migrating-legacy-wallets-to-descriptor-wallets
14:25 < stacie> what you said about expecting two descriptors generated from one master seed, one for internal and one for external makes sense! I'll see if I can try and follow along with the code you linked. 
14:35 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has quit [Remote host closed the connection]
14:35 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has joined #bitcoin-core-pr-reviews
15:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:5e5:d19a:8ea9:9a28] has quit [Ping timeout: 268 seconds]
15:29 -!- chipxxx [~chip@pop.92-184-118-79.mobile.abo.orange.fr] has joined #bitcoin-core-pr-reviews
16:20 -!- dlb76 [~dlb76@user/dlb76] has quit [Quit: .]
16:24 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has quit [Remote host closed the connection]
16:24 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has joined #bitcoin-core-pr-reviews
16:30 -!- dlb76 [~dlb76@user/dlb76] has joined #bitcoin-core-pr-reviews
16:49 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has quit [Remote host closed the connection]
16:50 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has joined #bitcoin-core-pr-reviews
17:03 -!- adam2k [~adam2k@ip24-254-208-245.hr.hr.cox.net] has quit [Quit: Client closed]
17:33 -!- chipxxx [~chip@pop.92-184-118-79.mobile.abo.orange.fr] has quit [Ping timeout: 244 seconds]
18:09 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 258 seconds]
18:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
18:23 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has quit [Remote host closed the connection]
18:24 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has joined #bitcoin-core-pr-reviews
19:05 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has quit [Remote host closed the connection]
19:06 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has joined #bitcoin-core-pr-reviews
19:15 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
19:15 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
20:11 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
20:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 258 seconds]
20:30 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has quit [Remote host closed the connection]
20:30 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has joined #bitcoin-core-pr-reviews
20:31 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has quit [Remote host closed the connection]
20:32 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has joined #bitcoin-core-pr-reviews
20:47 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has quit [Ping timeout: 265 seconds]
20:51 -!- amovfx [~amovfx@d75-156-179-9.abhsia.telus.net] has joined #bitcoin-core-pr-reviews
--- Log closed Sat Oct 01 00:00:35 2022