--- Log opened Wed Jan 18 00:00:19 2023
00:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has joined #bitcoin-core-pr-reviews
00:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has quit [Ping timeout: 264 seconds]
00:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has joined #bitcoin-core-pr-reviews
00:07 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
00:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has quit [Ping timeout: 256 seconds]
00:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has joined #bitcoin-core-pr-reviews
00:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has quit [Ping timeout: 252 seconds]
00:26 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
00:38 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
00:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has joined #bitcoin-core-pr-reviews
00:43 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds]
00:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has quit [Ping timeout: 248 seconds]
00:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has joined #bitcoin-core-pr-reviews
00:46 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
00:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has quit [Ping timeout: 256 seconds]
00:51 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
01:04 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
01:08 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
01:21 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
01:25 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews
01:25 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds]
01:26 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
01:31 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 248 seconds]
01:31 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 246 seconds]
01:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has joined #bitcoin-core-pr-reviews
01:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has quit [Ping timeout: 256 seconds]
01:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has joined #bitcoin-core-pr-reviews
01:44 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
01:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has quit [Ping timeout: 256 seconds]
01:49 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 272 seconds]
01:53 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews
01:58 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 268 seconds]
01:59 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews
02:00 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
02:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has joined #bitcoin-core-pr-reviews
02:05 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 272 seconds]
02:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has quit [Ping timeout: 260 seconds]
02:09 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:989:f448:e177:6c51] has joined #bitcoin-core-pr-reviews
02:10 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews
02:11 -!- FrancisMr [~MrFrancis@2001:8a0:fa4c:901:15d6:7f65:1cbf:6796] has joined #bitcoin-core-pr-reviews
02:14 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
02:14 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:989:f448:e177:6c51] has quit [Ping timeout: 252 seconds]
02:15 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 256 seconds]
02:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has joined #bitcoin-core-pr-reviews
02:19 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
02:25 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has quit [Ping timeout: 252 seconds]
02:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has joined #bitcoin-core-pr-reviews
02:30 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
02:35 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
02:47 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
02:51 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds]
02:55 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
03:00 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds]
03:10 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
03:11 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
03:13 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
03:20 -!- FrancisMr [~MrFrancis@2001:8a0:fa4c:901:15d6:7f65:1cbf:6796] has quit [Quit: Leaving]
03:20 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
03:20 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:15d6:7f65:1cbf:6796] has joined #bitcoin-core-pr-reviews
03:32 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
03:39 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds]
03:52 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
03:58 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds]
04:10 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
04:14 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 264 seconds]
04:26 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
04:31 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
04:34 -!- __gotcha [~Thunderbi@79.132.249.86] has joined #bitcoin-core-pr-reviews
04:42 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
04:47 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds]
04:58 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
05:03 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 246 seconds]
05:16 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
05:17 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:15d6:7f65:1cbf:6796] has quit [Ping timeout: 256 seconds]
05:21 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
05:24 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:15d6:7f65:1cbf:6796] has joined #bitcoin-core-pr-reviews
05:33 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
05:39 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 255 seconds]
05:44 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
05:49 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds]
06:01 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
06:06 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds]
06:18 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
06:21 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
06:21 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
06:23 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds]
06:35 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
06:39 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 246 seconds]
06:52 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
06:57 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 272 seconds]
07:08 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
07:12 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds]
07:24 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
07:28 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds]
07:32 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
07:33 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
07:41 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
07:46 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds]
07:50 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
07:54 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 265 seconds]
07:55 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
07:57 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
07:59 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews
07:59 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Client Quit]
08:01 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews
08:01 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
08:02 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
08:07 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
08:08 < LarryRuane> we'll be starting in just under one hour from now
08:09 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
08:10 -!- dxzgx [~dxzgx@67-0-212-195.albq.qwest.net] has joined #bitcoin-core-pr-reviews
08:12 -!- dxzgx [~dxzgx@67-0-212-195.albq.qwest.net] has quit [Client Quit]
08:13 -!- sdaftuar [~sdaftuar@user/sdaftuar] has quit [Ping timeout: 268 seconds]
08:13 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Read error: Connection reset by peer]
08:13 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
08:14 -!- sdaftuar [~sdaftuar@user/sdaftuar] has joined #bitcoin-core-pr-reviews
08:17 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds]
08:27 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
08:31 -!- rozehnal_paul [~rozehnal_@bras-base-mtrlpq1948w-grc-07-65-92-17-149.dsl.bell.ca] has joined #bitcoin-core-pr-reviews
08:32 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds]
08:34 -!- grettke [~grettke@184.55.131.155] has joined #bitcoin-core-pr-reviews
08:35 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
08:38 -!- __gotcha [~Thunderbi@79.132.249.86] has quit [Remote host closed the connection]
08:39 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 246 seconds]
08:45 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
08:45 -!- rozehnal_paul [~rozehnal_@bras-base-mtrlpq1948w-grc-07-65-92-17-149.dsl.bell.ca] has quit [Ping timeout: 246 seconds]
08:45 -!- jg [~jg@2a02:830a:b010:7e00:a9ae:40bd:dd38:921a] has joined #bitcoin-core-pr-reviews
08:47 -!- TheRec [~toto@user/therec] has quit []
08:47 -!- sdaftuar [~sdaftuar@user/sdaftuar] has quit [Read error: Connection reset by peer]
08:49 -!- dzxzg [~igloo@107.122.84.65] has joined #bitcoin-core-pr-reviews
08:49 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Read error: Connection reset by peer]
08:50 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
08:51 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
08:52 -!- sdaftuar [~sdaftuar@user/sdaftuar] has joined #bitcoin-core-pr-reviews
08:55 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
08:55 -!- dzxzg [~igloo@107.122.84.65] has quit [Ping timeout: 256 seconds]
08:55 -!- TheRec [~toto@user/therec] has joined #bitcoin-core-pr-reviews
08:55 -!- Yaz [~Yaz@gw81-151.jcsfiberlink.net] has joined #bitcoin-core-pr-reviews
08:56 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
08:56 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 268 seconds]
09:00 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has joined #bitcoin-core-pr-reviews
09:00 < LarryRuane> #startmeeting
09:00 < effexzi> Hi every1 
09:00 < stickies-v> hi
09:00 < emzy> hi
09:00 < kouloumos> hi
09:00 < brunoerg> hi
09:00 < Yaz> hi
09:00 < lightlike> hi
09:00 < codo> hi
09:00 < LarryRuane> Hi everyone, please feel free to say hi
09:01 -!- roze_paul [~quassel@142.243.254.224] has joined #bitcoin-core-pr-reviews
09:01 -!- rozehnal_paul [~rozehnal_@142.243.254.224] has joined #bitcoin-core-pr-reviews
09:01 < LarryRuane> If you just want to "lurk" that's fine too!
09:01 -!- dzxzg [~igloo@107.122.84.65] has joined #bitcoin-core-pr-reviews
09:01 < rozehnal_paul> hi
09:01 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 272 seconds]
09:01 < LarryRuane> Is anyone here new to review club? Please feel free to introduce yourself
09:01 < Yaz> Hi, my name is Yazid, an Industrial Engineer, looking to strengthen myself in bitcoins source code:)
09:02 -!- b_101 [~robert@189.236.26.147] has joined #bitcoin-core-pr-reviews
09:02 < LarryRuane> Reminder, if anyone is interested in hosting review club, just let me or @stickies-v or @glozow know, that would be great!
09:02 < dzxzg> Hi, second time at review club, just here to watch
09:02 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
09:02 < LarryRuane> Yaz: hi! welcome, glad you're here!
09:02 < coreyphillips> hi. I'm new. Will mostly lurk for now.
09:02 < LarryRuane> dzxzg: welcome to you too, glad you're back! :)
09:02 < b_101> hello every1
09:02 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:15d6:7f65:1cbf:6796] has quit [Ping timeout: 252 seconds]
09:03 < LarryRuane> hello @coreyphillips great to have you here, feel free to lurk! Or ask questions!
09:03 < LarryRuane> Today's review is: https://bitcoincore.reviews/26697
09:04 -!- raj [~raj_@103.139.171.114] has joined #bitcoin-core-pr-reviews
09:04 < LarryRuane> We'll go through the questions, but feel free to continue discussing anything we've already covered
09:04 -!- raj is now known as Guest5800
09:04 < LarryRuane> So let's begin, Did you review the PR? Concept ACK, approach ACK, tested ACK, or NACK?
09:04 < stickies-v> Approach ACK
09:05 < codo> Tested ACK
09:05 < emzy> Concept and tested ACK (not good at C++) :)
09:05 < LarryRuane> Oh I should also ask, does anyone have any questions or comments about the Notes? Anything you'd like to add?
09:06 < codo> The last part of the last Q I did not understand, but maybe I will if we come to that.
09:06 < glozow> For people who reviewed, how did you go about doing so?
09:07 < emzy> I first git clone it and compile it. Read the conversation and test it. Then try to understand a bit the code. 
09:08 -!- d33r_gee [~d33r_gee@45-27-31-99.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-pr-reviews
09:08 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds]
09:08 < roze_paul> I just read over the file changes and comments, going back to maxwell's PR in late 2016...but i didn't test...AFAIK all the testing added amounts to one in-line code (asserts)
09:08 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
09:08 < emzy> try to figure out what to test. I'm more testing then doing code review.
09:09 < emzy> That is manual testing.
09:09 < LarryRuane> good! Did anyone try the `logging` rpc? It's cool how you can enable and disable logging categories on the fly
09:09 < codo> I wrote down what I did in a comment in the PR: https://github.com/bitcoin/bitcoin/pull/26697#issuecomment-1387281337
09:09 < kouloumos> I haven't finish looking at the implementation yet, but what I started with is gathering context about how the change came to be, other related logging changes, other usages of bit operation in the codebase and looked a bit into the performance
09:09 < emzy> Yes, did that.
09:10 < emzy> Tested the RPC logging enable and disable on the fly. Very usefull.
09:10 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
09:10 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Read error: Connection reset by peer]
09:10 < LarryRuane> those all are great! It's something I struggle with myself, how to go about reviewing a PR (there are so many things one can do)
09:10 < LarryRuane> let's go to Q2, What does this PR do, and what is the problem it proposes to address?
09:11 < codo> There was a limit on the number of possible logging categories. This PR removes that limit.
09:11 < roze_paul> it extends the number of log-topics available to an arbitrary amount by using the std::bitset function
09:12 < LarryRuane> roze_paul: yes, although it's actually a type
09:12 < emzy> Before it there was a bit set or unset to set the categories. That was limitet by the size of the interger used.
09:12 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Read error: Connection reset by peer]
09:12 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
09:13 < LarryRuane> did you notice that `std::bitset` has a fixed size (number of bits)? the fact that the number of bits is specified within angle brackets indicates that
09:14 < LarryRuane> https://github.com/bitcoin/bitcoin/pull/26697/files#diff-21abb6b14af1e9330a6f0c89a87231035a439248c556ef5e110eb0617b88a1f4R77 (`ALL` is a constant)
09:14 < LarryRuane> emzy: +1
09:14 < brunoerg> So, `ALL` defines the maximum size?
09:15 < LarryRuane> yes, which is ... a little confusing! but it probably makes sense to do that identifier rather than create another one to indicate size
09:15 -!- raj [~raj_@103.139.171.114] has joined #bitcoin-core-pr-reviews
09:16 < brunoerg> makes sense
09:16 < LarryRuane> Q3 What are the advantages of std::bitset compared with bit manipulations on integers?
09:16 -!- raj is now known as Guest7558
09:17 < andrew_m_> it has more internal methods?
09:17 < roze_paul> we get to get rid of the manual bitshifting code...which i don't understand why this is such a huge advantage, but it was stated in the notes as an advantage
09:17 < b_101> will size (ALL) wll change everytime a new log category gets added?
09:17 < emzy> It will be grow with more options for categories.
09:17 < lightlike> code looks cleaner, no need to manage the bits of an integer with "1 <<  4" and such.
09:17 < roze_paul> other than making the code more concise**
09:17 < roze_paul> +1 b_101
09:17 < LarryRuane> b_101: yes, but automatically
09:18 < LarryRuane> lightlike: yes, there may be fewer code conflicts to resolve (like if two PRs allocate the same bit)... although those aren't too hard to resolve
09:18 < emzy> I think it make the code more high level, without the bit shifting.
09:19 < roze_paul> another adv: we now get to utilize std::bitset's built-in functions like set() and reset()
09:19 < LarryRuane> here's what @lightlike is referring to: https://github.com/bitcoin/bitcoin/pull/26697/files#diff-21abb6b14af1e9330a6f0c89a87231035a439248c556ef5e110eb0617b88a1f4R77
09:19 < LarryRuane> emzy: yes, I like that about it too
09:20 < roze_paul> i can't recall if the version we are replacing also used a form of set and reset() ??
09:20 -!- Yaz [~Yaz@gw81-151.jcsfiberlink.net] has quit [Quit: Connection closed]
09:20 < LarryRuane> roze_paul: yes, I think those are conceptually more clear than `0` and `~0` :)
09:20 < kouloumos> test() is also cool
09:20 < LarryRuane> roze_paul: i think it does bitwise and (`&`) and or (`|`)
09:21 < LarryRuane> also for me, the type  `uint32_t` is generic, just seeing that type doesn't indicate what how it's being used
09:21 < brunoerg> seems elegant set() and reset() for enabling and disabling categories, it's a good reason..
09:22 < LarryRuane> although that (`uint32_t` being too generic) could be improved with `using LoggingFlags = uint32_t` (or `typedef uint32_t LoggingFlags`)
09:22 < LarryRuane> (i think `using` is preferred)
09:22 < emzy> set() and reset() sounds more like C++ than C to me. :)
09:23 < LarryRuane> on the other hand, `std::bitset` may reveal too much of the underlying representation... but I don't think so because could be _conceptual_ bits (flags)
09:23 < emzy> So it fits better in my mind.
09:23 < LarryRuane> emzy: yes me too
09:24 < codo> is it also more portable?
09:24 < LarryRuane> codo: good point, it's definitely more abstract, so yes, I'd say more portable (hadn't thought of that)
09:25 < roze_paul> by portable, we mean between architectures && machines?
09:26 < LarryRuane> (i'll go on but again, feel free to keep discussing previous questions)
09:26 < LarryRuane> we kind of covered this already, but Q4: An earlier attempt, PR #26619, was closed in favor of the current PR. What are some advantages and disadvantages of each approach?
09:26 < LarryRuane> roze_paul: right, although i would say `uint32_t` is definitely the same everywhere
09:27 < LarryRuane> https://github.com/bitcoin/bitcoin/pull/26619
09:27 < emzy> I think the only change was using a bigger integer. So only extend it to 64 options.
09:27 -!- TheRec [~toto@user/therec] has quit []
09:28 < roze_paul> re. q4: the previous approach (26619) required less work, in that there was no approach change, just a change from 32 to 64 bit integers...in that sense it probably required less testing and review, which is an advantage
09:28 < brunoerg> #26619 you're just increasing the limit but not making it flexible like the new approach?
09:28 < LarryRuane> emzy: yes, smaller diff, less review and risk
09:29 < LarryRuane> brunoerg: right, it's conceivable that we could need more than 64 logging categories in the future (new subsystems or make them more fine-grained)
09:29 < LarryRuane> *make existing categories more fine-grain
09:30 < LarryRuane> roze_paul: +1
09:31 < LarryRuane> I think another advantage of the closed 26619 is that we can still use std::atomic (I couldn't figure out how to wrap `std::bitset` with `std::atomic` but maybe there's a way)
09:32 < kouloumos> although "levels" seems to be targeting that fine-graining, right?
09:33 < LarryRuane> kouloumos: yes, I guess that can serve that purpose too, good point (i personally don't like levels, I've always like categories only)
09:33 < LarryRuane> let's try Q5 There are two special logging categories, ALL and NONE. Why are these needed?
09:34 < roze_paul> @larry do you use trace levels, to get all the data, and then filter the logging data yourself...just thinking of a way to work around using levels..
09:35 < roze_paul> Q5: not entirely sure, but i think calling all will turn on all logging topics, and none will turn of (bitset.reset) all topics...ALL also conveys the number of total number of topics, if one wants that info
09:36 < LarryRuane> Yes you could do that, I think the default is to get all the logging for a given category
09:37 < LarryRuane> well I think `ALL` being the total number of categories is just a code-internal thing, not anything the user is aware of
09:37 < LarryRuane> For Q5, i would say `debug=all` is more convenient than `-debug=net -debug=tor -debug=mempool ...`
09:38 < roze_paul> most definitely more convenient
09:38 < brunoerg> it's also easier to enable and disable all categories
09:38 < LarryRuane> the functional tests do this, because they assume that by default you would want to see all categories, AND, there's one other reason, anyone know why?
09:38 < LarryRuane> brunoerg: +1 that's a good point
09:38 < kouloumos> I think `NONE` indicates the unconditional logging done with `LogPrintf()`
09:39 < LarryRuane> kouloumos: i think that would be `ALL`, rather than `NONE`
09:40 < LarryRuane> well I'm not sure, maybe that's wrong, need to think about it!
09:41 < LarryRuane> notice you can't write `LogPrint(ALL, ...)` because those calls are always specified to a particular category
09:42 < kouloumos> I think that's what this implies https://github.com/bitcoin/bitcoin/blob/0c2a1288a210916254c939d080ce12ffc5547841/src/logging.h#L236
09:43 < LarryRuane> anyway, I think the other reason the functional tests enable all categories is to test the `LogPrint` calls! It would be bad if you enabled a category, and the `LogPrint` dereferenced a null pointer or something and crashed the process
09:44 < LarryRuane> kouloumos: Oh i see, you're right! thanks
09:45 < LarryRuane> we kind of touched on this already, but Q6 `Logger::m_categories` was wrapped by `std::atomic`. Why was that needed? Why is it no longer needed?
09:45 -!- metallicc [metallicc@gateway/vpn/protonvpn/metallicc] has joined #bitcoin-core-pr-reviews
09:45 -!- kevkevin [~kevkevin@c-98-226-43-69.hsd1.il.comcast.net] has joined #bitcoin-core-pr-reviews
09:45 < roze_paul> i believe we replaced std::atomic with a rw-lock?
09:46 < kouloumos> interesting! I've seen that for functional tests there are some logging categories that we ignore, could this become be an issue if such regression occurs for those categories?
09:46 < LarryRuane> roze_paul: yes but just a regular mutex lock, not a read-write lock
09:47 < roze_paul> @LarryRuane that's the StdLockGuard scoped_lock   ?
09:47 < LarryRuane> kouloumos: good point! 
09:47 < LarryRuane> roze_paul: correct
09:48 < kouloumos> I think it was needed because of concurrency due to different components wanting to access the logger. I was curious why it was now replaced with locks, but I think you already touched why.
09:49 < LarryRuane> kouloumos: yes, I couldn't figure out how to wrap a `std::bitset` variable within `std::atomic` (but probably worth trying harder!)
09:50 < LarryRuane> good transition to Q7 Following on to that question, some concern was expressed on the PR about performance, and the need for benchmarking. Why would this be important?
09:51 < LarryRuane> i see that @kouloumos just posted some really helpful benchmark results to the PR: https://github.com/bitcoin/bitcoin/pull/26697#pullrequestreview-1253717862
09:51 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-pr-reviews
09:51 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host]
09:51 -!- TheRec [~toto@user/therec] has joined #bitcoin-core-pr-reviews
09:51 < kouloumos> Cause logging is a common operation, so a slowdown could have a significant impact
09:52 -!- svav [~svav@82-69-86-143.dsl.in-addr.zen.co.uk] has joined #bitcoin-core-pr-reviews
09:52 -!- dzxzg2 [~dzxzg2@2600:387:f:4b19::3] has joined #bitcoin-core-pr-reviews
09:52 < LarryRuane> kouloumos: right, especially if the relevant logging category is _not_ enabled (if enabled, probably performance isn't of much concern)
09:52 < emzy> If I read that corectly than there is no slow down from the change. I'm right?
09:53 < LarryRuane> that's why I think LoggingNoCategory is the most important of those results
09:53 < LarryRuane> no, there's a significant slowdown in LoggingNoCategory
09:54 < LarryRuane> but it's hard to say how important that difference is (is it a drop in the ocean compared with a half-drop in the ocean? Or is it a drop in the glass of water?) ... depends on the surrounding code
09:54 < emzy> Oh I see.
09:55 < LarryRuane> Q8 An unknown P2P message does not cause a LogPrintf() message. Why not? Wouldn’t it be helpful to see if a peer is sending us a message we don’t understand?
09:55 < kouloumos> Also looking into those benchmarks, I was wondering how significant are the results of such a logging benchmark. They are benchmarking the performance of a single invocation, is this actually a good metric? 
09:55 < codo> re Q8: The daemon should ignore any unknown messages so it can't be DOS'sed.
09:55 < brunoerg> codo: +1
09:55 < LarryRuane> yes I think benchmarks attempt to isolate just one particular area of the code, so I think that's good
09:56 < brunoerg> DoS is a good explanation
09:56 < b_101> can the change of locking method of m_categories cause an impact?
09:56 < kouloumos> +1 they were concerns about such a logging attack in the past https://github.com/bitcoin/bitcoin/issues/21559 
09:56 < LarryRuane> codo: yes! that's exactly what i had in mind... what would be the nature of the DoS?
09:56 < roze_paul> codo +1
09:57 < LarryRuane> oh there's the answer to my question right in the title of 21559 -- disk filling
09:57 < brunoerg> cool
09:57 < LarryRuane> Q9 Does the same principle apply to RPC, REST, or ZMQ requests?
09:57 < roze_paul> q9 i would imagine yes. same attack vector
09:57 < emzy> For shure the contents of the unknown P2P message must not be logged.
09:58 < LarryRuane> emzy: only the contents? what about the fact that it happened?
09:58 < brunoerg> what is "unknown P2P message" for us?
09:58 < brunoerg> unknown message or any message from an unknown peer?
09:59 < LarryRuane> unknown message ... in a way, all peers are unknown :)
09:59 < LarryRuane> I'm thinking that for Q9, no, because those sources are trusted (can do lots of other harmful things anyway)
09:59 < emzy> LarryRuane: seems to be relevant that there are unknown messages. Could be also a local problem. So I would like to have that option.
10:00 < LarryRuane> yes I think logging unknown messages from RPC etc. should be logged .. is that what you're saying?
10:00 < LarryRuane> we're at time, didn't get to Q10 The Logger::WillLogCategory is annotated with const; what does this mean? How is it possible to modify the object by locking m_cs?
10:01 < emzy> But LogPrintf() is unconditionallly. So It sould be in LogPrint() net 
10:01 < LarryRuane> but if anyone would like to discuss, I'll stick around!
10:01 < LarryRuane> #endmeeting
10:01 < glozow> thanks LarryRuane! great meeting
10:01 < effexzi> Thanks every1
10:01 < codo> thank you LarryRuane a lot
10:01 < emzy> Thank you LarryRuane and all others!
10:01 < d33r_gee> thanks LarryRuane and every1
10:02 < roze_paul> q10 i couldn't find where m_cs was first declared, so i don't understand what m_cs even `is`
10:02 < roze_paul> thanks larry!!!
10:02 < brunoerg> Thanks LarryRuane
10:02 < svav> Thanks LarryRuane and all!
10:02 < brunoerg> learned a lot
10:02 < LarryRuane> thanks to all who participated! was really fun for me to host!
10:02 -!- d33r_gee [~d33r_gee@45-27-31-99.lightspeed.sntcca.sbcglobal.net] has quit [Quit: Connection closed]
10:02 < kouloumos> Thank you LarryRuane!
10:04 -!- svav [~svav@82-69-86-143.dsl.in-addr.zen.co.uk] has quit [Quit: Connection closed]
10:04 -!- b_101 [~robert@189.236.26.147] has quit [Read error: Connection reset by peer]
10:05 -!- b_101 [~robert@189.236.26.147] has joined #bitcoin-core-pr-reviews
10:05 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews
10:06 < codo> I'd like to discuss Q10 also if more are interested.
10:06 < b_101> thnks LarryRuane: for hosting and everyone!
10:06 -!- roze_paul [~quassel@142.243.254.224] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
10:06 < b_101> yes I would like to understand Q10
10:07 -!- Guest7558 [~raj_@103.139.171.114] has left #bitcoin-core-pr-reviews [Leaving]
10:07 < codo> I think the first part might be: the annotation with const is good practice
10:07 < codo> The second part of the question I do not understand
10:07 -!- Guest5800 [~raj_@103.139.171.114] has quit [Quit: Leaving]
10:07 -!- jg [~jg@2a02:830a:b010:7e00:a9ae:40bd:dd38:921a] has quit [Ping timeout: 260 seconds]
10:08 -!- raj [~raj_@103.139.171.114] has joined #bitcoin-core-pr-reviews
10:08 -!- raj is now known as Guest3116
10:10 < b_101> const means no data will be changed by the fuction, right?
10:11 -!- dzxzg [~igloo@107.122.84.65] has quit [Ping timeout: 260 seconds]
10:11 < b_101> they can't change the data members to be more precise
10:12 < codo> yes that is how I understand it also
10:12 < codo> but the function does not change anything, so that is why I think it is for good practice
10:13 < codo> that it shouts out "I'm only reading, not writing"
10:15 < b_101> ok, not sure about the second part either
10:16 < LarryRuane> b_101: both of you are on exactly the right track ... `const` means that calling this method won't change the state of the object (it's a "read-only" call)
10:16 < LarryRuane> but if a member variable is labeled `mutable`, then the method _can_ change the variable
10:16 < LarryRuane> (just that variable)
10:17 < LarryRuane> mostly done for locking
10:17 < codo> ah
10:17 < LarryRuane> https://en.cppreference.com/w/cpp/language/cv refers to the M&M rule: mutable and mutex go together
10:18 < LarryRuane> there's one other common use of `mutable` besides locking ... do you know what it is?
10:18 -!- az [~az@45.4.192.254] has joined #bitcoin-core-pr-reviews
10:19 < codo> I don't
10:19 < b_101> so in this case m_cs is the mutable data member?
10:19 -!- az is now known as Guest4535
10:19 < LarryRuane> right
10:19 -!- Guest4535 [~az@45.4.192.254] has quit [Client Quit]
10:20 -!- oompa [~oompa@45.4.192.254] has joined #bitcoin-core-pr-reviews
10:20 -!- oompa [~oompa@45.4.192.254] has quit [Client Quit]
10:20 -!- lazarus96 [~lazarus@45.4.192.254] has joined #bitcoin-core-pr-reviews
10:21 < b_101> so this `StdLockGuard scoped_lock(m_cs);` mutates m_cs?
10:22 < LarryRuane> yes
10:22 < b_101> thx LarryRuane: very interesting
10:23 < LarryRuane> that acquires (locks) `m_cs` ... then it also get mutated (unlocked) when `scoped_lock` goes out of scope (by its destructor)
10:23 < b_101> right, thanks for clarifying that!
10:23 < LarryRuane> `mutable` is also often used for member variables that are merely a cache of some kind, for performance ... doesn't change functionality
10:24 < LarryRuane> here's an example (you can see from the name of the variable member): https://github.com/bitcoin/bitcoin/blob/aef8b4f43b0c4300aa6cf2c5cf5c19f55e73499c/src/coins.h#L220
10:25 < LarryRuane> the comment just above that line is very helpful
10:25 < b_101> yes 
10:26 < LarryRuane> but `mutable` does allow you to cheat, in that a const method can make changes that are actual functional changes! i.e. change the _logical_ state of the object
10:26 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:15d6:7f65:1cbf:6796] has joined #bitcoin-core-pr-reviews
10:26 < b_101> I have been studying mutex and locks, a little confused why Bitcoin Core has so many LOC macros instead of using standard c++ lock functions
10:27 < LarryRuane> i.e. nothing in the language verifies that your use of `mutable` and `const` functions are non-functional ... there's probably no way to automatically check that
10:27 -!- roze_paul [~quassel@142.243.254.224] has joined #bitcoin-core-pr-reviews
10:27 < b_101> LarryRuane: ok, thx
10:29 -!- lazarus96 [~lazarus@45.4.192.254] has quit [Quit: Connection closed]
10:29 < LarryRuane> b_101: yes, I think `LOCK()` is the most common way to do locking (I don't know why the logging subsystem doesn't use `LOCK`), but what that macro does is actually declare a (local) variable with some constructed artificial name,
10:29 -!- roze_paul [~quassel@142.243.254.224] has quit [Client Quit]
10:29 -!- roze_paul [~quassel@142.243.254.224] has joined #bitcoin-core-pr-reviews
10:30 < LarryRuane> and that variable's constructor actually does the mutex lock, and its destructor does the unlock.. which is very clever! it's hard to make the mistake of forgetting to unlock a mutex (like it is if you're doing unlocking explicitly)
10:31 < LarryRuane> you may notice lots of places where there's an opening brace (`{`) then a call to `LOCK`, then a small amount of code, then the close brace ... that's to limit the duration of the mutex locking to just the block of code (not locked after the close brace)
10:32 < b_101> yes, I still have to read more and make some basic c++ toy projects to fullly understand it
10:32 < LarryRuane> `StdLockGuard scoped_lock(m_cs)` has that same property as `LOCK` where the unlock is automatic, but with `StdLockGuard` you're making the variable visible (you choose the name), instead of it being hidden within the `LOCK` macro
10:33 < LarryRuane> and as i said, i don't really know why it's done that way in the logging subsystem ... maybe historical? maybe `LOCK` didn't exist when the logging code was written? not sure
10:41 -!- roze_paul [~quassel@142.243.254.224] has left #bitcoin-core-pr-reviews [https://quassel-irc.org - Chat comfortably. Anywhere.]
10:41 -!- roze_paul [~quassel@142.243.254.224] has joined #bitcoin-core-pr-reviews
10:41 -!- b_101 [~robert@189.236.26.147] has quit [Ping timeout: 268 seconds]
10:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has quit [Remote host closed the connection]
10:43 -!- roze_paul [~quassel@142.243.254.224] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
10:44 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews
10:48 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 256 seconds]
10:48 -!- roze_paul [~quassel@142.243.254.224] has joined #bitcoin-core-pr-reviews
10:52 -!- Guest3116 [~raj_@103.139.171.114] has quit [Quit: Leaving]
10:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has joined #bitcoin-core-pr-reviews
10:56 -!- b_101 [~robert@189.236.26.147] has joined #bitcoin-core-pr-reviews
10:57 -!- jg [~jg@2a02:830a:b010:7e00:a9ae:40bd:dd38:921a] has joined #bitcoin-core-pr-reviews
10:59 -!- dzxzg2 [~dzxzg2@2600:387:f:4b19::3] has quit [Quit: Client closed]
10:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has quit [Ping timeout: 252 seconds]
10:59 -!- dzxzg2 [~dzxzg2@2600:387:f:4b19::3] has joined #bitcoin-core-pr-reviews
11:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has joined #bitcoin-core-pr-reviews
11:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has quit [Ping timeout: 252 seconds]
11:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has joined #bitcoin-core-pr-reviews
11:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has quit [Ping timeout: 256 seconds]
11:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has joined #bitcoin-core-pr-reviews
11:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has quit [Ping timeout: 264 seconds]
11:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has joined #bitcoin-core-pr-reviews
11:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has quit [Ping timeout: 264 seconds]
11:35 -!- AmishNick [~AmishNick@pool-100-37-32-9.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews
11:38 -!- jg [~jg@2a02:830a:b010:7e00:a9ae:40bd:dd38:921a] has quit [Quit: Ping timeout (120 seconds)]
11:38 -!- jg [~jg@2a02:830a:b010:7e00:a9ae:40bd:dd38:921a] has joined #bitcoin-core-pr-reviews
11:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has joined #bitcoin-core-pr-reviews
11:40 -!- jg [~jg@2a02:830a:b010:7e00:a9ae:40bd:dd38:921a] has quit [Client Quit]
11:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has quit [Ping timeout: 252 seconds]
11:45 -!- AmishNick [~AmishNick@pool-100-37-32-9.nycmny.fios.verizon.net] has quit [Quit: Leaving]
11:46 -!- amishnick [~amishnick@pool-100-37-32-9.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews
11:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has joined #bitcoin-core-pr-reviews
11:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has quit [Ping timeout: 260 seconds]
11:59 -!- roze_paul [~quassel@142.243.254.224] has quit [Ping timeout: 252 seconds]
11:59 -!- rozehnal_paul [~rozehnal_@142.243.254.224] has quit [Ping timeout: 256 seconds]
12:01 -!- amishnick [~amishnick@pool-100-37-32-9.nycmny.fios.verizon.net] has quit [Quit: Leaving]
12:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has joined #bitcoin-core-pr-reviews
12:02 -!- dzxzg2 [~dzxzg2@2600:387:f:4b19::3] has quit [Quit: Client closed]
12:03 -!- b_101_ [~robert@189.236.26.147] has joined #bitcoin-core-pr-reviews
12:03 -!- b_101 [~robert@189.236.26.147] has quit [Ping timeout: 252 seconds]
12:17 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:15d6:7f65:1cbf:6796] has quit [Ping timeout: 256 seconds]
12:18 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:23 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:15d6:7f65:1cbf:6796] has joined #bitcoin-core-pr-reviews
12:36 -!- b_101_ [~robert@189.236.26.147] has quit [Ping timeout: 260 seconds]
12:47 -!- dzxzg2 [~dzxzg2@2600:387:15:816::7] has joined #bitcoin-core-pr-reviews
12:52 -!- dzxzg2 [~dzxzg2@2600:387:15:816::7] has quit [Quit: Client closed]
12:53 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
12:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:8176:85da:dd42:e674] has quit []
13:04 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Ping timeout: 268 seconds]
13:27 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
13:41 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:15d6:7f65:1cbf:6796] has quit [Ping timeout: 252 seconds]
13:47 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Remote host closed the connection]
13:48 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
13:52 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Read error: Connection reset by peer]
13:53 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
13:55 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
13:57 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds]
13:59 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
14:00 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds]
14:03 < hebasto> the reason to use StdMutex / StdLockGuard see here -- https://github.com/bitcoin/bitcoin/blob/8ae2808a4354e8dcc697f76bacc5e2f2befe9220/src/logging.h#L86
14:03 < hebasto> "Can not use Mutex from sync.h because in debug mode it would cause a deadlock when a potential deadlock was detected"
14:04 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 272 seconds]
14:05 < hebasto> it won't be relevant after https://github.com/bitcoin/bitcoin/pull/26781
14:10 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity]
14:11 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
14:15 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
14:17 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 268 seconds]
14:18 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
14:20 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds]
14:27 -!- b_101 [~robert@189.236.26.147] has joined #bitcoin-core-pr-reviews
14:33 -!- b_101__ [~robert@189.236.26.147] has joined #bitcoin-core-pr-reviews
14:37 -!- b_101 [~robert@189.236.26.147] has quit [Ping timeout: 252 seconds]
14:40 -!- b_101_ [~robert@189.236.26.147] has joined #bitcoin-core-pr-reviews
14:44 -!- b_101__ [~robert@189.236.26.147] has quit [Ping timeout: 272 seconds]
14:48 -!- b_101_ [~robert@189.236.26.147] has quit [Quit: leaving]
14:48 -!- b_101_ [~robert@189.236.26.147] has joined #bitcoin-core-pr-reviews
14:51 -!- b_101_ [~robert@189.236.26.147] has quit [Client Quit]
14:52 -!- b_101_ [~robert@189.236.26.147] has joined #bitcoin-core-pr-reviews
14:57 -!- b_101_ [~robert@189.236.26.147] has quit [Ping timeout: 272 seconds]
14:57 -!- b_101 [~robert@189.236.26.147] has joined #bitcoin-core-pr-reviews
15:08  * b_101 action
15:25 -!- b_101 [~robert@189.236.26.147] has quit [Killed (NickServ (GHOST command used by b_101_))]
15:32 -!- b_101 [~robert@189.236.26.147] has joined #bitcoin-core-pr-reviews
15:33 -!- b_101 [~robert@189.236.26.147] has quit [Killed (NickServ (GHOST command used by b_101_))]
15:34 -!- b_101 [~robert@189.236.26.147] has joined #bitcoin-core-pr-reviews
15:36 -!- b_101 [~robert@189.236.26.147] has quit [Killed (NickServ (GHOST command used by b_101_))]
15:43 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Remote host closed the connection]
15:44 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
15:48 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
15:48 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
15:53 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
15:56 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
15:59 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
16:01 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 272 seconds]
16:55 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Remote host closed the connection]
16:56 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
16:59 -!- b_101 [~robert@189.236.26.147] has joined #bitcoin-core-pr-reviews
16:59 -!- b_101 [~robert@189.236.26.147] has quit [Client Quit]
17:01 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
17:01 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 268 seconds]
17:02 -!- b_101 [~robert@185.242.5.35] has joined #bitcoin-core-pr-reviews
17:07 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 268 seconds]
17:10 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
17:14 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds]
17:26 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
17:31 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds]
17:35 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
17:37 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:15d6:7f65:1cbf:6796] has joined #bitcoin-core-pr-reviews
17:41 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
17:47 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
17:52 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
17:53 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 268 seconds]
17:57 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
17:58 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 272 seconds]
18:00 -!- amishnick [~amishnick@cpe-74-72-75-120.nyc.res.rr.com] has joined #bitcoin-core-pr-reviews
18:02 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
18:02 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
18:07 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
18:18 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
18:21 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
18:23 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
18:24 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
18:25 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
18:51 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Remote host closed the connection]
18:51 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
18:56 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
19:05 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:15d6:7f65:1cbf:6796] has quit [Ping timeout: 256 seconds]
19:06 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
19:10 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
19:11 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
19:15 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
19:15 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
19:18 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
19:20 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds]
19:23 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
19:26 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
19:28 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
19:31 -!- andrew___ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
19:31 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 268 seconds]
19:33 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 272 seconds]
19:37 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
19:37 -!- andrew___ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds]
19:38 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
19:42 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds]
19:43 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds]
19:44 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
19:49 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
19:49 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 272 seconds]
19:53 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
19:56 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
20:00 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds]
20:04 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
20:08 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 272 seconds]
20:09 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
20:34 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Remote host closed the connection]
20:35 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
20:40 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds]
20:45 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
20:46 -!- kevkevin [~kevkevin@c-98-226-43-69.hsd1.il.comcast.net] has quit [Quit: Connection closed]
20:49 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
20:52 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
20:56 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Remote host closed the connection]
20:57 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
21:02 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 268 seconds]
21:02 -!- exfrog [~exfrog@135-180-198-168.fiber.dynamic.sonic.net] has joined #bitcoin-core-pr-reviews
21:04 -!- exfrog [~exfrog@135-180-198-168.fiber.dynamic.sonic.net] has quit [Remote host closed the connection]
21:04 -!- exfrog [~exfrog@135-180-198-168.fiber.dynamic.sonic.net] has joined #bitcoin-core-pr-reviews
21:09 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
21:09 -!- exfrog [~exfrog@135-180-198-168.fiber.dynamic.sonic.net] has quit [Remote host closed the connection]
21:11 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Remote host closed the connection]
21:12 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
22:16 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Remote host closed the connection]
22:16 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
22:21 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
22:33 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
22:39 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
22:45 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
23:04 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
23:08 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
23:12 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 246 seconds]
23:24 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
23:29 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds]
23:40 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
23:45 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds]
23:58 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews
--- Log closed Thu Jan 19 00:00:19 2023