--- Log opened Wed Jan 25 00:00:26 2023 00:00 -!- RubenSomsen_ is now known as RubenSomsen 00:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 255 seconds] 00:03 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 255 seconds] 00:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 00:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 264 seconds] 00:10 -!- __gotcha [~Thunderbi@79.132.249.86] has joined #bitcoin-core-pr-reviews 00:15 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 00:15 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 00:20 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds] 00:25 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 264 seconds] 00:27 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews 00:32 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 00:33 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 268 seconds] 00:37 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 00:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 00:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 246 seconds] 00:49 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews 00:49 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 00:53 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 255 seconds] 00:54 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 01:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 01:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 246 seconds] 01:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 01:07 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 01:11 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds] 01:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 248 seconds] 01:15 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 01:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 246 seconds] 01:23 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 01:25 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews 01:27 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 264 seconds] 01:32 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 252 seconds] 01:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 01:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 260 seconds] 01:39 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 01:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 01:43 -!- stratospher[m] [~stratosph@2001:470:69fc:105::2:728e] has joined #bitcoin-core-pr-reviews 01:43 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 246 seconds] 01:46 -!- __gotcha1 [~Thunderbi@79.132.249.86] has joined #bitcoin-core-pr-reviews 01:49 -!- __gotcha [~Thunderbi@79.132.249.86] has quit [Ping timeout: 264 seconds] 01:49 -!- __gotcha1 is now known as __gotcha 01:55 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 02:00 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 02:12 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 02:16 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 255 seconds] 02:25 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 02:30 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds] 02:42 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 02:46 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 02:54 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:957c:f7ea:1809:9d2d] has joined #bitcoin-core-pr-reviews 03:00 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 03:01 -!- Netsplit *.net <-> *.split quits: andrew_mo_ 03:01 -!- Netsplit over, joins: andrew_mo_ 03:05 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds] 03:12 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 03:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Remote host closed the connection] 03:17 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds] 03:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 03:22 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 03:25 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 260 seconds] 03:27 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 03:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 03:39 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 03:44 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:957c:f7ea:1809:9d2d] has quit [Ping timeout: 252 seconds] 03:45 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 03:48 -!- __gotcha1 [~Thunderbi@79.132.249.86] has joined #bitcoin-core-pr-reviews 03:48 -!- __gotcha [~Thunderbi@79.132.249.86] has quit [Read error: Connection reset by peer] 03:48 -!- __gotcha1 is now known as __gotcha 03:57 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 04:02 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 246 seconds] 04:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Remote host closed the connection] 04:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 04:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 252 seconds] 04:15 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 04:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 04:20 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 268 seconds] 04:20 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:957c:f7ea:1809:9d2d] has joined #bitcoin-core-pr-reviews 04:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 256 seconds] 04:28 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews 04:31 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 04:32 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 252 seconds] 04:37 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds] 04:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 04:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 256 seconds] 04:45 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 04:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 246 seconds] 04:50 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 04:55 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 04:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 05:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 252 seconds] 05:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 05:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 246 seconds] 05:07 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 05:11 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 246 seconds] 05:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 05:13 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 05:14 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 255 seconds] 05:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 248 seconds] 05:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 05:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 246 seconds] 05:24 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 05:28 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 05:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 05:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 264 seconds] 05:41 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 05:46 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 255 seconds] 05:59 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 06:04 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 06:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 06:11 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 06:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 252 seconds] 06:17 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 06:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 06:28 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 06:33 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 06:35 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 06:39 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 06:47 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 06:48 -!- jg [~jg@2a02:830a:b010:7e00:6103:5096:3d4c:8416] has joined #bitcoin-core-pr-reviews 06:52 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 06:55 -!- jg [~jg@2a02:830a:b010:7e00:6103:5096:3d4c:8416] has quit [Quit: Ping timeout (120 seconds)] 06:55 -!- jg [~jg@2a02:830a:b010:7e00:6103:5096:3d4c:8416] has joined #bitcoin-core-pr-reviews 06:56 -!- jg [~jg@2a02:830a:b010:7e00:6103:5096:3d4c:8416] has quit [Client Quit] 07:05 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 07:10 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds] 07:11 -!- b_101 [~robert@193.37.254.131] has joined #bitcoin-core-pr-reviews 07:11 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:957c:f7ea:1809:9d2d] has quit [Ping timeout: 252 seconds] 07:13 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 07:18 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 07:25 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 07:29 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 256 seconds] 07:33 -!- grettke [~grettke@184.55.131.155] has joined #bitcoin-core-pr-reviews 07:42 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 07:45 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 07:46 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 264 seconds] 07:50 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 07:52 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 07:56 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 07:57 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 264 seconds] 08:13 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Remote host closed the connection] 08:14 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 08:18 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 08:22 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: WeeChat 3.8] 08:26 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 08:30 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 08:30 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 08:34 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds] 08:38 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 08:45 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 08:50 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 08:51 -!- hernanmarino [~hernanmar@181.99.169.107] has joined #bitcoin-core-pr-reviews 08:52 -!- pablomartin [~pablomart@109.69.107.227] has joined #bitcoin-core-pr-reviews 08:52 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 08:57 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 268 seconds] 08:59 -!- svav [~svav@82-69-86-143.dsl.in-addr.zen.co.uk] has joined #bitcoin-core-pr-reviews 09:00 < ishaanam[m]> #startmeeting 09:00 -!- d33r_gee [~d33r_gee@45-27-31-99.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-pr-reviews 09:00 < ishaanam[m]> Hey everyone, welcome to PR Review club! 09:00 < brunoerg> hi 09:00 < d33r_gee> hello 09:01 < raj21> hi 09:01 < pablomartin> hello! 09:01 < b_101> hello all! 09:01 < hernanmarino> Hello 09:01 < ishaanam[m]> Today we will be reviewing #26347 "Ensure the wallet is unlocked when needed for rescanning" 09:01 < LarryRuane> hi 09:01 < ishaanam[m]> Notes are posted here: https://bitcoincore.reviews/26347 09:01 < grettke> Hello. 09:02 < ishaanam[m]> As always, feel free to jump in with any questions or comments! 09:02 < svav> Hi 09:02 < glozow> hi 09:02 -!- roze_paul [~quassel@142.243.254.224] has joined #bitcoin-core-pr-reviews 09:02 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 09:02 < ishaanam[m]> Has everyone gotten the chance to take a look at the PR or the notes? 09:02 < d33r_gee> yes 09:02 < roze_paul> hi 09:02 < pablomartin> yup, both 09:02 < roze_paul> a bit 09:02 < b_101> y/y 09:03 < LarryRuane> some of both :) 09:03 < svav> yes 09:03 < hernanmarino> I did a review on the PR a couple of months ago, but didn t read the notes thoroughly today 09:03 < willcl_ark> Hi 09:03 < Murch1> Hey 09:04 < ishaanam[m]> Great! Can someone give a short summary of the bug this PR is fixing? 09:04 -!- rot13maxi [~rot13maxi@pool-71-171-103-145.clppva.fios.verizon.net] has joined #bitcoin-core-pr-reviews 09:04 -!- dzxzg [~igloo@166.198.37.129] has joined #bitcoin-core-pr-reviews 09:05 < d33r_gee> This PR makes sure that the wallet stays unlocked while rescanning and that the following rpc calls do not run while rescanning 09:05 < d33r_gee> - walletlock 09:05 < d33r_gee> - encryptwallet 09:05 < d33r_gee> - walletpassphrasechange 09:05 < grettke> Yes took a look. 09:05 < LarryRuane> while either of the 2 long-running RPCs is running, the wallet lock can timeout (wallet locks), which prevents key-topoff (those long-running RPCs create a need for topoff) 09:05 < b_101> fix risk of missing some keys when rescanning the blockchain due to an unlockwallet time-out, particularly if time set is not enough 09:06 < LarryRuane> one thing I'm unclear on is what happens (without the PR) if the key topoff wants to run but the wallet is locked? Does the long-running RPC immediately fail? 09:06 < ishaanam[m]> d33r_gee: LarryRuane: b_101: yes! 09:06 < LarryRuane> or do we just not do the topoff? if so, what's the effect of that? 09:07 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 09:07 < ishaanam[m]> LarryRuane: the key topoff fails silently, meaning that the scan continues, but with less keys in its keypool than it should have 09:07 < b_101> can someone define the meaning of topoff? 09:07 < LarryRuane> ishaanam[m]: thanks 09:08 < LarryRuane> for topoff, this is a good article https://blog.lopp.net/mind-the-bitcoin-address-gap/ 09:08 < b_101> LarryRuane: thx! 09:09 < ishaanam[m]> This sort of lead to the next question: Why can wallets that use unhardened derivation top up the keypool without being unlocked? 09:10 < LarryRuane> when rescanning, if you detect a payment to one of your addresses, you want to make sure you're looking for payments to the next 1000 addresses ... may need to generate more addresses 09:10 < LarryRuane> (hope i got that right!) 09:11 < ishaanam[m]> Yes, that is what it means to top up the keypool. 09:11 < rot13maxi> Will other signing operations with the wallet fail/error if the wallet is in the middle of rescanning? In other words, if my wallet normally re-locks after 30 seconds, but is "held open" because it's rescanning, could an RPC to send a transaction come in while its rescanning, or would that RPC fail because there's a scan-in-progress? 09:12 < LarryRuane> ishaanam[m]: unhardened doesn't need private keys? ... but i'm fuzzy on this topic, is it kind of watch-only situation? 09:13 < roze_paul> +1 @rot13maxi 09:13 < ishaanam[m]> LarryRuane: yes, with unhardened derivation, the "keypool" is basically the xpub, because private information is not needed to derive additional keys. 09:13 -!- hernanmarino [~hernanmar@181.99.169.107] has quit [Quit: Leaving] 09:13 < Murch1> ishaanam: Only the private keys are encrypted, so the unlocked wallet.dat is sufficient to derive unhardened keys 09:14 < LarryRuane> ishaanam[m]: +1 thanks 09:14 < ishaanam[m]> Murch: yes, thanks for pointing that out. It is important to note that the wallet only encrypts private keys 09:15 < Murch1> err 09:15 < Murch1> also, I meant the “locked wallet is sufficient” 09:15 < LarryRuane> ishaanam[m]: does a wallet use *either* unhardened or hardened derivation, but never both? 09:15 < Murch1> I was trying to respond to your question, not correct your answpr 09:15 < rot13maxi> if other signing RPCs don't currently fail/error when a rescan is in progress, then we might want to have the ` if (pwallet->IsScanningWithPassphrase())` guard on those other operations, right? 09:16 < ishaanam[m]> rot13maxi: Yeah, I don't think that other signing RPCs currently fail when a rescan is in progress 09:16 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 09:17 < ishaanam[m]> rot13maxi: yes, I wonder if that is a bug or if there is a deliberate reason for doing that. I think the main problem is that scanning RPCs don't hold cs_wallet, but signing RPCs do. 09:17 < ishaanam[m]> LarryRuane: If importdescriptors is used, then technically both hardened and hardened derivation can be used. 09:18 < ishaanam[m]> But in Bitcoin Core legacy wallets use hardened and descriptor wallets use unhardened 09:18 < LarryRuane> while rescanning, we're discovered UTXOs that we own (have keys for), but it should be okay to, for example, `sendmany` which would just use the UTXOs that we do know about? (rather than waiting for the rescan to complete?) 09:18 < LarryRuane> *discovering 09:21 < ishaanam[m]> LarryRuane: I think so, I would have to double check with the code but I can't see any immediate problems on master with spending while rescanning 09:21 -!- hernanmarino [~hernanmar@181.99.169.107] has joined #bitcoin-core-pr-reviews 09:21 < ishaanam[m]> Writing a test for this PR was one of the trickier parts. Does the test added to wallet_importdescriptors.py fail on master for you? 09:22 -!- dzxzg [~igloo@166.198.37.129] has quit [Ping timeout: 260 seconds] 09:22 < ishaanam[m]> The test I am talking about: https://github.com/bitcoin-core-review-club/bitcoin/commit/b2e2829014c5c9a3dc02eab7fcd77dd907228c78#diff-c3ff95ab6716d726b68003d2d29f72d91e15e813c8b41e3e1c82d4f2a0feb26d 09:22 < hernanmarino> I didn't have a chance to test that, will do it later 09:23 < LarryRuane> no it didn't fail for me (tried 3 times) 09:23 < LarryRuane> i was wondering if using mocktime would help make the test more reliable? (i love mocktime!) 09:24 < pablomartin> i still have to perform the tests... but talking about it, is it worth to add more coverage regarding the signing RPCs during rescan and other situations/ combinations?? 09:26 < ishaanam[m]> LarryRuane: Yeah, when writing this I had played around with using mocktime but it didn't seem to make a difference. However, if you can think of any ways to make this more reliable please let me know! Perhaps you can increase the "range" and "next_index" values in the descriptor object that the scan is being done for? 09:26 < LarryRuane> yes I would be glad to take a look 09:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Remote host closed the connection] 09:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 09:28 -!- dzxzg [~igloo@166.198.37.129] has joined #bitcoin-core-pr-reviews 09:29 < LarryRuane> for anyone who may be newer here, you can see the PR changes many `LOCK` to `LOCK2` (to include the new `m_relocl_mutex`) -- the order of those `LOCK2` arguments is very important! 09:29 < ishaanam[m]> pablomartin: Currently it is somewhat difficult for the functional test suite to have a rescan going on in the backgroung while other RPCs are being run, but I think I remember there being a PR open for fixing that. 09:29 < ishaanam[m]> So now that we have gone over the bug, what is this PR's approach to fixing it? 09:31 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Remote host closed the connection] 09:31 -!- svav [~svav@82-69-86-143.dsl.in-addr.zen.co.uk] has quit [Quit: Connection closed] 09:31 < LarryRuane> i think during the long-running RPCs, hold the new `m_relock_mutex` the entire time, 09:31 < hernanmarino> disallowing the execution of certain commands while the rescan is running . Also, introducing a new mutex 09:31 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 09:31 < b_101> Add a flag to CWallet to avoid some RPCs to be run while rescanning and add a recursive mutex 09:32 < LarryRuane> so that if the timeout wants to occur, re-locking the wallet will be delayed by this mutex 09:32 < LarryRuane> https://github.com/bitcoin/bitcoin/pull/26347/files#diff-c4eeb9bd8e84ac276465d100d6ac4c1c9b9ddc145827a03dfe11932598b028b9R1660 09:32 -!- dzxzg [~igloo@166.198.37.129] has quit [Remote host closed the connection] 09:33 < b_101> LarryRuane: +1 09:33 < pablomartin> ishaanam: thanks! 25957? 09:33 < LarryRuane> (does other stuff, but IIUC, that is the heart of it) 09:33 < ishaanam[m]> Right, so I think that the new recursive mutex is the most important part of this PR. Why is m_relock_mutex added instead of just using cs_wallet? 09:34 < b_101> Is there any documentation for the Bitcoin Core LOCK macros? 09:34 < rot13maxi> what does `LOCK2` do over `LOCK`? 09:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 246 seconds] 09:34 < LarryRuane> is it because `cs_wallet` is pretty "hot", used for lots of stuff that we don't want to block during the entire time of a rescan? 09:34 < glozow> rot13maxi: it takes 2 locks, one after the other 09:34 < rot13maxi> thanks 09:35 < rot13maxi> does it do the two locks atomically? 09:35 < LarryRuane> rot13maxi: `LOCK2(a, b)` first does `LOCK(a)` and *then* does `LOCK(b)` 09:35 < LarryRuane> rot13maxi: no, not atomically 09:35 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has joined #bitcoin-core-pr-reviews 09:35 < rot13maxi> got it. thanks 09:35 < ishaanam[m]> pablomartin: perhaps but I haven't taken a look at #25957. I was referring to the draft PR #26700 09:35 < LarryRuane> it may get the first lock, then block for a while before getting the second lock 09:36 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 246 seconds] 09:38 < ishaanam[m]> Theoretically while cs_wallet could be used, m_relock_mutex is added because rescanning a wallet can take a long time, and we would still want other RPCs that lock cs_wallet to be able to run. 09:38 < pablomartin> ishaanam: insteresting (#26700), thanks again! I'll take a look! 09:39 < ishaanam[m]> Why is m_relock_mutex a RecursiveMutex instead of a Mutex? What are the differences? 09:40 < roze_paul> so m_relock_mutex functionally is very similar to cs_wallet, it just has a more focussed scope, (and is recursive) ? 09:40 < b_101> Because more than one selected RPCs can be run in parallel while rescan is in progress ? 09:41 < ishaanam[m]> roze_paul: yes, m_relock_mutex has a more focused scope, but cs_wallet is recursive as well 09:41 < LarryRuane> RecursiveMutex allows the same thread that already owns the lock to lock it again ... it's only unlocked on the last unlock (that is, there's a lock recursion counter) 09:41 < LarryRuane> if a thread locks a `Mutex` that it already owns, we'll either crash or just hang forever (i forget which) 09:43 < ishaanam[m]> LarryRuane: Yes, I think that Bitcoin Core would crash because its locking code detects things like that 09:43 < rot13maxi> ah. I think this lock on `pwallet->cs_wallet` in the `rescanblockchain()` will prevent concurrent spends from happening (https://github.com/bitcoin/bitcoin/blob/master/src/wallet/rpc/spend.cpp#L270) right? 09:43 < LarryRuane> but there's a general push to move away from RecursiveMutex because it encourages sloppy code ... I'm not sure why a `Mutex` wouldn't work here (i saw that there's a comment on the PR that you replied to) 09:43 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 09:44 < rot13maxi> dropped the link. This lock in rescanblockchain: https://github.com/bitcoin/bitcoin/pull/26347/files#diff-07e4c0f110004a013432ac478fc6e1386b124cb1ad59bbb2e5fee1cdd92a307fR879 09:44 < hernanmarino> b_101 : take a look at https://github.com/bitcoin/bitcoin/blob/ab98673f058853e00c310afad57925f54c1ecfae/src/sync.h#L258-L263 or perhaps even the whole file 09:45 < rot13maxi> thanks hernanmarino 09:45 < b_101> hernanmarino: Thx! 09:46 < glozow> from https://github.com/bitcoin/bitcoin/pull/26347#discussion_r1003661127, is the concern you might wait on m_relock_mutex and cs_wallet in different orders and deadlock? 09:46 < ishaanam[m]> LarryRuane: it is because sometimes cs_wallet is locked, and then CWallet::Lock is called, which locks m_rescan_mutex and then cs_wallet, which is inconsistent from a few other places 09:48 < ishaanam[m]> glozow: yes, but if there is a strong preference towards Mutex then I can revisit the code and perhaps do it differently such that this is no longer a concern. This would require a few more changes then what is there currently from what I can tell. 09:48 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 09:50 < glozow> yes, from quick glance it seems `Lock()` could require `cs_wallet` to already be held and that could solve the problem. but i'm scope creeping 09:50 -!- rot13maxi [~rot13maxi@pool-71-171-103-145.clppva.fios.verizon.net] has left #bitcoin-core-pr-reviews [] 09:50 < ishaanam[m]> What would happen if the first commit of this PR was removed and a user tried to run walletlock while performing a rescan that required the passphrase? 09:51 < LarryRuane> https://github.com/bitcoin/bitcoin/pull/26347#discussion_r1008917871 (question about recusive versus non-recursive mutex) 09:53 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 09:54 < glozow> Just a guess - the user doesn't get a warning, but it still blocks, waiting for m_relock_mutex to become available? 09:55 < ishaanam[m]> Really what this question is asking is: if none of the encryption RPCs listed in the PR ran IsScanningWithPassphrase, would happen when locking a wallet during a rescan? 09:55 < ishaanam[m]> glozow: Yes! 09:55 < hernanmarino> I have to go, see you all next time . Thanks ishaanam[m] for hosting 09:56 < glozow> That's good, though getting a warning immediately is definitely preferable 09:56 < LarryRuane> i think those can be really tough questions in general ... if a request (probably an RPC let's say) can't be satisfied immediately, is it better to block or to return an error? 09:56 < ishaanam[m]> That first commit was added so the user does not get confused if an RPC takes too long because of this. 09:56 -!- svav [~svav@82-69-86-143.dsl.in-addr.zen.co.uk] has joined #bitcoin-core-pr-reviews 09:57 < LarryRuane> i don't know if bitcoin core has a convention for that ... maybe it's just case-by-case ... depending on how long the delay would typically be? 09:57 < ishaanam[m]> LarryRuane: I think that would make sense. Here the delay has the potential to be pretty long. 09:58 < LarryRuane> ishaanam[m]: +1 09:59 < ishaanam[m]> Looks like we are coming up on an hour. Thanks everyone for participating! 09:59 < d33r_gee> thanks every1! 09:59 < glozow> Great meeting, thank you ishaanam! 10:00 < ishaanam[m]> #endmeeting 10:00 < roze_paul> without the first PR, would a user be able to see that the walletlock rpc was blocked via logging output? 10:00 < roze_paul> thanks ishaanam & all 10:00 < b_101> thanks ishaanam[m] for hosting and everyone! 10:00 < LarryRuane> ishaanam[m]: thanks, really informative! let's all go and review the PR!! 10:00 < pablomartin> thanks ishaanam! thanks all! 10:00 -!- d33r_gee [~d33r_gee@45-27-31-99.lightspeed.sntcca.sbcglobal.net] has quit [Quit: Connection closed] 10:01 -!- pablomartin [~pablomart@109.69.107.227] has quit [Quit: Leaving] 10:01 < svav> Thanks ishaanam and all! 10:02 < effexzi> Thanks every1! 10:04 -!- svav [~svav@82-69-86-143.dsl.in-addr.zen.co.uk] has quit [Quit: Connection closed] 10:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 10:06 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 10:08 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds] 10:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 256 seconds] 10:11 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 255 seconds] 10:17 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 10:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 10:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 246 seconds] 10:43 -!- nick [~nick@c-24-18-226-80.hsd1.wa.comcast.net] has joined #bitcoin-core-pr-reviews 10:44 -!- nick [~nick@c-24-18-226-80.hsd1.wa.comcast.net] has quit [Client Quit] 10:49 -!- dzxzg [~dzxzg@2600:387:15:81b::4] has joined #bitcoin-core-pr-reviews 10:59 -!- dzxzg [~dzxzg@2600:387:15:81b::4] has quit [Quit: Client closed] 11:04 -!- roze_paul [~quassel@142.243.254.224] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 11:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 11:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 264 seconds] 11:16 -!- __gotcha [~Thunderbi@79.132.249.86] has quit [Read error: Connection reset by peer] 11:16 -!- __gotcha [~Thunderbi@79.132.249.86] has joined #bitcoin-core-pr-reviews 11:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 11:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 252 seconds] 11:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 11:42 < codo> hi ishaanam[m] I've been playing around with the test. It seems to fail more reliably on master by duplicating this line once or twice more https://github.com/bitcoin/bitcoin/blob/b2e2829014c5c9a3dc02eab7fcd77dd907228c78/test/functional/wallet_importdescriptors.py#L681 11:44 < codo> But I think with systems getting faster over time one looses that reliability without noticing. 11:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 260 seconds] 11:52 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 11:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 252 seconds] 11:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 12:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 246 seconds] 12:06 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 12:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has joined #bitcoin-core-pr-reviews 12:10 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:1560:7ab9:328d:83ec] has quit [Ping timeout: 252 seconds] 12:15 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 255 seconds] 12:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 12:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 252 seconds] 12:25 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 12:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 12:28 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:957c:f7ea:1809:9d2d] has joined #bitcoin-core-pr-reviews 12:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 246 seconds] 12:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 12:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 246 seconds] 12:44 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews 12:49 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 264 seconds] 12:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 12:55 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 264 seconds] 13:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 13:05 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity] 13:17 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 13:20 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Client Quit] 13:22 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 13:27 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Remote host closed the connection] 13:28 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 13:30 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:957c:f7ea:1809:9d2d] has quit [Ping timeout: 246 seconds] 13:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Remote host closed the connection] 13:31 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews 13:32 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 13:35 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 246 seconds] 13:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 13:45 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 13:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 256 seconds] 13:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 13:49 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 13:52 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 256 seconds] 13:53 -!- __gotcha [~Thunderbi@79.132.249.86] has quit [Ping timeout: 255 seconds] 13:54 -!- __gotcha [~Thunderbi@79.132.249.86] has joined #bitcoin-core-pr-reviews 13:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 14:01 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 14:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 248 seconds] 14:04 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds] 14:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 14:05 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds] 14:07 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 14:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 260 seconds] 14:15 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 14:18 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 14:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 252 seconds] 14:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 14:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 252 seconds] 14:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 14:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 256 seconds] 14:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 14:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 248 seconds] 14:48 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 14:50 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews 14:51 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 255 seconds] 14:54 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 246 seconds] 14:59 -!- hernanmarino [~hernanmar@181.99.169.107] has quit [Quit: Leaving] 15:00 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:909c:9c2f:e3c6:a7b6] has joined #bitcoin-core-pr-reviews 15:01 -!- FrancisMr [~MrFrancis@bl15-115-2.dsl.telepac.pt] has joined #bitcoin-core-pr-reviews 15:03 -!- ___nick___ [~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net] has quit [Ping timeout: 248 seconds] 15:05 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:909c:9c2f:e3c6:a7b6] has quit [Ping timeout: 252 seconds] 15:13 -!- __gotcha [~Thunderbi@79.132.249.86] has quit [Remote host closed the connection] 15:14 -!- __gotcha [~Thunderbi@79.132.249.86] has joined #bitcoin-core-pr-reviews 15:17 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 15:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 248 seconds] 15:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 15:25 -!- FrancisMr [~MrFrancis@bl15-115-2.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 15:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 248 seconds] 15:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 15:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 246 seconds] 15:44 -!- __gotcha [~Thunderbi@79.132.249.86] has quit [Read error: Connection reset by peer] 15:44 -!- __gotcha [~Thunderbi@79.132.249.86] has joined #bitcoin-core-pr-reviews 15:44 -!- dongcarl [~dongcarl@cpe-66-65-184-36.nyc.res.rr.com] has quit [Quit: Ping timeout (120 seconds)] 15:45 -!- dongcarl [~dongcarl@cpe-66-65-184-36.nyc.res.rr.com] has joined #bitcoin-core-pr-reviews 16:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 16:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 248 seconds] 16:16 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews 16:21 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 252 seconds] 16:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 16:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 252 seconds] 16:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 16:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 264 seconds] 16:40 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews 16:44 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 252 seconds] 16:46 -!- jeremyrubin [~jeremyrub@ec2-44-199-24-18.compute-1.amazonaws.com] has quit [Quit: Ping timeout (120 seconds)] 16:46 -!- jeremyrubin [~jeremyrub@ec2-44-199-24-18.compute-1.amazonaws.com] has joined #bitcoin-core-pr-reviews 16:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 16:51 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 260 seconds] 16:51 -!- FrancisMr [~MrFrancis@2001:8a0:fa4c:901:523:e999:53a:cc39] has joined #bitcoin-core-pr-reviews 16:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 17:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 260 seconds] 17:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 17:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 255 seconds] 17:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 17:09 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Remote host closed the connection] 17:09 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 17:12 -!- theStack [~theStack@95.179.145.232] has quit [Quit: theStack] 17:14 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds] 17:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 246 seconds] 17:23 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews 17:26 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 17:28 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 252 seconds] 17:32 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 17:34 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews 17:37 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 17:38 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 252 seconds] 17:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 17:43 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 17:43 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 17:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 252 seconds] 17:48 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds] 17:51 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews 17:59 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 18:02 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 252 seconds] 18:03 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 18:07 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 18:08 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews 18:10 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 18:12 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 18:13 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 248 seconds] 18:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 18:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 252 seconds] 18:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 18:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 264 seconds] 18:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 18:33 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Remote host closed the connection] 18:34 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 18:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 264 seconds] 18:38 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 18:41 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 18:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 246 seconds] 18:50 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 18:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 18:55 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 18:58 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 18:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 264 seconds] 18:59 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Read error: Connection reset by peer] 18:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 19:00 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 19:04 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 19:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 252 seconds] 19:05 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds] 19:07 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Read error: Connection reset by peer] 19:08 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 19:10 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 19:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 19:13 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 19:14 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 19:15 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 260 seconds] 19:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 19:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 260 seconds] 19:24 -!- FrancisMr [~MrFrancis@2001:8a0:fa4c:901:523:e999:53a:cc39] has quit [Ping timeout: 248 seconds] 19:27 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 19:31 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 255 seconds] 19:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 19:44 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 19:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 256 seconds] 19:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 19:50 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 19:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 248 seconds] 19:56 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 20:01 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews 20:04 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds] 20:05 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 256 seconds] 20:11 -!- grettke [~grettke@184.55.131.155] has quit [Quit: grettke] 20:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 20:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 246 seconds] 20:17 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 20:22 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 20:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 20:25 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 20:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 252 seconds] 20:29 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 20:30 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 20:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 248 seconds] 20:36 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 20:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 20:41 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 20:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 252 seconds] 20:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 20:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 248 seconds] 20:52 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 20:56 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 20:57 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 268 seconds] 21:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 255 seconds] 21:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 21:05 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 21:07 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 248 seconds] 21:09 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 21:09 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds] 21:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 21:13 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 21:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 246 seconds] 21:24 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 21:27 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 21:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 248 seconds] 21:30 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 21:31 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 21:34 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 248 seconds] 21:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 21:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 252 seconds] 21:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 21:43 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 21:47 -!- tnull [~tnull@user/tnull/x-8645464] has joined #bitcoin-core-pr-reviews 21:47 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds] 21:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 248 seconds] 21:47 -!- tnull [~tnull@user/tnull/x-8645464] has quit [Client Quit] 21:58 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 22:04 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds] 22:05 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 22:09 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 248 seconds] 22:11 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 22:16 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds] 22:16 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews 22:20 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 260 seconds] 22:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 22:24 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 22:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 248 seconds] 22:28 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds] 22:28 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 22:33 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews 22:33 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 22:37 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 248 seconds] 22:39 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 22:41 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 22:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 246 seconds] 22:44 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews 22:49 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 255 seconds] 22:50 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 22:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 260 seconds] 23:00 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds] 23:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 23:06 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 256 seconds] 23:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 23:12 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 23:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 248 seconds] 23:18 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds] 23:18 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 23:23 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews 23:23 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 23:28 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 248 seconds] 23:29 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews 23:34 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 248 seconds] 23:34 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 23:37 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 23:40 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 23:40 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 23:42 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds] 23:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has quit [Ping timeout: 248 seconds] 23:46 -!- brunoerg [~brunoerg@187.183.43.178] has joined #bitcoin-core-pr-reviews 23:50 -!- brunoerg [~brunoerg@187.183.43.178] has quit [Ping timeout: 248 seconds] 23:54 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 23:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:477:c38e:8bc5:df7d] has joined #bitcoin-core-pr-reviews 23:58 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 248 seconds] --- Log closed Thu Jan 26 00:00:27 2023