--- Log opened Wed May 10 00:00:55 2023
--- Day changed Wed May 10 2023
00:00 -!- jomat [~jomat@2001:470:69fc:105::21] has quit [Quit: Bridge terminating on SIGTERM]
00:00 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has quit [Quit: Bridge terminating on SIGTERM]
00:00 -!- sipa [~sipa@user/sipa] has quit [Quit: Bridge terminating on SIGTERM]
00:00 -!- dunxen [~dunxen@2001:470:69fc:105::1:fec1] has quit [Quit: Bridge terminating on SIGTERM]
00:00 -!- sequences[m] [~sequences@2001:470:69fc:105::2:ffee] has quit [Quit: Bridge terminating on SIGTERM]
00:00 -!- stratospher[m] [~stratosph@2001:470:69fc:105::2:728e] has quit [Quit: Bridge terminating on SIGTERM]
00:00 -!- Murch [~murch@user/murch] has quit [Quit: Bridge terminating on SIGTERM]
00:01 -!- sr_gi[m] [~srgimatri@2001:470:69fc:105::1:c14c] has quit [Quit: Bridge terminating on SIGTERM]
00:01 -!- ishaanam[m] [~ishaanamm@2001:470:69fc:105::2:4078] has quit [Quit: Bridge terminating on SIGTERM]
00:01 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has quit [Quit: Bridge terminating on SIGTERM]
00:23 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
00:28 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 240 seconds]
00:59 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
01:04 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 264 seconds]
01:40 -!- Murch [~murch@user/murch] has joined #bitcoin-core-pr-reviews
01:44 -!- jomat [~jomat@2001:470:69fc:105::21] has joined #bitcoin-core-pr-reviews
01:44 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-core-pr-reviews
01:44 -!- sipa [~sipa@user/sipa] has joined #bitcoin-core-pr-reviews
01:44 -!- sequences[m] [~sequences@2001:470:69fc:105::2:ffee] has joined #bitcoin-core-pr-reviews
01:44 -!- dunxen [~dunxen@2001:470:69fc:105::1:fec1] has joined #bitcoin-core-pr-reviews
01:48 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
01:53 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
02:06 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has joined #bitcoin-core-pr-reviews
02:22 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
02:27 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 240 seconds]
02:56 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:1152:641e:5d2:bb34] has joined #bitcoin-core-pr-reviews
03:01 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:1152:641e:5d2:bb34] has quit [Ping timeout: 264 seconds]
03:21 -!- sr_gi[m] [~srgimatri@2001:470:69fc:105::1:c14c] has joined #bitcoin-core-pr-reviews
03:21 -!- stratospher[m] [~stratosph@2001:470:69fc:105::2:728e] has joined #bitcoin-core-pr-reviews
03:21 -!- ishaanam[m] [~ishaanamm@2001:470:69fc:105::2:4078] has joined #bitcoin-core-pr-reviews
03:29 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:1152:641e:5d2:bb34] has joined #bitcoin-core-pr-reviews
03:34 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:1152:641e:5d2:bb34] has quit [Ping timeout: 240 seconds]
03:42 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
04:24 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds]
04:54 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Remote host closed the connection]
04:54 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:1152:641e:5d2:bb34] has joined #bitcoin-core-pr-reviews
04:59 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:1152:641e:5d2:bb34] has quit [Ping timeout: 264 seconds]
05:19 -!- Zenton [~user@user/zenton] has quit [Ping timeout: 250 seconds]
06:14 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:1152:641e:5d2:bb34] has joined #bitcoin-core-pr-reviews
06:19 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:1152:641e:5d2:bb34] has quit [Ping timeout: 265 seconds]
06:36 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
07:59 -!- mutex [~mutex@108-213-70-206.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-pr-reviews
08:04 -!- Zenton [~user@user/zenton] has joined #bitcoin-core-pr-reviews
08:07 -!- mutex [~mutex@108-213-70-206.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving]
08:27 -!- pablomartin4btc_ [~pablomart@138.199.63.210] has joined #bitcoin-core-pr-reviews
08:29 -!- pablomartin4btc_ [~pablomart@138.199.63.210] has quit [Client Quit]
08:40 -!- pablomartin [~pablomart@138.199.63.210] has joined #bitcoin-core-pr-reviews
08:47 -!- ___nick___ [~quassel@host86-164-104-11.range86-164.btcentralplus.com] has joined #bitcoin-core-pr-reviews
08:50 -!- ___nick___ [~quassel@host86-164-104-11.range86-164.btcentralplus.com] has quit [Client Quit]
08:52 -!- ___nick___ [~quassel@host86-164-104-11.range86-164.btcentralplus.com] has joined #bitcoin-core-pr-reviews
09:36 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews
09:39 -!- jonatack [~jonatack@user/jonatack] has quit [Client Quit]
09:47 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has left #bitcoin-core-pr-reviews []
09:47 -!- jomat [~jomat@2001:470:69fc:105::21] has left #bitcoin-core-pr-reviews []
09:47 -!- sequences[m] [~sequences@2001:470:69fc:105::2:ffee] has left #bitcoin-core-pr-reviews []
09:47 -!- sipa [~sipa@user/sipa] has left #bitcoin-core-pr-reviews []
09:47 -!- dunxen [~dunxen@2001:470:69fc:105::1:fec1] has left #bitcoin-core-pr-reviews []
09:47 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-core-pr-reviews
09:47 -!- sipa [~sipa@user/sipa] has joined #bitcoin-core-pr-reviews
09:47 -!- jomat [~jomat@2001:470:69fc:105::21] has joined #bitcoin-core-pr-reviews
09:47 -!- dunxen [~dunxen@2001:470:69fc:105::1:fec1] has joined #bitcoin-core-pr-reviews
09:47 -!- sequences[m] [~sequences@2001:470:69fc:105::2:ffee] has joined #bitcoin-core-pr-reviews
09:47 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has left #bitcoin-core-pr-reviews []
09:47 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has joined #bitcoin-core-pr-reviews
09:50 < kevkevin> ping
09:53 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews
09:55 -!- abubakarsadiq [~abubakars@197.210.71.209] has joined #bitcoin-core-pr-reviews
09:59 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has joined #bitcoin-core-pr-reviews
09:59 -!- kevkevin59 [~kevkevin@c-98-226-43-69.hsd1.il.comcast.net] has joined #bitcoin-core-pr-reviews
09:59 -!- kevkevin59 [~kevkevin@c-98-226-43-69.hsd1.il.comcast.net] has quit [Client Quit]
10:00 < stickies-v> #startmeeting
10:00 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has joined #bitcoin-core-pr-reviews
10:00 < kevkevin> hi
10:01 < pablomartin> hello
10:01 < stickies-v> welcome everyone! Today we're looking at #26485, authored by ryanofsky. The notes and questions are available on https://bitcoincore.reviews/26485
10:01 < effexzi> Hi every1
10:01 < abubakarsadiq> hello
10:01 < stickies-v> anyone joining us for the first time today? even if you're just lurking, feel free to say hi!
10:02 < stickies-v> who got the chance to review the PR or read the notes? (y/n)
10:02 < kevkevin> n
10:02 -!- Autumn [~Autumn@42.106.237.143] has joined #bitcoin-core-pr-reviews
10:02 -!- mutex [~mutex@108-213-70-206.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-pr-reviews
10:02 < kevkevin> well read some of the notes
10:02 < pablomartin> n - not yet, it was on my list of pendings
10:03 < abubakarsadiq> I read the PR and concept Ack
10:04 -!- AlexWiederin [~AlexWiede@5.151.70.133] has joined #bitcoin-core-pr-reviews
10:04 < stickies-v> nice one abubakarsadiq ! looks like not too many have gone in-depth so we can stay a bit more on the high level too, today, let's see.
10:04 < stickies-v> how would you summarize this PR in your own words?
10:04 < LarryRuane> hi
10:05 -!- Autumn is now known as AutumnSunshine
10:05 -!- guestguest [~guestgues@136.53.35.244] has joined #bitcoin-core-pr-reviews
10:05 < pablomartin> it adds a possibilty to avoid verbose options and passing "named args" as a dict
10:05 < yashraj> this PR simplifies the syntax of some RPC commands?
10:06 < stickies-v> pablomartin: could you go in a bit more detail on the "passing named args as a dict" bit?
10:06 < abubakarsadiq> the PR enables rpc options parameter keys to be also passed as parameters
10:06 < stickies-v> yashraj: is it a backwards compatible simplification?
10:07 < pablomartin> sorry, the other way around, haha, my bad... instead of options='{"fee_rate": 10}' as a named arg fee_rate=10
10:07 < stickies-v> abubakarsadiq: named parameters, to be precise! can they both be passed as an options items as well as a named parameter?
10:08 < pablomartin> *params, not args yeah
10:08 -!- guestguest [~guestgues@136.53.35.244] has quit [Client Quit]
10:08 < stickies-v> pablomartin: well, that's just the cli syntax. on the RPC side (which is the only thing this PR is touching), we're indeed passing named arguments as a dict/object, but that's nothing new - we already had named arguments
10:09 < pablomartin> true, i was referring to the bitcoin-cli side
10:09 < yashraj> stickies-v: yeah you can still use the options={}
10:09 < abubakarsadiq> you can pass as either named params or option items, I am not sure though
10:09 < stickies-v> yashraj: exactly! it's just an additional way to interface with RPC, applications can keep using the `options` parameter
10:09 < LarryRuane> I like how the PR updates all the tests to use the simplified syntax!
10:10 < LarryRuane> (er... i'm not sure if "all" but many at least)
10:10 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews
10:11 < stickies-v> abubakarsadiq: only one of both is allowed, but you can mix and match (pass some as options keys, and others as named args): https://github.com/bitcoin-core-review-club/bitcoin/commit/411485082c22b86e1224f60534fccf1e2bb8e8f3#diff-019ee7d5e66b74eac42199f64e08cd0e90af4603bb3c105e294665ea4b411219R460-R473
10:12 < stickies-v> LarryRuane: yeah, it definitely does make things more readable 👍
10:12 < stickies-v> Which function is responsible for checking if an `options` field is passed as a named parameter? What other approaches can you think of to achieve the same goal this PR is trying to achieve?
10:12 < abubakarsadiq> thanks stickes: talking about that whats fr?
10:13 < LarryRuane> Probably some of the tests should use the old syntax to make sure it doesn't break (and some may still, I didn't check)
10:13 < abubakarsadiq> transformNamedArguments
10:13 < stickies-v> abubakarsadiq: we'll get to that in a later question, actually!
10:13 < stickies-v> abubakarsadiq: yeah I did kinda give it away with my previous link already hahaha
10:14 < yashraj> u for real
10:14 < stickies-v> so, does anyone have ideas for alternative approaches for this PR?
10:14 < stickies-v> yashraj: ?
10:14 < abubakarsadiq> yeah :)
10:15 < yashraj> sorry, ignore!
10:15 < LarryRuane> another proposal is (was): https://github.com/bitcoin/bitcoin/pull/17356
10:15 < LarryRuane> but I haven't looked to see how it differs
10:17 < stickies-v> yeah, I still need to look into it myself actually hah
10:17 < stickies-v> alright, moving on
10:17 < stickies-v> The documentation for `send` lists `conf_target` both as a named argument (#2) as well as a field in `options`. When looking at the code, however, it seems like `conf_target` is defined only once. How is this possible?
10:17 < pablomartin> yeah, same LarryRuane... it seems simpler/ less changes... but not sure about the use of it
10:18 < stickies-v> (links: https://bitcoincore.org/en/doc/24.0.0/rpc/wallet/send/ , https://github.com/bitcoin/bitcoin/blob/6c7ebcc14b7908a67a8f8764b398e76c8fb4fe8b/src/wallet/rpc/spend.cpp#L1180-L1233 , https://github.com/bitcoin/bitcoin/blob/6c7ebcc14b7908a67a8f8764b398e76c8fb4fe8b/src/wallet/rpc/spend.cpp#L1180-L1233)
10:20 < abubakarsadiq> initially is their a reason why some arguments are passed through `options` not named parameters e.g `conf_target` for send rpc
10:21 < stickies-v> ohh that's a great question abubakarsadiq and actually one that i meant to cover in the previous question
10:22 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 265 seconds]
10:23 < stickies-v> named arguments have only been added to bitcoin core since v14.0
10:24 < stickies-v> and for RPCs with a lot of parameters, such as e.g. the `send` family, it's quite cumbersome to provide a whole bunch of null/default values for every single RPC call. 
10:24 < stickies-v> so the `options` parameter was used instead
10:24 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews
10:24 < stickies-v> and now we have both for backwards compatibility
10:25 < LarryRuane> would the old way eventually be removed? I'm guessing probably not?
10:25 < stickies-v> I think that's the main reason, but I wasn't there when all of this was done, so I may be missing something
10:25 < abubakarsadiq> thats cool, you can use any. thanks stickies-v.
10:26 < stickies-v> LarryRuane: seems pretty low priority, probably, at least until we more drastically overhaul the RPC interface?
10:26 < LarryRuane> stickies-v: +1 thanks
10:26 < stickies-v> (hint for the current question: https://github.com/bitcoin/bitcoin/blob/6c7ebcc14b7908a67a8f8764b398e76c8fb4fe8b/src/wallet/rpc/spend.cpp#L1231)
10:29 < pablomartin> indicates if /*named_only=*/?
10:31 < stickies-v> so my point is if you run `bitcoin-cli help send`, the help shows definitions for e.g. `conf_target` twice: once as a named parameter, and once as an `options` field. but in the code, we only seem to be defining it once
10:31 < stickies-v> but so the trick is that we sometimes just put a bunch of cli args in a function so we can reuse it in multiple places, which is what's happening here with https://github.com/bitcoin/bitcoin/blob/6c7ebcc14b7908a67a8f8764b398e76c8fb4fe8b/src/wallet/rpc/spend.cpp#L1231
10:32 < stickies-v> and then we use the `Cat` helper function to just concatenate both vectors: https://github.com/bitcoin/bitcoin/blob/6c7ebcc14b7908a67a8f8764b398e76c8fb4fe8b/src/wallet/rpc/spend.cpp#L1191
10:33 < abubakarsadiq> because because it's passed in FundTxDoc, with other args like pubkeys
10:33 < stickies-v> anyway, not something super relevant to the PR but i found interesting to highlight since it's a pattern used in quite a few methods
10:33 < LarryRuane> oh I see, it's in there also: https://github.com/bitcoin/bitcoin/blob/6c7ebcc14b7908a67a8f8764b398e76c8fb4fe8b/src/wallet/rpc/spend.cpp#L456
10:33 < stickies-v> abubakarsadiq: LarryRuane yup!
10:33 < stickies-v> Why does `RPCHelpMan::GetArgNames()` now return a `std::vector<std::pair<std::string, bool>>` instead of a `std::vector<std::string>`? What does the `bool` represent?
10:33 < pablomartin> I see
10:34 < stickies-v> (link: https://github.com/bitcoin-core-review-club/bitcoin/commit/411485082c22b86e1224f60534fccf1e2bb8e8f3#diff-647c2f0c4261e4ba2bbfc487178f54f4702ad284b52c1ed2dbbd30a53a5ad487R609)
10:35 < pablomartin> oh, my last answer was for this one actually
10:35 < LarryRuane> the comment for that function kind of gives it away: "Return list of arguments and whether they are named-only"
10:36 < pablomartin> like here: https://github.com/bitcoin-core-review-club/bitcoin/blob/411485082c22b86e1224f60534fccf1e2bb8e8f3/src/rpc/util.cpp#L657
10:37 < stickies-v> LarryRuane: yeah I guess it does haha, but why do we need to distinguish here between which arguments are named-only?
10:41 < stickies-v> the answer is pretty simple actually, we just want to be able to specify for which objects we enable passing keys as named parameters
10:42 < stickies-v> alright, moving on:
10:42 < yashraj> someone might use named-only with the options syntax?
10:42 < stickies-v> In `transformNamedArguments`, why do we use `__pushKV` instead of `pushKV`?
10:42 < stickies-v> (link: https://github.com/bitcoin-core-review-club/bitcoin/commit/411485082c22b86e1224f60534fccf1e2bb8e8f3#diff-019ee7d5e66b74eac42199f64e08cd0e90af4603bb3c105e294665ea4b411219R440)
10:42 < stickies-v> yashraj: this is an internal API, not something we'd expose to the end user
10:43 < stickies-v> whoever implements the RPC method needs to define the parameters and how they can be specified
10:45 < yashraj> thanks
10:45 < pablomartin> yeah you need to be able to distinguish cos you need to pass/ push it to a diff section
10:46 < LarryRuane> looks like __pushKV allows multiple of same key?
10:48 < stickies-v> pablomartin: oh yeah, absolutely, the end-user decides whether they pass positional or named args. but adding the `bool` as a `pair` item allows us to let the developer specify per-method how they want this behaviour to work, as opposed to for example automatically enabling it for all `OBJ` parameters, or for all `OBJ` parameters named `options`
10:48 < stickies-v> LarryRuane: exactly. (why) is that safe?
10:49 < LarryRuane> for anyone who would like a link: https://github.com/bitcoin/bitcoin/blob/e0a70c5b4f2c691e8d6b507c8ce879f0b0424254/src/univalue/lib/univalue.cpp#L118
10:50 < LarryRuane> oh because we've already checked that it doesn't exist: https://github.com/bitcoin-core-review-club/bitcoin/commit/411485082c22b86e1224f60534fccf1e2bb8e8f3#diff-019ee7d5e66b74eac42199f64e08cd0e90af4603bb3c105e294665ea4b411219R437
10:51 < pablomartin> stickies-v: thanks
10:51 < LarryRuane> so it's a small performance improvement (?)
10:53 < stickies-v> LarryRuane: yeah exactly. kinda like how even though when accessing a vector element it's safer and generally recommended to use `v.at(i)`, you'll often see `v[i]` used in our codebase but (typically/hopefully) only if we've ensured that `i` definitely is in range, because then it's just a bit faster
10:54 < stickies-v> alright abubakarsadiq now we're coming back to the q you had earlier
10:54 < stickies-v> What is the `fr` input parameter? Why are we handling this case separately?
10:54 < stickies-v> link: https://github.com/bitcoin-core-review-club/bitcoin/commit/411485082c22b86e1224f60534fccf1e2bb8e8f3#diff-019ee7d5e66b74eac42199f64e08cd0e90af4603bb3c105e294665ea4b411219R460-R462
10:55 < LarryRuane> stickies-v: +1 and also I'd say using `__pushKV` documents the code better... because it describes exactly what the effect will be
10:59 < stickies-v> i think (but didn't name the variable) that `fr` just stands for `find_result` or something (not a huge fan of 1-2 letter named variables...)
11:00 < LarryRuane> OH! that makes sense, I couldn't figure that out!
11:00 < stickies-v> we just want to check if we've already processed the key/value pair earlier, and if so throw an error, to avoid people passing the same parameter as option/positional/named parameter
11:00 < abubakarsadiq> yeah find_result is much better
11:00 < stickies-v> alright i think that's all for today folks, thank you for attending and see you next week!
11:01 < stickies-v> #endmeeting
11:01 < yashraj> fr
11:01 < LarryRuane> thank you, @stickies-v! This was great! sorry I wasn't better prepared
11:01 < yashraj> thanks stickies-v: for hosting
11:01 < abubakarsadiq> thanks for hosting stickies-v. 
11:01 -!- AlexWiederin [~AlexWiede@5.151.70.133] has quit [Quit: Connection closed]
11:01 < stickies-v> yashraj: hahaha `for_real` is also a possibility
11:02 < yashraj> :)
11:02 < LarryRuane> you'd think argument processing would be pretty simple, but amazing how complicated it can get! (not a criticism, it's good engineering)
11:03 < pablomartin> thanks stickies-v! thanks all!
11:03 < abubakarsadiq> +1 LarryRuane
11:04 < stickies-v> LarryRuane: yeah, and in most other projects you'd probably just use a third party library for those kinds of things
11:07 -!- AutumnSunshine [~Autumn@42.106.237.143] has left #bitcoin-core-pr-reviews []
11:13 -!- pablomartin [~pablomart@138.199.63.210] has quit [Remote host closed the connection]
11:13 -!- pablomartin [~pablomart@138.199.63.210] has joined #bitcoin-core-pr-reviews
11:16 -!- abubakarsadiq [~abubakars@197.210.71.209] has quit [Quit: Lost terminal]
11:22 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has quit []
11:27 -!- pablomartin [~pablomart@138.199.63.210] has quit [Ping timeout: 264 seconds]
11:29 -!- b_101_ [~robert@185.180.13.45.adsl.inet-telecom.org] has joined #bitcoin-core-pr-reviews
11:30 -!- b_101 [~robert@189.236.26.199] has quit [Ping timeout: 240 seconds]
11:38 -!- b_101_ [~robert@185.180.13.45.adsl.inet-telecom.org] has quit [Ping timeout: 265 seconds]
12:14 -!- mutex [~mutex@108-213-70-206.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving]
12:20 -!- b_101 [~robert@189.236.7.141] has joined #bitcoin-core-pr-reviews
12:34 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
13:04 -!- ___nick___ [~quassel@host86-164-104-11.range86-164.btcentralplus.com] has quit [Ping timeout: 240 seconds]
13:09 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity]
13:23 -!- kevkevin [~kevkevin@2601:241:8703:7b30:69bc:82a9:e070:345a] has quit [Remote host closed the connection]
14:05 -!- kevkevin [~kevkevin@173-15-26-57-Illinois.hfc.comcastbusiness.net] has joined #bitcoin-core-pr-reviews
14:09 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Remote host closed the connection]
14:10 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
14:15 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has quit [Ping timeout: 265 seconds]
14:29 -!- __gotcha [~Thunderbi@94.105.119.42.dyn.edpnet.net] has quit [Ping timeout: 248 seconds]
14:31 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
14:36 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has quit [Ping timeout: 264 seconds]
14:41 -!- __gotcha [~Thunderbi@94.105.119.42.dyn.edpnet.net] has joined #bitcoin-core-pr-reviews
14:46 -!- __gotcha [~Thunderbi@94.105.119.42.dyn.edpnet.net] has quit [Ping timeout: 264 seconds]
14:52 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
14:56 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has quit [Ping timeout: 265 seconds]
15:07 -!- gyedt [~gyedt@81.184.64.85.dyn.user.ono.com] has joined #bitcoin-core-pr-reviews
15:11 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
15:15 -!- gyedt [~gyedt@81.184.64.85.dyn.user.ono.com] has quit [Quit: Ping timeout (120 seconds)]
15:16 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has quit [Ping timeout: 264 seconds]
15:18 -!- kevkevin [~kevkevin@173-15-26-57-Illinois.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
15:38 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
15:43 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has quit [Ping timeout: 265 seconds]
15:57 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
16:02 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has quit [Ping timeout: 264 seconds]
16:47 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
16:52 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has quit [Ping timeout: 264 seconds]
17:00 -!- b_101_ [~robert@185.242.5.35] has joined #bitcoin-core-pr-reviews
17:02 -!- b_101 [~robert@189.236.7.141] has quit [Ping timeout: 256 seconds]
17:06 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
17:11 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has quit [Ping timeout: 265 seconds]
17:24 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
17:28 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 264 seconds]
18:04 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
18:09 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has quit [Ping timeout: 265 seconds]
18:27 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
18:31 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has quit [Ping timeout: 240 seconds]
18:38 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
18:43 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 264 seconds]
19:22 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
19:27 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has quit [Ping timeout: 264 seconds]
19:45 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
19:49 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has quit [Ping timeout: 265 seconds]
20:02 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
20:07 -!- grettke [~grettke@065-026-198-174.biz.spectrum.com] has quit [Quit: grettke]
20:07 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has quit [Ping timeout: 264 seconds]
20:08 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
20:13 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has quit [Ping timeout: 265 seconds]
20:21 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
20:26 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has quit [Ping timeout: 264 seconds]
20:43 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
20:48 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
21:04 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
21:09 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 240 seconds]
21:23 -!- b_101_ [~robert@185.242.5.35] has quit [Ping timeout: 265 seconds]
21:26 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
21:31 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has quit [Ping timeout: 264 seconds]
21:50 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
21:55 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has quit [Ping timeout: 265 seconds]
21:57 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
22:01 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 240 seconds]
22:13 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
22:18 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has quit [Ping timeout: 264 seconds]
22:36 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
22:40 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has quit [Ping timeout: 265 seconds]
22:46 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
22:52 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has quit [Ping timeout: 264 seconds]
22:58 -!- b_101 [~robert@185.242.5.35] has joined #bitcoin-core-pr-reviews
23:03 -!- b_101 [~robert@185.242.5.35] has quit [Ping timeout: 240 seconds]
23:15 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
23:19 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
23:43 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
23:47 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 240 seconds]
23:59 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:3594:8a78:c69a:3bd4] has joined #bitcoin-core-pr-reviews
--- Log closed Thu May 11 00:00:58 2023