--- Log opened Thu May 25 00:00:11 2023
00:00 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
00:05 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 256 seconds]
00:27 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:7108:9225:17ed:74d4] has joined #bitcoin-core-pr-reviews
00:32 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:7108:9225:17ed:74d4] has quit [Ping timeout: 265 seconds]
00:33 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:7108:9225:17ed:74d4] has joined #bitcoin-core-pr-reviews
00:38 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:7108:9225:17ed:74d4] has quit [Ping timeout: 246 seconds]
00:41 -!- b_101 [~robert@189.236.6.88] has joined #bitcoin-core-pr-reviews
00:46 -!- b_101 [~robert@189.236.6.88] has quit [Ping timeout: 240 seconds]
01:01 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:7108:9225:17ed:74d4] has joined #bitcoin-core-pr-reviews
01:06 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:7108:9225:17ed:74d4] has quit [Ping timeout: 264 seconds]
01:12 -!- pablomartin [~pablomart@5.226.142.10] has joined #bitcoin-core-pr-reviews
01:46 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:7108:9225:17ed:74d4] has joined #bitcoin-core-pr-reviews
01:50 -!- __gotcha [~Thunderbi@natx-145.kulnet.kuleuven.be] has joined #bitcoin-core-pr-reviews
01:56 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:7108:9225:17ed:74d4] has quit [Ping timeout: 265 seconds]
01:57 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:7108:9225:17ed:74d4] has joined #bitcoin-core-pr-reviews
02:02 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:7108:9225:17ed:74d4] has quit [Ping timeout: 264 seconds]
02:08 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:7108:9225:17ed:74d4] has joined #bitcoin-core-pr-reviews
02:13 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:7108:9225:17ed:74d4] has quit [Ping timeout: 240 seconds]
02:30 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:7108:9225:17ed:74d4] has joined #bitcoin-core-pr-reviews
02:35 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:7108:9225:17ed:74d4] has quit [Ping timeout: 264 seconds]
02:36 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:7108:9225:17ed:74d4] has joined #bitcoin-core-pr-reviews
02:43 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:7108:9225:17ed:74d4] has quit [Ping timeout: 240 seconds]
03:15 < stickies-v> we're thinking about changing the frequency of the review club, and would love your input on glozow's proposal on https://github.com/bitcoin-core-review-club/website/issues/684
03:15 -!- in3rsha [~in3rsha@138.199.6.227] has joined #bitcoin-core-pr-reviews
03:30 -!- __gotcha [~Thunderbi@natx-145.kulnet.kuleuven.be] has quit [Ping timeout: 246 seconds]
04:12 -!- b_101 [~robert@189.236.6.88] has joined #bitcoin-core-pr-reviews
04:16 -!- b_101 [~robert@189.236.6.88] has quit [Ping timeout: 250 seconds]
04:23 -!- martinus_ [~martinus@213142096115.public.telering.at] has quit [Remote host closed the connection]
04:56 -!- __gotcha [~Thunderbi@natx-145.kulnet.kuleuven.be] has joined #bitcoin-core-pr-reviews
05:02 -!- evansmj [~evansmj@66.135.146.144] has quit [Quit: Connection closed]
05:02 -!- martinus [~martinus@212095005102.public.telering.at] has joined #bitcoin-core-pr-reviews
05:08 -!- martinus [~martinus@212095005102.public.telering.at] has quit [Read error: Connection reset by peer]
05:08 -!- martinus [~martinus@212095005102.public.telering.at] has joined #bitcoin-core-pr-reviews
05:54 < darosior> Makes sense.
06:34 -!- evansmj [~evansmj@170.55.118.200] has joined #bitcoin-core-pr-reviews
06:40 < pablomartin> I agree... left my opinion on the issue linked above.
06:50 < stickies-v> thanks both 👍
06:55 -!- b_101 [~robert@189.236.6.88] has joined #bitcoin-core-pr-reviews
06:56 < evansmj> you can ignore if this is a dumb question, but i was going through the tests and got all the way to the Finalizing a PSBT test, and now when i try to run bitcoind-test i get "Unable to bind any endpoint for RPC server".  I've deleted and recreated all of the setup steps over and looked online but im not entirely sure whats going on.  fails
06:56 < evansmj> Binding RPC on address "::1" and "127.0.0.1" on ports 18443.  i tried setting an rpcuser and password but i didn't get anywhere.  when trying to run bcli commands i get "error: Could not locate RPC credentials. No authentication cookie could be found, and RPC password is not set."
06:59 < stickies-v> evansmj: are you running `bitcoind` with a custom `-datadir`? if so, you need to pass that also run `bitcoin-cli` with that `-datadir` argument (or alternatively setup RPC credentials)
07:00 -!- b_101 [~robert@189.236.6.88] has quit [Ping timeout: 240 seconds]
07:01 < evansmj> i used the datadir from the testing guide yes and i set these:
07:01 < evansmj> alias bitcoind-test="$(echo $BINARY_PATH)/bitcoind -datadir=$DATA_DIR"
07:01 < evansmj> alias bcli="$(echo $BINARY_PATH)/bitcoin-cli -datadir=$DATA_DIR"
07:02 < evansmj> and i did set the binary path from the built src directory
07:04 < stickies-v> could you maybe create a gist/pastebin with all the commands you're executing and then send the link here so I can try to replicate?
07:13 < evansmj> https://gist.github.com/evansmj/df0840dafc5858e263844841a03df630
07:15 -!- evansmj2 [~evansmj2@170.55.118.200] has joined #bitcoin-core-pr-reviews
07:15 -!- evansmj2 [~evansmj2@170.55.118.200] has quit [Client Quit]
07:17 < evansmj> here it is, it was all working earlier for the first tests, only for the PSBT one is where it suddenly stopped working https://kiwiirc.com/nextclient/irc.libera.chat?channel=#bitcoin-core-pr-reviews
07:20 < stickies-v> I think you might have another instance of bitcoind on -regtest running already that's preventing this one to bind on those ports? a nuclear option would be to run `pkill bitcoind` and then try again (but make sure it doesn't force kill e.g. your mainnet bitcoind if you have that running on the same machine)
07:20 < evansmj> wow thanks that was it, thanks a lot
07:21 < stickies-v> np, thanks for providing those steps to reproduce, that makes helping so much easier
07:23 < stickies-v> whenever running `bitcoind -daemon` (as is done in the testing guide) it's pretty common to forget killing it again afterwards (at least for me 🤷)
07:44 < evansmj> should we note that in the guide somewhere?  im not sure if it makes sense to add it to the 4. Reset testing environment step.  its not strictly a testing phenomenon so idk
07:45 -!- b_101 [~robert@189.236.6.88] has joined #bitcoin-core-pr-reviews
07:50 -!- b_101 [~robert@189.236.6.88] has quit [Ping timeout: 240 seconds]
08:18 -!- b_101 [~robert@189.236.6.88] has joined #bitcoin-core-pr-reviews
08:23 -!- b_101 [~robert@189.236.6.88] has quit [Ping timeout: 240 seconds]
08:44 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews
09:02 -!- __gotcha [~Thunderbi@natx-145.kulnet.kuleuven.be] has quit [Ping timeout: 240 seconds]
09:02 < stickies-v> evansmj: cc abubakarsadiq yeah i think adding a `bcli stop` command at the end of every section that started with running bitcoind in `-daemon` mode makes sense 
09:03 -!- b_101 [~robert@189.236.6.88] has joined #bitcoin-core-pr-reviews
09:08 -!- b_101 [~robert@189.236.6.88] has quit [Ping timeout: 240 seconds]
09:42 < abubakarsadiq> Yeah, to avoid such issues. I remember I had to pkill bitcoind which has to stop all my bitcoin nodes running, thanks for pointing that out evansmj, also thanks stickies-v for the ping
10:12 -!- b_101 [~robert@189.236.6.88] has joined #bitcoin-core-pr-reviews
10:17 -!- b_101 [~robert@189.236.6.88] has quit [Ping timeout: 240 seconds]
10:41 -!- b_101 [~robert@189.236.6.88] has joined #bitcoin-core-pr-reviews
10:49 < evansmj> great glad i could contribute
10:49 -!- ___nick___ [~quassel@host86-169-197-175.range86-169.btcentralplus.com] has joined #bitcoin-core-pr-reviews
10:55 -!- anjannath [~anjannath@user/anjannath] has left #bitcoin-core-pr-reviews []
11:03 -!- Zenton [~user@user/zenton] has quit [Remote host closed the connection]
11:18 -!- Zenton [~user@user/zenton] has joined #bitcoin-core-pr-reviews
12:07 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:13 < evansmj> having issues with Test unloadwallet fails if a rescan is in progress, if i open a new terminal my bcli is not able to find the bitcoind-test -daemon that is running already.  I did run the alias commands again.  if i try to use any bcli command in the other terminal it isn't able to detect it running.  is there a trick to this?
12:27 < evansmj> i figured it out, you need to also do the export bash commands in the new window.
12:27 < evansmj> export DATA_DIR=/tmp/25-rc-test
12:27 < evansmj> export BINARY_PATH=$(pwd)/src
12:43 -!- grettke [~grettke@065-026-198-174.biz.spectrum.com] has quit [Read error: Connection reset by peer]
12:43 -!- grettke_ [~grettke@065-026-198-174.biz.spectrum.com] has joined #bitcoin-core-pr-reviews
12:54 -!- ___nick___ [~quassel@host86-169-197-175.range86-169.btcentralplus.com] has quit [Ping timeout: 240 seconds]
13:15 < evansmj> where is the hello.txt supposed to be found?  i dont see it anywhere.  command fails with "bcli touch hello.txt", so i used what someone else commented, "touch hello.txt" but i dont see it in tmp nor the project dir
13:16 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
13:16 < evansmj> ah nvm, found it in my user dir on the machine
13:59 -!- grettke_ is now known as grettke
14:31 -!- neha_ [~neha@41.213.196.104.bc.googleusercontent.com] has joined #bitcoin-core-pr-reviews
14:31 -!- evansmj [~evansmj@170.55.118.200] has quit [Quit: Connection closed]
14:32 -!- lowhope___ [~lowhope@cow9.org] has joined #bitcoin-core-pr-reviews
14:37 -!- Netsplit *.net <-> *.split quits: lowhope_, neha, elichai2, kevkevin
14:37 -!- lowhope___ is now known as lowhope
14:54 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-pr-reviews
14:57 < abubakarsadiq> evansmj the trick is to add all the alias in /.bashrc worked for me, also I think this is also worth pointing out in the guide, thanks again for your through test
14:58 < abubakarsadiq> evansmj yes the second issue was reported on the issues also. 👍
15:04 -!- Netsplit over, joins: elichai2
15:21 -!- kevkevin [~kevkevin@173-15-26-57-Illinois.hfc.comcastbusiness.net] has joined #bitcoin-core-pr-reviews
16:04 -!- kevkevin [~kevkevin@173-15-26-57-Illinois.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
16:19 -!- in3rsha [~in3rsha@138.199.6.227] has quit [Remote host closed the connection]
17:36 -!- casiojapi [~casiojapi@2800:40:1b:2d5:95dd:a2fa:b487:1a61] has joined #bitcoin-core-pr-reviews
17:45 -!- casiojapi [~casiojapi@2800:40:1b:2d5:95dd:a2fa:b487:1a61] has quit [Quit: Leaving...]
19:19 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:ed17:b04c:4ae4:e0e7] has joined #bitcoin-core-pr-reviews
19:23 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
20:14 -!- grettke [~grettke@065-026-198-174.biz.spectrum.com] has quit [Quit: grettke]
21:02 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:ed17:b04c:4ae4:e0e7] has quit [Remote host closed the connection]
21:04 -!- b_101 [~robert@189.236.6.88] has quit [Ping timeout: 240 seconds]
21:10 -!- b_101 [~robert@189.236.6.88] has joined #bitcoin-core-pr-reviews
21:15 -!- b_101 [~robert@189.236.6.88] has quit [Ping timeout: 240 seconds]
21:52 -!- b_101 [~robert@189.236.6.88] has joined #bitcoin-core-pr-reviews
21:57 -!- b_101 [~robert@189.236.6.88] has quit [Ping timeout: 240 seconds]
23:45 -!- b_101 [~robert@189.236.6.88] has joined #bitcoin-core-pr-reviews
23:50 -!- b_101 [~robert@189.236.6.88] has quit [Ping timeout: 246 seconds]
--- Log closed Fri May 26 00:00:13 2023