--- Log opened Wed May 31 00:00:07 2023
--- Day changed Wed May 31 2023
00:00 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 240 seconds]
00:29 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
00:32 -!- puchka [~puchka@185.203.122.82] has joined #bitcoin-core-pr-reviews
00:33 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 240 seconds]
00:45 -!- Guest31 [~Guest31@105.162.20.130] has joined #bitcoin-core-pr-reviews
00:46 -!- Guest31 [~Guest31@105.162.20.130] has quit [Client Quit]
00:50 -!- b_101 [~robert@189.236.5.138] has joined #bitcoin-core-pr-reviews
00:54 -!- b_101 [~robert@189.236.5.138] has quit [Ping timeout: 250 seconds]
01:02 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
01:07 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 256 seconds]
01:23 -!- __gotcha [~Thunderbi@94.105.119.44.dyn.edpnet.net] has joined #bitcoin-core-pr-reviews
01:27 -!- __gotcha [~Thunderbi@94.105.119.44.dyn.edpnet.net] has quit [Ping timeout: 250 seconds]
01:35 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
01:40 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 265 seconds]
02:11 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
02:15 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 246 seconds]
02:24 -!- b_101 [~robert@189.236.5.138] has joined #bitcoin-core-pr-reviews
02:28 -!- b_101 [~robert@189.236.5.138] has quit [Ping timeout: 250 seconds]
02:35 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
02:40 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 256 seconds]
02:44 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
02:51 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 248 seconds]
02:52 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
02:57 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 265 seconds]
03:27 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
03:31 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 265 seconds]
03:34 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-pr-reviews
03:45 -!- puchka [~puchka@185.203.122.82] has quit [Ping timeout: 268 seconds]
03:49 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
03:54 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 250 seconds]
03:55 -!- puchka [~puchka@185.203.122.200] has joined #bitcoin-core-pr-reviews
04:17 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
04:23 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 248 seconds]
04:29 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
04:34 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 250 seconds]
04:57 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
05:02 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 265 seconds]
05:03 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
05:08 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 248 seconds]
05:08 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
05:13 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 265 seconds]
05:16 -!- pablomartin [~pablomart@185.128.9.11] has joined #bitcoin-core-pr-reviews
05:28 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
05:33 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 250 seconds]
05:39 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
05:44 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 250 seconds]
06:11 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
06:16 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 250 seconds]
06:30 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
07:28 -!- MatrixBot123456 [~matrixbot@2001:bc8:1824:bc3::1] has quit [Quit: Bridge terminating on SIGTERM]
07:31 -!- MatrixBot123456 [~matrixbot@2001:bc8:1824:bc3::1] has joined #bitcoin-core-pr-reviews
07:40 -!- b_101 [~robert@189.236.5.138] has joined #bitcoin-core-pr-reviews
07:44 -!- b_101 [~robert@189.236.5.138] has quit [Ping timeout: 248 seconds]
08:09 -!- grettke [~grettke@065-026-198-174.biz.spectrum.com] has joined #bitcoin-core-pr-reviews
08:10 -!- pharonix71 [~pharonix7@user/pharonix71] has quit [Remote host closed the connection]
08:10 -!- pharonix71 [~pharonix7@user/pharonix71] has joined #bitcoin-core-pr-reviews
08:27 -!- b_101 [~robert@189.236.5.138] has joined #bitcoin-core-pr-reviews
08:31 -!- b_101 [~robert@189.236.5.138] has quit [Ping timeout: 240 seconds]
09:02 -!- __gotcha [~Thunderbi@94.105.119.44.dyn.edpnet.net] has joined #bitcoin-core-pr-reviews
09:03 -!- __gotcha1 [~Thunderbi@94.105.119.44.dyn.edpnet.net] has joined #bitcoin-core-pr-reviews
09:03 -!- __gotcha [~Thunderbi@94.105.119.44.dyn.edpnet.net] has quit [Read error: Connection reset by peer]
09:03 -!- __gotcha1 is now known as __gotcha
09:05 -!- __gotcha1 [~Thunderbi@94.105.119.44.dyn.edpnet.net] has joined #bitcoin-core-pr-reviews
09:05 -!- __gotcha [~Thunderbi@94.105.119.44.dyn.edpnet.net] has quit [Read error: Connection reset by peer]
09:05 -!- __gotcha1 is now known as __gotcha
09:17 -!- pablomartin [~pablomart@185.128.9.11] has quit [Remote host closed the connection]
09:22 -!- __gotcha1 [~Thunderbi@94.105.119.44.dyn.edpnet.net] has joined #bitcoin-core-pr-reviews
09:22 -!- __gotcha [~Thunderbi@94.105.119.44.dyn.edpnet.net] has quit [Read error: Connection reset by peer]
09:22 -!- __gotcha1 is now known as __gotcha
09:23 -!- ccdle12 [~ccdle12@243.222.90.149.rev.vodafone.pt] has joined #bitcoin-core-pr-reviews
09:25 -!- __gotcha1 [~Thunderbi@94.105.119.44.dyn.edpnet.net] has joined #bitcoin-core-pr-reviews
09:26 -!- pablomartin [~pablomart@77-74-192-228.as42831.net] has joined #bitcoin-core-pr-reviews
09:27 -!- __gotcha [~Thunderbi@94.105.119.44.dyn.edpnet.net] has quit [Ping timeout: 240 seconds]
09:27 -!- __gotcha1 is now known as __gotcha
09:28 -!- hernanmarino [~hernanmar@190.245.116.245] has joined #bitcoin-core-pr-reviews
09:28 -!- hernanmarino_ [~hernanmar@190.245.116.245] has joined #bitcoin-core-pr-reviews
09:28 -!- hernanmarino_ [~hernanmar@190.245.116.245] has quit [Client Quit]
09:31 -!- kevkevin [~kevkevin@2601:241:8703:7b30:39f9:af12:2f93:daf3] has joined #bitcoin-core-pr-reviews
09:33 < kevkevin> ping
09:34 < stickies-v> pong?
09:34 < kevkevin> thanks!
09:35 -!- SebastianvStaa [~Sebastian@45.128.199.6] has joined #bitcoin-core-pr-reviews
09:38 -!- SebastianvStaa [~Sebastian@45.128.199.6] has quit [Client Quit]
09:40 -!- SebastianvStaa [~Sebastian@45.128.199.57] has joined #bitcoin-core-pr-reviews
09:43 -!- Pins [~Pins@179.209.140.115] has joined #bitcoin-core-pr-reviews
09:49 -!- __gotcha [~Thunderbi@94.105.119.44.dyn.edpnet.net] has quit [Ping timeout: 250 seconds]
09:59 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has joined #bitcoin-core-pr-reviews
09:59 -!- ranemirus [~ranemirus@104.28.217.122] has joined #bitcoin-core-pr-reviews
10:00 < josie> #startmeeting
10:00 < josie> hi! 
10:00 < abubakarsadiq> Hi
10:00 < kevkevin> hi
10:00 < glozow> hi
10:00 < LarryRuane> hi
10:00 < Pins> hi
10:00 < ranemirus> hi
10:00 < pablomartin> hello
10:00 < hernanmarino> Hi
10:00 < effexzi> Hi every1 
10:01 < SebastianvStaa> hi
10:01 < josie> welcome to this week's PR review club. any first timers here?
10:01 < Pins> Me
10:01 < josie> Pins: welcome! 
10:01 < Pins> Thanks!
10:01 < glozow> Pins: welcome!
10:02 < josie> just a general reminder: don't hesitate to ask a question or speak up (no need to ask if its okay to ask)
10:02 < josie> first question: did you get a chance to review the PR?
10:03 < josie> (can respond with a y/n)
10:03 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has joined #bitcoin-core-pr-reviews
10:03 < SebastianvStaa> y
10:03 < kevkevin> n :(
10:03 < abubakarsadiq> y
10:03 < hernanmarino> n, just lurking today 
10:03 < pablomartin> same
10:03 < Pins> y
10:03 < josie> if you did review it, what was your approach? and what's your conclusion? concept/approach ack, or nack?
10:03 -!- ishaana [~ishaana@165.155.171.167] has joined #bitcoin-core-pr-reviews
10:03 < josie> lurking is always fine :) 
10:04 < hernanmarino> From a light reading , approach ACK .
10:05 < abubakarsadiq> Tested Ack I, run the test on the PR it passed, and also run the functional test on master to ensure the test fail.
10:05 < SebastianvStaa> same here
10:05 < ishaana> hi
10:05 < LarryRuane> abubakarsadiq: same
10:05 < josie> abubakarsadiq: nice! I was curious if anyone got a chance to run the test on master before the PR got merged
10:06 < stickies-v> (and if you didnt before it got merged, you still can, of course: https://github.com/bitcoin-core-review-club/website/pull/685#discussion_r1211727602)
10:07 < josie> stickies-v: thanks for the link!
10:07 < abubakarsadiq> Yeah, thats what I did, thanks for the link and help stickies-v
10:07 < josie> so question 2: what issue does this PR address? can you reproduce the problem?
10:08 < josie> (for those who ran the test on master pre-merge, this should be an easy question :D) 
10:09 < abubakarsadiq> This PR address issue whereby if a block is disconnected, the state of all the transaction in the block that our node/wallet know will change to inactive and have 0 confirmations. 
10:09 < josie> (also, forgot to post this at the beginning! we are discussing: https://bitcoincore.reviews/27145)
10:10 < SebastianvStaa> On master, formerly conflicted txns are not set from conflicted to inactive after reorg
10:10 < SebastianvStaa> (reorginging out of the conflicted txn)
10:11 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews
10:13 < josie> SebastianvStaa: yep! before this PR, txs marked as conflicted were not being updated to the correct state of inactive when relevant 
10:15 < josie> abubakarsadiq: I didn't actually verify what the behavior was before this PR, so you maybe correct. I'd say the main issue this PR attempts to address is *not* marking txs as inactive on blockDisconnect, when they should be marked inactive 
10:15 < josie> unrelated question: did anyone get a chance to read the wiki or the gist linked in the notes? if not, I'd recommend it! I learned a lot about re-orgs and transaction states by reading them 
10:16 < glozow> indeed! https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Wallet-Transaction-Conflict-Tracking
10:16 -!- b_101 [~robert@189.236.5.138] has joined #bitcoin-core-pr-reviews
10:16 < glozow> https://gist.github.com/ishaanam/846adf3b453c3a85fe6e15c882c57ae0#locations-where-tx-states-are-updated
10:17 < josie> okay, moving on to question 3: what are the different states a CWalletTx (a transaction known by the wallet) can be in?
10:17 < josie> glozow: thanks! 
10:17 < abubakarsadiq> thanks josie
10:17 < SebastianvStaa> TxStateConfirmed: Contains corresponding block information
10:17 < SebastianvStaa> TxStateInMempool
10:17 < SebastianvStaa> TxStateConflicted: Contains corresponding conflicting block information
10:17 < SebastianvStaa> TxStateInactive: Can be abandoned or not
10:17 < SebastianvStaa> TxStateUnrecognized: Treated as inactive
10:18 < abubakarsadiq> Inactive, Confirmed, Conflicted, InMempool, and Unrecognized
10:18 -!- wim96 [~wim96@193.176.31.66] has joined #bitcoin-core-pr-reviews
10:19 < josie> SebastianvStaa, abubakarsadiq: yep! curious what you think about Unrecognized? I was trying to think of an example of an Unrecognized state and couldn't come up with one 
10:20 < SebastianvStaa> josie don't know yet. Just looked up the state definitons in the code
10:20 < abubakarsadiq> Josie, Are they transaction whose inputs are known to the node?
10:21 < josie> yeah, same. Unrecognized stuck out to me tho, as it seems like this is an area we should be able to account for everything 
10:21 < glozow> what does a tx state start as if you created but couldnt broadcast it (yet)?
10:22 < glozow> or would that never go to mapwallet?
10:22 < josie> abubakarsadiq: it's certainly possible to have external inputs in a tx, but I don't think this would apply here as the inputs would either be in a confirmed or unconfirmed state. if its confirmed the node definitely knows about it since it appears in a block
10:22 < ishaana> glozow: TxStateInactive
10:22 < glozow> ishaana: ah thanks
10:22 < ishaana> and I think it would be added to mapWallet
10:23 < josie> glozow, ishaana: interesting! my gut reaction was to say it wouldn't be added to mapWallet yet 
10:24 < josie> seems like Unrecognized might be a better state than inactive for a tx yet to be broadcasted? anyways, don't want to go on too far a tangent 
10:25 < josie> question 4: what transaction states are considered "final" ?
10:26 < josie> by final, we mean once a tx reaches this state it will never (or it is extremely unlikely) change states again
10:26 < SebastianvStaa> josie since there is only statistical finality in Bitcoin, probably no txns state is final forever
10:26 < abubakarsadiq> considering reorg happens i dont think there is
10:26 < SebastianvStaa> abubakarsadiq +1
10:27 < Pins> +1
10:27 < josie> SebastianvStaa, abubakarsadiq: reading the question from the notes, I agree :) which is why I added the "extremely unlikely" qualifier 
10:27 < ishaana> glozow, josie: see https://github.com/bitcoin/bitcoin/blob/f08bde7f715cf84ef050c3f6902bc75fb90cedb3/src/wallet/wallet.cpp#L2314
10:29 < glozow> thanks for the link!
10:29 < ishaana> I don't think that an "abandoned" transaction can change tx state, but technically that would just be a TxStateInactive transaction
10:29 < josie> but I think we have to assume some notion of probabilistic finality, otherwise something like showing a wallet balance would be impossible
10:30 < josie> so given that we accept some notion of probabilistic finality, what states would you consider "final"/
10:30 < josie> ?*
10:30 < abubakarsadiq> I also noticed while running the test on master,  that even though the conflicting transaction state does not change to inactive 0 confirmations it was accepted to the mempool and mined in the next block after rebroadcast. https://github.com/bitcoin/bitcoin/blob/f08bde7f715cf84ef050c3f6902bc75fb90cedb3/test/functional/wallet_conflicts.py#L119 this line passes when running test/functional/wallet_conflicts.py 
10:30 < abubakarsadiq> on master before this pr was merged, just asking conceptually the real problem that will require the state to change to inactive
10:32 < SebastianvStaa> josie TxStateConfirmed could be considered final (unless reorg)
10:33 < josie> SebastianvStaa: correct! TxStateConfirmed is considered (increasingly) final the more confirmations it has. The PR specifically mentions 100 blocks as a number where a TxState is definitely considered final 
10:34 < Pins> +1 (considering it is extremely unlikely the reorg)
10:34 < josie> any other states we might consider "final" (especially if we assume > 100 confirmations)
10:35 < wim96> spend?
10:35 < Pins> TxStateConflicted
10:35 < SebastianvStaa> yes, that is also the time span after which the coinbase transaction becomes spendable
10:35 < abubakarsadiq> +1 Josie
10:36 < josie> abubakarsadiq: I'm not sure I follow your question? The conflicted transaction shouldn't be mine-able as it would be spending inputs that are already confirmed spent in the longest chain
10:36 < josie> wim96: I would consider "spent" as TxConfirmed
10:37 < SebastianvStaa> josie maybe TxStateConflicted could be considered final after conflicting txn is mined 100 blocks deep
10:38 < josie> Pins, SebastianvStaa: ah! so it seems we agree that TxConflicted is not really a "final" state. based on this PR, what state does a TxConflicted tx get updated to? (e.g on blockDisconnect)
10:39 < abubakarsadiq> Josie the conflicting transaction's block was disconnected. 
10:39 < Pins> TxStateInactive
10:40 < abubakarsadiq> TxStateInactive
10:40 < SebastianvStaa> josie TxStateInactive
10:40 < josie> Pins: yep! from my understanding of the PR, I'd say TxStateInactive is a "final" state for a tx in our wallet 
10:41 < Pins> Agreed
10:41 -!- abubakar [~abubakar@197.210.52.56] has joined #bitcoin-core-pr-reviews
10:41 < josie> so we have TxConfirmed (the tx in a block that is part of the heaviest chain), and TxInactive (txs that were at one point in a conflicting block, but that block is no longer part of the longest chain)
10:42 -!- abubakar [~abubakar@197.210.52.56] has quit [Client Quit]
10:42 < josie> okay, question 5: where in `net_processing.cpp` is `CWallet::blockDisconnected()` triggered to be executed? 
10:42 < josie> which thread executes this wallet function?
10:42 -!- abubakar [~abubakar@197.210.52.56] has joined #bitcoin-core-pr-reviews
10:43 < SebastianvStaa> josie: didn'T we state earlier that TxStateInactive is also the inital state for a txn after creation?
10:43 < SebastianvStaa> [7:21:45 PM] <glozow> what does a tx state start as if you created but couldnt broadcast it (yet)?
10:43 < SebastianvStaa> [7:22:13 PM] <glozow> or would that never go to mapwallet?
10:43 < SebastianvStaa> [7:22:32 PM] <ishaana> glozow: TxStateInactive
10:43 < SebastianvStaa> [7:22:55 PM] <glozow> ishaana: ah thanks
10:44 < SebastianvStaa> so I don't see why this state could be considered 'final'
10:45 < josie> SebastianvStaa: yep, which is a bit surprising to me, tbh. I suppose "final" almost always is accompanied with some notion of confirmations
10:46 < SebastianvStaa> josie ok makes sense. the state by itself is not final, the txn need more properties for that
10:47 < josie> yep! that's how I think about it. An Inactive tx which spends inputs in the UTXO set wouldn't be considered final
10:47 < josie> but an Inactive tx which spends inputs that were spent many blocks back by a different transaction I would definitely consider to be in a final state 
10:49 -!- abubakar [~abubakar@197.210.52.56] has quit [Quit: Connection closed]
10:49 -!- ccdle12 [~ccdle12@243.222.90.149.rev.vodafone.pt] has quit [Quit: Client closed]
10:50 < josie> feel free to throw out any ideas regarding question 5. I'll admit, I don't think I know the answer to this one 
10:50 -!- abubakar [~abubakar@197.210.52.56] has joined #bitcoin-core-pr-reviews
10:50 < SebastianvStaa> I'm curious about question 5 as well, as I don't understand thread concurrency in Bitcoin Core (yet)
10:50 < josie> (altho, I did learn that subscribers to the ValidationInterface can assume that events happen in a sequential order, which is kinda cool)
10:53 < josie> ishaana: curious if you have any insights for question 5? 
10:54 < josie> SebastianvStaa: threading in bitcoin core is quite the beast! I'm still stumbling my way through understanding it 
10:54 -!- abubakar [~abubakar@197.210.52.56] has quit [Client Quit]
10:54 < SebastianvStaa> this link on the topic seems quite cool. Currently reading it: https://diyhpl.us/wiki/transcripts/scalingbitcoin/tokyo-2018/edgedevplusplus/overview-bitcoin-core-architecture/
10:54 < SebastianvStaa> josie +1
10:55 < josie> let's move on to question 6: what does the wallet do with TxUpdate::NOTIFY_CHANGED? 
10:55 < yashraj> nice
10:55 -!- casiojapi [~casiojapi@181.29.6.102] has joined #bitcoin-core-pr-reviews
10:55 < josie> (who is notifying whom, of what?)
10:56 < josie> SebastianvStaa: great link! thanks for sharing. https://obc.256k1.dev/ is also a great architecture overview, which might be slightly more up to date 
10:57 < SebastianvStaa> very nice resource! Thanks
10:57 < lightlike> as for q5: looks like ActivateBestChain() is called in various places in net_processing, which can lead to DisconnectTip() in validation being called, which then creates the BlockDisconnected() signal which is picked up by the wallet later.
10:58 < abubakarsadiq> Josie: After running the test on master before this pr was merged the error was
10:58 < abubakarsadiq>   `AssertionError: not(-15 == 0)` for both https://github.com/bitcoin/bitcoin/blob/f08bde7f715cf84ef050c3f6902bc75fb90cedb3/test/functional/wallet_conflicts.py#LL115C5-L115C5 and https://github.com/bitcoin/bitcoin/blob/f08bde7f715cf84ef050c3f6902bc75fb90cedb3/test/functional/wallet_conflicts.py#LL117C3-L117C3
10:58 < abubakarsadiq> when I commented the two lines the test passes this>> https://github.com/bitcoin/bitcoin/blob/f08bde7f715cf84ef050c3f6902bc75fb90cedb3/test/functional/wallet_conflicts.py#LL119C1-L119C1, My question is that If the state of the conflicting transaction did not change before the PR from TxConflicted to TxInactive why does it this pass on master
10:59 < josie> lightlike: thanks! I got as far as DisconnectTip() -> BlockDisconnected() but didn't realize it was originating with ActivateBestChain()
11:00 < ishaana> josie: yeah it looks like it is called during ActivateBestChain()
11:00 < josie> that's time, so we'll stop here, but I'd encourage everyone to work through the remaining questions! 
11:00 < josie> #endmeeting
11:00 < josie> thanks everyone for attending and for the great discussion! 
11:00 < pablomartin> thanks josie and all!
11:00 < Pins> Thanks
11:00 < glozow> thank you josie!
11:00 < wim96> Thanks!
11:00 < hernanmarino> Goodbye, and thank you josie and everyone
11:00 < SebastianvStaa> thanks for hosting josie, and everone else!
11:01 < yashraj> great topics folks. thanks for hosting josie!
11:01 < ishaana> thanks josie for hosting and glozow for writing the notes!
11:01 < abubakarsadiq> Thanks Josie
11:01 < yashraj> topic*
11:01 < josie> big thanks to glozow for the notes, and ishaana for the PR! 
11:03 -!- ranemirus [~ranemirus@104.28.217.122] has quit [Quit: Connection closed]
11:03 < josie> abubakarsadiq: interesting, off the top of my head I'm not quite sure
11:05 -!- Pins [~Pins@179.209.140.115] has quit [Quit: Connection closed]
11:05 < abubakarsadiq> Yeah, I thought if the state did not change from TxConflicting then that should not pass right?
11:06 -!- wim96 [~wim96@193.176.31.66] has quit [Ping timeout: 240 seconds]
11:07 -!- yashraj_ [yashraj@gateway/vpn/protonvpn/yashraj] has joined #bitcoin-core-pr-reviews
11:08 -!- ishaana [~ishaana@165.155.171.167] has quit [Ping timeout: 250 seconds]
11:10 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has quit [Ping timeout: 268 seconds]
11:12 -!- belpdahc [~devbox@2601:cf:8200:6050:ce1e:8ce6:5d4a:ffc] has joined #bitcoin-core-pr-reviews
11:13 -!- belpdahc [~devbox@2601:cf:8200:6050:ce1e:8ce6:5d4a:ffc] has left #bitcoin-core-pr-reviews []
11:32 -!- pablomartin [~pablomart@77-74-192-228.as42831.net] has quit [Ping timeout: 268 seconds]
11:41 -!- yashraj_ [yashraj@gateway/vpn/protonvpn/yashraj] has quit []
12:19 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:38 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Read error: Connection reset by peer]
12:39 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
12:43 -!- Zenton [~user@user/zenton] has quit [Ping timeout: 256 seconds]
12:47 -!- SebastianvStaa [~Sebastian@45.128.199.57] has quit [Ping timeout: 240 seconds]
13:02 -!- casiojapi [~casiojapi@181.29.6.102] has quit [Remote host closed the connection]
13:50 -!- BrinkingChancell [~BrinkingC@cpe-24-168-85-43.si.res.rr.com] has joined #bitcoin-core-pr-reviews
14:07 -!- BrinkingChancell [~BrinkingC@cpe-24-168-85-43.si.res.rr.com] has quit [Quit: Connection closed]
14:09 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity]
14:10 -!- brunoerg_ [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
14:10 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Read error: Connection reset by peer]
14:13 -!- meshcollider [meshcollid@jujube.rpblc.net] has quit [Ping timeout: 240 seconds]
14:22 -!- brunoerg_ [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Remote host closed the connection]
14:38 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
14:39 -!- meshcollider [meshcollid@jujube.rpblc.net] has joined #bitcoin-core-pr-reviews
14:43 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 250 seconds]
15:01 -!- BrinkingChancell [~BrinkingC@38-13-41-161.starry-inc.net] has joined #bitcoin-core-pr-reviews
15:15 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
15:19 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 246 seconds]
15:35 -!- BrinkingChancell [~BrinkingC@38-13-41-161.starry-inc.net] has quit [Quit: Connection closed]
15:47 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
15:53 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 250 seconds]
16:24 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
16:29 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 265 seconds]
16:42 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
16:45 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Remote host closed the connection]
16:46 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
16:50 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 240 seconds]
16:59 -!- b_101 [~robert@189.236.5.138] has quit [Ping timeout: 265 seconds]
17:00 -!- b_101 [~robert@193.37.254.131] has joined #bitcoin-core-pr-reviews
17:08 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
17:10 -!- b_101_ [~robert@189.236.5.138] has joined #bitcoin-core-pr-reviews
17:11 -!- b_101 [~robert@193.37.254.131] has quit [Ping timeout: 265 seconds]
17:13 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 265 seconds]
17:16 -!- b_101_ [~robert@189.236.5.138] has quit [Ping timeout: 256 seconds]
17:17 -!- b_101 [~robert@193.37.254.131] has joined #bitcoin-core-pr-reviews
17:31 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
17:33 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
17:36 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 250 seconds]
18:07 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
18:12 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 250 seconds]
18:24 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
18:40 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 265 seconds]
18:49 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
18:53 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
18:59 -!- b_101 [~robert@193.37.254.131] has quit [Ping timeout: 256 seconds]
19:00 -!- b_101 [~robert@193.37.254.131] has joined #bitcoin-core-pr-reviews
19:06 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
19:11 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 265 seconds]
19:22 -!- _aj_ [aj@user/aj/x-5857768] has quit [Ping timeout: 256 seconds]
19:23 -!- _aj_ [aj@user/aj/x-5857768] has joined #bitcoin-core-pr-reviews
19:34 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
19:39 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 250 seconds]
19:45 -!- jakob[m] [~jakobrowa@2001:470:69fc:105::1:ef81] has joined #bitcoin-core-pr-reviews
19:56 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
20:01 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 250 seconds]
20:12 -!- hernanmarino [~hernanmar@190.245.116.245] has quit [Ping timeout: 250 seconds]
20:19 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
20:24 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 265 seconds]
21:08 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
21:13 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 265 seconds]
21:42 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
21:47 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 265 seconds]
22:00 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
22:05 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 250 seconds]
22:06 -!- b_101 [~robert@193.37.254.131] has quit [Ping timeout: 240 seconds]
22:17 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
22:22 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 265 seconds]
22:23 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
22:28 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 246 seconds]
22:29 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
22:33 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 265 seconds]
22:50 -!- b_101 [~robert@193.37.254.131] has joined #bitcoin-core-pr-reviews
22:51 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
22:54 -!- b_101 [~robert@193.37.254.131] has quit [Ping timeout: 240 seconds]
22:56 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 250 seconds]
23:06 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
23:10 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 248 seconds]
23:22 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
23:26 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 240 seconds]
23:28 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
23:33 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has quit [Ping timeout: 250 seconds]
23:39 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
23:44 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 250 seconds]
23:56 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:a911:4682:3cca:2e85] has joined #bitcoin-core-pr-reviews
--- Log closed Thu Jun 01 00:00:17 2023