--- Log opened Wed Jun 07 00:00:24 2023
00:03 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 250 seconds]
00:06 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews
00:09 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
00:14 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 246 seconds]
00:37 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
00:42 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 240 seconds]
01:08 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 240 seconds]
01:11 -!- jamesob [~jamesob@108.44.248.162] has quit [Ping timeout: 256 seconds]
01:11 -!- jamesob44 [~jamesob@108.44.248.162] has quit [Ping timeout: 256 seconds]
01:34 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
01:39 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 240 seconds]
01:40 -!- puchka [~puchka@185.203.122.251] has quit [Ping timeout: 240 seconds]
02:08 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
02:13 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
02:17 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-pr-reviews
02:25 -!- jamesob44 [~jamesob@108.44.248.162] has joined #bitcoin-core-pr-reviews
02:25 -!- jamesob [~jamesob@108.44.248.162] has joined #bitcoin-core-pr-reviews
02:51 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
03:04 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
03:10 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
03:15 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
03:17 < stickies-v> today's PR under review #27711 just underwent a pretty significant overhaul. for today's discussion, we'll be focusing on the previous HEAD (https://github.com/bitcoin-core-review-club/bitcoin/commit/a6a3c3245303d05917c04460e71790e33241f3b5)
03:17 < stickies-v> of course - checking out the latest HEAD (and related discussion) is helpful and encouraged, if you have the time
03:21 -!- puchka [~puchka@185.203.122.137] has joined #bitcoin-core-pr-reviews
03:28 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
03:37 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 240 seconds]
03:44 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
03:49 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 250 seconds]
03:55 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
03:59 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 240 seconds]
04:18 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
04:24 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 265 seconds]
04:46 -!- b_101 [~robert@193.37.254.131] has joined #bitcoin-core-pr-reviews
04:51 -!- b_101 [~robert@193.37.254.131] has quit [Ping timeout: 240 seconds]
04:54 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
04:58 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 250 seconds]
04:59 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
05:05 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 268 seconds]
05:18 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
05:23 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 246 seconds]
05:40 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
05:45 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
05:59 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
06:00 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
06:03 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
06:08 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 256 seconds]
06:17 -!- puchka [~puchka@185.203.122.137] has quit [Ping timeout: 265 seconds]
06:29 -!- kevkevin [~kevkevin@2601:241:8703:7b30:29b5:ecb6:3409:5eac] has joined #bitcoin-core-pr-reviews
06:34 -!- kevkevin [~kevkevin@2601:241:8703:7b30:29b5:ecb6:3409:5eac] has quit [Ping timeout: 250 seconds]
06:36 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
06:41 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
07:04 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
07:08 -!- kevkevin [~kevkevin@2601:241:8703:7b30:29b5:ecb6:3409:5eac] has joined #bitcoin-core-pr-reviews
07:18 -!- puchka [~puchka@185.203.122.139] has joined #bitcoin-core-pr-reviews
07:20 -!- puchka1101 [~puchka@185.203.122.139] has joined #bitcoin-core-pr-reviews
07:46 -!- kevkevin [~kevkevin@2601:241:8703:7b30:29b5:ecb6:3409:5eac] has quit [Remote host closed the connection]
07:55 -!- evansmj [~evansmj@pool-72-66-113-135.washdc.fios.verizon.net] has joined #bitcoin-core-pr-reviews
08:21 -!- kevkevin [~kevkevin@2601:241:8703:7b30:29b5:ecb6:3409:5eac] has joined #bitcoin-core-pr-reviews
08:39 -!- puchka1101 [~puchka@185.203.122.139] has quit [Quit: leaving]
08:41 -!- b_101 [~robert@193.37.254.131] has joined #bitcoin-core-pr-reviews
09:01 -!- b10c [~quassel@user/b10c] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
09:03 -!- b10c [~quassel@static.33.106.217.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews
09:03 -!- b10c [~quassel@static.33.106.217.95.clients.your-server.de] has quit [Changing host]
09:03 -!- b10c [~quassel@user/b10c] has joined #bitcoin-core-pr-reviews
09:19 < glozow> are self-advertisements the only possible scenario where we'd send an addr with 1 entry?
09:19 < darosior> cc lightlike
09:42 < lightlike> glozow: normal gossip relay could also result in those, e. g. it could happen if a node just received a few addrs in a given time window. 
09:43 < sipa> (haven't checked code recently) don't self-advertisements just get added to the buffer of to-be-sent addrs, which may get more addresses through relay before being sent out.
09:48 < lightlike> Yes, but the initial self-adv right after connection initialisation is usually sent right away, bc of how the timer is initialised to 0
09:48 < lightlike> So that is usually an addr of size 1
09:54 -!- schjonhaug [~schjonhau@185.176.244.166] has joined #bitcoin-core-pr-reviews
09:55 -!- testtest [~testtest@185.176.244.166] has joined #bitcoin-core-pr-reviews
09:55 < glozow> ah thanks!
09:56 -!- testtest [~testtest@185.176.244.166] has quit [Client Quit]
09:56 -!- schjonhaug [~schjonhau@185.176.244.166] has quit [Client Quit]
09:56 -!- schjonhaug [~textual@185.176.244.166] has joined #bitcoin-core-pr-reviews
09:57 -!- ccdle12 [~ccdle12@243.222.90.149.rev.vodafone.pt] has joined #bitcoin-core-pr-reviews
09:59 -!- mutex [~mutex@108-213-70-206.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-pr-reviews
09:59 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has joined #bitcoin-core-pr-reviews
10:00 < stickies-v> #startmeeting
10:00 < LarryRuane> hi
10:01 < stickies-v> welcome everyone! Today we're looking at #27711, authored by TheCharlatan. The notes and questions are available on https://bitcoincore.reviews/27711
10:01 < abubakarsadiq> hello
10:01 < effexzi> Hi every1 
10:02 < stickies-v> note: we'll be focusing on the previous PR HEAD (https://github.com/bitcoin-core-review-club/bitcoin/commit/a6a3c3245303d05917c04460e71790e33241f3b5), which is _not_ the current HEAD anymore (but we don't want to overhaul the notes and questions last minute)
10:02 < stickies-v> anyone joining us for the first time today? even if you're just lurking, feel free to say hi!
10:03 < LarryRuane> silly question, but is there a way to see the commits before that one?
10:03 < LarryRuane> (on GitHub)
10:03 < TheCharlatan> hi :)
10:04 < stickies-v> LarryRuane: GitHub allows you to browse a repo at a certain commit (like checkout), and if you do that and then click the commit history button, you can see the history indeed
10:05 < stickies-v> https://github.com/bitcoin-core-review-club/bitcoin/commits/a6a3c3245303d05917c04460e71790e33241f3b5 would be the link
10:05 < stickies-v> (an extra `s` after `commit` in the url)
10:05 < LarryRuane> that's it, perfect, thanks
10:05 < stickies-v> who got the chance to review the PR or read the notes? (y/n)
10:05 < stickies-v> hi TheCharlatan, thanks for joining us today!
10:06 < LarryRuane> do others do a lot of URL hacking on github? I do, but always wondered if it's only because I don't know of better ways
10:06 < mutex> when in doubt I revert to cli :-D
10:07 < LarryRuane> I have not much at all, sorry, I got stuck on a question that didn't make sense with the most recent head
10:07 < LarryRuane> mutex: is that the `gh` command? I haven't used it but maybe should learn how to
10:07 < mutex> this is my first PR review, not well versed in C++ so i'm at a bit of a disadvantage
10:07 < TheCharlatan> LarryRuane, url's are made to be hacked :D
10:08 < mutex> LarryRuane: git command, I haven't used the 'gh' tool
10:08 < abubakarsadiq> I read the notes and  was reading about the kernel project :)
10:08 < LarryRuane> :) .. yeah i actually don't mind it! but just was wondering.. sorry for the sidetrack
10:08 < stickies-v> hey mutex, glad to have you here! there's a bit of  a learning curve but hang in there :-)
10:09 -!- abagnalejr [~abagnalej@181.84.165.33] has joined #bitcoin-core-pr-reviews
10:09 < stickies-v> the PR turned out to be a bit more complex than I imagined when I first selected it hah, as also evidenced by the recent discussions and today's force-push
10:09 < LarryRuane> mutex: yes i of course use `git` constantly, but to interact with github, there's a `gh` command you can install, which i did, but i haven't used it yet
10:09 < stickies-v> I see there's not been too much review, so perhaps we can start if anyone has any questions about the purpose of this PR? does the approach make sense?
10:10 < LarryRuane> stickies-v: yes, i started reading the comments on the PR was like, wow, this is way over my head!
10:10 < stickies-v> LarryRuane: I've not had any use case where `git` and shell alias/functions couldn't help me out tbh
10:10 -!- b_101 [~robert@193.37.254.131] has quit [Ping timeout: 250 seconds]
10:12 < mutex> concept ACK
10:12 < LarryRuane> is this a step toward getting rid of the fRequestShutdown flag?
10:12 -!- schjonhaug [~textual@185.176.244.166] has quit [Quit: Textual IRC Client: www.textualapp.com]
10:12 < LarryRuane> (but I'm unclear on how exactly that flag interacts with the consensus kernel)
10:13 < stickies-v> LarryRuane: oh, good question. I don't think that's quite in the scope of the libbitcoinkernel project, since `fRequestShutdown` is owned by the node
10:14 < stickies-v> I think the version of the PR that we're reviewing doesn't really make any progress towards that goal either, since we're still very much relying on a global boolean value
10:15 < stickies-v> the new, current version, however, seems to be moving in that direction with the `interrupt()` function
10:15 < mutex> is there more than one PR we should be looking at?
10:16 < stickies-v> mutex: the most relevant prior PR to this one is https://github.com/bitcoin/bitcoin/pull/27636, that introduced the notification interface
10:17 < stickies-v> but I'd say the PR is pretty self contained
10:17 < stickies-v> gonna start with the first question:
10:17 < stickies-v> Why do we have `startShutdown` both in `kernel/notifications_interface.h` as well as in `node/kernel_notifications.h`?
10:18 -!- b_101 [~robert@193.37.254.131] has joined #bitcoin-core-pr-reviews
10:19 < LarryRuane> (that's the question i got stumped on, since it's not in both of those places)
10:19 < mutex> yeah I'm not seeing it
10:19 < LarryRuane> (in the latest PR head)
10:19 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews
10:21 < stickies-v> yeah, it's in commit a6a3c3245303d05917c04460e71790e33241f3b5
10:23 < stickies-v> but, I think it probably doesn't make sense to keep discussing questions that no one's seen the code for
10:23 < stickies-v> so I suggest we stop covering the prepared questions and instead just move to general Q&A on the PR, if there are any?
10:25 < mutex> is this an issue of the questions being prepared for code that has already been superceded?
10:26 < LarryRuane> Here's something I wondered while reviewing this PR (but the latest on github), but just a c++ question, https://github.com/bitcoin/bitcoin/pull/27711/files#diff-d6d633592a40f5f3d8b03863e41547de8751b874c1d20f129a616b9dd719b999R26 there are empty braces at the end of that declaration, do those need to be there? what do they do?
10:27 < stickies-v> mutex: yeah, there was quite a big code overhaul this morning. we do include the HEAD that we look at on the bitcoincore.reviews website, but I now see that it only is mentioned for reviews in the past, not for current/upcoming ones
10:27 < mutex> I have a quesiton about this comment: https://github.com/bitcoin/bitcoin/pull/27711/files#diff-04c8e84ee77f6085c064940c211aedb95c781be20927aec64553d8448253af97R44  No signals on windows? I thought windows was POSIX compliant? 
10:27 < mutex> (modern windows)
10:28 < LarryRuane> mutex: +1 good question, what happens when you hit control-c on windows? Does that even work there? How does it work without signals?
10:28 -!- abagnalejr [~abagnalej@181.84.165.33] has quit [Ping timeout: 240 seconds]
10:29 < TheCharlatan> afaik windows has its own event thing that you can use to emulate posix signals.
10:30 < TheCharlatan> (I'm not a windows dev though)
10:30 < TheCharlatan> https://stackoverflow.com/questions/51476296/what-signals-should-i-use-to-terminate-kill-applications-on-windows
10:30 < mutex> my knowledge here is from 20 years ago, where WindowsNT had a POSIX subsystem, i'm sure things have changed since then ;-)
10:30 < stickies-v> LarryRuane: I think `KernelNotifications notifications` and `KernelNotifications notifications{}` are equivalent, since `KernelNotifications` is a class with a default constructor
10:31 < evansmj> `As a standalone library the libbitcoinkernel should not have to rely on code that accesses shutdown state through a global.`  was `static std::atomic<bool> fRequestShutdown(false);` the original global?  the state being just true/false?
10:31 < LarryRuane> thanks
10:31 -!- abagnalejr [~abagnalej@181.84.165.33] has joined #bitcoin-core-pr-reviews
10:31 < stickies-v> but with the braces we ensure that it's always initialized, so probably better practice to do it like this?
10:31 < LarryRuane> i see, so even if the class does have a default constructor, probably no harm in specifying those braces
10:32 < stickies-v> evansmj: that's my understanding, yes!
10:38 < LarryRuane> in case this is also helpful to others... here's a list of the files that are considered part of libbitcoinkernel: https://github.com/bitcoin/bitcoin/blob/2026301405f83c925ca68db6a3cd5134ed619ca7/src/Makefile.am#L911
10:39 < LarryRuane> (well, not "considered" ... actually are!)
10:39 < LarryRuane> it's more than I thought
10:39 < stickies-v> with the "#TODO" line above it quite important:
10:39 < stickies-v> "...as more and more modules are decoupled from the consensus engine, this list will shrink to only those which are absolutely necessary."
10:40 < LarryRuane> yes, great point, i had missed that!
10:41 < mutex> So the PR changes the signaling method, does the behavior change at all?  I see a few exceptions being thrown, does that change the behavior other than to stop hashing?
10:42 < mutex> I don't think i know enough about the surrounding code to understand
10:42 < LarryRuane> so the first two commits (in the review club version, not the latest PR tip) are removing calls to the global `ShutdownRequested()` function from those files (that make up libbitcoinkernel), IIUC
10:43 < stickies-v> mutex: I've not looked at the current version too much yet, but I think behaviour is not meant to change, no
10:44 < evansmj> so now, classes interested in the shutdown state need to look at the kernel Context notifications for the signal interrupt flag.  what kinds of things/classes are interested in this?  i see bitcoind checks it immediately in AppInit(), is that somehow the main looping check?
10:45 < TheCharlatan> behaviour should not change except for the two subtle changes/bugfixes in the latest PR tip.
10:45 < stickies-v> LarryRuane: I think just the first commit? but otherwise, yeah
10:45 < LarryRuane> yes, you're right
10:51 < stickies-v> evansmj: I think long-running operations, mostly? In `master`,  I'd look at callsites of `ShutdownRequested()`, e.g. here when we're loading the blockindex: https://github.com/bitcoin/bitcoin/blob/2026301405f83c925ca68db6a3cd5134ed619ca7/src/node/blockstorage.cpp#L264
10:54 < LarryRuane> I assume one of the goals of a PR like this is making consensus code more testable? So that last commit, "kernel: Remove shutdown from kernel library" changes all the calls (in libbitcoinkernel) to the global `StartShutdown()`, to instead call a notification callback, for example `chainman.GetNotifications().startShutdown(ShutdownReason::StopAfterBlockImport)`
10:55 < LarryRuane> so with that change, test code won't *really* get shutdown (the test process) when this condition occurs
10:56 < LarryRuane> test code wouldn't really get shut down, it might check that this callback did happen (like presumably it's supposed to), and fail the test if not .. something like that
10:58 < stickies-v> LarryRuane: yeah I think that's definitely true, and probably holds for pretty much all decoupling? the less intertwined everything is, the more straightforward your tests can be
10:58 < stickies-v> I didn't think of that though, nice
10:59 < stickies-v> alright, looks like we're out of time
11:00 < evansmj> thanks
11:00 < stickies-v> thanks for your work on this PR TheCharlatan, and thanks everyone else for attending!
11:00 < stickies-v> #endmeeting
11:01 < LarryRuane> thanks @stickies-v! and @TheCharlatan for the PR!
11:02 < abubakarsadiq> thanks stickies-v
11:02 < mutex> thank you everyone
11:05 -!- mutex [~mutex@108-213-70-206.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving]
11:17 -!- ccdle12 [~ccdle12@243.222.90.149.rev.vodafone.pt] has quit [Quit: Connection closed]
11:23 -!- abagnalejr [~abagnalej@181.84.165.33] has quit [Quit: Connection closed]
11:24 -!- abagnalejrrr [~abagnalej@181.84.165.33] has joined #bitcoin-core-pr-reviews
12:03 -!- abagnalejrrr [~abagnalej@181.84.165.33] has quit [Ping timeout: 268 seconds]
12:34 -!- b_101 [~robert@193.37.254.131] has quit [Ping timeout: 240 seconds]
12:40 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
13:03 -!- grettke [~grettke@065-026-198-174.biz.spectrum.com] has quit [Ping timeout: 256 seconds]
13:07 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Remote host closed the connection]
13:08 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
13:08 -!- grettke [~grettke@065-026-198-174.biz.spectrum.com] has joined #bitcoin-core-pr-reviews
13:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
13:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
13:13 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
13:17 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
13:19 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
13:23 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 250 seconds]
13:25 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
13:39 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity]
13:58 -!- evansmj [~evansmj@pool-72-66-113-135.washdc.fios.verizon.net] has quit [Quit: Connection closed]
14:06 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
14:13 -!- evansmj [~evansmj@pool-72-66-113-135.washdc.fios.verizon.net] has joined #bitcoin-core-pr-reviews
14:36 -!- kevkevin [~kevkevin@2601:241:8703:7b30:29b5:ecb6:3409:5eac] has quit [Remote host closed the connection]
15:07 -!- b_101 [~robert@189.236.5.138] has joined #bitcoin-core-pr-reviews
15:12 -!- b_101 [~robert@189.236.5.138] has quit [Ping timeout: 248 seconds]
15:15 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
15:19 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
15:26 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
15:30 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 240 seconds]
15:56 -!- b_101 [~robert@189.236.5.138] has joined #bitcoin-core-pr-reviews
16:05 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
16:14 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 248 seconds]
16:16 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
16:20 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 240 seconds]
16:37 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
16:42 -!- evansmj [~evansmj@pool-72-66-113-135.washdc.fios.verizon.net] has quit [Ping timeout: 256 seconds]
16:42 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
16:43 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
16:48 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
16:54 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
16:58 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 240 seconds]
17:39 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
17:43 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
18:07 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
18:11 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 240 seconds]
18:12 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
18:17 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 240 seconds]
18:23 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
18:27 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 240 seconds]
18:30 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
18:39 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 248 seconds]
18:52 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
18:57 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 250 seconds]
19:03 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
19:10 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
19:11 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
19:15 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 256 seconds]
19:39 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
19:44 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
19:44 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
19:49 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
20:46 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
20:50 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 240 seconds]
20:54 -!- b_101 [~robert@189.236.5.138] has quit [Ping timeout: 256 seconds]
20:56 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
20:59 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews
21:00 -!- b_101 [~robert@189.236.5.138] has joined #bitcoin-core-pr-reviews
21:02 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
21:03 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
21:05 -!- b_101 [~robert@189.236.5.138] has quit [Ping timeout: 256 seconds]
21:07 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
21:08 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
21:13 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 256 seconds]
21:15 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: WeeChat 3.8]
21:18 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews
21:30 -!- b_101 [~robert@189.236.5.138] has joined #bitcoin-core-pr-reviews
21:30 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
21:35 -!- b_101 [~robert@189.236.5.138] has quit [Ping timeout: 240 seconds]
21:40 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
21:58 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
22:03 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 246 seconds]
22:04 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
22:09 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 248 seconds]
22:16 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
22:20 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 240 seconds]
22:21 -!- b_101 [~robert@189.236.5.138] has joined #bitcoin-core-pr-reviews
22:22 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
22:26 -!- b_101 [~robert@189.236.5.138] has quit [Ping timeout: 240 seconds]
22:26 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 246 seconds]
22:27 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
22:29 -!- grettke [~grettke@065-026-198-174.biz.spectrum.com] has quit [Quit: grettke]
22:32 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
22:34 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
22:38 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 250 seconds]
22:40 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
22:44 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
22:46 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
22:51 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 240 seconds]
22:57 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
23:02 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
23:08 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has joined #bitcoin-core-pr-reviews
23:13 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:e4cf:dbb3:f4b6:c0c6] has quit [Ping timeout: 265 seconds]
23:31 -!- b_101 [~robert@189.236.5.138] has joined #bitcoin-core-pr-reviews
23:38 -!- b_101 [~robert@189.236.5.138] has quit [Ping timeout: 256 seconds]
23:53 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
23:57 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
--- Log closed Thu Jun 08 00:00:24 2023