--- Log opened Wed Jun 28 00:00:46 2023 00:01 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 00:05 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 00:11 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 00:16 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 240 seconds] 00:24 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has joined #bitcoin-core-pr-reviews 00:25 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 00:29 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has quit [Ping timeout: 260 seconds] 00:30 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 00:43 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 00:43 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has joined #bitcoin-core-pr-reviews 00:47 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 264 seconds] 00:50 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has quit [Ping timeout: 260 seconds] 00:57 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 01:03 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 01:16 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 01:20 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 240 seconds] 01:22 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews 01:26 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 240 seconds] 01:33 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 01:37 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 01:44 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has joined #bitcoin-core-pr-reviews 01:49 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has quit [Ping timeout: 260 seconds] 01:49 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 01:54 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 02:00 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 02:04 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 02:12 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews 02:16 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 250 seconds] 02:17 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 02:21 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 02:33 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 02:34 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews 02:37 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 02:41 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 260 seconds] 02:49 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews 02:49 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 02:53 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 260 seconds] 02:54 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 240 seconds] 02:56 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 03:01 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 240 seconds] 03:14 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 03:18 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 246 seconds] 03:23 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has joined #bitcoin-core-pr-reviews 03:27 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has quit [Ping timeout: 246 seconds] 03:30 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 03:35 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 03:47 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 03:52 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 264 seconds] 04:04 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 04:06 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews 04:09 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 240 seconds] 04:11 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 252 seconds] 04:13 -!- RubenSomsen [sid301948@user/rubensomsen] has quit [Server closed connection] 04:14 -!- RubenSomsen [sid301948@user/rubensomsen] has joined #bitcoin-core-pr-reviews 04:21 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 04:26 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 258 seconds] 04:37 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 04:41 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 04:49 -!- w0xlt [sid555702@id-555702.ilkley.irccloud.com] has quit [Server closed connection] 04:50 -!- w0xlt [sid555702@id-555702.ilkley.irccloud.com] has joined #bitcoin-core-pr-reviews 04:53 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 04:56 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has joined #bitcoin-core-pr-reviews 04:59 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 05:06 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has quit [Ping timeout: 240 seconds] 05:11 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 05:15 -!- greypw2546002161 [~greypw254@grey.pw] has quit [Read error: Connection reset by peer] 05:16 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 05:24 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has joined #bitcoin-core-pr-reviews 05:28 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 05:28 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has quit [Ping timeout: 260 seconds] 05:32 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 05:32 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 264 seconds] 05:36 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 05:46 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has joined #bitcoin-core-pr-reviews 05:47 -!- jess [K2JEA7mgao@libera/staff/cat/jess] has quit [Remote host closed the connection] 05:48 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 05:50 -!- jess [lugzODKDCX@libera/staff/cat/jess] has joined #bitcoin-core-pr-reviews 05:51 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has quit [Ping timeout: 245 seconds] 05:52 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has joined #bitcoin-core-pr-reviews 05:52 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 05:52 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 05:56 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has quit [Ping timeout: 260 seconds] 05:57 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 06:09 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 06:10 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has joined #bitcoin-core-pr-reviews 06:13 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 06:15 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has quit [Ping timeout: 245 seconds] 06:15 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 06:20 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 06:31 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 06:31 -!- theStack [~theStack@95.179.145.232] has quit [Ping timeout: 250 seconds] 06:35 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 06:41 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 06:46 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 240 seconds] 06:56 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has joined #bitcoin-core-pr-reviews 06:57 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 07:01 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has quit [Ping timeout: 260 seconds] 07:04 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 264 seconds] 07:11 -!- aureleoules [~aureleoul@82-64-162-213.subs.proxad.net] has quit [Ping timeout: 250 seconds] 07:11 -!- aureleoules [~aureleoul@82-64-162-213.subs.proxad.net] has joined #bitcoin-core-pr-reviews 07:13 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has joined #bitcoin-core-pr-reviews 07:16 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 07:16 -!- ishaana [~ishaana@87.249.138.143] has joined #bitcoin-core-pr-reviews 07:18 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has quit [Ping timeout: 260 seconds] 07:18 -!- ishaana [~ishaana@87.249.138.143] has quit [Client Quit] 07:20 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-pr-reviews 07:20 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 07:20 -!- TheRec [~toto@user/therec] has quit [Ping timeout: 250 seconds] 07:23 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has joined #bitcoin-core-pr-reviews 07:28 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has quit [Ping timeout: 260 seconds] 07:32 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 07:35 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 07:37 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 07:39 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 246 seconds] 07:47 -!- instagibbs1 [~instagibb@pool-100-15-126-231.washdc.fios.verizon.net] has joined #bitcoin-core-pr-reviews 07:49 -!- instagibbs [~instagibb@pool-100-15-126-231.washdc.fios.verizon.net] has quit [Ping timeout: 250 seconds] 07:49 -!- instagibbs1 is now known as instagibbs 07:50 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has joined #bitcoin-core-pr-reviews 07:52 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 07:54 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has quit [Ping timeout: 240 seconds] 07:56 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 240 seconds] 07:56 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has joined #bitcoin-core-pr-reviews 08:10 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 08:14 -!- grettke [~grettke@065-026-198-174.biz.spectrum.com] has joined #bitcoin-core-pr-reviews 08:14 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 08:18 -!- evansmj [~evansmj@pool-72-66-113-135.washdc.fios.verizon.net] has joined #bitcoin-core-pr-reviews 08:23 -!- pablomartin [~pablomart@94-46-192-107.as42831.net] has joined #bitcoin-core-pr-reviews 08:26 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 08:30 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 264 seconds] 08:33 -!- theStack [~theStack@95.179.145.232] has joined #bitcoin-core-pr-reviews 08:35 -!- __gotcha [~Thunderbi@94.105.119.44.dyn.edpnet.net] has joined #bitcoin-core-pr-reviews 08:43 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 08:48 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 08:48 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 08:53 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 08:54 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 08:59 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 09:06 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 09:07 -!- willcl-ark_ [~willcl-ar@77.100.20.178] has quit [Server closed connection] 09:07 -!- willcl-ark [~willcl-ar@cpc123780-trow7-2-0-cust177.18-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 09:07 -!- willcl-ark [~willcl-ar@cpc123780-trow7-2-0-cust177.18-1.cable.virginm.net] has quit [Changing host] 09:07 -!- willcl-ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-core-pr-reviews 09:07 -!- drusilla [uid607105@2a03:5180:f:1::9:4381] has quit [Quit: Connection closed for inactivity] 09:09 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 240 seconds] 09:09 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 09:10 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 09:10 -!- ___nick___ [~quassel@host86-164-104-156.range86-164.btcentralplus.com] has joined #bitcoin-core-pr-reviews 09:11 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 245 seconds] 09:12 -!- ___nick___ [~quassel@host86-164-104-156.range86-164.btcentralplus.com] has quit [Client Quit] 09:14 -!- ___nick___ [~quassel@host86-164-104-156.range86-164.btcentralplus.com] has joined #bitcoin-core-pr-reviews 09:14 -!- ___nick___ [~quassel@host86-164-104-156.range86-164.btcentralplus.com] has quit [Client Quit] 09:16 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 09:16 -!- ___nick___ [~quassel@host86-164-104-156.range86-164.btcentralplus.com] has joined #bitcoin-core-pr-reviews 09:29 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 09:32 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-pr-reviews 09:34 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 09:43 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 09:46 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 09:47 -!- Pins [~Pins@179.209.140.115] has joined #bitcoin-core-pr-reviews 09:47 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 09:47 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcbb:5adc:637d:c1c] has joined #bitcoin-core-pr-reviews 09:48 < kevkevin> ping 09:51 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 09:52 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 09:55 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 09:56 < brunoerg> kevkevin: pong 09:56 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 09:57 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 09:59 < kevkevin> brunoerg: ty 09:59 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 10:00 < ishaanam[m]> #startmeeting 10:00 < ishaanam[m]> Hey everyone, welcome to PR review club! 10:00 < LarryRuane> hi 10:00 < brunoerg> hi 10:00 < ishaanam[m]> Today we will be reviewing #27307: "Track mempool conflicts with wallet transactions" 10:00 < ishaanam[m]> The notes and questions can be found here: https://bitcoincore.reviews/27307 10:01 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 10:01 < Pins> hi 10:01 < kevkevin> hi 10:01 < ishaanam[m]> Feel free to ask any questions! 10:01 < ishaanam[m]> Has anyone gotten a chance to review the PR or look at the notes? 10:01 -!- BrandonOdiwuor [~BrandonOd@105.162.13.122] has joined #bitcoin-core-pr-reviews 10:01 < evansmj> hey do scripted diffs normally come in an independent pr?  i think yes right? 10:02 < abubakarsadiq> hello 10:02 -!- pablomartin [~pablomart@94-46-192-107.as42831.net] has quit [Ping timeout: 264 seconds] 10:02 < LarryRuane> One really basic question, is there a `CWalletTx` instance in memory for every tx that is either paying *to* this wallet or paying *from* this wallet? And both mined and unmined transactions? 10:03 < sipa> Yes, and yes. 10:03 < Pins> ishaanam[m] I did 10:03 -!- drusilla [uid607105@id-607105.helmsley.irccloud.com] has joined #bitcoin-core-pr-reviews 10:03 < LarryRuane> evansmj: no, scripted diff is generally *one* commit within a larger PR 10:04 < ishaanam[m]> Great, can someone give a short summary of what this PR is doing? 10:05 < LarryRuane> ishaanam[m]: I was confused by the description of `TxStateConflicted` in the notes... its inputs are not spent (by another tx? and its outputs are not available to spend, for example immature coinbase? To me, that doesn't sounds "conflicted" ... so I must be missing something 10:05 < Pins> creating a new tx state to the mempool conflicted tx 10:06 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 10:07 < ishaanam[m]> LarryRuane: To clarify, that was not about what makes a transaction TxStateConflicted, it was about how a wallet treats a TxStateConflicted transaction 10:08 < LarryRuane> oh i see, thanks, that helps a lot 10:08 < abubakarsadiq> Solving an intermittent issue where mempool droped transaction are marked as TxStateConflicted, by creating a new state for mempool dropped transaction 10:08 < LarryRuane> i thought it was defining those states 10:10 < ishaanam[m]> LarryRuane: yes, I think there was some confusion about that earlier as well, I think I'll go back and clarify the notes 10:10 < LarryRuane> I still didn't understand (sorry, you can go on) exactly which event(s) causes funds (by which I think you mean balance) to briefly disappear? And which event(s) cause them to come back? 10:11 < LarryRuane> But as I said, you can go on if everyone else gets it :) 10:11 < ishaanam[m]> abubakarasdiq: while a new transaction state is created for mempool conflicted transactions, I don't think that mempool dropped transactions were ever marked as TxStateConflicted? 10:12 < ishaanam[m]> Also, I want to clarify that this new transaction state is only applied to transactions which are conflicted by another transaction in the mempool, not transactions which have been dropped without conflicts 10:13 < abubakarsadiq> thanks 10:14 < BrandonOdiwuor> I think the PR tries to solve the issue of mempool conflicted transactions being treated as TxStateInactive by adding TxStateMempoolConflicted state 10:15 < ishaanam[m]> LarryRuane: Because the funds are marked as TxStateInactive when they are conflicted out of the mempool, the wallet will not show the outputs (the funds which disappear), but it will still consider the inputs as spent 10:15 < ishaanam[m]> BrandonOdiwuor: yes! 10:15 < LarryRuane> ishaanam[m]: +1 thanks 10:16 < ishaanam[m]> That being said, what are the trade-offs with considering a mempool-conflicted transaction as TxStateMempoolConflicted instead of TxStateInactive? 10:18 < ishaanam[m]> Meaning, is it more or less "safe", from a user's perspective 10:19 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 10:20 < abubakarsadiq> mempool-conflicted transaction inputs will no longer be considered as spent 10:20 < ishaanam[m]> Is it better to err on the side of caution and consider something as "spent" even if it technically is not, or consider something as "unspent" even though it's funds could potentially be spent (though not likely)? 10:21 < LarryRuane> considering something as spent that may not be seems like the more conservative view 10:21 < Pins> +1 10:22 < LarryRuane> and in bitcoin we like to be conservative 😄 10:22 < Pins> ;D 10:22 < ishaanam[m]> yes, that's true 10:23 < ishaanam[m]> What is the benefit of adding another transaction state (TxStateMempoolConflicted) instead of just using TxStateConflicted? 10:24 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 10:25 < evansmj> other wallets can differentiate between either mempool or block conflicts more clearly with the new state in transaction.h, and display it different or inform the user whats going on? 10:25 < BrandonOdiwuor> To distinguish between block conflicted and mempool conflicted transactions 10:25 < Pins> Diferentiate the kind of conflict 10:26 < ishaanam[m]> evansmj: BrandonOdiwuor: Pins: Yes, to make the distinction more clear. 10:27 < ishaanam[m]> There was a previous attempt at this PR where TxStateConflicted was used 10:27 < evansmj> does marking a tx as a mempool-conflict consider it "spent" or "unspent"? 10:27 < evansmj> vs inactive 10:27 < Pins> evansmj spent 10:29 < Pins> I'm not very sure 10:29 < ishaanam[m]> Also, because previously mempool-conflicted states were serialized differently, a new tx state was introduced to maintain this behavior 10:29 < ishaanam[m]> evansmj: Pins: Marking a tx as mempool-conflicted means that it's inputs are "unspent" 10:30 < Pins> ishaanam[m] Yes, sure ... thanks 10:30 < ishaanam[m]> The code for this is here: https://github.com/bitcoin/bitcoin/pull/27307/commits/2be57fea174b7079b86d3954413c7be1fd993db2#diff-69473389a98be9232528ccdef04f9fa51ce8c5558e64994e15589be924eebae3L259-R260 10:31 < LarryRuane> One thing that I found was pretty interesting, and I wasn't aware of, is `std::get_if` https://github.com/bitcoin/bitcoin/blob/d6ee03507f39223889a5f039c4db7204ddfb91d5/src/wallet/transaction.h#L314 ... that's some pretty advanced c++ 10:31 -!- BrandonOdiwuor98 [~BrandonOd@105.162.13.122] has joined #bitcoin-core-pr-reviews 10:31 < abubakarsadiq> whats the difference between mempool conficted and mempool dropped transactions? 10:32 < ishaanam[m]> After a wallet is reloaded, what will be the transaction state of a previously mempool-conflicted transaction? 10:32 < Pins> ishaanam[m] TxStateInactive 10:34 < ishaanam[m]> abubakarsadiq: the way I see it is that mempool conflicted transactions are a subset of mempool dropped transactions. 10:34 < abubakarsadiq> in master TxStateInactive, with this pr TxStateMempoolConflicted 10:34 < ishaanam[m]> mempool dropped transactions could have been dropped for some reason other than being conflicted 10:35 < evansmj> after a wallet reload will it go through WalletBatch::LoadWallet() which will start everything over again, or will it do the mapWallet check when a wallet is 'reloaded'? 10:35 -!- BrandonOdiwuor [~BrandonOd@105.162.13.122] has quit [Ping timeout: 250 seconds] 10:35 -!- BrandonOdiwuor98 is now known as BrandonOdiwuor 10:35 < ishaanam[m]> For example, they could have been dropped from the mempool because of size-limiting 10:36 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 10:36 < ishaanam[m]> Pins: yes 10:37 < ishaanam[m]> abubakarsadiq: Because this PR doesn't change how mempool-conflicted transactions are serialized, and previously they would be considered TxStateInactive, it is still TxStateInactive 10:39 < ishaanam[m]> evansmj: it won't go through the mapTxSpends check that it does during `transactionAddedToMempool` and `transactionRemovedFromMempool`, if that's what you mean 10:40 < ishaanam[m]> Come to think of it, there should be a test for reloading a wallet with a mempool-conflicted transaction 10:40 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 10:40 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 10:40 < ishaanam[m]> Speaking of tests, has anyone tried running the added tests on master? 10:41 < evansmj> so just copy paste the new tests to master and make sure they fail? 10:42 -!- markus [~markus@159.148.154.210] has joined #bitcoin-core-pr-reviews 10:42 < ishaanam[m]> evansmj: You could do that, or you could run git cherry-pick 0538ad7d4cfddb5a377f879cbf221b2b028c264a(the test commit hash) so that only the commit with the tests gets added to your master branch 10:43 < abubakarsadiq> evansmj: or can just run the test without compiling the pr 10:43 < abubakarsadiq> thanks ishaanam 10:44 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 10:45 < ishaanam[m]> Are there any additional test cases that you would like to see implemented? 10:49 < ishaanam[m]> What about the first commit of this PR, does it change any existing behavior? 10:50 < ishaanam[m]> This is the commit that I'm referring to: https://github.com/bitcoin/bitcoin/pull/27307/commits/2be57fea174b7079b86d3954413c7be1fd993db2 10:52 -!- ishaana [~ishaana@96.232.34.225] has joined #bitcoin-core-pr-reviews 10:54 < evansmj> makes CachedTxIsTrusted() use the new tx state instead of checking tx depth 10:55 < evansmj> same for IsTxInMainChain() 10:55 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 10:55 < LarryRuane> I don't think that commit changed behavior. You could run the existing tests on just that commit and see if any fail. If none fail, this *may* be a behavior non-change. (I guess you still can't be sure.) 10:57 < ishaanam[m]> evansmj: yes, there were multiple places that used the depth instead of just checking the state 10:58 < ishaanam[m]> LarryRuane: Yes, this commit is interesting because it is technically just a refactor, but this PR won't work without it. This is because it changed the balance calculation by modifying IsSpent. 10:58 < ishaanam[m]> If depth was still used, then mempool-conflicted transactions would have a depth of 0, so their inputs would be considered as spent. 10:59 < LarryRuane> +1 makes sense 11:00 < ishaanam[m]> It looks like an hour is up 11:00 < ishaanam[m]> thanks everyone for coming! 11:00 < ishaanam[m]> #endmeeting 11:01 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 264 seconds] 11:02 < abubakarsadiq> Thanks ishanaam 11:02 < Pins> thnak you 11:03 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 11:04 -!- BrandonOdiwuor52 [~BrandonOd@105.162.13.122] has joined #bitcoin-core-pr-reviews 11:04 -!- BrandonOdiwuor52 [~BrandonOd@105.162.13.122] has quit [Client Quit] 11:05 -!- ishaana [~ishaana@96.232.34.225] has quit [Quit: Connection closed] 11:05 -!- BrandonOdiwuor [~BrandonOd@105.162.13.122] has quit [Ping timeout: 252 seconds] 11:06 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 11:07 -!- markus [~markus@159.148.154.210] has quit [Ping timeout: 240 seconds] 11:08 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 11:10 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 11:13 < evansmj> i do get errors when running the new tests on master 11:17 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 11:18 < LarryRuane> Thank you, @ishaanam[m]! Very interesting PR! 11:21 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 11:21 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 11:23 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 11:25 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 11:26 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 11:29 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 246 seconds] 11:30 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 11:35 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 11:48 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 11:52 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 12:06 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 12:11 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 12:15 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 12:19 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 240 seconds] 12:20 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 12:27 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 240 seconds] 12:27 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 12:32 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 12:33 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 12:36 -!- Pins [~Pins@179.209.140.115] has quit [Quit: Connection closed] 12:38 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 12:50 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 12:56 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 12:57 -!- drusilla [uid607105@id-607105.helmsley.irccloud.com] has quit [Quit: Connection closed for inactivity] 13:03 -!- ___nick___ [~quassel@host86-164-104-156.range86-164.btcentralplus.com] has quit [Ping timeout: 245 seconds] 13:08 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 13:11 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity] 13:14 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 13:19 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-pr-reviews 13:25 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 13:30 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 13:30 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 264 seconds] 14:09 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Remote host closed the connection] 14:10 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 14:15 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 264 seconds] 14:18 -!- josie [~josibake@suhail.uberspace.de] has quit [Server closed connection] 14:18 -!- josie [~josibake@suhail.uberspace.de] has joined #bitcoin-core-pr-reviews 14:27 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 14:27 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Read error: Connection reset by peer] 14:27 -!- TheRec [~toto@user/therec] has joined #bitcoin-core-pr-reviews 14:28 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 14:31 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 14:33 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 14:33 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 14:37 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 14:43 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 15:03 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Remote host closed the connection] 15:04 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 15:08 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 264 seconds] 15:11 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 16:14 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Remote host closed the connection] 16:15 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 16:41 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Remote host closed the connection] 16:41 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 16:46 -!- achow101 [~achow101@user/achow101] has quit [Ping timeout: 250 seconds] 16:46 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 264 seconds] 16:47 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-pr-reviews 16:57 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 17:02 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 240 seconds] 17:13 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 17:18 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 17:23 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 17:28 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 246 seconds] 17:36 -!- Davers [~Davers@pool-108-51-145-141.washdc.fios.verizon.net] has joined #bitcoin-core-pr-reviews 17:37 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 17:38 -!- Davers [~Davers@pool-108-51-145-141.washdc.fios.verizon.net] has left #bitcoin-core-pr-reviews [] 17:40 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 17:41 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 17:46 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 17:56 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 18:01 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 264 seconds] 18:01 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity] 18:12 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 18:17 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 18:19 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 18:24 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 18:24 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 18:27 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 18:29 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 18:29 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 18:31 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 18:34 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 18:36 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 18:41 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 264 seconds] 18:46 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 18:50 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 19:02 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 19:07 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 19:19 -!- evansmj [~evansmj@pool-72-66-113-135.washdc.fios.verizon.net] has quit [Quit: Connection closed] 19:20 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 19:24 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 19:24 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 19:28 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 245 seconds] 19:37 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 19:40 -!- Netsplit *.net <-> *.split quits: angusp, BUSY 19:42 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 264 seconds] 19:44 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 19:46 -!- kevkevin [~kevkevin@2601:241:8703:7b30:dcbb:5adc:637d:c1c] has quit [Remote host closed the connection] 19:46 -!- Netsplit over, joins: angusp, BUSY 19:48 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 240 seconds] 20:01 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 20:05 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 264 seconds] 20:15 -!- grettke [~grettke@065-026-198-174.biz.spectrum.com] has quit [Quit: grettke] 20:19 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 20:23 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 240 seconds] 20:32 -!- TheRec [~toto@user/therec] has quit [] 20:35 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 20:40 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 252 seconds] 20:45 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 20:50 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 20:53 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:6b:c684:7a07:d8a2] has quit [Remote host closed the connection] 20:54 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:948e:23fb:c999:a53b] has joined #bitcoin-core-pr-reviews 20:59 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:948e:23fb:c999:a53b] has quit [Ping timeout: 264 seconds] 21:01 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 21:02 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-pr-reviews 21:02 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 21:02 -!- TheRec [~toto@user/therec] has joined #bitcoin-core-pr-reviews 21:06 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 245 seconds] 21:20 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 21:25 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 21:28 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 21:28 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:948e:23fb:c999:a53b] has joined #bitcoin-core-pr-reviews 21:33 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 21:33 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 21:33 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:948e:23fb:c999:a53b] has quit [Ping timeout: 260 seconds] 21:38 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 245 seconds] 21:42 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 21:46 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 245 seconds] 21:49 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 21:53 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 22:01 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:948e:23fb:c999:a53b] has joined #bitcoin-core-pr-reviews 22:05 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 22:06 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:948e:23fb:c999:a53b] has quit [Ping timeout: 246 seconds] 22:08 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews 22:08 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 22:09 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 22:12 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 240 seconds] 22:13 -!- andrew_m_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 22:14 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:948e:23fb:c999:a53b] has joined #bitcoin-core-pr-reviews 22:14 -!- b_101 [~robert@187.202.249.157] has quit [Ping timeout: 246 seconds] 22:18 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:948e:23fb:c999:a53b] has quit [Ping timeout: 260 seconds] 22:20 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 22:25 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 245 seconds] 22:26 -!- jon_atack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer] 22:26 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 22:37 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 22:39 -!- b_101 [~robert@187.202.249.157] has joined #bitcoin-core-pr-reviews 22:41 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds] 22:41 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews 22:43 -!- b_101 [~robert@187.202.249.157] has quit [Ping timeout: 260 seconds] 22:46 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 245 seconds] 22:55 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 22:59 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 245 seconds] 23:00 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 23:04 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:948e:23fb:c999:a53b] has joined #bitcoin-core-pr-reviews 23:05 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 23:08 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:948e:23fb:c999:a53b] has quit [Ping timeout: 264 seconds] 23:14 -!- b_101 [~robert@187.202.249.157] has joined #bitcoin-core-pr-reviews 23:18 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 23:23 -!- b_101 [~robert@187.202.249.157] has quit [Ping timeout: 260 seconds] 23:23 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 250 seconds] 23:35 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 23:39 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:948e:23fb:c999:a53b] has joined #bitcoin-core-pr-reviews 23:40 -!- __gotcha [~Thunderbi@94.105.119.44.dyn.edpnet.net] has quit [Ping timeout: 260 seconds] 23:40 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 245 seconds] 23:44 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:948e:23fb:c999:a53b] has quit [Ping timeout: 264 seconds] 23:46 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-pr-reviews 23:51 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 245 seconds] --- Log closed Thu Jun 29 00:00:46 2023