--- Log opened Thu Sep 07 00:00:17 2023
00:04 -!- __gotcha [~Thunderbi@85.234.220.64] has quit [Ping timeout: 258 seconds]
00:30 -!- pablomartin [~pablomart@193.160.247.138] has quit [Ping timeout: 255 seconds]
00:45 -!- puchka [~puchka@185.203.122.98] has joined #bitcoin-core-pr-reviews
00:51 -!- __gotcha [~Thunderbi@natx-145.kulnet.kuleuven.be] has joined #bitcoin-core-pr-reviews
01:25 -!- __gotcha1 [~Thunderbi@natx-145.kulnet.kuleuven.be] has joined #bitcoin-core-pr-reviews
01:25 -!- __gotcha [~Thunderbi@natx-145.kulnet.kuleuven.be] has quit [Read error: Connection reset by peer]
01:25 -!- __gotcha1 is now known as __gotcha
01:51 -!- __gotcha [~Thunderbi@natx-145.kulnet.kuleuven.be] has quit [Ping timeout: 240 seconds]
02:07 -!- __gotcha [~Thunderbi@natx-145.kulnet.kuleuven.be] has joined #bitcoin-core-pr-reviews
02:14 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-pr-reviews
03:24 -!- emzy [~quassel@user/emzy] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
03:30 -!- emzy [~quassel@user/emzy] has joined #bitcoin-core-pr-reviews
04:12 -!- __gotcha [~Thunderbi@natx-145.kulnet.kuleuven.be] has quit [Ping timeout: 244 seconds]
04:42 -!- __gotcha [~Thunderbi@natx-145.kulnet.kuleuven.be] has joined #bitcoin-core-pr-reviews
04:43 -!- __gotcha1 [~Thunderbi@natx-145.kulnet.kuleuven.be] has joined #bitcoin-core-pr-reviews
04:45 -!- __gotcha1 [~Thunderbi@natx-145.kulnet.kuleuven.be] has quit [Read error: Connection reset by peer]
04:46 -!- __gotcha [~Thunderbi@natx-145.kulnet.kuleuven.be] has quit [Read error: Connection reset by peer]
04:46 -!- lowhope_ [~lowhope@cow9.org] has quit [Server closed connection]
04:46 -!- lowhope_ [~lowhope@cow9.org] has joined #bitcoin-core-pr-reviews
04:47 -!- __gotcha [~Thunderbi@natx-145.kulnet.kuleuven.be] has joined #bitcoin-core-pr-reviews
06:58 -!- SebastianvStaa [~Sebastian@185.221.132.221] has joined #bitcoin-core-pr-reviews
06:59 -!- SebastianvStaa6 [~Sebastian@185.221.132.221] has joined #bitcoin-core-pr-reviews
07:00 -!- puchka [~puchka@185.203.122.98] has quit [Ping timeout: 258 seconds]
07:02 -!- SebastianvStaa [~Sebastian@185.221.132.221] has quit [Client Quit]
07:04 -!- SebastianvStaa [~Sebastian@ip-095-223-106-143.um35.pools.vodafone-ip.de] has joined #bitcoin-core-pr-reviews
07:06 -!- puchka [~puchka@185.203.122.98] has joined #bitcoin-core-pr-reviews
07:08 -!- SebastianvStaa6 [~Sebastian@185.221.132.221] has quit [Ping timeout: 258 seconds]
07:11 -!- puchka [~puchka@185.203.122.98] has quit [Ping timeout: 255 seconds]
07:21 -!- brunoerg [~brunoerg@50.204.42.240] has joined #bitcoin-core-pr-reviews
07:29 -!- puchka [~puchka@185.203.122.98] has joined #bitcoin-core-pr-reviews
07:47 -!- SebastianvStaa [~Sebastian@ip-095-223-106-143.um35.pools.vodafone-ip.de] has quit [Quit: Connection closed]
07:51 -!- pablomartin [~pablomart@193.160.247.132] has joined #bitcoin-core-pr-reviews
07:56 -!- pablomartin is now known as pablomartin4btc
08:02 -!- brunoerg [~brunoerg@50.204.42.240] has quit [Remote host closed the connection]
08:09 -!- brunoerg [~brunoerg@50.204.42.240] has joined #bitcoin-core-pr-reviews
08:46 -!- brunoerg [~brunoerg@50.204.42.240] has quit [Remote host closed the connection]
08:51 -!- __gotcha [~Thunderbi@natx-145.kulnet.kuleuven.be] has quit [Ping timeout: 240 seconds]
09:24 -!- pablomartin4btc [~pablomart@193.160.247.132] has quit [Ping timeout: 245 seconds]
09:54 -!- dberkelmans [~dberkelma@2001:1c03:530d:8100:e52b:63ba:aaa:150d] has joined #bitcoin-core-pr-reviews
09:55 -!- vmammal [~vmammal@162.250.26.106] has joined #bitcoin-core-pr-reviews
10:00 < glozow> hi!
10:00 < lightlike> hi
10:00 < glozow> #startmeeting
10:01 < dberkelmans> hi
10:01 < glozow> Welcome to PR review club, today is meeting #2 for #28165: https://bitcoincore.reviews/28165
10:01 < glozow> Feel free to say hi so we know you're here
10:01 < glozow> If you're not here, don't say hi
10:02 < glozow> A tad quieter than yesterday. Did anybody get a chance to review the PR or look at the notes/questions?
10:03 < lightlike> I did review the PR some weeks ago, looked at the questions a bit too.
10:04 < sipa> hi, i'm here
10:05 < glozow> :D
10:05 < glozow> Would anybody like to summarize what this PR is doing?
10:06 < glozow> haha I guess we've all moved on to #28196?
10:07 < lightlike> looks like it :(
10:07 < sipa> I'm not complaining.
10:07 < glozow> :P
10:08 < lightlike> yep, re-reviewing that right now.
10:09 -!- brunoerg [~brunoerg@50.204.42.240] has joined #bitcoin-core-pr-reviews
10:10 < glozow> ok if anybody wants to go through the questions for today's meeting please speak up rn, otherwise we can just end here / chat about 28196
10:10 < glozow> #endmeeting
10:12 < dberkelmans> I want to understand the code but find it hard to start (having a background in C#)
10:12 < dberkelmans> Any other suggestions or groups that work together in a way
10:13 < dberkelmans> I have a day a week available to spend
10:14 < glozow> dberkelmans: usually I'd recommend review club as a good place for beginners! it's how I got started
10:15 < dberkelmans> That's why I'm here but I didn't have enough time to prepare except reading the notes/pr
10:16 < glozow> ah, great that you prepared! do you want to go through the questions together?
10:18 < dberkelmans> No it's like starting at the end, I'm used to doing stuff and then debugging and steppng through code. But my c++ is bad so I'm trying to level that
10:19 < dberkelmans> I've got the code running in Visual Studio but have some warnings and errors in test and have the impression that I'm missing settings or variabeles and don't have  a place to ask if I'm doing something wrong
10:20 < glozow> Yeah it's a learning curve. If you like books, I found A Tour of C++ quite helpful when I was starting out.
10:20 < glozow> Are you running into these errors on master?
10:20 < sipa> I'm not sure how many developers use Visual Studio for Bitcoin Core, which may make it harder to find guides.
10:20 < sipa> hebasto perhaps does
10:24 < dberkelmans> Yeah I allready thought there are less microsoft based developers, for the c++ part it doesn't matter. The errors are only when rebuilding and I guess only on test units because it runs
10:27 < dberkelmans> Thanks for the time, I'll just keep joining and trying to get a grasp of the overall project and how thinks work and see if I can make myself usefull while learning
10:46 -!- vmammal [~vmammal@162.250.26.106] has quit [Quit: Connection closed]
10:49 -!- dberkelmans [~dberkelma@2001:1c03:530d:8100:e52b:63ba:aaa:150d] has quit [Quit: Client closed]
10:53 -!- brunoerg [~brunoerg@50.204.42.240] has quit [Remote host closed the connection]
10:56 -!- brunoerg [~brunoerg@50.204.42.240] has joined #bitcoin-core-pr-reviews
11:03 -!- grettke [~grettke@065-026-198-174.biz.spectrum.com] has joined #bitcoin-core-pr-reviews
11:17 -!- jamesob [~jamesob@108.44.248.162] has quit [Ping timeout: 260 seconds]
11:25 -!- brunoerg [~brunoerg@50.204.42.240] has quit [Remote host closed the connection]
11:34 -!- brunoerg [~brunoerg@50.204.42.240] has joined #bitcoin-core-pr-reviews
11:45 -!- brunoerg [~brunoerg@50.204.42.240] has quit [Remote host closed the connection]
11:55 -!- brunoerg [~brunoerg@50.204.42.240] has joined #bitcoin-core-pr-reviews
12:00 -!- brunoerg [~brunoerg@50.204.42.240] has quit [Remote host closed the connection]
12:03 -!- brunoerg [~brunoerg@50.204.42.240] has joined #bitcoin-core-pr-reviews
12:17 -!- pablomartin [~pablomart@193.160.247.137] has joined #bitcoin-core-pr-reviews
12:32 -!- brunoerg [~brunoerg@50.204.42.240] has quit [Remote host closed the connection]
12:34 -!- brunoerg [~brunoerg@50.204.42.240] has joined #bitcoin-core-pr-reviews
12:36 -!- pablomartin is now known as pablomartinbtc
13:05 -!- brunoerg [~brunoerg@50.204.42.240] has quit [Remote host closed the connection]
13:14 -!- brunoerg [~brunoerg@50.204.42.240] has joined #bitcoin-core-pr-reviews
13:29 -!- brunoerg [~brunoerg@50.204.42.240] has quit []
14:25 -!- pablomartinbtc [~pablomart@193.160.247.137] has quit [Remote host closed the connection]
14:25 -!- pablomartinbtc [~pablomart@193.160.247.137] has joined #bitcoin-core-pr-reviews
14:27 -!- userhello [~userhello@cpe-24-168-85-43.si.res.rr.com] has joined #bitcoin-core-pr-reviews
14:28 -!- userhello [~userhello@cpe-24-168-85-43.si.res.rr.com] has quit [Client Quit]
14:28 -!- pablomartin4btc [~pablomart@193.160.247.130] has joined #bitcoin-core-pr-reviews
14:30 -!- pablomartinbtc [~pablomart@193.160.247.137] has quit [Ping timeout: 258 seconds]
14:31 < BrinkingChancell> I'd like to go over the questions quickly if no one minds
14:31 < BrinkingChancell> I went over the material from yesterday extensively, but not as much for this PR-specific
14:58 -!- jon_atack [~jonatack@user/jonatack] has quit [Quit: WeeChat 3.8]
15:34 -!- pablomartin4btc [~pablomart@193.160.247.130] has quit [Remote host closed the connection]
15:35 -!- pablomartin4btc [~pablomart@193.160.247.130] has joined #bitcoin-core-pr-reviews
15:43 -!- pablomartin4btc [~pablomart@193.160.247.130] has quit [Ping timeout: 255 seconds]
16:34 -!- BrinkingChancell [~BrinkingC@cpe-24-168-85-43.si.res.rr.com] has quit [Quit: Connection closed]
18:16 -!- johnzweng [~johnzweng@zweng.at] has quit [Server closed connection]
18:16 -!- johnzweng [~johnzweng@zweng.at] has joined #bitcoin-core-pr-reviews
19:25 -!- pablomartin [~pablomart@193.160.247.135] has joined #bitcoin-core-pr-reviews
19:25 -!- pablomartin is now known as pablomartinbtc
20:34 -!- pablomartinbtc [~pablomart@193.160.247.135] has quit [Ping timeout: 258 seconds]
20:36 -!- pablomartinbtc [~pablomart@193.160.247.131] has joined #bitcoin-core-pr-reviews
20:55 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews
21:23 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
22:38 -!- pablomartinbtc [~pablomart@193.160.247.131] has quit [Ping timeout: 246 seconds]
22:43 -!- pablomartinbtc [~pablomart@193.160.247.130] has joined #bitcoin-core-pr-reviews
23:22 -!- duderonomy [~duderonom@c-107-3-165-79.hsd1.ca.comcast.net] has quit [Ping timeout: 246 seconds]
23:24 -!- duderonomy_ [~duderonom@c-107-3-165-79.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews
--- Log closed Fri Sep 08 00:00:19 2023