--- Log opened Fri Nov 10 00:00:23 2023
00:19 -!- fanquake [sid369002@user/fanquake] has quit [Server closed connection]
00:19 -!- fanquake [sid369002@user/fanquake] has joined #bitcoin-core-pr-reviews
00:30 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
00:35 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 264 seconds]
00:36 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
00:46 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 264 seconds]
00:52 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
00:57 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 258 seconds]
01:23 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
01:24 -!- Amirreza [~Amirreza7@2.177.23.195] has joined #bitcoin-core-pr-reviews
01:26 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Remote host closed the connection]
01:26 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
01:26 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-pr-reviews
01:31 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 252 seconds]
01:34 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
01:38 -!- ariard [~ariard@167.99.46.220] has quit [Server closed connection]
01:38 -!- ariard [~ariard@167.99.46.220] has joined #bitcoin-core-pr-reviews
01:41 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Remote host closed the connection]
01:42 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
01:47 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 258 seconds]
01:53 -!- kevkevin [~kevkevin@2601:241:8703:7b30:98bc:619b:150:7a29] has joined #bitcoin-core-pr-reviews
01:58 -!- kevkevin [~kevkevin@2601:241:8703:7b30:98bc:619b:150:7a29] has quit [Ping timeout: 258 seconds]
02:26 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
02:31 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 240 seconds]
02:31 < Amirreza> Hi everyone, I'm working on PR #27638. I added a new field to the result of TxToUniv function in `src/core_write.cpp`. Now many tests are failed due to this unrecognized field. Should I add this new field to CTxIn class in test_framework/messages.py? The problem with this approach is that it cause mismatch in calculating transaction weight.
02:32 < Amirreza> PR link: https://github.com/bitcoin/bitcoin/pull/27638
02:41 -!- kevkevin [~kevkevin@98.226.43.69] has joined #bitcoin-core-pr-reviews
02:45 -!- kevkevin [~kevkevin@98.226.43.69] has quit [Ping timeout: 246 seconds]
03:02 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
03:07 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 246 seconds]
03:32 -!- kevkevin [~kevkevin@2601:241:8703:7b30:98bc:619b:150:7a29] has joined #bitcoin-core-pr-reviews
03:36 -!- kevkevin [~kevkevin@2601:241:8703:7b30:98bc:619b:150:7a29] has quit [Ping timeout: 240 seconds]
03:37 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
03:38 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Remote host closed the connection]
03:39 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
03:47 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 255 seconds]
03:54 -!- amirreza79 [~Amirreza7@104.28.249.49] has joined #bitcoin-core-pr-reviews
03:54 -!- Amirreza [~Amirreza7@2.177.23.195] has quit [Ping timeout: 252 seconds]
04:06 -!- kevkevin [~kevkevin@2601:241:8703:7b30:98bc:619b:150:7a29] has joined #bitcoin-core-pr-reviews
04:11 -!- kevkevin [~kevkevin@2601:241:8703:7b30:98bc:619b:150:7a29] has quit [Ping timeout: 272 seconds]
04:16 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
04:21 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 246 seconds]
04:24 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
04:34 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
05:07 -!- Murch[m] [~murch@user/murch] has quit [Server closed connection]
05:07 -!- Murch[m] [~murch@2620:6e:a000:ce11::1b] has joined #bitcoin-core-pr-reviews
05:13 -!- kevkevin [~kevkevin@2601:241:8703:7b30:98bc:619b:150:7a29] has joined #bitcoin-core-pr-reviews
05:18 -!- kevkevin [~kevkevin@2601:241:8703:7b30:98bc:619b:150:7a29] has quit [Ping timeout: 252 seconds]
06:15 -!- kevkevin [~kevkevin@2601:241:8703:7b30:98bc:619b:150:7a29] has joined #bitcoin-core-pr-reviews
06:20 -!- kevkevin [~kevkevin@2601:241:8703:7b30:98bc:619b:150:7a29] has quit [Ping timeout: 252 seconds]
06:23 -!- jonatack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer]
06:24 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews
06:31 -!- stickies-v [sid544753@id-544753.uxbridge.irccloud.com] has quit [Server closed connection]
06:31 -!- stickies-v [sid544753@id-544753.uxbridge.irccloud.com] has joined #bitcoin-core-pr-reviews
06:48 -!- kevkevin [~kevkevin@2601:241:8703:7b30:98bc:619b:150:7a29] has joined #bitcoin-core-pr-reviews
06:49 -!- dergoegge [sid453889@id-453889.lymington.irccloud.com] has quit [Server closed connection]
06:49 -!- dergoegge [sid453889@id-453889.lymington.irccloud.com] has joined #bitcoin-core-pr-reviews
06:52 -!- kevkevin [~kevkevin@2601:241:8703:7b30:98bc:619b:150:7a29] has quit [Ping timeout: 258 seconds]
07:16 -!- kevkevin [~kevkevin@2601:241:8703:7b30:98bc:619b:150:7a29] has joined #bitcoin-core-pr-reviews
07:20 -!- kevkevin [~kevkevin@2601:241:8703:7b30:98bc:619b:150:7a29] has quit [Client Quit]
07:41 -!- kevkevin [~kevkevin@2601:241:8703:7b30:e080:3126:7632:c1f2] has joined #bitcoin-core-pr-reviews
07:46 -!- amirreza97 [~Amirreza7@2.177.23.195] has joined #bitcoin-core-pr-reviews
07:48 -!- amirreza79 [~Amirreza7@104.28.249.49] has quit [Ping timeout: 255 seconds]
08:25 -!- kashifs [~kashifs@cpe-24-168-85-43.si.res.rr.com] has joined #bitcoin-core-pr-reviews
08:26 -!- kashifs [~kashifs@cpe-24-168-85-43.si.res.rr.com] has quit [Client Quit]
09:28 -!- amirreza97 [~Amirreza7@2.177.23.195] has quit [Ping timeout: 255 seconds]
10:23 -!- achow101 [~achow101@user/achow101] has quit [Remote host closed the connection]
10:27 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-pr-reviews
10:28 -!- kevkevin [~kevkevin@2601:241:8703:7b30:e080:3126:7632:c1f2] has quit [Remote host closed the connection]
10:33 -!- kevkevin [~kevkevin@2601:241:8703:7b30:e080:3126:7632:c1f2] has joined #bitcoin-core-pr-reviews
10:40 -!- achow101 [~achow101@user/achow101] has quit [Remote host closed the connection]
10:40 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-pr-reviews
10:42 -!- achow101 [~achow101@user/achow101] has quit [Remote host closed the connection]
10:43 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-pr-reviews
11:03 -!- achow101 [~achow101@user/achow101] has quit [Remote host closed the connection]
11:04 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-pr-reviews
11:05 -!- achow101 [~achow101@user/achow101] has quit [Remote host closed the connection]
11:21 -!- grettke [~grettke@065-026-198-174.biz.spectrum.com] has joined #bitcoin-core-pr-reviews
11:21 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-pr-reviews
11:22 -!- achow101 [~achow101@user/achow101] has quit [Read error: Connection reset by peer]
12:34 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-pr-reviews
13:13 -!- FelixWeis_ [sid154231@id-154231.hampstead.irccloud.com] has quit [Server closed connection]
13:13 -!- FelixWeis_ [sid154231@id-154231.hampstead.irccloud.com] has joined #bitcoin-core-pr-reviews
13:51 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews
14:13 -!- kevkevin [~kevkevin@2601:241:8703:7b30:e080:3126:7632:c1f2] has quit [Remote host closed the connection]
14:27 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
14:30 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Remote host closed the connection]
14:30 -!- kevkevin [~kevkevin@2601:241:8703:7b30:e080:3126:7632:c1f2] has joined #bitcoin-core-pr-reviews
14:31 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
14:34 -!- kevkevin [~kevkevin@2601:241:8703:7b30:e080:3126:7632:c1f2] has quit [Ping timeout: 252 seconds]
14:35 -!- kevkevin [~kevkevin@2601:241:8703:7b30:e080:3126:7632:c1f2] has joined #bitcoin-core-pr-reviews
14:35 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 246 seconds]
14:55 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
15:00 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 272 seconds]
15:17 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
15:22 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 240 seconds]
15:23 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
15:27 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 246 seconds]
15:45 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
15:47 -!- RubenSomsen [sid301948@user/rubensomsen] has quit [Server closed connection]
15:47 -!- RubenSomsen [sid301948@user/rubensomsen] has joined #bitcoin-core-pr-reviews
15:50 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 264 seconds]
15:56 -!- kevkevin [~kevkevin@2601:241:8703:7b30:e080:3126:7632:c1f2] has quit [Remote host closed the connection]
16:07 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
16:12 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 264 seconds]
16:26 -!- stratospher [uid514069@id-514069.ilkley.irccloud.com] has quit [Server closed connection]
16:26 -!- stratospher [uid514069@id-514069.ilkley.irccloud.com] has joined #bitcoin-core-pr-reviews
16:27 -!- kevkevin [~kevkevin@2601:241:8703:7b30:e080:3126:7632:c1f2] has joined #bitcoin-core-pr-reviews
16:36 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
16:40 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 246 seconds]
16:40 -!- kevkevin [~kevkevin@2601:241:8703:7b30:e080:3126:7632:c1f2] has quit [Ping timeout: 246 seconds]
16:48 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
16:53 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 252 seconds]
16:54 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
16:59 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
17:09 -!- kevkevin [~kevkevin@2601:241:8703:7b30:e080:3126:7632:c1f2] has joined #bitcoin-core-pr-reviews
17:22 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
17:27 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 252 seconds]
17:40 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
17:44 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 258 seconds]
17:45 -!- kevkevin [~kevkevin@2601:241:8703:7b30:e080:3126:7632:c1f2] has quit [Remote host closed the connection]
18:06 -!- kevkevin [~kevkevin@2601:241:8703:7b30:25dd:8838:a5ef:a4e0] has joined #bitcoin-core-pr-reviews
18:10 -!- kevkevin [~kevkevin@2601:241:8703:7b30:25dd:8838:a5ef:a4e0] has quit [Ping timeout: 258 seconds]
18:12 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
18:17 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 264 seconds]
18:25 -!- Netsplit *.net <-> *.split quits: jess
18:26 -!- Netsplit over, joins: jess
18:27 -!- kevkevin [~kevkevin@2601:241:8703:7b30:25dd:8838:a5ef:a4e0] has joined #bitcoin-core-pr-reviews
18:46 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
18:51 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
18:53 -!- kevkevin [~kevkevin@2601:241:8703:7b30:25dd:8838:a5ef:a4e0] has quit [Ping timeout: 246 seconds]
19:13 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
19:17 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 240 seconds]
19:18 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
19:23 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 246 seconds]
19:32 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
19:37 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 258 seconds]
19:44 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
19:52 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 264 seconds]
19:57 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
20:02 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 246 seconds]
20:02 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
20:07 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 264 seconds]
20:25 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
20:37 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 272 seconds]
20:38 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
20:38 -!- kevkevin [~kevkevin@2601:241:8703:7b30:f4a7:e742:6b3e:8560] has joined #bitcoin-core-pr-reviews
20:43 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 264 seconds]
20:43 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
20:48 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 252 seconds]
20:54 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
20:59 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 252 seconds]
21:17 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
21:21 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 246 seconds]
21:33 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
21:36 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-pr-reviews
21:38 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 252 seconds]
21:55 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
22:00 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 246 seconds]
22:09 -!- kevkevin [~kevkevin@2601:241:8703:7b30:f4a7:e742:6b3e:8560] has quit [Remote host closed the connection]
22:21 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
22:25 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 240 seconds]
22:41 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has joined #bitcoin-core-pr-reviews
22:42 -!- kevkevin [~kevkevin@2601:241:8703:7b30:f4a7:e742:6b3e:8560] has joined #bitcoin-core-pr-reviews
22:46 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:d490:fb70:7f18:4022] has quit [Ping timeout: 246 seconds]
22:46 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
22:47 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
22:47 -!- kevkevin [~kevkevin@2601:241:8703:7b30:f4a7:e742:6b3e:8560] has quit [Ping timeout: 272 seconds]
23:15 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews
23:25 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 252 seconds]
--- Log closed Sat Nov 11 00:00:24 2023