--- Log opened Thu Feb 01 00:00:46 2024 00:09 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Quit: Leaving] 00:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews 00:51 -!- __gotcha [~Thunderbi@natx-145.kulnet.kuleuven.be] has joined #bitcoin-core-pr-reviews 01:14 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 255 seconds] 01:15 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews 02:09 -!- Guest20 [~Guest20@109-81-93-228.rct.o2.cz] has joined #bitcoin-core-pr-reviews 02:11 -!- Guest20 [~Guest20@109-81-93-228.rct.o2.cz] has quit [Client Quit] 02:29 -!- puchka [~puchka@185.203.122.132] has quit [Ping timeout: 260 seconds] 02:51 -!- puchka [~puchka@185.203.122.138] has joined #bitcoin-core-pr-reviews 02:54 -!- the_mariner [~Thunderbi@191-247-16-126.3g.claro.net.br] has joined #bitcoin-core-pr-reviews 02:58 -!- the_mariner1 [~Thunderbi@2804:389:7104:9173:9528:62de:bc67:e70] has joined #bitcoin-core-pr-reviews 02:59 -!- the_mariner [~Thunderbi@191-247-16-126.3g.claro.net.br] has quit [Ping timeout: 260 seconds] 02:59 -!- the_mariner1 is now known as the_mariner 02:59 -!- GregTonoski [~GregTonos@89.174.3.105] has joined #bitcoin-core-pr-reviews 03:08 -!- the_mariner [~Thunderbi@2804:389:7104:9173:9528:62de:bc67:e70] has quit [Ping timeout: 260 seconds] 03:18 -!- abubakarsadiq [uid602234@2a03:5180:f:4::9:307a] has joined #bitcoin-core-pr-reviews 03:28 < GregTonoski> #28408 datacarriersize: Match more datacarrying - I'm suggesting that PR to discuss in the next Bitcoin Core review monthly meeting. stickies-v, glozow, I'm contacting you in order to host the meeting (following-up on the instruction at https://bitcoincore.reviews/). I will make a new post at "https://github.com/bitcoin-core-review-club/website". 03:28 < GregTonoski> Do you think that there is anything else worth preparing before the meeting? 03:33 <@glozow> GregTonoski: can you send me a DM? we would first need to figure out scheduling and there are a few people asking about the March slot. Also remember that review club is a place for people to learn about the codebase and review, so it’s best to pick a PR suitable for that goal. 03:43 -!- __gotcha [~Thunderbi@natx-145.kulnet.kuleuven.be] has quit [Ping timeout: 255 seconds] 03:44 -!- lbia [~lbia@user/lbia] has joined #bitcoin-core-pr-reviews 03:50 < GregTonoski> I have just sent the DM. I would suggest discussing that PR in the meeting next week as there is only one PR discussion booked so far. 03:53 < stickies-v> we cover one PR per meeting, that's already plenty of material 03:53 -!- lbia [~lbia@user/lbia] has quit [Remote host closed the connection] 03:54 -!- lbia [~lbia@user/lbia] has joined #bitcoin-core-pr-reviews 03:59 < stickies-v> I don't think #28408 is a good PR for the review club at this moment. It seems like it's still quite politically heated at the moment and that will probably make it difficult to have a serene code review discussion 04:04 -!- the_mariner [~Thunderbi@2804:7f7:e18e:3341:4970:cb13:f104:53dd] has joined #bitcoin-core-pr-reviews 04:07 < GregTonoski> I count on discussion based on merits and not politics here. Politicians won't probably come here (unlike Twitter), right? 04:38 -!- GregTonoski39 [~GregTonos@89.174.3.105] has joined #bitcoin-core-pr-reviews 04:40 -!- GregTonoski39 [~GregTonos@89.174.3.105] has quit [Client Quit] 04:40 -!- GregTonoski9 [~GregTonos@89.174.3.105] has joined #bitcoin-core-pr-reviews 04:40 -!- GregTonoski [~GregTonos@89.174.3.105] has quit [Ping timeout: 250 seconds] 04:41 -!- GregTonoski9 [~GregTonos@89.174.3.105] has quit [Client Quit] 05:05 -!- __gotcha [~Thunderbi@natx-145.kulnet.kuleuven.be] has joined #bitcoin-core-pr-reviews 05:33 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 05:40 -!- GregTonoski [~GregTonos@2a00:f41:1c88:dd9e:d5c3:c3a:575a:a25d] has joined #bitcoin-core-pr-reviews 05:41 -!- GregTonoski [~GregTonos@2a00:f41:1c88:dd9e:d5c3:c3a:575a:a25d] has quit [Client Quit] 05:42 -!- GregTonoski [~GregTonos@89.174.3.105] has joined #bitcoin-core-pr-reviews 05:43 -!- GregTonoski [~GregTonos@89.174.3.105] has quit [Client Quit] 05:57 -!- Guest42 [~Guest42@212.129.79.120] has joined #bitcoin-core-pr-reviews 05:58 -!- kevkevin [~kevkevin@2601:243:197e:8f10:656d:7734:1036:649b] has joined #bitcoin-core-pr-reviews 05:59 -!- kashifs [~kashifs@2603-7000-4600-0500-b078-8a7f-23bd-84b1.res6.spectrum.com] has joined #bitcoin-core-pr-reviews 06:13 -!- Guest42 [~Guest42@212.129.79.120] has quit [Quit: Client closed] 06:13 -!- Guest42 [~Guest42@212.129.79.120] has joined #bitcoin-core-pr-reviews 06:22 < Murch[m]> I don’t think your suggestion is based on how well-suited the PR is for a PR Review Club session, but rather on your own political agenda, so you sound hypocritical 06:23 -!- sdaftuar [~sdaftuar@user/sdaftuar] has joined #bitcoin-core-pr-reviews 06:23 < Murch[m]> If you need help with understanding why that PR is a bad idea, maybe read the ~12 NACKs on it again? 06:37 -!- kashifs [~kashifs@2603-7000-4600-0500-b078-8a7f-23bd-84b1.res6.spectrum.com] has quit [Quit: Client closed] 06:41 -!- kashifs [~kashifs@2603-7000-4600-0500-b078-8a7f-23bd-84b1.res6.spectrum.com] has joined #bitcoin-core-pr-reviews 06:58 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds] 07:09 -!- Guest42 [~Guest42@212.129.79.120] has quit [Quit: Client closed] 07:21 -!- kevkevin [~kevkevin@2601:243:197e:8f10:656d:7734:1036:649b] has quit [Remote host closed the connection] 07:22 -!- kevkevin [~kevkevin@2601:243:197e:8f10:656d:7734:1036:649b] has joined #bitcoin-core-pr-reviews 07:49 -!- kevkevin [~kevkevin@2601:243:197e:8f10:656d:7734:1036:649b] has quit [Remote host closed the connection] 08:23 -!- kashifs [~kashifs@2603-7000-4600-0500-b078-8a7f-23bd-84b1.res6.spectrum.com] has quit [Quit: Client closed] 08:40 -!- kevkevin [~kevkevin@2601:243:197e:8f10:656d:7734:1036:649b] has joined #bitcoin-core-pr-reviews 08:58 -!- puchka [~puchka@185.203.122.138] has quit [Ping timeout: 240 seconds] 09:01 -!- puchka [~puchka@185.203.122.132] has joined #bitcoin-core-pr-reviews 09:07 < PaperSword> Just going to shill my own PR, but I totally understand if it's not a review candidate. 09:07 < PaperSword> https://github.com/bitcoin/bitcoin/pull/27260 09:11 -!- pablomartin [~pablomart@193.203.14.54] has joined #bitcoin-core-pr-reviews 09:13 -!- __gotcha [~Thunderbi@natx-145.kulnet.kuleuven.be] has quit [Ping timeout: 260 seconds] 09:21 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 09:31 -!- GregTonoski [~GregTonos@2a00:f41:1c88:dd9e:d5c3:c3a:575a:a25d] has joined #bitcoin-core-pr-reviews 09:33 -!- GregTonoski [~GregTonos@2a00:f41:1c88:dd9e:d5c3:c3a:575a:a25d] has quit [Client Quit] 09:34 -!- GregTonoski [~GregTonos@2a00:f41:1c88:dd9e:d5c3:c3a:575a:a25d] has joined #bitcoin-core-pr-reviews 10:01 -!- GregTonoski [~GregTonos@2a00:f41:1c88:dd9e:d5c3:c3a:575a:a25d] has quit [Quit: Quit] 10:05 -!- kevkevin [~kevkevin@2601:243:197e:8f10:656d:7734:1036:649b] has quit [Remote host closed the connection] 10:05 -!- kevkevin [~kevkevin@2601:243:197e:8f10:656d:7734:1036:649b] has joined #bitcoin-core-pr-reviews 10:10 -!- kevkevin [~kevkevin@2601:243:197e:8f10:656d:7734:1036:649b] has quit [Ping timeout: 276 seconds] 10:22 -!- Talkless [~Talkless@62.80.227.49] has joined #bitcoin-core-pr-reviews 10:29 -!- ___nick___ [~quassel@host86-130-0-114.range86-130.btcentralplus.com] has joined #bitcoin-core-pr-reviews 10:30 -!- kevkevin [~kevkevin@2601:243:197e:8f10:656d:7734:1036:649b] has joined #bitcoin-core-pr-reviews 10:46 -!- ___nick___ [~quassel@host86-130-0-114.range86-130.btcentralplus.com] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 10:48 -!- ___nick___ [~quassel@host86-130-0-114.range86-130.btcentralplus.com] has joined #bitcoin-core-pr-reviews 10:51 -!- ___nick___ [~quassel@host86-130-0-114.range86-130.btcentralplus.com] has quit [Client Quit] 10:54 -!- ___nick___ [~quassel@host86-130-0-114.range86-130.btcentralplus.com] has joined #bitcoin-core-pr-reviews 11:03 -!- pablomartin [~pablomart@193.203.14.54] has quit [Ping timeout: 268 seconds] 11:36 -!- abubakarsadiq [uid602234@2a03:5180:f:4::9:307a] has quit [Quit: Connection closed for inactivity] 11:56 -!- the_mariner [~Thunderbi@2804:7f7:e18e:3341:4970:cb13:f104:53dd] has quit [Ping timeout: 255 seconds] 12:02 -!- Talkless [~Talkless@62.80.227.49] has quit [Quit: Konversation terminated!] 12:03 -!- kevkevin [~kevkevin@2601:243:197e:8f10:656d:7734:1036:649b] has quit [Remote host closed the connection] 12:11 -!- the_mariner [~Thunderbi@2804:7f7:e18e:3341:4970:cb13:f104:53dd] has joined #bitcoin-core-pr-reviews 12:15 -!- the_mariner [~Thunderbi@2804:7f7:e18e:3341:4970:cb13:f104:53dd] has quit [Ping timeout: 264 seconds] 12:28 -!- the_mariner [~Thunderbi@2804:7f7:e18e:3341:4970:cb13:f104:53dd] has joined #bitcoin-core-pr-reviews 12:41 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds] 13:04 -!- ___nick___ [~quassel@host86-130-0-114.range86-130.btcentralplus.com] has quit [Ping timeout: 264 seconds] 13:31 -!- the_mariner [~Thunderbi@2804:7f7:e18e:3341:4970:cb13:f104:53dd] has quit [Ping timeout: 255 seconds] 13:45 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-pr-reviews 13:54 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-pr-reviews 14:10 -!- pablomartin [~pablomart@193.203.14.59] has joined #bitcoin-core-pr-reviews 14:10 -!- the_mariner [~Thunderbi@2804:7f7:e18e:3341:4970:cb13:f104:53dd] has joined #bitcoin-core-pr-reviews 14:15 -!- the_mariner [~Thunderbi@2804:7f7:e18e:3341:4970:cb13:f104:53dd] has quit [Ping timeout: 260 seconds] 14:30 -!- kevkevin [~kevkevin@c-73-111-168-5.hsd1.il.comcast.net] has joined #bitcoin-core-pr-reviews 14:34 -!- kevkevin [~kevkevin@c-73-111-168-5.hsd1.il.comcast.net] has quit [Ping timeout: 276 seconds] 14:44 -!- the_mariner [~Thunderbi@2804:7f7:e18e:3341:4970:cb13:f104:53dd] has joined #bitcoin-core-pr-reviews 14:48 -!- the_mariner [~Thunderbi@2804:7f7:e18e:3341:4970:cb13:f104:53dd] has quit [Ping timeout: 246 seconds] 15:11 -!- the_mariner [~Thunderbi@2804:7f7:e18e:3341:4970:cb13:f104:53dd] has joined #bitcoin-core-pr-reviews 15:15 -!- the_mariner [~Thunderbi@2804:7f7:e18e:3341:4970:cb13:f104:53dd] has quit [Ping timeout: 255 seconds] 15:46 -!- the_mariner [~Thunderbi@2804:7f7:e18e:3341:4970:cb13:f104:53dd] has joined #bitcoin-core-pr-reviews 15:53 -!- the_mariner [~Thunderbi@2804:7f7:e18e:3341:4970:cb13:f104:53dd] has quit [Ping timeout: 264 seconds] 15:54 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 16:06 -!- grettke [~grettke@065-026-198-174.biz.spectrum.com] has quit [Ping timeout: 255 seconds] 16:13 -!- the_mariner [~Thunderbi@2804:7f7:e18e:3341:4970:cb13:f104:53dd] has joined #bitcoin-core-pr-reviews 16:18 -!- the_mariner [~Thunderbi@2804:7f7:e18e:3341:4970:cb13:f104:53dd] has quit [Ping timeout: 260 seconds] 16:21 -!- grettke [~grettke@065-026-198-174.biz.spectrum.com] has joined #bitcoin-core-pr-reviews 16:49 -!- the_mariner [~Thunderbi@2804:7f7:e18e:3341:4970:cb13:f104:53dd] has joined #bitcoin-core-pr-reviews 16:54 -!- the_mariner [~Thunderbi@2804:7f7:e18e:3341:4970:cb13:f104:53dd] has quit [Ping timeout: 255 seconds] 16:57 -!- the_mariner [~Thunderbi@2804:7f7:e18e:3341:4970:cb13:f104:53dd] has joined #bitcoin-core-pr-reviews 17:01 -!- the_mariner [~Thunderbi@2804:7f7:e18e:3341:4970:cb13:f104:53dd] has quit [Ping timeout: 256 seconds] 17:17 -!- grettke [~grettke@065-026-198-174.biz.spectrum.com] has quit [Quit: grettke] 18:26 -!- grettke [~grettke@65.26.198.174] has joined #bitcoin-core-pr-reviews 18:37 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity] 19:30 -!- lbia [~lbia@user/lbia] has quit [Quit: lbia] 19:40 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Remote host closed the connection] 19:48 -!- grettke [~grettke@65.26.198.174] has quit [Quit: grettke] 19:49 -!- puchka [~puchka@185.203.122.132] has quit [Ping timeout: 268 seconds] 19:52 -!- grettke [~grettke@065-026-198-174.biz.spectrum.com] has joined #bitcoin-core-pr-reviews 19:57 -!- grettke_ [~grettke@065-026-198-174.biz.spectrum.com] has joined #bitcoin-core-pr-reviews 19:58 -!- grettke [~grettke@065-026-198-174.biz.spectrum.com] has quit [Ping timeout: 260 seconds] 20:08 -!- grettke_ [~grettke@065-026-198-174.biz.spectrum.com] has quit [Quit: grettke_] 21:30 -!- pablomartin [~pablomart@193.203.14.59] has quit [Ping timeout: 260 seconds] 21:56 -!- puchka [~puchka@185.203.122.136] has joined #bitcoin-core-pr-reviews --- Log closed Fri Feb 02 00:00:49 2024