--- Log opened Wed May 01 00:00:44 2024 00:03 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 00:59 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 01:03 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 01:18 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds] 02:00 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 02:00 -!- blockdyor [~blockdyor@dynamic-adsl-94-34-196-193.clienti.tiscali.it] has joined #bitcoin-core-pr-reviews 02:04 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 02:11 -!- the_mariner [~Thunderbi@179.180.141.11] has joined #bitcoin-core-pr-reviews 02:17 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 02:33 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 02:34 -!- johnzweng [~johnzweng@zweng.at] has joined #bitcoin-core-pr-reviews 02:34 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 02:38 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 02:39 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 02:42 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 02:44 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 02:47 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 02:49 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 02:52 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 02:54 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 02:58 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 02:59 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 03:02 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 03:02 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 03:03 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 03:04 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 03:08 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 03:09 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 03:12 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 03:14 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 03:17 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 03:19 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 03:22 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 03:24 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 03:27 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 03:29 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 03:32 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 03:34 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 03:36 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 03:37 -!- Guest33 [~Guest72@69.197.184.114] has joined #bitcoin-core-pr-reviews 03:39 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 03:42 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 03:44 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 03:47 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 03:49 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 03:52 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 03:54 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 03:57 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 03:59 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 04:02 -!- msc_ [~msc@user/msc] has quit [Remote host closed the connection] 04:07 -!- Guest50 [~Guest50@2600:1700:1f7f:c010:dd77:5e67:863b:67e0] has joined #bitcoin-core-pr-reviews 04:08 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 04:09 -!- Guest50 [~Guest50@2600:1700:1f7f:c010:dd77:5e67:863b:67e0] has quit [Client Quit] 04:09 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 04:13 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 04:13 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 04:14 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 04:17 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 04:19 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 04:23 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 04:24 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 04:27 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 04:29 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 04:31 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 04:32 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 04:32 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 04:34 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 04:37 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 04:39 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 04:42 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 04:43 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 04:48 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 04:49 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 04:52 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 04:58 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 04:58 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 04:59 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 05:03 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 05:04 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 05:07 -!- msc_ [~msc@user/msc] has quit [Remote host closed the connection] 05:09 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 05:12 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 05:13 -!- Guest33 [~Guest72@69.197.184.114] has quit [Ping timeout: 250 seconds] 05:14 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 05:18 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 05:19 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 05:20 < stickies-v> we're celebrating the 30k PRs milestone with a last-minute review club today on... #30000 05:20 < stickies-v> hosted by glozow today at 5PM UTC - checkout the notes at https://bitcoincore.reviews/30000 05:21 < stickies-v> bring party hats 05:22 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 05:23 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:a90d:ac1f:c195:a0] has joined #bitcoin-core-pr-reviews 05:24 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 05:27 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 05:27 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 05:28 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 05:29 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 05:33 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 05:34 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 05:37 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 05:39 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 05:42 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 05:44 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 05:47 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 05:49 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 05:52 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 05:54 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 05:57 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 05:59 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 06:02 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 06:04 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 06:06 -!- blockdyor [~blockdyor@dynamic-adsl-94-34-196-193.clienti.tiscali.it] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 06:07 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 06:09 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 06:10 -!- msc_ [~msc@user/msc] has quit [Remote host closed the connection] 06:12 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 06:15 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 06:19 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 06:22 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-pr-reviews 06:22 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 06:24 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 06:28 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 06:29 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 06:32 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 06:34 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 06:35 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 06:37 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 06:39 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 06:41 -!- msc_ [~msc@user/msc] has quit [Remote host closed the connection] 06:42 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 06:43 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 06:44 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 06:48 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 06:49 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 06:52 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 06:54 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds] 06:54 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 06:57 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 06:59 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 07:02 -!- msc_ [~msc@user/msc] has quit [Remote host closed the connection] 07:03 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 07:03 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 07:04 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 07:08 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 07:09 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 07:12 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 07:14 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 07:17 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 07:19 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 07:22 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 07:23 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 07:25 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 07:29 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 07:32 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 07:34 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 07:37 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 07:38 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 07:42 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 07:44 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 07:44 -!- msc_ [~msc@user/msc] has quit [Remote host closed the connection] 07:44 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 07:45 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 07:49 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 07:52 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 07:53 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 07:54 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 07:54 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 07:54 -!- msc_ [~msc@user/msc] has quit [Remote host closed the connection] 07:55 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 07:59 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 08:02 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 08:04 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 08:07 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 08:12 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 08:13 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 08:14 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 08:14 -!- msc_ [~msc@user/msc] has quit [Remote host closed the connection] 08:15 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 08:18 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 08:18 -!- blockdyor [~blockdyor@dynamic-adsl-94-34-196-193.clienti.tiscali.it] has joined #bitcoin-core-pr-reviews 08:18 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds] 08:19 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 08:20 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 08:22 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 08:24 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 08:26 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 08:29 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 08:33 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 08:34 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 08:37 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 08:39 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 08:42 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 08:44 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 08:45 -!- msc_ [~msc@user/msc] has quit [Remote host closed the connection] 08:45 -!- pablomartin4btc [~pablomart@185.216.146.253] has joined #bitcoin-core-pr-reviews 08:52 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 08:54 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 08:55 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 08:55 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 08:58 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds] 08:59 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 09:01 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 09:06 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds] 09:06 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 09:09 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 09:13 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 09:14 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 09:17 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 09:18 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 09:19 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 09:21 -!- S3RK [~S3RK@user/s3rk] has joined #bitcoin-core-pr-reviews 09:23 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 09:23 -!- msc_ [~msc@user/msc] has quit [Remote host closed the connection] 09:24 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 09:24 -!- S3RK_ [~S3RK@user/s3rk] has quit [Ping timeout: 260 seconds] 09:24 -!- cguida [~cguida@207.91.133.10] has joined #bitcoin-core-pr-reviews 09:28 -!- blockdyor [~blockdyor@dynamic-adsl-94-34-196-193.clienti.tiscali.it] has quit [Remote host closed the connection] 09:29 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 09:32 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 09:34 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 09:34 -!- cguida [~cguida@207.91.133.10] has quit [Remote host closed the connection] 09:34 -!- cguida [~cguida@207.91.133.10] has joined #bitcoin-core-pr-reviews 09:37 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 09:39 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 09:43 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 09:44 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 09:46 -!- blockdyor [~blockdyor@dynamic-adsl-94-34-196-193.clienti.tiscali.it] has joined #bitcoin-core-pr-reviews 09:47 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 09:48 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-pr-reviews 09:50 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 09:52 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 09:54 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 09:57 < glozow> hi 09:57 -!- cguida [~cguida@207.91.133.10] has quit [Ping timeout: 268 seconds] 09:57 < ion-> Hello! 09:58 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 09:58 < angusp> o/ 09:59 < maxedw_> hi 10:01 < glozow> #startmeeting 10:01 < dergoegge> hi 10:01 < maxedw_> hi 10:01 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has joined #bitcoin-core-pr-reviews 10:01 < glozow> Welcome to PR Review Club! 10:01 < glozow> We're looking at #30000 today: https://bitcoincore.reviews/30000 10:01 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 10:02 < glozow> I know we posted the notes very very late, but did anybody get a chance to look at the PR or the notes? 10:02 -!- Guest31 [~Guest31@2a01:c23:8ccd:1d00:5ad:c935:190c:1d9c] has joined #bitcoin-core-pr-reviews 10:02 < angusp> yep 10:02 < maxedw_> yes 10:02 < ion-> Very briefly 10:02 < glozow> angusp: maxedw_: ion-: ⭐ yay! 10:03 < glozow> Let's dive into the questions. Why would we want to allow multiple transactions with the same txid to exist in the TxOrphanage at the same time? What kind of situation does this prevent? 10:03 < maxedw_> When a parent comes in that a valid orphaned child can be combined with it to form a package. Prevents an attacker from preventing us getting our package in the mempool and confirmed 10:03 < stickies-v> hi 10:05 < stickies-v> mostly looked at the PR (well, mostly at TxOrphanage in general) 10:05 < angusp> I'm not super sure, my guess is malleability, if a messed-with tx was seen first and in the orphanage and you're indexing by txid, the honest one can't be included 10:05 < glozow> maxedw_: great! let's look at that a bit more closely. let's say an attacker has the parent tx and the child tx. what should they do / send to you? 10:05 < ion-> If an attacker constructs a malleable transaction to a valid one, and his version is received first? 10:05 < glozow> angusp: ion-: yep yep, malleated how? 10:06 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 10:06 < angusp> put `[b"garbage"]` in the witness ;) - or tweak the signature 10:06 < maxedw_> they should malleate the child and hold off sending the parent? 10:07 < angusp> you can't know it's an invalid tx if you've never seen the parent 10:07 < glozow> angusp: haha yes, was just about to link to the test as a hint. correct, they change the witness somehow 10:07 < ion-> the two transactions having different witness versions? 10:07 < ion-> as you say in the pr description? 10:08 < glozow> okay so the attacker sent you a malleated version of the child, and nobody has sent you the parent yet. what happens if an honest peer sends you the real child tx? 10:08 < angusp> in the current code? 10:08 < glozow> angusp: yes 10:08 < ion-> it will be rejected i guess 10:09 < maxedw_> before pr you wouldn't put it in the orphanage 10:09 < glozow> still walking through what exactly we're trying to fix in the PR 10:09 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 10:09 < angusp> the line `if (m_orphans.count(hash)) return false;` would prevent the honest/real child tx from being accepted 10:09 < glozow> maxedw_: angusp: yes exactly! 10:10 < angusp> so then the honest peer would have to rebroadcast the real child later when it's not an orphan? (Or is there a mechanism for my peer to re-request it later?) 10:10 < glozow> we'd call `AddTx` here https://github.com/bitcoin/bitcoin/blob/842f7fdf786fcbbdf3df40522945813404f8a397/src/net_processing.cpp#L4635-L4637 but it'd be dropped at the start of the function 10:10 < glozow> angusp: good question 10:11 < glozow> TLDR yes you would need to download it again from that peer or from somebody else 10:11 < glozow> however let's look at what the code does 10:11 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 10:12 < glozow> as you can see, after `AddTx`, we call `ForgetTxHash()` to forget about all the announcements we got for this tx: https://github.com/bitcoin/bitcoin/blob/842f7fdf786fcbbdf3df40522945813404f8a397/src/net_processing.cpp#L4635-L4642 10:13 < glozow> which means that we won't download it again until somebody sends us the inv or tx again 10:13 < glozow> and if, at that point, we still have the fake orphan in the orphanage, the same thing happens 10:14 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 10:14 < glozow> Let's say we never receive the parent transaction from anybody. When will we finally delete the fake tx from orphanage? 10:14 < maxedw_> 20 minute timeout? 10:14 < angusp> after time / random when orphanage is full? 10:14 < maxedw_> or when we know it's invalid 10:14 < glozow> maxedw_: angusp: yep! 10:14 < ion-> expiration 20 min 10:14 < maxedw_> (if it's invalid) 10:15 < angusp> > or when we know it's invalid 10:15 < angusp> Can we ever know an orphan is invalid? 10:15 < glozow> maxedw_: yes, that's correct. but we wouldn't figure that out until we recieved the parent 10:15 < glozow> angusp: only if we reconsider it after getting the missing parent(s) 10:15 < glozow> let's explore this as well: while we have the malleated child in the orphanage, what happens if we receive the (real) parent? 10:16 < maxedw_> low fee or not? 10:16 < ion-> Accpet it and invalidate the child 10:16 < glozow> maxedw_: let's start with not low fee 10:16 < glozow> (well, the answer is the same but the codepaths are slightly different) 10:17 < maxedw_> parent accepted, child kicked out? 10:18 < maxedw_> was there an example where it was malleated so it was still valid but larger and so fee less? 10:18 < glozow> maxedw_: yep. When we accept the parent, we queue up the orphan for reconsideration in `ProcessOrphanTx`: https://github.com/bitcoin/bitcoin/blob/842f7fdf786fcbbdf3df40522945813404f8a397/src/net_processing.cpp#L3366 10:18 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 10:18 < glozow> maxedw_: yeah, so let's answer the other option: what happens if the parent is low feerate (i.e. needs bumping from the child)? 10:19 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 10:20 < maxedw_> If it's really low feerate it could get dropped out of the mempool and if it's just too low to get in a block it could be delayed? 10:20 < glozow> maxedw_: it's so low feerate it doesn't get accepted to mempool 10:21 < maxedw_> then I spose it gets discarded? 10:21 < glozow> ok so the parent gets rejected, and we try to submit it with the orphan transaction as a package here: https://github.com/bitcoin/bitcoin/blob/842f7fdf786fcbbdf3df40522945813404f8a397/src/net_processing.cpp#L4669-L4673 10:21 < glozow> it's the same result - the child has an invalid signature, so it gets removed from the orphanage 10:22 < glozow> and, yes, we discard the parent after 10:22 -!- msc_ [~msc@user/msc] has quit [Remote host closed the connection] 10:22 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 10:22 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 10:22 < glozow> Ok! We covered the next question "What are some examples of same-txid-different-witness orphans?", we mentioned a bad signature and a really large witness for a lower feerate 10:23 < ion-> segwit v0 compared to v1 maybe? 10:24 < maxedw_> can an attacker make a witness larger knowing only the valid witness and transaction? 10:24 < ion-> Depending on the sighash used? 10:24 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 10:25 < glozow> maxedw_: certainly they can make the witness larger, though they might not make a valid tx 10:25 < maxedw_> with P2WSH there could be multiple different WitnessScripts that are possible, not sure if there is something that could be done there 10:25 < angusp> The code you linked to here https://github.com/bitcoin/bitcoin/blob/842f7fdf786fcbbdf3df40522945813404f8a397/src/net_processing.cpp#L4639-L4641 we forget both the txid and wtxid -- is that still OK in the attack case we've covered? You're 'forgetting' the txid which could be malleated 10:25 < glozow> in any case, the feerate would be checked before the script 10:27 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 10:28 < glozow> angusp: hm. the intention there is "ok we've already downloaded this tx so there's no point in continuing to try to download it" 10:28 < glozow> I suppose... anything with this txid is also going to be an orphan 10:29 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 10:29 < glozow> And we aren't going to add anything with the same txid to the orphanage anyway 10:30 < glozow> So I guess this is consistent with current behavior? 10:30 < angusp> yeah, makes sense 10:32 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 10:32 < glozow> Ok next question. Instead of allowing multiple transactions with the same txid (where we are obviously wasting some space on a version we will not accept), should we allow a transaction to replace an existing entry in the TxOrphanage? 10:32 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 10:32 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 10:32 < glozow> ion-: I don't think the version is in the witness? 10:33 < ion-> nope! 10:33 < glozow> so that is not a way to change the wtxid without changing the txid 10:34 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 10:34 < angusp> Also think no, because you know nothing about the parent tx, you can't really pick which will be valid or not (between an honest tx and a maleated one) 10:34 < maxedw_> the only reason I could think to replace would be if it was a higher fee but you would also have to know it was valid which you couldn't do without the parent 10:35 < angusp> maxedw_: Higher fee should change the txid because the amounts change? 10:36 < maxedw_> smaller witness could do it? 10:36 < glozow> angusp: maxedw_: nice, good answers. for "higher fee" you can go by size i suppose 10:36 < glozow> (going for feerate not fee) 10:37 < glozow> somebody gave a good suggestion to not have duplicate txids from the same peer 10:37 < angusp> do orphaned txs not get broadcast to other peers? 10:37 < glozow> (because presumably if a peer is going to send you duplicates, they're either replacing the previous one or sending garbage) 10:37 < glozow> angusp: no they don't. we only broadcast after we submit to mempool 10:38 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 10:38 < angusp> gotcha 10:38 < glozow> but other than that, I agree. there's not really a metric we can use to choose one tx over the other 10:39 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 10:39 < ion-> Could we use a sometimes change and sometimes not approach? 10:40 < glozow> ion-: you mean like flip a coin? 10:40 < ion-> yes, to make the attackers work more difficult 10:40 < glozow> doesn't that make it easier? an honest peer will only send 1 tx. an attacker can send many, and has a 1/2 chance of displacing the tx each time 10:41 < glozow> Next question: Where in the code do we check whether the orphanage contains a transaction? Is the query done by wtxid, txid, or both? (Hint: there are at least 5). 10:42 < maxedw_> TxOrphanage::AddTx - wtxid (txid only used for log messages) 10:42 < maxedw_> TxOrphanage::EraseTxNoLock - wtxid 10:42 < maxedw_> TxOrphanage::HaveTx - wtxid 10:42 < maxedw_> TxOrphanage::GetTxToReconsider - wtxid 10:42 < maxedw_> TxOrphanage::EraseForBlock - uses outpoint which is txid? 10:42 -!- msc_ [~msc@user/msc] has quit [Remote host closed the connection] 10:42 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 10:43 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 10:43 < glozow> Yes nice, lots of queries within txorphanage. There are at least 4 more (hint: I'm looking for lines in net_processing.cpp) 10:44 < angusp> Presumably it was done by both Txid and Wtxid as the existing code also had m_wtxid_to_orphan_it -- I'm not really familiar enough to know where other than doing a code search! 10:44 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 10:44 < maxedw_> I did think I should have looked in net_processing too! 10:44 < glozow> :) and to clarify the question, let's talk about queries in the code before this PR 10:45 < glozow> Hint: you can see that `m_orphanage.HaveTx()` is called in `AlreadyHaveTx` here: https://github.com/bitcoin/bitcoin/blob/842f7fdf786fcbbdf3df40522945813404f8a397/src/net_processing.cpp#L2298 10:45 < glozow> Where is `AlreadyHaveTx` called? 10:46 < maxedw_> PeerManagerImpl::ProcessInvalidTx looks to be one 10:46 < maxedw_> I checked with the PR.. 10:46 < angusp> 1) When receiving a new tx (/package?) from a peer 2) getting a new block 10:47 < glozow> angusp: yes on the first one! that ones right here: https://github.com/bitcoin/bitcoin/blob/842f7fdf786fcbbdf3df40522945813404f8a397/src/net_processing.cpp#L4531 10:47 < glozow> (and we check only by wtxid) 10:47 < glozow> maxedw_ mentioned the getting a new block one, that's `EraseForBlock` 10:48 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 10:48 < angusp> 3) If removing rejecting a tx that's a parent of an orphan we have 10:49 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 10:49 < glozow> Actually to note "uses outpoint which is txid" note that that's the txid of the parent, not the tx in the orphanage 10:49 -!- cguida [~cguida@207.91.133.10] has joined #bitcoin-core-pr-reviews 10:50 < glozow> angusp: aha, i assume you mean this line: https://github.com/bitcoin/bitcoin/blob/842f7fdf786fcbbdf3df40522945813404f8a397/src/net_processing.cpp#L4632 10:50 < maxedw_> glozow: that makes sense 10:50 < glozow> angusp: for that (3), is that by txid, wtxid, or both? 10:52 < glozow> hint: we're looking at parents using the prevouts of the tx 10:52 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 10:52 < angusp> I think both - or rather, Wtxid if has witness, else txid 10:52 < angusp> 50/50 haha 10:53 < glozow> it's by txid, but I'll give you partial credit for "both" because txid == wtxid sometimes 10:54 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 10:54 < glozow> There's 2 more `AlreadyHaveTx` callsites i'm looking for in net_processing.cpp. Can we find them? 10:55 < angusp> Hrm, so how does that work when you switch the orphanage to being Wtxid indexed? 10:55 < glozow> angusp: good question!! 10:55 < glozow> (that's also Q8, which is the only question left) 10:56 < glozow> "This PR removes the ability to query the orphanage by txid, since the TxOrphanage no longer has an index by txid. Is that okay, and why or why not?" 10:56 -!- cguida [~cguida@207.91.133.10] has quit [Ping timeout: 268 seconds] 10:56 < angusp> (I can find the other `AlreadyHaveTx` calls but not sure what the code around them is doing!) 10:56 < glozow> angusp: ok no problem i'll just list them here 10:57 < glozow> https://github.com/bitcoin/bitcoin/blob/842f7fdf786fcbbdf3df40522945813404f8a397/src/net_processing.cpp#L4226 is when we receive an `inv` message for a transaction 10:57 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 10:57 < glozow> and https://github.com/bitcoin/bitcoin/blob/842f7fdf786fcbbdf3df40522945813404f8a397/src/net_processing.cpp#L6288 is when we are sending a `getdata` (in response to an `inv`) and we want to make sure that we aren't about to request a tx we already have 10:58 < glozow> these can be by txid or wtxid. however in the vast majority of cases, we should be getting invs by wtxid and sending getdata by wtxid 10:59 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 10:59 < glozow> unless we are requesting parents of an orphan :P 11:00 < glozow> Aho, we are out of time already! lmk your answer to the last question as a review comment on the PR 11:00 < glozow> #endmeeting 11:00 < maxedw_> thanks glozow! 11:00 < glozow> thanks for coming! 11:00 < dergoegge> thanks glozow 11:00 < maxedw_> very interesting review club 11:00 < ion-> thank you, that was a good lesson for me! 11:00 < angusp> thanks! 11:01 < glozow> awesome! Next one will be hosted by stickies-v 11:02 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 11:04 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 11:07 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 11:09 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 11:12 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 11:14 -!- Guest31 [~Guest31@2a01:c23:8ccd:1d00:5ad:c935:190c:1d9c] has quit [Quit: Client closed] 11:14 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 11:15 -!- ion- [ion-@user/ion-] has quit [Remote host closed the connection] 11:17 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 11:19 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 11:22 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 11:24 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 11:27 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 11:29 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 11:32 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 11:32 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-pr-reviews 11:34 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 11:37 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 11:38 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 11:41 -!- ion- [ion-@user/ion-] has quit [Ping timeout: 260 seconds] 11:42 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 11:46 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-pr-reviews 11:47 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 11:51 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 11:54 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 11:55 -!- ion- [ion-@user/ion-] has quit [] 11:57 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 12:00 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 12:02 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 12:04 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 12:07 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 12:09 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 12:11 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:11 -!- rkrux [~rkrux@223.190.85.116] has joined #bitcoin-core-pr-reviews 12:12 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 12:14 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 12:15 -!- rkrux [~rkrux@223.190.85.116] has quit [Client Quit] 12:17 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 12:19 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 12:22 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 12:24 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 12:27 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 12:29 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 12:31 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity] 12:33 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 12:34 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 12:37 -!- cguida [~cguida@207.91.133.9] has joined #bitcoin-core-pr-reviews 12:37 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 12:39 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 12:40 -!- cguida_ [~cguida@207.91.133.10] has joined #bitcoin-core-pr-reviews 12:42 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 12:44 -!- cguida [~cguida@207.91.133.9] has quit [Ping timeout: 268 seconds] 12:44 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 12:47 -!- the_mariner [~Thunderbi@179.180.141.11] has quit [Ping timeout: 260 seconds] 12:47 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 12:49 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 12:50 -!- cguida_ [~cguida@207.91.133.10] has quit [Ping timeout: 246 seconds] 12:52 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 12:54 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 12:57 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 12:58 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 13:02 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 13:04 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 13:07 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 13:09 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 13:12 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 13:14 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 13:16 -!- VonNaturAustreVe [~ne0h_@user/vonnaturaustreve] has quit [Quit: Leaving] 13:17 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 13:19 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 13:21 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has joined #bitcoin-core-pr-reviews 13:22 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 13:24 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 13:27 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 13:29 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 13:32 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 13:34 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 13:36 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 13:39 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 13:42 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 13:44 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 13:47 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 13:49 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 13:52 -!- grettke [~grettke@184.55.133.0] has quit [Quit: grettke] 13:52 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 13:54 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 13:55 -!- grettke [~grettke@syn-184-055-133-000.res.spectrum.com] has joined #bitcoin-core-pr-reviews 13:57 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 13:59 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 14:02 -!- blockdyor [~blockdyor@dynamic-adsl-94-34-196-193.clienti.tiscali.it] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 14:02 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 14:04 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 14:04 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 14:09 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 14:12 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 14:13 -!- cguida_ [~cguida@207.91.133.10] has joined #bitcoin-core-pr-reviews 14:14 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 14:17 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 14:19 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 14:19 -!- cguida_ [~cguida@207.91.133.10] has quit [Ping timeout: 272 seconds] 14:22 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 14:24 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 14:27 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 14:29 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 14:32 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 14:34 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 14:38 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 14:39 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 14:42 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 14:44 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 14:47 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 14:49 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 14:53 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 14:54 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 14:57 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 14:59 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 15:02 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 15:04 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 15:07 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 15:09 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 15:12 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 15:14 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 15:17 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 15:18 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 15:22 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 15:24 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 15:27 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 15:29 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 15:31 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity] 15:32 -!- Guest83 [~Guest83@201.17.114.76] has joined #bitcoin-core-pr-reviews 15:32 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 15:33 -!- Guest83 [~Guest83@201.17.114.76] has quit [Client Quit] 15:33 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 15:37 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 15:42 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 15:45 -!- cguida_ [~cguida@207.91.133.9] has joined #bitcoin-core-pr-reviews 15:46 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 15:49 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 15:52 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 15:54 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 15:57 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 15:59 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 15:59 -!- cguida [~cguida@207.91.133.9] has joined #bitcoin-core-pr-reviews 16:02 -!- cguida_ [~cguida@207.91.133.9] has quit [Ping timeout: 256 seconds] 16:03 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 16:04 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 16:04 -!- cguida [~cguida@207.91.133.9] has quit [Ping timeout: 245 seconds] 16:07 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 16:07 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 16:08 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 16:09 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 16:09 -!- msc_ [~msc@user/msc] has quit [Remote host closed the connection] 16:10 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 16:13 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 16:14 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 16:17 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 16:19 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 16:22 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 16:24 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 16:27 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 16:29 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 16:32 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 16:34 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 16:38 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 16:39 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 16:42 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 16:44 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 16:47 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 16:49 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 16:52 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 16:54 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 16:55 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 16:55 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 16:57 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 16:58 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 17:02 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 17:03 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 17:07 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 17:09 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 17:10 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 17:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews 17:12 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 17:14 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 17:17 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 17:19 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 17:22 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 17:24 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 17:25 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 272 seconds] 17:27 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 17:29 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 17:32 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 17:34 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 17:37 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 17:41 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 17:42 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 17:44 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 17:48 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 17:49 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 17:52 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 17:54 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 17:58 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 17:59 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 18:02 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 18:03 -!- msc_ [~msc@user/msc] has quit [Remote host closed the connection] 18:03 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 18:09 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 18:12 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 18:13 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 18:14 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 18:14 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity] 18:17 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 18:17 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 18:18 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 18:19 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 18:23 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 18:24 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 18:24 -!- msc_ [~msc@user/msc] has quit [Remote host closed the connection] 18:29 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 18:32 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 18:34 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 18:37 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 18:39 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 18:42 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 18:44 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 18:47 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 18:49 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 18:52 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 18:54 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 18:57 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 18:59 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 19:02 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 19:04 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 19:07 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 19:09 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 19:12 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 19:14 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 19:17 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 19:19 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 19:22 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 19:24 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 19:27 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 19:29 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 19:32 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 19:33 -!- msc_ [~msc@user/msc] has quit [Remote host closed the connection] 19:33 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 19:33 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 19:38 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 19:39 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 19:42 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 19:44 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 19:47 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 19:48 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 19:52 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 19:54 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 19:54 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 19:59 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 20:02 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 20:03 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 20:07 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 20:09 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 20:12 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 20:14 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 20:17 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 20:19 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 20:22 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 20:24 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 20:26 -!- msc_ [~msc@user/msc] has quit [Remote host closed the connection] 20:27 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 20:27 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 20:29 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 20:33 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 20:34 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 20:37 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 20:39 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 20:43 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 20:44 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 20:47 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 20:49 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 20:52 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 20:54 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 20:57 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 20:59 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 21:02 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 21:04 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 21:07 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 21:09 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 21:12 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 21:13 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 21:13 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 21:19 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 21:22 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 21:24 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 21:27 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 21:28 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 21:32 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 21:33 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 21:37 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 21:39 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 21:42 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 21:44 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 21:46 -!- cguida [~cguida@syn-035-146-037-041.res.spectrum.com] has joined #bitcoin-core-pr-reviews 21:47 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 21:49 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 21:51 -!- cguida [~cguida@syn-035-146-037-041.res.spectrum.com] has quit [Ping timeout: 260 seconds] 21:52 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 21:54 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 21:57 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 21:58 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 22:02 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 22:04 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 22:07 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 22:09 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 22:12 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 22:14 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 22:17 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 22:19 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 22:22 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 22:24 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 22:27 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 22:29 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 22:32 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 22:34 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 22:37 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 22:39 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 22:40 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 22:44 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 22:45 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 22:46 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 22:47 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 22:49 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 22:52 -!- blockdyor [~blockdyor@dynamic-adsl-94-34-196-193.clienti.tiscali.it] has joined #bitcoin-core-pr-reviews 22:52 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 22:54 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 22:57 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 22:59 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 23:02 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 23:02 -!- msc_ [~msc@user/msc] has quit [Remote host closed the connection] 23:03 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 23:04 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 23:08 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 23:09 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 23:12 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 23:14 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 23:17 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 23:19 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 23:19 -!- msc_ [~msc@user/msc] has quit [Remote host closed the connection] 23:19 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 23:20 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 23:23 -!- Goblin [~Goblin@157.97.134.99] has joined #bitcoin-core-pr-reviews 23:23 -!- Goblin [~Goblin@157.97.134.99] has quit [Client Quit] 23:24 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 23:27 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 23:29 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 23:32 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 23:34 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 23:37 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 23:39 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 23:42 -!- msc [~msc@user/msc] has quit [Remote host closed the connection] 23:42 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 23:42 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 23:44 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 23:48 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 23:49 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews 23:52 -!- msc_ [~msc@user/msc] has quit [Ping timeout: 260 seconds] 23:54 -!- msc_ [~msc@user/msc] has joined #bitcoin-core-pr-reviews 23:57 -!- msc [~msc@user/msc] has quit [Ping timeout: 260 seconds] 23:59 -!- msc [~msc@user/msc] has joined #bitcoin-core-pr-reviews --- Log closed Thu May 02 00:00:44 2024