--- Log opened Wed Jun 05 00:00:17 2024
00:10 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has joined #bitcoin-core-pr-reviews
00:21 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has quit [Ping timeout: 268 seconds]
00:36 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has joined #bitcoin-core-pr-reviews
00:41 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has quit [Ping timeout: 256 seconds]
00:53 -!- yonson [~yonson@2600:8801:e800:28::1962] has quit [Ping timeout: 268 seconds]
00:54 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has joined #bitcoin-core-pr-reviews
00:59 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has quit [Ping timeout: 256 seconds]
01:10 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has joined #bitcoin-core-pr-reviews
01:16 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has quit [Ping timeout: 260 seconds]
01:32 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has joined #bitcoin-core-pr-reviews
01:38 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has quit [Ping timeout: 268 seconds]
01:51 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has joined #bitcoin-core-pr-reviews
01:56 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has quit [Ping timeout: 268 seconds]
02:09 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has joined #bitcoin-core-pr-reviews
02:14 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has quit [Ping timeout: 260 seconds]
02:26 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has joined #bitcoin-core-pr-reviews
02:32 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has quit [Ping timeout: 255 seconds]
02:42 -!- yonson [~yonson@ip70-181-225-218.sd.sd.cox.net] has joined #bitcoin-core-pr-reviews
02:46 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has joined #bitcoin-core-pr-reviews
02:54 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has quit [Ping timeout: 268 seconds]
03:11 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has joined #bitcoin-core-pr-reviews
03:17 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has quit [Ping timeout: 268 seconds]
03:49 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has joined #bitcoin-core-pr-reviews
03:54 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
03:55 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
03:55 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has quit [Ping timeout: 268 seconds]
04:11 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has joined #bitcoin-core-pr-reviews
04:18 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has quit [Ping timeout: 268 seconds]
04:49 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has joined #bitcoin-core-pr-reviews
04:55 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has quit [Ping timeout: 268 seconds]
05:13 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has joined #bitcoin-core-pr-reviews
05:14 -!- hernanmarino [~hernanmar@181.85.37.94] has quit [Ping timeout: 252 seconds]
05:18 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has quit [Ping timeout: 268 seconds]
05:34 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has joined #bitcoin-core-pr-reviews
05:38 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has quit [Ping timeout: 240 seconds]
06:07 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has joined #bitcoin-core-pr-reviews
06:12 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has quit [Ping timeout: 256 seconds]
06:22 -!- hernanmarino [~hernanmar@2800:2330:2800:1c0::ee31] has joined #bitcoin-core-pr-reviews
06:30 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has joined #bitcoin-core-pr-reviews
06:31 -!- hernanmarino [~hernanmar@2800:2330:2800:1c0::ee31] has quit [Quit: ZNC 1.8.2+deb2 - https://znc.in]
06:33 -!- hernanmarino [~hernanmar@181.85.44.52] has joined #bitcoin-core-pr-reviews
06:37 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has quit [Ping timeout: 268 seconds]
06:39 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
06:50 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has joined #bitcoin-core-pr-reviews
08:29 -!- grettke [~grettke@syn-184-055-133-000.res.spectrum.com] has joined #bitcoin-core-pr-reviews
08:34 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews
08:36 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds]
09:04 -!- puchka [~puchka@185.203.122.230] has quit [Ping timeout: 246 seconds]
09:11 -!- puchka [~puchka@185.203.122.225] has joined #bitcoin-core-pr-reviews
09:15 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has joined #bitcoin-core-pr-reviews
09:19 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has quit [Client Quit]
09:31 -!- Guest35 [~Guest35@2604:3d08:a487:5700:9d55:7644:1072:818f] has joined #bitcoin-core-pr-reviews
09:31 -!- Guest35 [~Guest35@2604:3d08:a487:5700:9d55:7644:1072:818f] has quit [Client Quit]
09:31 -!- Guest35 [~Guest35@2604:3d08:a487:5700:9d55:7644:1072:818f] has joined #bitcoin-core-pr-reviews
09:55 -!- emc99 [~emc99@212.129.79.218] has joined #bitcoin-core-pr-reviews
09:56 -!- mickin [~quassel@212.129.79.218] has joined #bitcoin-core-pr-reviews
09:57 -!- mickin [~quassel@212.129.79.218] has quit [Client Quit]
10:00 < stickies-v> #startmeeting
10:01 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has joined #bitcoin-core-pr-reviews
10:01 < stickies-v> anyone here for the review club?
10:02 < TheCharlatan> hi :)
10:02 < monlovesmango> hey i'm here
10:02 < emc99> hi
10:02 < kevkevin> hi
10:02 < stickies-v> ah, yay. welcome everyone! today we're looking at #30132, authored by TheCharlatan. the notes and questions are available on https://bitcoincore.reviews/30132
10:02 < kevkevin> havent had a chance to review so will be lurking
10:03 < stickies-v> anyone joining us for the first time today? even if you're just lurking, feel free to say hi!
10:04 < stickies-v> who got the chance to review the PR or read the notes? (y/n)
10:04 < TheCharlatan> y :P
10:04 < monlovesmango> y
10:04 < stickies-v> that's a okay kevkevin , great that you're joining anyway!
10:04 < stickies-v> mmm wondering about your Concept (N)ACK TheCharlatan but we'll find out soon enough
10:05 < stickies-v> Did you review the PR? [Concept ACK, approach ACK, tested ACK, or NACK](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#peer-review)? What was your review approach?
10:05 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has joined #bitcoin-core-pr-reviews
10:06 < monlovesmango> a bit. concept ack but don't know enough to comment on approach
10:07 < stickies-v> we'll mostly be talking about the concept here anyway so that works :-D
10:08 < stickies-v> let's dig into those
10:08 < stickies-v> 2. What is the behaviour change introduced by this PR. Can you reproduce it, and if so - how?
10:09 < monlovesmango> start bitcoind with reindex flag with additional optional indexes, restart bitcoind, check that optional index's progress isn't wiped out
10:10 < kevkevin> looks like we want to stop the reindex from being deleted if the user restarts their bitcoind without the reindex flag after one has been started
10:10 < kevkevin> we should resume the previous reindex process
10:11 < stickies-v> monlovesmango: exactly, on master you should observe that the leveldbs are being wiped, whereas that shouldn't be the case with 30132
10:11 < stickies-v> kevkevin: i think you're close but i don't fully comprehend what you're saying (reindex is a process, so it can't be deleted)
10:12 < stickies-v> but yes we want to resume the reindex process without deleting the *optional* indices
10:12 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds]
10:12 < stickies-v> is that the only behaviour change introduced in this PR?
10:13 < kevkevin> yea sorry I was referring to the indexes we have stored in the datadir
10:13 < monlovesmango> there is also a bug fix but I wasn't able to get to understanding the bug itself
10:13 < kevkevin> ya looks like a bug fix in https://github.com/bitcoin/bitcoin/pull/30132/commits/f27290c39d63df36a1e1baa7f9c1609ebb65ca97
10:14 < stickies-v> monlovesmango: which part don't you understand? how it manifests, or why it manifests?
10:15 -!- Guest35 [~Guest35@2604:3d08:a487:5700:9d55:7644:1072:818f] has quit [Quit: Client closed]
10:15 < kevkevin> looks like we want to use the reindex param provided by the user, but currently it is not clear if it will be true or false in options.reindex
10:17 < monlovesmango> I guess why? I don't understand what the bug is (but I also didn't spend time looking at that)
10:17 < stickies-v> so we have this convenience feature for GUI users where if loading the chainstate fails, we ask them (in a popup box, so GUI only) if they'd like to try again with reindex
10:18 < stickies-v> but in b47bd959207e82555f07e028cc2246943d32d4c3, that behaviour was accidentally changed a bit - if the user responded yes to that, we would try again but without reindexing, and then we'd keep asking the user (ad infinitum) if they want to try again with reindex
10:19 < stickies-v> both of those are fixed in this bugfix commit
10:19 < monlovesmango> ahh ok. and the user's choice on whether to reindex was stored in chainman.m_blockman.m_reindexing?
10:20 < stickies-v> indeed it was - and why is that not a safe thing to do?
10:20 -!- Guest3 [~Guest35@2604:3d08:a487:5700:9d55:7644:1072:818f] has joined #bitcoin-core-pr-reviews
10:20 < TheCharlatan> yes, exactly monlovesmango
10:20 < monlovesmango> bc that gets destroyed in initialization (AppInitMain)
10:20 < monlovesmango> (taking this from ryanofsky's comment https://github.com/bitcoin/bitcoin/pull/30132#issuecomment-2120741121)
10:21 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews
10:21 < monlovesmango> thanks for diving into the bug stickies-v! its very clear now
10:22 < kevkevin> ahh I didnt know that either, thats helpful!
10:22 < TheCharlatan> yes, being more concrete the problem is that it (the chainman) gets destroyed and recreated on each for loop iteration. So the users choice is immediately discarded.
10:23 < stickies-v> it gets destroyed because we have this rather unintuitive for-loop that, at the beginning constructs a new chainman and blockman: https://github.com/bitcoin/bitcoin/blob/ff7d2054c4f1d7ff98078b9695e7c36e79a476c6/src/init.cpp#L1534
10:23 < monlovesmango> got to step away for a few minutes!
10:23 < stickies-v> blessed be them who improve that code to make it less footgunny
10:24 < stickies-v> okay - any other behaviour change introduced in this PR or is that it?
10:25 < TheCharlatan> yes, improvements to that retry logic would be very welcome. It is constantly tripping up people if they have to deal with it.
10:26 < TheCharlatan> yes, there is a tiny log line being removed :P
10:26 < stickies-v> YAAAAA
10:27 < stickies-v> alright, moving on
10:27 < stickies-v> 3. What are the two ways an index can process new blocks? How does this PR affect that logic?
10:29 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
10:31 < stickies-v> one way is to process them through the validation interface (after registering itself with `RegisterValidationInterface()`) on a per-block basis, or another is to do it in batch through a background sync (through `BaseIndex::StartBackgroundSync()`)
10:33 < stickies-v> so, any guesses as how this PR affects how blocks are processed?
10:34 < kevkevin> not sure does it have to do with the background sync?
10:37 < stickies-v> do you know when background sync is used vs when the validation interface is used?
10:40 < monlovesmango> does it have to do with whether it is processed via start up verses blocks arriving in real time?
10:41 < kevkevin> looks like in BaseIndex::Init we use RegisterValidationInterface and it seems like background one (StartIndexBackgroundSync) is used in AppInitMain
10:41 < stickies-v> monlovesmango: it does indeed! although arriving not just in a "received from peer" sense, but importantly in this case also when processed while reindexing
10:42 < stickies-v> so basically in `BaseIndex::Init()` we check if we're currently caught up with the chaintip: https://github.com/bitcoin/bitcoin/blob/ff7d2054c4f1d7ff98078b9695e7c36e79a476c6/src/index/base.cpp#L123
10:44 < stickies-v> if we're synced up, we will process all new blocks through the  validation interface. if we're not synced up, we'll wait for the background sync to finish (started here: https://github.com/bitcoin/bitcoin/blob/ff7d2054c4f1d7ff98078b9695e7c36e79a476c6/src/init.cpp#L1755), and then process new blocks through the validation interface
10:45 < stickies-v> kevkevin: indeed! we register the index early on, to make sure we don't miss out on any events
10:45 < stickies-v> so, does this PR mean we start processing more through validation interface, more through background sync, or both/can't say?
10:46 < emc99> both
10:46 < monlovesmango> it depends whether people use reindex more often when they are completely synced up
10:46 < monlovesmango> ?
10:47 < monlovesmango> which I think would be the case (if you aren't synced I don't think there is much point having reindex flag right?)
10:47 < kevkevin> I would think through background sync if users tend to not use reindex, but I am not sure
10:47 < monlovesmango> so I guess my vote is validatoni interface
10:48 < stickies-v> so this is the scenario: a user has started bitcoind with -reindex, aborted after half an hour (well before reindex has finished), and then started bitcoind again *without* the -reindex flag
10:49 < stickies-v> prior to this PR, when their node is started for the second time, the optional indices will be wiped
10:49 < stickies-v> in that case, will they start syncing through validation interface right away, or will they go through background sync first?
10:51 < kevkevin> well if they were wiped they would go through the validation interface is my guess
10:52 < stickies-v> kevkevin: alas! as per https://github.com/bitcoin/bitcoin/blob/ff7d2054c4f1d7ff98078b9695e7c36e79a476c6/src/index/base.cpp#L123, the index will be considered out-of-sync, and when we're out of sync we first catch up through background validation
10:53 < stickies-v> so, how does that behaviour change with this PR?
10:54 < monlovesmango> ahh ok were considering whether index is out of sync, not whether block db is out of sync. got mixed up
10:56 < stickies-v> ah yes, very good point!
10:56 < monlovesmango> i don't think the behavior between whether validation interface or background sync is used has changed..? i must be missing something. whether indexes are wiped or not on restart, the index is still out of sync
10:56 < monlovesmango> whether or not*
10:57 < stickies-v> monlovesmango: well, what this PR does in https://github.com/bitcoin/bitcoin/pull/30132/commits/9de8b263dabd6dd2f86f1f0253c6ee3fac7a4407 is to not actually wipe the optional indixes when we don't have to
10:58 < stickies-v> so in that case, the optional indices should be still be in sync with the chain tip - and we don't need to do a background sync
10:58 < monlovesmango> omg you are referring to local chain tip right? not peer's chain tip? if so that is what I am missing
10:59 < stickies-v> ah, i see
10:59 < stickies-v> reindex is a local process, i.e. we rebuild all of our indices again *from disk*, so generally there's no network activity involved (although we may have to request blocks from peers if they are missing on disk)
11:00 < monlovesmango> yep that makes sense
11:00 < stickies-v> a peer's chain tip is not relevant in any of the code we're looking at here (but the confusion is very understandable), that's handled in the p2p code
11:00 < kevkevin> looks like because m_synced = true it will skip the background sync?
11:00 < stickies-v> kevkevin: indeed
11:01 < kevkevin> and we will only need to use RegisterValidationInterface
11:01 -!- Guest3 [~Guest35@2604:3d08:a487:5700:9d55:7644:1072:818f] has quit [Ping timeout: 250 seconds]
11:01 < stickies-v> alright folks, we're unfortunately at time already so we'll have to wrap up here
11:01 < kevkevin> ok thank you! this was very informational!
11:01 < monlovesmango> thank you for hosting stickies-v! learned a lot
11:02 < stickies-v> thanks for the discussion, and thanks a lot TheCharlatan for your work on improving this bit of code!
11:02 < TheCharlatan> thanks for digging into this last point stickies-v
11:02 < stickies-v> #endmeeting
11:02 < monlovesmango> yes, thanks for your work TheCharlatan!!
11:02 -!- monlovesmango [monlovesma@gateway/vpn/protonvpn/monlovesmango] has quit []
11:02 -!- emc99 [~emc99@212.129.79.218] has quit [Quit: Client closed]
11:42 -!- Guest17 [~Guest35@2604:3d08:a487:5700:8c15:38e7:edc6:a66c] has joined #bitcoin-core-pr-reviews
11:42 -!- Guest17 [~Guest35@2604:3d08:a487:5700:8c15:38e7:edc6:a66c] has quit [Client Quit]
11:42 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds]
11:54 -!- grettke [~grettke@syn-184-055-133-000.res.spectrum.com] has quit [Quit: grettke]
11:59 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
12:08 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
12:15 -!- grettke [~grettke@syn-184-055-133-000.res.spectrum.com] has joined #bitcoin-core-pr-reviews
12:18 -!- Talkless [~Talkless@mail.dargis.net] has quit [Remote host closed the connection]
12:25 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
12:26 -!- ___nick___ [~quassel@cpc68290-cdif17-2-0-cust24.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews
12:30 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds]
13:17 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
13:39 -!- ___nick___ [~quassel@cpc68290-cdif17-2-0-cust24.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
13:41 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has quit [Remote host closed the connection]
14:12 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has joined #bitcoin-core-pr-reviews
14:14 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity]
14:17 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has quit [Ping timeout: 268 seconds]
14:59 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds]
15:05 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
15:26 -!- ___nick___ [~quassel@cpc68290-cdif17-2-0-cust24.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews
15:28 -!- kevkevin [~kevkevin@98.226.206.182] has joined #bitcoin-core-pr-reviews
15:34 -!- kevkevin [~kevkevin@98.226.206.182] has quit [Ping timeout: 268 seconds]
15:38 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds]
15:48 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has joined #bitcoin-core-pr-reviews
15:54 -!- kevkevin [~kevkevin@2601:241:8703:7b30:21b6:d1c6:8c4b:ab11] has quit [Ping timeout: 268 seconds]
16:05 -!- kevkevin [~kevkevin@98.226.206.182] has joined #bitcoin-core-pr-reviews
16:26 -!- kevkevin [~kevkevin@98.226.206.182] has quit [Remote host closed the connection]
18:27 -!- ___nick___ [~quassel@cpc68290-cdif17-2-0-cust24.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
18:29 -!- ___nick___ [~quassel@cpc68290-cdif17-2-0-cust24.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews
18:30 -!- ___nick___ [~quassel@cpc68290-cdif17-2-0-cust24.5-1.cable.virginm.net] has quit [Client Quit]
18:32 -!- ___nick___ [~quassel@cpc68290-cdif17-2-0-cust24.5-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews
19:03 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews
19:06 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:d16f:cf00:5262:8678] has joined #bitcoin-core-pr-reviews
19:53 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:d16f:cf00:5262:8678] has quit [Remote host closed the connection]
20:17 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds]
20:30 -!- grettke [~grettke@syn-184-055-133-000.res.spectrum.com] has quit [Ping timeout: 260 seconds]
20:33 -!- grettke [~grettke@syn-184-055-133-000.res.spectrum.com] has joined #bitcoin-core-pr-reviews
20:37 -!- grettke_ [~grettke@syn-184-055-133-000.res.spectrum.com] has joined #bitcoin-core-pr-reviews
20:37 -!- grettke [~grettke@syn-184-055-133-000.res.spectrum.com] has quit [Ping timeout: 252 seconds]
20:44 -!- grettke_ is now known as grettke
21:30 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:d16f:cf00:5262:8678] has joined #bitcoin-core-pr-reviews
21:34 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:d16f:cf00:5262:8678] has quit [Ping timeout: 240 seconds]
21:52 -!- grettke is now known as grettke_
22:30 -!- grettke_ [~grettke@syn-184-055-133-000.res.spectrum.com] has quit [Quit: grettke_]
22:42 -!- dongcarl [~dongcarl@66.65.169.19] has quit [Ping timeout: 256 seconds]
22:52 -!- dongcarl [~dongcarl@syn-066-065-169-019.res.spectrum.com] has joined #bitcoin-core-pr-reviews
--- Log closed Thu Jun 06 00:00:18 2024