--- Log opened Wed Jul 03 00:00:42 2024 00:01 -!- BUSY [~BUSY@user/busy] has joined #bitcoin-core-pr-reviews 00:05 -!- BUSY [~BUSY@user/busy] has quit [Ping timeout: 260 seconds] 00:07 -!- BUSY [~BUSY@user/busy] has joined #bitcoin-core-pr-reviews 00:12 -!- BUSY [~BUSY@user/busy] has quit [Ping timeout: 252 seconds] 00:14 -!- BUSY [~BUSY@user/busy] has joined #bitcoin-core-pr-reviews 00:27 -!- BUSY [~BUSY@user/busy] has quit [Ping timeout: 252 seconds] 00:41 -!- BUSY [~BUSY@user/busy] has joined #bitcoin-core-pr-reviews 01:16 -!- BUSY [~BUSY@user/busy] has quit [Ping timeout: 255 seconds] 01:30 -!- BUSY [~BUSY@user/busy] has joined #bitcoin-core-pr-reviews 02:41 -!- dunxen [~dunxen@155.93.206.125] has joined #bitcoin-core-pr-reviews 02:44 -!- dunxen [~dunxen@155.93.206.125] has quit [Remote host closed the connection] 06:17 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 07:02 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has joined #bitcoin-core-pr-reviews 07:14 -!- grettke [~grettke@syn-184-055-133-000.res.spectrum.com] has joined #bitcoin-core-pr-reviews 07:42 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 07:42 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 08:30 -!- djinni` [~djinni@static.38.6.217.95.clients.your-server.de] has quit [Quit: Leaving] 08:33 -!- djinni` [~djinni@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 08:45 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has quit [Remote host closed the connection] 08:57 < fjahr> Hi, we'll get started in a little more than 1h. Looking forward to it! 09:00 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has joined #bitcoin-core-pr-reviews 09:09 -!- pablomartin [~pablomart@2a02:9130:84ad:7f0f:f6fc:a5c3:f367:f6b8] has joined #bitcoin-core-pr-reviews 09:55 < glozow> :) 09:56 -!- GregTonoski [~GregTonos@2a02:a31a:4049:ea80:2489:e9fa:7b15:3d9] has joined #bitcoin-core-pr-reviews 10:00 < emzy> Hi 10:00 < fjahr> #startmeeting 10:00 < stickies-v> hi 10:00 < pablomartin> hello 10:00 -!- Guest95 [~Guest95@94.204.202.221] has joined #bitcoin-core-pr-reviews 10:00 < GregTonoski> #29520 add -limitdummyscriptdatasize option - I'm suggesting discussion about that PR in the next Bitcoin Core review monthly meeting, stickies-v and glozow. I'm contacting you in order to host the meeting (per instruction at https://bitcoincore.reviews. 10:00 -!- emc99 [~emc99@212.129.77.156] has joined #bitcoin-core-pr-reviews 10:00 < fjahr> Hi everyone, welcome to the PR Review Club on the Testnet 4 PR #29775! I hope you enjoyed reviewing it as much as I enjoy working on it. 10:00 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Quit: Leaving] 10:00 < glozow> hi 10:01 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews 10:01 < fjahr> I came up with a lot of questions so we will jump right into it :) 10:01 < lightlike> hi 10:01 < fjahr> Did you review the PR? [Concept ACK, approach ACK, tested ACK, or NACK](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#peer-review)? What was your review approach? 10:02 < emzy> tested ACK 10:02 < fjahr> emzy: whoop :D 10:02 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has joined #bitcoin-core-pr-reviews 10:03 < pablomartin> concept ack, light code review... read all relevant readings from the notes (i still need to re-read some) 10:03 < stickies-v> concept ACK on resetting testnet, the current testnet issues seem prohibitive for it to be a useful dev tool 10:04 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-pr-reviews 10:04 < fjahr> pablomartin, stickies-v: cool! 10:04 < fjahr> I will get started with the rest of the questions because I think there are some interesting learnings even if you haven't reviewed everything. 10:04 < pablomartin> +1 stickies-v 10:05 < fjahr> Q: What is the message in the Genesis block in Testnet 3 and why (reference the code)? 10:06 < fjahr> by "code" I just mean the two functions involved 10:07 -!- puchka [~puchka@185.203.122.189] has quit [Ping timeout: 252 seconds] 10:07 < emzy> https://github.com/bitcoin/bitcoin/blob/3714692644f45808a6480525abc36870aeee1de4/src/kernel/chainparams.cpp#L240 10:07 < glozow> Isn't it also the chancellor on the brink message/ 10:07 < emzy> I think it is this. 10:07 < emzy> glozow: looks like it. 10:08 < abubakarsadiq> hi 10:08 < glozow> https://github.com/bitcoin/bitcoin/blob/3714692644f45808a6480525abc36870aeee1de4/src/kernel/chainparams.cpp#L238 10:08 < fjahr> Right, it’s the same as on mainnet, this actually surprised me which is why I added the question. Definitely good trivia knowledge ;) 10:09 < fjahr> can you read me? I just got a weird error message... 10:09 < glozow> fjahr: i can see you 10:10 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 10:10 < fjahr> ok, cool, so there are two versions of CreateGenesisBlock, one of which defaults to the chancellor message. I found that interesting :) 10:10 < fjahr> Q: Aside from the consensus changes, what differences do you see between Testnet 4 and Testnet 3, particularly the chain params? 10:11 < stickies-v> it's got a different genesis message (`testnet4_genesis_msg`) 10:12 < fjahr> stickies-v: yepp! 10:12 < lightlike> all softforks are already active at height 1. 10:13 < fjahr> lightlike: Right! The deployment heights of the past softforks are all set to 1, i.e. they are active from the beginning. While this might seem kind of trivial, these could have also been set to some later value allowing for some potential testing of deployment mechanisms, but there wasn’t that much appetite in that from what I remember. 10:14 < glozow> New default port 48333 10:14 < stickies-v> different messagestart too, so serialized data can be distinguished between testnets 10:15 < fjahr> Yepp, both right, and there are also some differences in the seed nodes and no checkpoints and assumeutxo data (yet). 10:15 < fjahr> Next Q: Pick a single chain param that you don’t know/remember the meaning of. Look up what it does and explain it in one sentence. 10:15 < lightlike> unrelated question: looking at the existing testnet4 chain, according to mempool.space, blocks 10000 and 20000 were mined just 5 hours apart. Was someone just pointing a ridiculous amount hash power at testnet, or was there still some funny stuff going on? 10:17 < emzy> IIRC there was a big reorg. Seems to be related to that. 10:17 < fjahr> I don't know about funny stuff, the difficulty has to ramp up initially and if someone pointed an ASIC at the chain that doesn't seem ridiculous. But still interesting to check. 10:18 < stickies-v> I had to look up `fPowNoRetargeting` during review, forgot about regtest not doing difficulty adjustments (luckily). So that's what it does: when `true`, don't adjust the required pow difficulty 10:18 < glozow> the coinbases do seem to suggest they have a common miner, from a quick glance 10:19 -!- BenA [~BenA@2601:5c3:c200:4783:6ba1:93f:1a1b:a83d] has joined #bitcoin-core-pr-reviews 10:19 < fjahr> I kind of failed at this Q and looked at something that's only in Testnet 3 but I found it interesting: The BIP16 exception (script_flag_exceptions). BIP16 standardized P2SH transactions and defined 3 rules that transactions can not violate. The blockhash in the exception is block 394 in Testnet. I didn’t have time to check which transaction exactly violates which the rules though. 10:20 < abubakarsadiq> fjahr: you mean al derived class of `CChainParams` ? 10:20 < abubakarsadiq> "a" 10:21 < fjahr> Well, yeah, I was thinking of the Testnet 4 chainparams but the learning is more broadly because it may apply to other chains too. 10:22 < fjahr> Ok, so let's get to the meat: How does the 20-min exception rule work in Testnet 3? How does this lead to the block storm bug? Please try to reference the code. 10:23 < fjahr> (no offence to vegetarians 😉) 10:25 < stickies-v> the exception for testnet3 is made in `GetNextWorkRequired` by looking at the timestamp in a block's header: https://github.com/bitcoin/bitcoin/blob/3714692644f45808a6480525abc36870aeee1de4/src/pow.cpp#L26 10:27 < fjahr> right, and what is the effect? 10:28 < lightlike> if there is no block for 20 minutes, difficulty goes to 1 for the next block. For the ones after the next block, it goes back to whatever the difficulty was before the 20 minutes had passed. 10:28 < fjahr> hint: the bip has more information on this, which I added based on feedback after coming up with the questions :) 10:29 < fjahr> lightlike: right! 10:29 -!- grettke [~grettke@syn-184-055-133-000.res.spectrum.com] has quit [Quit: grettke] 10:30 < fjahr> And how does this lead to the blockstorms? Which leads right into the next question: How is that fixed? 10:31 < stickies-v> if the last block in a difficulty period is min-difficulty, then the next block (i.e. the first of the next epoch) won't have any "lookback window" to find the true difficulty, so it'll just take the previous difficulty, which is min-difficulty 10:31 < stickies-v> https://github.com/bitcoin/bitcoin/blob/3714692644f45808a6480525abc36870aeee1de4/src/pow.cpp#L32 10:33 < fjahr> stickies-v: correct, and you already mentioned the lookback window which is coming into play again with the fix currently implemented. 10:34 < fjahr> Can someone name the alternative fix that was also contemplated? It can pretty much be derived from stickies answer. 10:34 < stickies-v> this can be exploited ad infinitum, right? so i guess the only reason block storms stop is because eventually attacker/trolls just decide to do so? 10:35 < fjahr> Yeah, like jameson lopp did recently on Testnet 3. I don't know how long it was, 2-3 weeks maybe? But it only got back to normal because he stopped. 10:35 < lightlike> don't you have to wait for 20 minutes regularly to avoid the difficulty from going back up (and in these 20 minutes, someone else could mine a block)? 10:36 < fjahr> In testnet 4 you do, in Testnet 3 you don't 10:37 < fjahr> (when you are within a blockstorm in testnet 3) 10:38 < fjahr> you can reorg someone who is a "fair" miner as well 10:38 < lightlike> ah, i see. 10:39 < stickies-v> oooh 10:39 < fjahr> Alright, the alternative fix I wanted to mention is just disallowing the last block in the difficulty to be min-difficulty. I think almost everyone was kind of indifferent between this and the look-back solution. 10:40 < fjahr> Let's talk about the time warp: Why was the time warp fix included in the PR? Hint: This came up in the PR discussion. 10:41 < stickies-v> since we're trying to fix it with the great consensus cleanup, test-running it in testnet seems sensible? 10:42 < lightlike> because that's an unrelated way to manipulate the block production rate, so why not fix both ways? 10:42 < stickies-v> and also it helps prevent block storms so 10:43 < fjahr> Right, the 20 min exception exploits in combination with this still are pretty annoying and test running it was the second entry in the pro column :) 10:44 < fjahr> And how does the time warp fix work? 10:47 < stickies-v> we check that the first block of a new difficulty adjustment period is not earlier than 2h before the previous block 10:47 < lightlike> is there any best practice on how to make exceptions for testnet? It used to be a flag (fPowAllowMinDifficultyBlocks), in the PR the genesis block is compared, elsewhere we use "chainparams.GetChainType() != ChainType::REGTEST" - are some ways better than others? 10:48 < fjahr> stickies-v: right! 10:50 < fjahr> lightlike: sjors gave the feedback that we should introduce a new helper method, I will do that probably when I retouch or as a follow-up. Using the hash was just an easy first step when I opened the PR. 10:50 < stickies-v> fjahr: i wonder why we don't check that with `if (nHeight % consensusParams.DifficultyAdjustmentInterval() == 0)` instead using the `pindexPrev->nHeight`? is it because of the genesis block handling? 10:52 < fjahr> stickies-v: Hm, I haven't thought about it to be honest. I used the code from Bluematt without unnecessary changes because it had many eyes on it already and I didn't think about this in particular 10:52 < stickies-v> okay, i'll leave a comment on the PR then, thanks 10:53 < fjahr> great! 10:53 < stickies-v> this code is never reached for genesis blocks (`assert(pindexPrev != nullptr);`) so I think it should be fine 10:53 -!- BenA [~BenA@2601:5c3:c200:4783:6ba1:93f:1a1b:a83d] has quit [Quit: Client closed] 10:53 < fjahr> Q: How do you start your node with Testnet 4? What happens when you start it just with -testnet=1 after Testnet 4 is included? Do you think that choice is sensible? 10:55 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has quit [Remote host closed the connection] 10:55 < emzy> It's not chaged it still runs in testnet3 mode. 10:55 < stickies-v> there's a new startup option `-testnet4` 10:55 < lightlike> by the way, using -testnet=4 also seems to result in testnet3 :) 10:56 < stickies-v> what about -testnet4=3? :-D 10:56 < emzy> :o) 10:56 < fjahr> lightlike: Interesting observation :D 10:56 < GregTonoski> Do you (achow101 and glozow) plan to reopen and unlock the "https://github.com/bitcoin/bitcoin/pull/28408", perhaps? 10:57 < fjahr> Right, it is planned that the default switches with the following release, does that make sense to everyone? 10:57 < fjahr> GregTonoski: I am not sure who you are asking but I am sure this meeting isn't the right place for discussing this. 10:58 < stickies-v> yeah, i think that's fair. defaulting users onto a net that's not widely used anymore doesn't seem helpful 10:58 < fjahr> Alright, I would like to skip 11 and 12 because they are pretty bike-sheddy and we can end roughtly on time still 10:59 < fjahr> But this is a good one I think: Why is it interesting to embed special scripts into the chain as test cases? What makes this useful beyond bitcoin core? 11:00 < stickies-v> I don't really understand the second part of the question, but having a single place to go to battle test your software for all kinds of weird cases is pretty helpful for devs 11:01 < fjahr> Right, maybe I didn't formulate it well: I think what makes this particularly interesting is that we force other implementations and tools to parse these transactions and scripts if they want to validate the chain. That means we are getting some tests for the whole ecosystem, not just bitcoin core. 11:02 < fjahr> Alright, I think the last one is also pretty bike-sheddy so I would say we finish up unless anyone has a comment on the last question or the ones we skipped :) 11:02 < lightlike> did that embedding happen in the existing testnet4 chain? seems like a bit of work to come up with all kind of special scripts that might be interesting and create txns for them. 11:03 < fjahr> lightlike: Yeah, that isn't done and it's a project that is on my list but where I would also be interested to collaborate with someone else. Volunteers welcome :) There are a lot of ideas for sources, like the Taproot functional test, the fuzzing body, existing scripts on Testnet 3 etc. 11:04 < fjahr> So we don't need to be creative but getting the existing scripts in there is already valuable 11:04 < fjahr> Great! Thanks everyone for participating! 11:04 < fjahr> #endmeeting 11:04 < lightlike> thanks! 11:05 -!- emc99 [~emc99@212.129.77.156] has quit [Quit: Client closed] 11:06 < emzy> thanks fjahr and all 11:06 < pablomartin> thanks fjahr and all! 11:06 < stickies-v> thanks a lot fjahr ! 11:14 < glozow> thank you fjahr! 11:17 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has joined #bitcoin-core-pr-reviews 11:19 -!- Guest26 [~Guest95@94.204.202.221] has joined #bitcoin-core-pr-reviews 11:19 -!- Guest26 [~Guest95@94.204.202.221] has quit [Client Quit] 11:20 -!- Guest71 [~Guest95@94.204.202.221] has joined #bitcoin-core-pr-reviews 11:20 -!- Guest71 [~Guest95@94.204.202.221] has quit [Client Quit] 11:22 -!- pablomartin [~pablomart@2a02:9130:84ad:7f0f:f6fc:a5c3:f367:f6b8] has quit [Ping timeout: 260 seconds] 11:22 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has quit [Ping timeout: 272 seconds] 11:35 -!- BUSY [~BUSY@user/busy] has quit [Ping timeout: 256 seconds] 11:38 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has joined #bitcoin-core-pr-reviews 11:38 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has quit [Read error: Connection reset by peer] 11:39 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has joined #bitcoin-core-pr-reviews 11:47 -!- BUSY [~BUSY@user/busy] has joined #bitcoin-core-pr-reviews 11:54 -!- Guest95 [~Guest95@94.204.202.221] has quit [Quit: Client closed] 11:54 -!- Guest95 [~Guest95@94.204.202.221] has joined #bitcoin-core-pr-reviews 11:55 -!- Guest95 [~Guest95@94.204.202.221] has quit [Client Quit] 11:56 -!- Guest95 [~Guest95@94.204.202.221] has joined #bitcoin-core-pr-reviews 11:57 -!- Guest95 [~Guest95@94.204.202.221] has quit [Client Quit] 12:00 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has quit [Remote host closed the connection] 12:05 -!- GregTonoski [~GregTonos@2a02:a31a:4049:ea80:2489:e9fa:7b15:3d9] has quit [Quit: Client closed] 12:13 -!- yonson [~yonson@2600:8801:e800:28::1962] has quit [Remote host closed the connection] 12:15 -!- yonson [~yonson@2600:8801:e800:28::1962] has joined #bitcoin-core-pr-reviews 12:22 -!- effexzi [uid474242@id-474242.ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity] 12:31 -!- kevkevin [~kevkevin@104-182-134-253.lightspeed.cicril.sbcglobal.net] has joined #bitcoin-core-pr-reviews 12:35 -!- kevkevin [~kevkevin@104-182-134-253.lightspeed.cicril.sbcglobal.net] has quit [Ping timeout: 252 seconds] 12:46 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has joined #bitcoin-core-pr-reviews 12:58 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity] 13:44 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has quit [Remote host closed the connection] 14:15 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has joined #bitcoin-core-pr-reviews 14:19 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has quit [Ping timeout: 246 seconds] 14:28 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has joined #bitcoin-core-pr-reviews 14:56 -!- pablomartin [~pablomart@194.35.122.135] has joined #bitcoin-core-pr-reviews 14:59 -!- pablomartin4btc [~pablomart@91.209.212.40] has joined #bitcoin-core-pr-reviews 15:00 -!- pablomartin4btc [~pablomart@91.209.212.40] has quit [Remote host closed the connection] 15:01 -!- pablomartin [~pablomart@194.35.122.135] has quit [Ping timeout: 264 seconds] 15:06 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has quit [Remote host closed the connection] 15:37 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has joined #bitcoin-core-pr-reviews 15:41 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has quit [Ping timeout: 246 seconds] 15:51 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has joined #bitcoin-core-pr-reviews 16:17 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds] 16:27 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has quit [Remote host closed the connection] 16:58 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has joined #bitcoin-core-pr-reviews 17:03 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has quit [Ping timeout: 240 seconds] 17:16 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has joined #bitcoin-core-pr-reviews 17:21 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has quit [Ping timeout: 264 seconds] 17:35 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has joined #bitcoin-core-pr-reviews 17:40 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has quit [Ping timeout: 268 seconds] 17:50 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews 17:50 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds] 17:52 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has joined #bitcoin-core-pr-reviews 17:57 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has quit [Ping timeout: 260 seconds] 18:05 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has joined #bitcoin-core-pr-reviews 18:10 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has quit [Ping timeout: 268 seconds] 18:21 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has joined #bitcoin-core-pr-reviews 18:27 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has quit [Ping timeout: 260 seconds] 18:41 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has joined #bitcoin-core-pr-reviews 18:46 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has quit [Ping timeout: 255 seconds] 18:48 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has joined #bitcoin-core-pr-reviews 19:40 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has quit [Remote host closed the connection] 20:03 -!- achow101 [~achow101@user/achow101] has quit [Remote host closed the connection] 20:21 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-pr-reviews 21:41 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has joined #bitcoin-core-pr-reviews 21:46 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:55a8:ad59:1512:6c91] has quit [Ping timeout: 268 seconds] 22:17 -!- TheRec [~toto@user/therec] has joined #bitcoin-core-pr-reviews 22:18 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Read error: Connection reset by peer] 22:47 -!- BUSY [~BUSY@user/busy] has quit [Ping timeout: 240 seconds] 23:01 -!- BUSY [~BUSY@user/busy] has joined #bitcoin-core-pr-reviews 23:05 -!- maflcko [~none@107.172.8.183] has quit [Quit: ZNC 1.8.2+deb2build5 - https://znc.in] 23:07 -!- maflcko [~none@107.172.8.183] has joined #bitcoin-core-pr-reviews --- Log closed Thu Jul 04 00:00:43 2024