--- Log opened Wed Mar 19 00:00:57 2025
00:19 -!- grettke [~grettke@syn-184-055-133-000.res.spectrum.com] has quit [Quit: grettke]
00:56 -!- jonatack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer]
00:59 -!- pablomartin [~pablomart@103.214.47.130] has joined #bitcoin-core-pr-reviews
01:16 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
01:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 264 seconds]
02:12 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews
02:13 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-pr-reviews
02:24 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-pr-reviews
02:24 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 272 seconds]
02:44 -!- rkrux [~rkrux@user/rkrux] has joined #bitcoin-core-pr-reviews
02:54 -!- lightlike [sid521075@user/lightlike] has quit [Read error: Connection reset by peer]
02:54 -!- lightlike [sid521075@user/lightlike] has joined #bitcoin-core-pr-reviews
04:03 -!- rkrux [~rkrux@user/rkrux] has quit [Quit: Client closed]
04:28 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-pr-reviews
04:29 -!- TheRec [~toto@user/therec] has quit [Read error: Connection reset by peer]
05:11 < glozow> reminder: 29.0 RC testing review club later today
05:11 < glozow> 17 UTC (I won't be available at the time)
05:13 < stickies-v> notes are available on https://bitcoincore.reviews/v29-rc-testing
06:19 -!- elichai2 [sid212594@id-212594.hampstead.irccloud.com] has quit [Ping timeout: 272 seconds]
06:21 -!- elichai2 [sid212594@id-212594.hampstead.irccloud.com] has joined #bitcoin-core-pr-reviews
06:50 -!- jarolrod [sid475272@id-475272.uxbridge.irccloud.com] has quit [Ping timeout: 248 seconds]
06:51 -!- elichai2 [sid212594@id-212594.hampstead.irccloud.com] has quit [Ping timeout: 260 seconds]
06:53 -!- jarolrod [sid475272@id-475272.uxbridge.irccloud.com] has joined #bitcoin-core-pr-reviews
06:55 -!- elichai2 [sid212594@id-212594.hampstead.irccloud.com] has joined #bitcoin-core-pr-reviews
07:16 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Read error: Connection reset by peer]
07:16 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-pr-reviews
07:18 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-pr-reviews
07:41 -!- pablomartin [~pablomart@103.214.47.130] has quit [Quit: Leaving]
07:44 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Quit: PaperSword]
08:17 -!- kevkevin_ [~kevkevin@209.242.39.30] has joined #bitcoin-core-pr-reviews
08:17 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Read error: Connection reset by peer]
09:02 -!- janb84 [janb84@user/janb84] has joined #bitcoin-core-pr-reviews
09:10 -!- pablomartin [~pablomart@103.214.47.132] has joined #bitcoin-core-pr-reviews
09:26 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-pr-reviews
09:56 -!- Guest48 [~Guest30@150.162.215.104] has joined #bitcoin-core-pr-reviews
09:57 -!- dzxzg [~dzxzg@user/dzxzg] has joined #bitcoin-core-pr-reviews
10:00 -!- arejula27 [~arejula27@dhcp134-96-49-1.stw.stud.uni-saarland.de] has joined #bitcoin-core-pr-reviews
10:00 < janb84> #startmeeting
10:00 < janb84> hi
10:00 < arejula27> hi :D
10:00 < emzy> hi
10:00 < kevkevin_> hi
10:00 < dzxzg> hi
10:00 < janb84> Hello everyone,
10:00 < janb84> Welcome to the Bitcoin Review Club meeting! Today, we will be discussing the Release Testing Guide for the upcoming 29.0 release. These guides are essential for assisting people in testing the release candidates across various systems and environments. This time, we, the students of the 2025 Chaincode Labs Boss program, have had the privilege of writing it.
10:00 < janb84> Typically, the Review Club focuses on discussing a pull request (PR), but this time we will be reviewing the Release Testing Guide. 
10:00 < janb84> You can find it here:  
10:00 < janb84> https://github.com/bitcoin-core/bitcoin-devwiki/wiki/29.0-Release-Candidate-Testing-Guide
10:01 < janb84> Just a reminder to please be mindful of the review club meeting conventions:
10:01 < janb84> Do not ask to ask a question, just ask! 
10:01 < janb84> The host moderates, not lead, just jump in :) 
10:01 < janb84> With that out of the way, let’s start ! 
10:01 -!- stringintech [~stringint@2602:fa59:3:774::1] has joined #bitcoin-core-pr-reviews
10:01 < janb84> Did everyone get a chance already to test v29 (and use our guide)? How about a quick y/n from everyone!
10:01 < dzxzg> n
10:01 < emzy> n
10:02 < emzy> I just did the build.
10:02 < janb84> That is a good start :) 
10:02 -!- Guest37 [~Guest37@2804:18:191c:a9b:1da1:4ce:af24:e78e] has joined #bitcoin-core-pr-reviews
10:02 -!- Guest37 [~Guest37@2804:18:191c:a9b:1da1:4ce:af24:e78e] has quit [Client Quit]
10:02 < janb84> Any trouble doing that ? was it clear how to do it from the guide ? 
10:04 < dzxzg> it seems like there is a small issue with setting the v29 bin when building from source (https://github.com/bitcoin-core/bitcoin-devwiki/wiki/29.0-Release-Candidate-Testing-Guide#v29-from-source)
10:04 < emzy> I actualy did not use the guide. Not the first time I'm doing it.
10:04 < janb84> ah cool cool 
10:04 -!- Guest37 [~Guest37@2804:18:191c:a9b:1da1:4ce:af24:e78e] has joined #bitcoin-core-pr-reviews
10:04 < dzxzg> should be "export BINARY_PATH_29=$RC_TEST_DIR/bitcoin/build/bin" after a recent change
10:05 -!- Guest37 [~Guest37@2804:18:191c:a9b:1da1:4ce:af24:e78e] has quit [Client Quit]
10:05 < janb84> yeah that is a good point @dzxzg 
10:05 < dzxzg> otherwise built and checked the versions and everything looks good (y)
10:06 < janb84> I have made a note of this issue, but if you come across any other issues please make a comment to the issue list :) 
10:07 < janb84> https://github.com/bitcoin/bitcoin/issues/32026
10:07 < janb84> Libnatpmp was replaced with a custom implementation of PCP and NAT-PMP. This supports automatic IPv4 port forwarding as well as IPv6 pinholing. We are interested in all test outcome, Please describe how to test this.
10:10 -!- Guest37 [~Guest37@2804:18:191c:a9b:1da1:4ce:af24:e78e] has joined #bitcoin-core-pr-reviews
10:10 -!- Guest37 [~Guest37@2804:18:191c:a9b:1da1:4ce:af24:e78e] has quit [Client Quit]
10:11 < dzxzg> I ran the following command: bitcoind29 -signet -natpmp=1 -debug=net and looked for logging output about pcp in my terminal, as described in the testing guide
10:12 < janb84> haha yeah thats it @dzxzg , kinda stupid question from me but it is a starter 
10:12 < dzxzg> I ran this command: cat $DATA_DIR_29/signet/debug.log | grep "pcp"  to grep for lines about pcp
10:12 < janb84> But once you have started the node like that how can one check if the node is reachable
10:14 < emzy> I think I have the feature off on my router. Getting this: pcp: Mapping failed with result NOT_AUTHORIZED (code 2)
10:15 < dzxzg> I see this after my node requests port mapping "[net:warning] pcp: Could not send request: Operation not permitted (1)"  looks like it doesn't work on my network!
10:16 < janb84> @emzy correct ! looks like pnp is not enabled 
10:16 < janb84> or pcp
10:16 < janb84> These testcases are also very valuable ! the developers would love to know if you could setup a connection and if PNP is enabled by default.
10:16 < janb84> Please if you are able to do so create a comment here:  https://github.com/bitcoin/bitcoin/issues/31663
10:17 < janb84> They would also like the know the route brand/model 
10:18 < janb84> Does anyone has IpV6 enabled on their network ? 
10:20 -!- dzxzg10 [~dzxzg@user/dzxzg] has joined #bitcoin-core-pr-reviews
10:21 -!- dzxzg10 [~dzxzg@user/dzxzg] has quit [Client Quit]
10:21 < emzy> Yes
10:21 -!- dzxzg86 [~dzxzg@user/dzxzg] has joined #bitcoin-core-pr-reviews
10:22 < arejula27> In the RPC updated methods, **mainnet** and **regtest** are used. Is it okay, or would it be better to test all methods only on **regtest**?
10:22 < emzy> I have a FRITZ!Box 7530 AX. But I changed a lot of settinge :)
10:23 < janb84> @emzy do you get any feedback on ipv6 pinholing being succesful ? 
10:23 -!- dzxzg [~dzxzg@user/dzxzg] has quit [Ping timeout: 240 seconds]
10:23 -!- dzxzg86 is now known as dzxzg
10:26 < janb84> @dzxzg is the connection issues related to PCP test? or just a coincedence ?  
10:27 -!- dzxzg [~dzxzg@user/dzxzg] has quit [Quit: Client closed]
10:27 < emzy> ipv4 pcp seems to work now, that I allowed it: "[net:info] portmap: Added mapping pcp:87.x.x.x:38333 -> 192.168.99.114:38333 (for 120s)"
10:27 -!- arejula27 [~arejula27@dhcp134-96-49-1.stw.stud.uni-saarland.de] has quit [Quit: Client closed]
10:27 -!- dzxzg [~dzxzg@user/dzxzg] has joined #bitcoin-core-pr-reviews
10:28 < dzxzg> I think it's just a coincidence, firefox garbage collecting my web.libera.chat tab :)
10:28 -!- mabu17 [~mabu44@165.22.193.105] has joined #bitcoin-core-pr-reviews
10:28 < emzy> looks like the "pcp: Mapping failed with result NOT_AUTHORIZED (code 2)" is from ipv6
10:28 < janb84> @emzy even if you have changed a lot of settings, i think it's valueble to create a comment to share these findings
10:28 < emzy> ok, will do.
10:29 < dzxzg> I'll share my router and settings in that issue as well
10:30 < emzy> is there a way to see the active mappings? It could be that just one of my ipv6 are NOT_AUTHORIZED
10:31 < janb84> that's a good question @emzy i do not know. 
10:32 < emzy> from the log, it seems only the ipv4 pcp was working.
10:32 < dzxzg> emzy: not sure if there's any rpc command for that, but you can see the mappings that get set using: `cat $DATA_DIR_29/regtest/debug.log | grep -i "pcp"`
10:33 < janb84> @emzy the ai tells me you would be able to see that in your Fritzbox, Network settings -> View active connections 
10:37 < emzy> Looks more it is at: Internet > Permit Access > Port Sharing.  I can see the ipv4 pcp there.
10:37 < emzy> I'm a networking guy. But the Fritzbox is made for normal people. Hard to use for me :)
10:37 < janb84> @emzy AI.. so yeah :') But glad you found it 
10:38 < emzy> I will look into it. And make a comment about it.
10:38 < janb84> @emzy thanks
10:39 < janb84> The issue also mentions that one can test if the mapping is successful by using nn 
10:39 < janb84>  nc -v -n -z <redacted> 8444
10:40 < janb84> ofc replace redacted with external ip and port with the correct port 
10:42 < janb84> Does anyone of you have a question about the guide ? or some remarks or missing something. We did not know how to create a test for the Ephemeral dust feature, if one of you would have a clue please create a comment in the feedback issue 
10:43 -!- Guest48 [~Guest30@150.162.215.104] has quit [Quit: Client closed]
10:43 < emzy> just tested to connect my local node. It works from a public node!
10:43 < emzy>  in         ipv4  nbwl2  2     24     24    0   34                   1          1 15 70016/Satoshi:27.1.0(@emzy)/
10:44 < janb84> @emzy nice ! thats a great result ! 
10:44 < emzy> in         ipv4  nbwl2  2     22     22   13    1                   1          2 15 178.63.87.163:44900
10:45 < emzy> nice
10:46 -!- Guest54 [~Guest30@150.162.215.104] has joined #bitcoin-core-pr-reviews
10:47 < janb84> @dzxzg thank you for also creating a comment about your PCP findings ! 
10:48 < janb84> Any questions ? if not I will wrap up this meeting in 5 minutes. 
10:53 < janb84> Thank you all for joining and actively participating! If you have any feedback, please leave a comment here:
10:53 < janb84> https://github.com/bitcoin/bitcoin/issues/32026
10:53 < dzxzg> None from me, I have to drop but thanks to all who wrote the testing guide and thank you janb84 for hosting!
10:53 < janb84> Thanks once again!
10:53 -!- dzxzg [~dzxzg@user/dzxzg] has quit [Quit: Client closed]
10:53 < janb84> #endmeeting
10:53 < emzy> I'm working on the comment. No questions from me.
10:53 < janb84> @emzy great ! 
10:53 < emzy> Thank you very much janb84!
10:54 < janb84> @emzy yw ! 
10:57 -!- mabu17 [~mabu44@165.22.193.105] has quit [Quit: Client closed]
10:58 -!- stringintech [~stringint@2602:fa59:3:774::1] has quit [Quit: Client closed]
10:59 -!- janb84 [janb84@user/janb84] has quit [Quit: WeeChat 4.4.3]
11:31 -!- Guest54 [~Guest30@150.162.215.104] has quit [Quit: Client closed]
11:34 -!- Guest59 [~Guest59@2804:30c:779:e600:5fa3:f965:56a3:ee20] has joined #bitcoin-core-pr-reviews
11:50 -!- pablomartin [~pablomart@103.214.47.132] has quit [Quit: Leaving]
11:58 -!- Guest59 [~Guest59@2804:30c:779:e600:5fa3:f965:56a3:ee20] has quit [Quit: Client closed]
12:36 -!- Guest1 [~Guest30@150.162.215.104] has joined #bitcoin-core-pr-reviews
12:39 -!- Guest1 [~Guest30@150.162.215.104] has quit [Client Quit]
12:42 -!- grettke [~grettke@syn-184-055-133-000.res.spectrum.com] has joined #bitcoin-core-pr-reviews
13:26 -!- brunoerg_ [~brunoerg@2804:14d:5285:84b2::1000] has quit [Remote host closed the connection]
14:06 -!- brunoerg [~brunoerg@179.191.242.9] has joined #bitcoin-core-pr-reviews
14:19 -!- grettke [~grettke@syn-184-055-133-000.res.spectrum.com] has quit [Quit: grettke]
14:28 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-pr-reviews
14:31 -!- kevkevin_ [~kevkevin@209.242.39.30] has quit [Ping timeout: 260 seconds]
14:50 -!- brunoerg [~brunoerg@179.191.242.9] has quit [Remote host closed the connection]
15:05 -!- grettke [~grettke@syn-184-055-133-000.res.spectrum.com] has joined #bitcoin-core-pr-reviews
17:05 -!- brunoerg [~brunoerg@2804:14d:5285:84b2::1000] has joined #bitcoin-core-pr-reviews
17:08 -!- brunoerg [~brunoerg@2804:14d:5285:84b2::1000] has quit [Read error: Connection reset by peer]
18:23 -!- grettke [~grettke@syn-184-055-133-000.res.spectrum.com] has quit [Quit: grettke]
18:32 -!- grettke [~grettke@syn-184-055-133-000.res.spectrum.com] has joined #bitcoin-core-pr-reviews
18:40 -!- theStack [~theStack@95.179.145.232] has quit [Remote host closed the connection]
19:30 -!- grettke [~grettke@syn-184-055-133-000.res.spectrum.com] has quit [Quit: grettke]
19:59 -!- hernanmarino [~hernanmar@2800:2330:2840:1f6:e0ac:bdc2:15e7:7225] has quit [Quit: ZNC 1.8.2+deb2+deb11u1 - https://znc.in]
20:00 -!- hernanmarino [~hernanmar@2800:2330:2840:1f6:e0ac:bdc2:15e7:7225] has joined #bitcoin-core-pr-reviews
21:01 -!- grettke [~grettke@syn-184-055-133-000.res.spectrum.com] has joined #bitcoin-core-pr-reviews
21:04 -!- grettke [~grettke@syn-184-055-133-000.res.spectrum.com] has quit [Client Quit]
--- Log closed Thu Mar 20 00:00:52 2025