--- Log opened Tue May 20 00:00:49 2025
09:13 < stickies-v> TheCharlatan: https://github.com/TheCharlatan/bitcoin/tree/kernelApi_Cpp is the best branch for the cpp header, right?
09:13 < TheCharlatan> let me check again
09:14 < stickies-v> asking because ed1d6fac21ff361aa9e51737d6eacd2af0b77255 doesn't compile for me
09:15 < stickies-v> https://www.irccloud.com/pastebin/mRatl8R6/
09:17 < TheCharlatan> I think this is the most up to date branch: kernelApi_Cpp_Internal_Headers
09:17 < TheCharlatan> the CI is reporting the same error, I'll see if I can rebase and fix
09:18 < stickies-v> okay i'll try that one instead. what does internal headers mean?
09:23 < TheCharlatan> it means it starts to install some of our internal headers directly, instead of re-defining their contents for a public interface.
09:27 < stickies-v> fyi adding a `TransactionImpl(CTransaction&& tx) : m_transaction{std::move(tx)} {}` fixed the build for me on macos
09:36 < TheCharlatan> nice, I'll try and push a fix soon, in the middle of trying to separate mempool from validation right now :P
09:36 < stickies-v> hmm, is `kernel_logging_connection_create` exported in the shared library for you? all (most?) of the other functions seem fine, but for some reason this is gets name mangled
09:36 < stickies-v> https://www.irccloud.com/pastebin/SfgCEYyk/
09:37 < stickies-v> yeah no rush i'm just updating my worktree locally for now
09:53 < stickies-v> found the `kernel_logging_connection_create` issue: the decl has a `const void* user_data` param whereas the impl has a non-const `void* user_data` param
12:22 < stickies-v> TheCharlatan: I've pushed 5 fixup commits to https://github.com/stickies-v/bitcoin/commits/fix-kernel-cpp/ . These on top of ed1d6fac21ff361aa9e51737d6eacd2af0b77255 make the py-bitcoinkernel test suite pass again, using the C header.
--- Log closed Wed May 21 00:00:50 2025