--- Log opened Tue Jun 08 00:00:32 2021
00:58 -!- afilini [~afilinima@2.233.112.151] has joined #bitcoin-rust
00:58 < afilini> not sure if we have something weird in bdk, but i think the default printing style of ChildNumber has changed in 0.26.1 because of this commit https://github.com/rust-bitcoin/rust-bitcoin/commit/017cd71ca7330aa557626a7083dbd517bf8b983f
00:58 < afilini> i think the `alt` thing should have been flipped to maintain the original behavior
00:59 < afilini> we have test failures because the descriptor we print uses h instead of ', or the other way around, i haven't really looked into it
01:04 < afilini> rcasatta told me he didn't see my first message, sending it again just in case: "not sure if we have something weird in bdk, but i think the default printing style of ChildNumber has changed in 0.26.1 because of this commit https://github.com/rust-bitcoin/rust-bitcoin/commit/017cd71ca7330aa557626a7083dbd517bf8b983f"
01:21 < elichai2> BlueMatt: Approved #289, not sure if we want/need 2 approvals for merging it. I'll try to look at #282 today but can't promise, I'll need to verify the spin-loop impl there
01:30 < afilini> opened an issue as well if you prefer to move the discussion to github: https://github.com/rust-bitcoin/rust-bitcoin/issues/608
05:18 -!- tibo [~tibo@2400:4050:2a83:7000:7dec:6e9b:83e5:1c4c] has quit [Remote host closed the connection]
05:18 -!- tibo [~tibo@2400:4050:2a83:7000:7dec:6e9b:83e5:1c4c] has joined #bitcoin-rust
05:18 -!- Guest9958 [~Guest99@2.233.112.151] has joined #bitcoin-rust
05:19 -!- Guest9958 [~Guest99@2.233.112.151] has left #bitcoin-rust []
05:23 -!- tibo [~tibo@2400:4050:2a83:7000:7dec:6e9b:83e5:1c4c] has quit [Ping timeout: 272 seconds]
05:28 -!- Guest79 [~Guest79@93-50-177-66.ip153.fastwebnet.it] has joined #bitcoin-rust
05:35 -!- Guest79 [~Guest79@93-50-177-66.ip153.fastwebnet.it] has quit [Quit: Client closed]
05:41 -!- dunxen [dunxen@gateway/vpn/protonvpn/dunxen] has joined #bitcoin-rust
06:01 -!- dunxen [dunxen@gateway/vpn/protonvpn/dunxen] has quit [Remote host closed the connection]
06:02 -!- dunxen [dunxen@gateway/vpn/protonvpn/dunxen] has joined #bitcoin-rust
06:55 -!- dunxen [dunxen@gateway/vpn/protonvpn/dunxen] has quit [Quit: Leaving...]
07:04 < sebx2a> The breakage seems pretty bad, I propose to yank 0.26.1 and to release 0.26.2 https://github.com/rust-bitcoin/rust-bitcoin/pull/611
07:04 < sebx2a> What do you think @afilini, @andytoshi and other maintainers?
07:04 -!- stevenroose [~steven@2001:19f0:6801:83a:5157:a229:22ca:bdf9] has joined #bitcoin-rust
07:38 < afilini> Yeah that's probably what i would do as well
07:39 < afilini> Also it doesn't fail at compile time, so we only know for sure that rust-miniscript/bdk don't like that change because we have tests in place that caught it, but we don't know if there are other places that might be failing silently
07:42 < sebx2a> Agreed, I think our reasoning back then was that any sound impl should support both variants anyway and we forgot about tests depending on specific behavior. I'm still not sure if depending on specific behavior in application logic would be even BIP compliant. But better safe than sorry.
07:45 < sebx2a> It's annoying that descriptor key checksums seem to depend on the string representation. That will always break roundtripability either way.
07:53 -!- RCasatta[m] [~rcasattam@2001:470:69fc:105::c85] has quit [Remote host closed the connection]
07:53 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has quit [Remote host closed the connection]
07:53 -!- prusnak[m] [~stickmatr@2001:470:69fc:105::98c] has quit [Remote host closed the connection]
07:54 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #bitcoin-rust
07:56 -!- prusnak[m] [~stickmatr@2001:470:69fc:105::98c] has joined #bitcoin-rust
07:56 < sanket1729> reviewing
07:56 -!- RCasatta[m] [~rcasattam@2001:470:69fc:105::c85] has joined #bitcoin-rust
11:37 -!- emzy [~quassel@user/emzy] has joined #bitcoin-rust
16:55 < ariard> BlueMatt: back to keyboard, refactoring #725 on top of main as a priority, hope to be done tmrwish :)
16:57 < BlueMatt> ariard: sounds great!
16:57 < BlueMatt> ariard: do you have thoughts on the suggested 0.0.98 versioning?
16:57 < BlueMatt> ariard: I think that more accurately captures the state of the lib - we're really rapidly reaching 0.1-level status
16:57 < BlueMatt> and basically after some cleanups I think we're there
16:57 < BlueMatt> maybe with anchor, but I'm starting to lean towards anchor being optional, dunno, what do you think?
17:30 -!- tibo [~tibo@p3002252-ipngn18401marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-rust
21:33 -!- Netsplit *.net <-> *.split quits: belcher
21:39 -!- Netsplit over, joins: belcher
22:43 -!- thomaseizinger[m [~thomaseiz@2001:470:69fc:105::16b2] has joined #bitcoin-rust
22:44 -!- thomaseizinger[m is now known as thomaseizinger
--- Log closed Wed Jun 09 00:00:33 2021