--- Log opened Thu Jun 17 00:00:40 2021
05:23 -!- tibo_ [~tibo@2400:4050:2a83:7000:d1d8:36e9:af51:30eb] has quit [Remote host closed the connection]
05:53 < elichai2> WTF https://github.com/briansmith/ring/issues/774, idk how I didn't see this issue until now
09:17 < darosior> andytoshi: would you mind taking a look to https://github.com/apoelstra/rust-jsonrpc/pull/42 ?
10:35 < andytoshi> sure
10:36 < andytoshi> lol elichai2 
10:42 < andytoshi> darosior: ok utack
10:42 < andytoshi> want me to merge that?
10:43 < andytoshi> and lemme do a bitcoin_hashes release while i'm here
10:43 < darosior> Cool thanks for having a look!
10:44 < andytoshi> these look really straightforward, i assume the only issues are weird low-level network stuff that we'll only discover with real-world usage
10:45 < andytoshi> so there isn't much value in me holding up the PR "until I eventually get around to testing it"
10:45 < darosior> Yeah it'd be great if you can merge and release, let me just test it again it since it's been 2 months
10:45 < andytoshi> ok :)
10:46 < andytoshi> BlueMatt: do you know off-hand if there are any breaking changes in the nostd stuff? it doesn't look like it but it's a little big
10:46 < andytoshi> for bitcoin_hashes
10:48 < andytoshi> https://github.com/rust-bitcoin/bitcoin_hashes/pull/129/files
10:49 < andytoshi> BlueMatt: looks like clark is the only owner on crates
10:50 < andytoshi> i'll open an issue asking him if me or you can be an owner
10:51 < andytoshi> https://github.com/rust-bitcoin/rust-bech32/issues/52
10:55 < BlueMatt> andytoshi: I dont think there are any breaking changes, no, but honestly I definitely did not review it *super* carefully for breaking changes, so I wouldn't take my word for it.
10:55 < BlueMatt> andytoshi: as for rust-bech32, yea, if you nag clark on twitter dm he shows up.
10:58 < andytoshi> heh, ok, i'm not on twitter
10:58 < andytoshi> and i checked reasonably carefully for breaking changes. i don't think there are any (not even "technically breaking changes that I have some argument for not counting" ;))
11:08 < BlueMatt> ha
12:27 -!- BlueMatt [~BlueMatt@ircb.bluematt.me] has quit [Quit: Quit]
12:27 -!- BlueMatt [~BlueMatt@ircb.bluematt.me] has joined #bitcoin-rust
13:27 -!- moneyball_ [sid299869@id-299869.brockwell.irccloud.com] has joined #bitcoin-rust
13:35 -!- Netsplit *.net <-> *.split quits: moneyball
13:35 -!- moneyball_ is now known as moneyball
16:04 < darosior> andytoshi: so i succesfully tested https://github.com/apoelstra/rust-jsonrpc/pull/42 downstream. Only had a quirk with the Windows hack, which is now fixed
16:05 < darosior> Btw is there any plan to move this repo to rust-bitcoin?
16:12 < andytoshi> i dunno, we really should, but it's never quite fit in rust-bitcoin
16:12 < andytoshi> it's only half-maintained and it's historically had a lot of trouble with MSRV
17:06 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-rust
17:09 -!- tibo_ [~tibo@2400:4050:2a83:7000:c435:9e8d:87cd:ad38] has joined #bitcoin-rust
17:09 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 244 seconds]
--- Log closed Fri Jun 18 00:00:41 2021