--- Log opened Thu Jul 01 00:00:54 2021 00:21 -!- belcher_ is now known as belcher 01:37 -!- Guest64 [~textual@2603-8000-3301-5d44-6c9b-8386-c248-b087.res6.spectrum.com] has joined #bitcoin-rust 03:13 -!- stevenroose [~steven@2001:19f0:6801:83a:a90a:4c55:7940:b7e2] has quit [Quit: ZNC 1.7.4 - https://znc.in] 03:13 -!- stevenroose [~steven@irc.roose.io] has joined #bitcoin-rust 03:15 -!- Guest64 [~textual@2603-8000-3301-5d44-6c9b-8386-c248-b087.res6.spectrum.com] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…] 04:15 -!- Guest94 [~textual@194.62.169.65.ipv4.parknet.dk] has joined #bitcoin-rust 05:52 < BlueMatt> ariard: yea, its def an issue - i think ultimately the package datastructure needs to be cleaned up a bit more 05:53 < BlueMatt> ariard: the old truism about how "if your datastructure matches the real world, your code is simple" applies here 05:57 -!- tibo__ [~tibo@2400:4050:2a83:7000:e9a6:59b8:7e78:97e1] has quit [Remote host closed the connection] 05:57 -!- tibo_ [~tibo@2400:4050:2a83:7000:e9a6:59b8:7e78:97e1] has joined #bitcoin-rust 06:01 -!- tibo_ [~tibo@2400:4050:2a83:7000:e9a6:59b8:7e78:97e1] has quit [Ping timeout: 240 seconds] 07:48 < BlueMatt> ariard: thanks! I think I addressed all your comments on the pr too 10:03 -!- Guest64 [~textual@2603-8000-3301-5d44-6c9b-8386-c248-b087.res6.spectrum.com] has joined #bitcoin-rust 10:15 -!- Guest64 [~textual@2603-8000-3301-5d44-6c9b-8386-c248-b087.res6.spectrum.com] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…] 10:16 -!- Guest64 [~textual@2603-8000-3301-5d44-6c9b-8386-c248-b087.res6.spectrum.com] has joined #bitcoin-rust 13:51 -!- Guest94 [~textual@194.62.169.65.ipv4.parknet.dk] has quit [Quit: Textual IRC Client: www.textualapp.com] 13:55 -!- Guest64 [~textual@2603-8000-3301-5d44-6c9b-8386-c248-b087.res6.spectrum.com] has quit [Quit: Textual IRC Client: www.textualapp.com] 16:22 < ariard> BlueMatt: yo, just acked #970, it's good enough to me even if it sounds agree we might have a weird issue about race conditions and re-broadcasting requests :/ 16:23 < ariard> BlueMatt: actually your solution of forever-tracking outpoints: https://github.com/rust-bitcoin/rust-lightning/pull/970#discussion_r662345698 might the more robust one, need to think about 16:24 < ariard> BlueMatt: yeah i know package needs more cleanup, sadly the whole onchain area won't get easier with anchor/more outputs types support 16:26 < ariard> BlueMatt: not forgetting todo comparison between fee-based input bumping vs chain-of-CPFPs for the UtxoPool implem, just catching up a bit with spec discussions 16:47 < BlueMatt> ariard: yea, I'm really worried about it, I think jeff said he was gonna play with it and see if he could come up with any way to make it cleaner, so hopefully he comes up with something. 16:48 < BlueMatt> but he's also working on cleaning up the router's outputs 16:48 < BlueMatt> ariard: re: https://github.com/rust-bitcoin/rust-lightning/pull/970#discussion_r662639453 are we on different pages here? 16:50 < BlueMatt> I agree its not ideal what its doing there but the not-ideal part is what the *current* code does 16:50 < BlueMatt> not what the new code does (depending on the connection style) 17:21 -!- tibo_ [~tibo@2400:4050:2a83:7000:6d99:2283:f83:9b19] has joined #bitcoin-rust 17:21 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-rust 17:25 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 272 seconds] 17:52 < ariard> BlueMatt: well iiuc we agree on a) *current* master we have a race, b) #970 is fixing the issue for few connection style but c) we're still emitting redundant commitment txn in some connect styles 17:53 < ariard> and my concern it might be a severe internal API issue once we have anchor support and we freeze fee-bumping reserve for a completely buggy broadcast 17:54 < ariard> so yes we could add a belt-and-suspender don't broadcast on deeply confirmed outpoints to prevent that kind of bug 17:54 < BlueMatt> ariard: yea, ok, i think we're on the same page. imo its pretty unrelated to 970, tho, which is fixing a *missed* broadcast, not a duplicate one. 17:54 < ariard> BlueMatt: yea zooming out and recalling initial 970 purpose, it's unrelated 17:55 < ariard> just something we discover by the way :/ 17:55 < BlueMatt> btw re swapping the ordering https://github.com/rust-bitcoin/rust-lightning/pull/970#discussion_r660748592 it does *not* cause any test failures, tho that's probably means our tests are bad.... 17:55 < BlueMatt> yea, right. 17:55 < BlueMatt> well glad we have 970 to find lots of thigns to work on with our packages :) 17:55 < BlueMatt> I'd still like to do the order swap in a seaprate pr if that's ok, though 17:55 < ariard> hmmmmmm :/ 17:55 < BlueMatt> ideally write a test in that pr as well but god I have so many things to do rn 17:55 < ariard> i'm okay with the state of 970 for sure, just a lot of things to think more about it 17:55 < BlueMatt> yea. 17:56 < BlueMatt> I'll get back around to some of that stuff after I fix fee updates :p 17:57 < ariard> yeah sorry still super busy core-side, hopefully back on hacking UtxoPool next week 17:57 < ariard> like prefer to be consistent on anchor output support 17:57 < BlueMatt> yea, i promised/still need to chat with people on core maybe tweaking the carve-out, but I swapped all that stuff out of my brain a year ago :( 17:57 < BlueMatt> need fricken package relay 17:57 < BlueMatt> I do wonder if we should write our rbf/anchor output api *assuming* package relay 17:57 < ariard> BlueMatt: well actually i'm hacking libmultiprocess because i still want better support for altnertate transport 17:58 < BlueMatt> given you kinda sorta need package relay to be "secure" 17:58 < ariard> because you know those lightning things they have weird p2p assumptions :/ 17:58 < BlueMatt> and if we assume package relay then you can do stuff like use one bump output with multiple anchor outputs 17:58 < BlueMatt> and then I can have my "only need one on-chain output" wish :) 17:58 < ariard> beware with package-relay not evicting your own chain of CPFP 17:59 < BlueMatt> right, I mean we'd have to be really careful how we do it 17:59 < BlueMatt> but still 17:59 < ariard> well imho it's more complexity swallowed up by LN implem to do right their "assumed in-mempool chain of transactiions" instead of complexifying carve-out core-side 18:00 < BlueMatt> I'd really rather assume core will eventually do the thing that can pay miners more, cause, like, they kinda have to at some point :p 18:00 < ariard> https://github.com/rust-bitcoin/rust-lightning/pull/970#discussion_r660748592 wr.t to this, yeah tests sound bad :/ 18:00 < BlueMatt> otherwise I'll just suggest pool create a public pushtx api which allows packages 18:00 < BlueMatt> and then we have package relay! 18:00 < BlueMatt> just the shitty version lol 18:01 < BlueMatt> anyway, gotta run 18:01 < BlueMatt> dinner time 18:01 < BlueMatt> lots to think about. 18:01 < ariard> yeah see you latter, almost night 18:02 < ariard> w.r.t to channel types, left a comment, on the long run imo roasbeef position make sense and should offer more flexibility for node policy 18:02 < ariard> especially interesting for us if we envision *weird* DLC channel-type support :) 20:10 -!- thomaseizinger [~thomaseiz@2001:470:69fc:105::16b2] has quit [Read error: Connection reset by peer] 20:10 -!- RCasatta[m] [~rcasattam@2001:470:69fc:105::c85] has quit [Remote host closed the connection] 20:10 -!- prusnak[m] [~stickmatr@2001:470:69fc:105::98c] has quit [Remote host closed the connection] 20:10 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has quit [Read error: Connection reset by peer] 20:12 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #bitcoin-rust 20:17 -!- prusnak[m] [~stickmatr@2001:470:69fc:105::98c] has joined #bitcoin-rust 20:17 -!- thomaseizinger [~thomaseiz@2001:470:69fc:105::16b2] has joined #bitcoin-rust 20:17 -!- RCasatta[m] [~rcasattam@2001:470:69fc:105::c85] has joined #bitcoin-rust 20:34 -!- prusnak[m] [~stickmatr@2001:470:69fc:105::98c] has quit [Quit: node-irc says goodbye] 20:34 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has quit [Quit: node-irc says goodbye] 20:35 -!- thomaseizinger [~thomaseiz@2001:470:69fc:105::16b2] has quit [Quit: node-irc says goodbye] 20:36 -!- RCasatta[m] [~rcasattam@2001:470:69fc:105::c85] has quit [Quit: node-irc says goodbye] --- Log closed Fri Jul 02 00:00:54 2021