--- Log opened Mon Jul 05 00:00:57 2021
00:55 -!- reallll is now known as belcher
05:20 -!- kallewoof is now known as kalle
05:25 -!- tibo_ [~tibo@2400:4050:2a83:7000:fc01:2082:4e63:2a54] has quit [Remote host closed the connection]
06:07 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has quit [Quit: ZNC 1.8.0 - https://znc.in]
06:52 < BlueMatt> andytoshi: can we do a bitcoin_hashes version bump for https://github.com/rust-bitcoin/bitcoin_hashes/pull/131 ?
06:52 < BlueMatt> then we can (finally) land no_std :)
11:35 -!- Netsplit *.net <-> *.split quits: michaelfolkson, jrawsthorne, mycroft, willcl_ark
11:40 -!- Netsplit over, joins: willcl_ark, michaelfolkson, jrawsthorne, mycroft
13:58 < BlueMatt> ariard: I'm a bit confused by this comment - note that this is a *private* internal interface not a public one https://github.com/rust-bitcoin/rust-lightning/pull/984#discussion_r664101712
14:16 < ariard> BlueMatt: ah right, so you can't confusely use the returned values in your application, or at least you have to consume `list_channels` good tome
14:17 < ariard> BlueMatt: yeah shrugh about the naming bikeshedding, though i would be glad to have clear names, i do remember introducing a serious bug due to inverting `to_self`/`to_remote` in chain backwned a while back
14:17 < BlueMatt> ah, ok, yea, that whole "channel is private" thing keeps tripping people up
14:17 < ariard> BlueMatt: gonna look again on PR updates after meeting
14:17 < BlueMatt> ariard: yea, I mean I dont disagree with any of your points, I just disagreed with your specific suggested alternative names :p
14:18 < ariard> BlueMatt: yep going to open an issue or join the comments to an already-existent one to not delay further 0.99
14:18 < BlueMatt> thanks, I mean the *new* public apis we should get right imo
14:18 < BlueMatt> we can spend a day debating names, but no longer :)
14:19 < BlueMatt> also, https://github.com/rust-bitcoin/rust-lightning/pull/975#discussion_r664129649 ariard 
14:24 < ariard> ahah i like proper names a lot :)
14:25 < ariard> yep gotcha for #975 also #949 should be mature?
14:26 < BlueMatt> ariard: 949's ack from devrandom was ~forever ago, and you never ack'd
14:26 < BlueMatt> so I dont hink it can be merged yet
14:27 < ariard> BlueMatt: yes it needs a real second look though val left a review
14:27 < ariard> though it sounds good after a first one
14:36 < andytoshi> BlueMatt: sure, one sec
14:40 < andytoshi> BlueMatt: https://github.com/rust-bitcoin/bitcoin_hashes/pull/132
14:49 < BlueMatt> andytoshi: lgtm merged
14:49 < BlueMatt> ariard: also lmk what you think of 975 - it may be nice to land that for 0.0.99 too
14:54 < andytoshi> dope, publishing, one sec
17:02 -!- tibo_ [~tibo@2400:4050:2a83:7000:4995:b34a:eaf9:c177] has joined #bitcoin-rust
17:09 < ariard> BlueMatt: replied on all comments on 975, sgtm overall though we'll ack tmrw with fresh mind
17:09 < ariard> night here :)
17:09 < BlueMatt> ariard: I'm gonna change `to_self_delay`, and then merge 984
17:09 < BlueMatt> how about spend_csv_on_our_commitment_funds?
17:09 < ariard> sound good to me
17:09 < BlueMatt> the documentation already clarifies that its only if we broadcast
17:10 < ariard> i had a look on 745 today : https://github.com/lightningnetwork/lightning-rfc/issues/745
17:10 < ariard> which was on the meeting agenda, afaict we're compliant with the proposed changes
17:10 < BlueMatt> oh, i saw that, I need to think about it
17:10 < BlueMatt> cool.
17:10 < BlueMatt> I'm implementing https://github.com/lightningnetwork/lightning-rfc/pull/847/files btw
17:10 < ariard> though our state machine is hard to read, was a good refresh
17:10 < BlueMatt> yea...
17:10 < ariard> gooood
17:25 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 268 seconds]
17:38 -!- belcher [~belcher@user/belcher] has joined #bitcoin-rust
19:30 -!- jkczyz_ is now known as jkczyz
21:20 -!- h4sh3d [~h4sh3d@user/h4sh3d] has quit [Quit: h4sh3d leaved]
21:22 -!- h4sh3d [~h4sh3d@user/h4sh3d] has joined #bitcoin-rust
--- Log closed Tue Jul 06 00:01:00 2021