--- Log opened Wed Jul 14 00:00:06 2021
00:26 -!- reallll is now known as belcher
02:40 -!- koolazer [~koo@user/koolazer] has quit [Ping timeout: 272 seconds]
02:43 -!- koolazer [~koo@user/koolazer] has joined #bitcoin-rust
03:15 -!- koolazer [~koo@user/koolazer] has quit [Ping timeout: 265 seconds]
04:16 -!- koolazer [~koo@user/koolazer] has joined #bitcoin-rust
04:48 -!- koolazer [~koo@user/koolazer] has quit [Ping timeout: 265 seconds]
05:06 -!- tibo_ [~tibo@2400:4050:2a83:7000:8cd9:35e6:a29b:7b7f] has quit []
05:47 -!- koolazer [~koo@user/koolazer] has joined #bitcoin-rust
06:13 -!- gene [~gene@2a0a:3840:1337:127:0:b9c1:7fec:1337] has quit [Quit: drained and gutted]
06:20 -!- koolazer [~koo@user/koolazer] has quit [Ping timeout: 245 seconds]
07:17 -!- ariard__ is now known as ariard
07:20 < ariard> BlueMatt: not sure if i follow on this one : https://github.com/rust-bitcoin/rust-lightning/pull/977#discussion_r669048550
07:20 < ariard> BlueMatt: on main we return Ok((None,None)) and it's not processed as a ChannelError::CLose by callers?
07:56 -!- koolazer [~koo@user/koolazer] has joined #bitcoin-rust
08:34 -!- koolazer [~koo@user/koolazer] has quit [Ping timeout: 258 seconds]
10:19 -!- koolazer [~koo@user/koolazer] has joined #bitcoin-rust
10:54 -!- koolazer [~koo@user/koolazer] has quit [Ping timeout: 246 seconds]
11:23 < stevenroose> sanket1729_: relating to my previous comment, I made a PR adding IntoIterator<Item = &Pk> to various types: https://github.com/rust-bitcoin/rust-miniscript/pull/252
11:23 < stevenroose> it's using `Box<dyn Iterator<..>>` though, unfortunately. Didn't see another way
12:07 -!- koolazer [~koo@user/koolazer] has joined #bitcoin-rust
12:30 -!- koolazer [~koo@user/koolazer] has quit [Ping timeout: 272 seconds]
13:19 < BlueMatt> ariard: yea. in tests/fuzz we panic, in release we simply ignore it.
13:20 < BlueMatt> sebx2a: can you re-ack https://github.com/rust-bitcoin/rust-bitcoin/pull/603 the diff since your last ack is pretty small
13:22 < BlueMatt> andytoshi: same, can you review https://github.com/rust-bitcoin/rust-bitcoin/pull/603 ? Note that it now requires a major version since it bumps the bitcoin_hashes dependency to get the released version of core2.
13:34 < sebx2a> devrandom: BlueMatt: sorry for being a bit absent, took a quick look, but have one last question regarding the recent changes: https://github.com/rust-bitcoin/rust-bitcoin/pull/603#discussion_r669932756
13:34 < sebx2a> will ack otherwise
13:35 < BlueMatt> thanks!
13:40 < andytoshi> sure, i have one more call in 20 mintues and will try to take a look after that
14:19 -!- koolazer [~koo@user/koolazer] has joined #bitcoin-rust
16:55 -!- belcher [~belcher@user/belcher] has quit [Read error: Connection reset by peer]
16:56 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-rust
18:05 < ariard> BlueMatt: oky it's a panic in test-mode, not a channel closure triggerable by the counterparty on the forward chan, sorry i did interpret your comment that way at first
18:22 -!- belcher_ is now known as belcher
--- Log closed Thu Jul 15 00:00:07 2021