--- Log opened Mon Jul 19 00:00:11 2021
03:44 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has joined #bitcoin-rust
03:50 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has quit [Quit: ZNC 1.8.0 - https://znc.in]
04:51 -!- thomaseizinger [~thomaseiz@2001:470:69fc:105::16b2] has quit [Quit: Bridge terminating on SIGTERM]
04:51 -!- prusnak[m] [~stickmatr@2001:470:69fc:105::98c] has quit [Quit: Bridge terminating on SIGTERM]
04:51 -!- RCasatta[m] [~rcasattam@2001:470:69fc:105::c85] has quit [Quit: Bridge terminating on SIGTERM]
04:51 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has quit [Quit: Bridge terminating on SIGTERM]
04:54 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #bitcoin-rust
05:00 -!- thomaseizinger [~thomaseiz@2001:470:69fc:105::16b2] has joined #bitcoin-rust
05:00 -!- RCasatta[m] [~rcasattam@2001:470:69fc:105::c85] has joined #bitcoin-rust
05:00 -!- prusnak[m] [~stickmatr@2001:470:69fc:105::98c] has joined #bitcoin-rust
06:26 -!- sebx2a [sid356034@id-356034.highgate.irccloud.com] has quit []
06:26 -!- sebx2a [sid356034@id-356034.highgate.irccloud.com] has joined #bitcoin-rust
14:29 < valwal> ariard: heyo, i couldn't parse your comment here: https://github.com/rust-bitcoin/rust-lightning/pull/967#discussion_r670482000 do you just want me to update it to saying "an unknown preimage for the received payment hash"? 
14:33 < valwal> that comment was already there (it was just a whitespace change) so i admit i don't understand it very well 
14:51 < ariard> valwal: yeah i think it's good an "unknown preimage", i think i was pointing that this comment is false as we'll never fail onchain a channel with an inbound htlc if the preimage is unknown to us
14:52 < ariard> valwal: so it should say "in the case of a known preimage for a received payment hash" 
14:52 < valwal> gotcha, will update the comment. and i agree that doesn't seem to be the case in `should_broadcast_holder_commitment_txn`, though i haven't looked elsewhere 
14:56 < ariard> valwal: iirc that's the only case where we automatically close channel? at least not triggered by a force-close from ChannelManager, which overrides any kind of urgent HTLC
15:03 < valwal> i guess i was thinking that one of those ChannelManager force close sites could be a site where we close on unknown payment hash 
15:03 < valwal> ariard
16:56 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-rust
16:59 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 265 seconds]
23:51 -!- belcher_ is now known as belcher
--- Log closed Tue Jul 20 00:00:11 2021