--- Log opened Fri Jul 23 00:00:15 2021
04:05 < stevenroose> I've not been following recent developments as closely (definitely intending to get back to that), but while trying to revive an old MR, I noticed that there's been a lot of changes in the no-std & alloc etc
04:06 < stevenroose> What do you guys do to test a build locally?
04:06 < stevenroose> I used to have a script that tested the MSRV, but now I can't even just do `cargo test --no-default-features --features "core2"` in my current (not 1.29) cargo because core2's build is broken.
04:07 < stevenroose> sorry, I meant `cargo test --no-default-features --features "no-std"`
05:08 < sebx2a> stevenroose: I think breaking MSRV for feature no-std was a conscious choice, as we did with other features in the past
05:09 < sebx2a> the embedded world is more cutting edge anyway most of the time
05:10 < sebx2a> I think we only have a strong MSRV guarantee for default features. For anything else it's case-by-case.
05:50 < stevenroose> sebx2a: okay, that makes sense. I was saying that i was failing to test no-std with my current (1.49) cargo though. idk what's latest these days though :D
05:52 < sebx2a> 1.53 or 52 afaik, always on nightly myself xD
05:53 < sebx2a> so kind of odd, but afaik our test suite should catch compile failures on stable
05:55 < stevenroose> core2 says "core2 always works with stable" so they have a fast roling MSRV so to speak. which is kinda annoying. I suppose then that we should add a message to the README that MSRV for no-std is `stable`
07:34 < devrandom> perhaps we should not upgrade core2 dep without updating no_std MSRV in docs (and CI tests)
07:36 < devrandom> and also pin core2 to a specific minor release if it's their policy to allow MSRV to increase for minor releases
07:38 < sebx2a> Why though? If we do not guarantee any MSRV then downstream users can do that too if they need to. It's a bit hacky but I wouldn't do anything prematurely in rust-bitcoin. Someone else might _want_ to have bleeding edge core2.
07:41 < sebx2a> what I mean is: you can always pin dependencies yourself if you really need to (see our test scripts for 1.29.0 where we have to do this)
07:42 < sebx2a> so technically rust-bitcoin out-of-the-box is not 1.29 compatible, but by pinning you can make it
07:43 < sebx2a> so maybe we should document the MSRV-core2 version mapping if that's useful to anyone?
17:12 -!- reallll [~belcher@user/belcher] has joined #bitcoin-rust
17:15 -!- belcher_ [~belcher@user/belcher] has quit [Ping timeout: 265 seconds]
21:22 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has joined #bitcoin-rust
23:40 -!- Crypt9a2e [~Crypt9a2e@49.37.223.20] has joined #bitcoin-rust
23:52 -!- reallll is now known as belcher
--- Log closed Sat Jul 24 00:00:16 2021