--- Log opened Mon Aug 09 00:00:33 2021 02:36 -!- stevenroose [~steven@2001:19f0:6801:83a:f54f:df1d:5be5:704b] has quit [Quit: ZNC 1.7.4 - https://znc.in] 02:36 -!- stevenroose [~steven@irc.roose.io] has joined #bitcoin-rust 06:56 < devrandom> so now we have the `no_std` embedded test in `bitcoin_hashes` `rust-bech32` `rust-bitcoin` and maybe we should have it in `rust-lightning`. I wonder if it makes sense to try to DRY it across repositories. It's about 100 LOC in each instance + a little bit of crate specific code. 07:21 < sebx2a> Yearly reminder: we still have rust-bitcoin.org, if anyone wants to build some nice landing page let me know 09:00 < dr-orlovsky> devrandom: we still have a pretty big bug and before this fix we can't say there is a proper no_std support in rust-bitcoin: https://github.com/rust-bitcoin/rust-secp256k1/pull/314 09:00 < dr-orlovsky> since w/o this fix using rust-bitcoin with secp256k1 and no_std will just not work 09:06 < devrandom> hmm... I wonder if the embedded test should test more to catch stuff like this. 09:57 < dr-orlovsky> --- 09:58 < dr-orlovsky> 2all (and andytoshi, since without his ACK we cant get this moving further): can we pls merge https://github.com/rust-bitcoin/rust-bitcoin/pull/617 to unlock the way to P2TR addresses and taproot support? 10:12 < andytoshi> sure on my list for today 11:56 -!- DeanGuss [~dean@user/deanguss] has quit [Remote host closed the connection] 11:57 -!- DeanGuss [~dean@nonplayercharacter.me] has joined #bitcoin-rust 11:57 -!- DeanGuss [~dean@nonplayercharacter.me] has quit [Changing host] 11:57 -!- DeanGuss [~dean@user/deanguss] has joined #bitcoin-rust 14:37 < dr-orlovsky> hopefully andytoshi will not kill me: I went through PR history in rust-bitcoin and merged those PR fitting very strict criteria: (1) either they have 2+ ACKS + andytoshi ACK and do not introduce anything incomparable with no_std; these PRs were pending major release - or (2) very trivial PRs with a single commit, 2 ACKs (but without andytoshi review) 14:37 < dr-orlovsky> just tried to get the project moving :( 15:01 < andytoshi> what does "do not introduce anything incomparable with no_std" and "these PRs were pending major release" mean? 15:02 < andytoshi> fine to merge trivial things without my ack. pls make sure they are trivial thuogh :) 16:56 -!- tibo_ [~tibo@2400:4050:2a83:7000:d4ea:2635:e1b0:bf1d] has joined #bitcoin-rust 17:16 < dr-orlovsky> andytoshi: "do not introduce anything incomparable with no_std" means that they use "core::" instead of "std::" 17:16 < dr-orlovsky> "these PRs were pending major release" means that we (including you) ACKed these PRs but b/c we were going to release non-API breaking 0.26.1 didn't merged it 17:16 < andytoshi> ah gotcha 17:16 < andytoshi> also gotcha 17:16 < andytoshi> cool 17:16 < andytoshi> sorry for my absense lately, i have been swapmed 17:17 < dr-orlovsky> however after 0.26.2 everyone forgot about them and 0.27 went without them being merged 17:17 < dr-orlovsky> andytoshi: I understand that very well. The only thinkg I really worry is to get as much of Taproot support as we can before November 17:18 < dr-orlovsky> two current blockers for further Taproot progress: 17:18 < dr-orlovsky> https://github.com/rust-bitcoin/rust-bitcoin/pull/617 (already ACKed by you but needed rebase) 17:19 < dr-orlovsky> https://github.com/rust-bitcoin/rust-bitcoin/pull/628 - quite big new PR from RCassata[m], but well written, consolidating all sighashes 18:20 -!- tibo__ [~tibo@2400:4050:2a83:7000:d4ea:2635:e1b0:bf1d] has joined #bitcoin-rust 18:20 -!- elichai2_ [sid212594@id-212594.stonehaven.irccloud.com] has joined #bitcoin-rust 18:21 -!- FelixWeis_ [sid154231@id-154231.stonehaven.irccloud.com] has joined #bitcoin-rust 18:25 -!- tibo_ [~tibo@2400:4050:2a83:7000:d4ea:2635:e1b0:bf1d] has quit [Read error: Connection reset by peer] 18:25 -!- elichai2 [sid212594@stonehaven.irccloud.com] has quit [Read error: Connection reset by peer] 18:25 -!- FelixWeis [sid154231@stonehaven.irccloud.com] has quit [Read error: Connection reset by peer] 18:25 -!- FelixWeis_ is now known as FelixWeis 18:25 -!- elichai2_ is now known as elichai2 21:40 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-rust 21:44 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 256 seconds] --- Log closed Tue Aug 10 00:00:34 2021