--- Log opened Tue Aug 24 00:00:48 2021
00:45 < sebx2a> Hey, I just saw this awesome CI PR from tibo__ https://github.com/rust-bitcoin/rust-bitcoincore-rpc/pull/195 a second ACK would be much appreciated so rust-bitcoincore-rpc has CI again
00:57 < tibo__> I think maybe someone needs to enable github actions on the repo so that it shows up in "actions"
02:40 -!- valwal5 [~valwal@96.224.58.144] has joined #bitcoin-rust
02:42 -!- valwal [~valwal@96.224.58.144] has quit [Ping timeout: 252 seconds]
02:42 -!- valwal5 is now known as valwal
04:00 < sebx2a> tibo__: let's see, I think to remember it was just not running the first time because repo owners need to allow it by merging.
04:28 < tibo__> Oh ok let's see then
05:15 -!- tibo__ [~tibo@2400:4050:2a83:7000:d81e:f7c4:20b0:eb0d] has quit [Remote host closed the connection]
06:24 -!- Netsplit *.net <-> *.split quits: DeanGuss, sanket1729, elichai2, andytosh1, ariard__
06:28 -!- andytosh1 [~apoelstra@s66-183-0-205.bc.hsia.telus.net] has joined #bitcoin-rust
06:28 -!- ariard__ [~ariard@167.99.46.220] has joined #bitcoin-rust
06:28 -!- sanket1729 [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has joined #bitcoin-rust
06:28 -!- elichai2 [sid212594@stonehaven.irccloud.com] has joined #bitcoin-rust
06:28 -!- DeanGuss [~dean@user/deanguss] has joined #bitcoin-rust
07:32 -!- muhblockchain [~muhblockc@user/muhblockchain] has joined #bitcoin-rust
10:40 < dr-orlovsky> sebx2a: reviewed PR, but I do not have ACK right, so just left my comments. BTW, can you pls make RCasatta[m]: maintainer there, he was asking some time ago stevenroose, but he wass busy and didn't replied
10:52 < sebx2a> dr-orlovsky: don't have the rights for that currently :( although I was talking with stevenroose about him giving me more rights since he's often absent
10:54 < sebx2a> also RCasatta[m] 
11:36 -!- andytosh1 is now known as andytoshi
13:49 -!- moneyball_ [sid299869@id-299869.brockwell.irccloud.com] has quit []
13:49 -!- moneyball_ [sid299869@id-299869.helmsley.irccloud.com] has joined #bitcoin-rust
13:51 -!- RubenSomsen [sid301948@user/rubensomsen] has quit []
13:51 -!- RubenSomsen [sid301948@user/rubensomsen] has joined #bitcoin-rust
15:31 -!- belcher [~belcher@user/belcher] has quit [Read error: Connection reset by peer]
15:31 -!- belcher [~belcher@user/belcher] has joined #bitcoin-rust
16:40 -!- tibo_ [~tibo@2400:4050:2a83:7000:58d7:d8ad:e3d0:7744] has joined #bitcoin-rust
16:52 < ariard__> BlueMatt: only 61 tests left to fix on #997, hopefully should be good tmrw :p
16:52 < ariard__> though did add an enum matching your suggestion: https://github.com/rust-bitcoin/rust-lightning/pull/997#issuecomment-880135731
16:53 < BlueMatt> ariard__: lol yea, that one just looks painful :(
16:53 < BlueMatt> luckily the test changes should be pretty mechanical
16:54 < BlueMatt> ariard__: to make sure I dont nag you *after* you've fixed tests, please do make the tests run in a macro or function that checks the reason, not just that a close event fired :)
16:55 -!- tibo__ [~tibo@2400:4050:2a83:7000:bd60:d36:c5c3:8447] has joined #bitcoin-rust
16:55 < ariard__> BlueMatt: yeah noted, will do once i'm sure all the call sites make sense
16:55 < ariard__> like not duplicate when we initiate the close and receive the closing_signed
16:56 < BlueMatt> right, sounds good. thanks
16:59 -!- tibo_ [~tibo@2400:4050:2a83:7000:58d7:d8ad:e3d0:7744] has quit [Ping timeout: 250 seconds]
--- Log closed Wed Aug 25 00:00:50 2021