--- Log opened Fri Sep 03 00:00:57 2021
02:50 -!- enick_57 [~afilini-m@51.15.93.184] has quit [Ping timeout: 250 seconds]
02:50 -!- enick_57 [~afilini-m@2001:bc8:1828:245::2] has joined #bitcoin-rust
05:34 -!- tibo__ [~tibo@2400:4050:2a82:1000:19c4:9c0f:1067:ae48] has quit []
08:10 -!- valwal [~valwal@96.224.58.144] has quit [Ping timeout: 252 seconds]
12:29 -!- belcher [~belcher@user/belcher] has quit [Quit: Leaving]
13:29 -!- NilsLoewen [~NilsLoewe@S01069050ca9da923.kn.shawcable.net] has joined #bitcoin-rust
13:45 < NilsLoewen> Hello, I am a first time contributor and relatively new to rust. I am working on a PR for #394 but I don't understand this proposal: https://github.com/rust-bitcoin/rust-bitcoin/issues/394#issuecomment-576924655
13:45 < NilsLoewen> What would be the benifit of turning Block::merkle_root() into a getter to return self.header.merkle_root if self.header.merkle_root is already public access?
13:55 -!- yakshaver123 is now known as yakshaver
14:34 -!- greypw2 [~greypw2@grey.pw] has quit [Quit: Ping timeout (120 seconds)]
14:34 -!- greypw2 [~greypw2@grey.pw] has joined #bitcoin-rust
16:21 -!- belcher [~belcher@user/belcher] has joined #bitcoin-rust
17:00 -!- Netsplit *.net <-> *.split quits: NilsLoewen
17:16 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-rust
17:19 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 240 seconds]
17:25 < BlueMatt> <ariard> but fuck, why we have so much tests :p <-- cause lightning can go wrong wayyyy too many ways :/
18:14 < BlueMatt> ariard: also note that the close pr needs rebase (and I reviewed it yesterday with some minor comments)
19:02 -!- moneyball_ [sid299869@id-299869.helmsley.irccloud.com] has quit [Ping timeout: 240 seconds]
19:02 -!- moneyball_ [sid299869@id-299869.helmsley.irccloud.com] has joined #bitcoin-rust
--- Log closed Sat Sep 04 00:00:58 2021