--- Log opened Mon Sep 13 00:00:06 2021
00:17 < dr-orlovsky> elichai2:, andytoshi: `Settings -> Branches -> master -> "Require branches to be up to date before merging "` is different to what antytoshi was looking for. This requires each PR to be on master tip before merge, which will imply constant rebases and all reviews being discarded even if there is no conflicts
01:47 < elichai2> Ohhh I misunderstood you, when you said "current PR tip" you meant the tip of the PR not of master, sorry 
01:48 < elichai2> I think there's another option that automatically dismisses any review if there's another push if that's what you meant
01:49 < elichai2> (I see now that thomaseizinger also said that :) ) 
01:49 < dr-orlovsky> all: current master got broken after merging one old PRs which didn't include CI tests for no_std. https://github.com/rust-bitcoin/rust-bitcoin/pull/651 fixes master, pls review
01:59 < sebx2a> dr-orlovsky: thx for the fast reaction. Just need a second ACK andytoshi sanket1729. Guess as the PR author I should also have paid more attention :( (tbh I had forgotten about it)
02:00 < dr-orlovsky> we all missed it, all reviewers :)
05:15 -!- tibo__ [~tibo@p3002252-ipngn18401marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection]
05:15 -!- tibo_ [~tibo@2400:4050:2a82:1000:f132:2891:827c:4e78] has joined #bitcoin-rust
05:21 -!- tibo_ [~tibo@2400:4050:2a82:1000:f132:2891:827c:4e78] has quit [Ping timeout: 268 seconds]
05:30 -!- sebx2a [sid356034@id-356034.highgate.irccloud.com] has quit []
05:30 -!- sebx2a [sid356034@id-356034.uxbridge.irccloud.com] has joined #bitcoin-rust
05:35 -!- michaelfolkson2 is now known as michaelfolkson
05:37 -!- fjahr [sid374480@id-374480.highgate.irccloud.com] has quit []
05:37 -!- fjahr [sid374480@id-374480.uxbridge.irccloud.com] has joined #bitcoin-rust
05:42 < andytoshi> sigh, that's what i get for trusting CI again
05:42 < andytoshi> i fixed my script, which had broken when --no-default-features was broken
08:50 < sanket1729> Updated Taproot tracking issue here. https://github.com/rust-bitcoin/rust-bitcoin/issues/503 
08:59 < sanket1729> stevenroose, sebx2a: Can you please release a version of bitcoincore-rpc with 0.26 bitcoin
08:59 < sanket1729> https://github.com/rust-bitcoin/rust-bitcoincore-rpc/pull/196
10:55 -!- FelixWeis [sid154231@id-154231.stonehaven.irccloud.com] has quit []
10:55 -!- FelixWeis [sid154231@id-154231.hampstead.irccloud.com] has joined #bitcoin-rust
11:19 -!- elichai2 [sid212594@id-212594.stonehaven.irccloud.com] has quit []
11:19 -!- elichai2 [sid212594@id-212594.hampstead.irccloud.com] has joined #bitcoin-rust
12:47 < dr-orlovsky> seb2x: can you pls re-review #590 - it seems you hadn't critical requests (at least those which didn't contradict to changes introduced by other reviewers). If you ACK we can merge and be one step closer to Taproot
12:47 < dr-orlovsky> sebx2a: *
13:02 < sebx2a> dr-orlovsky: looks good
13:03 < sebx2a> but idk if any of us can actually publish a release yet (stevenroose being quite absent)
13:03 < dr-orlovsky> still a lot of PRs to merge between release, but we will be one step closer with this PR :)
13:04 < dr-orlovsky> *between -> before
13:05 < sebx2a> I meant a release of bitcoincore-rpc, if we don't need it now why the PR?
13:05 < dr-orlovsky> bitcoincore-rpc is needed independently
13:06 < dr-orlovsky> #590 was about this one https://github.com/rust-bitcoin/rust-bitcoin/pull/590
13:36 < dr-orlovsky> sebx2a: if you are still around, can you pls re-ACK https://github.com/rust-bitcoin/rust-bitcoin/pull/580 which failed to initiate CI and had to be rebased?
14:22 < andytoshi> is there anything i can do right now for taproot in rust-bitcoin
14:23 < andytoshi> it seems like there's a lot of PRs with open unadressed comments, CI failures, etc
17:18 -!- tibo_ [~tibo@2400:4050:2a82:1000:4b8:e5ab:15b2:97e9] has joined #bitcoin-rust
17:20 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 252 seconds]
17:22 -!- tibo_ [~tibo@2400:4050:2a82:1000:4b8:e5ab:15b2:97e9] has quit [Ping timeout: 268 seconds]
17:25 -!- tibo_ [~tibo@2400:4050:2a82:1000:1a6:49f8:24ad:865a] has joined #bitcoin-rust
17:33 -!- belcher [~belcher@user/belcher] has joined #bitcoin-rust
19:31 -!- tibo__ [~tibo@2400:4050:2a82:1000:f4af:9eb4:4f64:4e1] has joined #bitcoin-rust
19:34 -!- tibo_ [~tibo@2400:4050:2a82:1000:1a6:49f8:24ad:865a] has quit [Ping timeout: 268 seconds]
22:16 < dr-orlovsky> andytoshi: there are PRs that are fully addressed (aside from Nits) and even reviewed, but we do not like to merge without you:
22:16 < dr-orlovsky> the most important is https://github.com/rust-bitcoin/rust-bitcoin/pull/628
22:23 < dr-orlovsky> https://github.com/rust-bitcoin/rust-bitcoin/pull/563 introduces P2TR addresses and ready for the review (also passes CI). All previous comments there are addressed
22:25 < dr-orlovsky> last one https://github.com/rust-bitcoin/rust-bitcoin/pull/590 is PSBT-related; has one ACK and passes CI
23:24 < sanket1729> dr-orlovsky: Do I need to configure github permissions somehow? Not that I am against it, but how can you add a commit to my PR without my approval.
23:28 < dr-orlovsky> have no idea! I was impressed myself. Did `git push` and that is how it happened
23:46 < sanket1729> So, whenever you open a PR, there is an option  "Allow edits by maintainers"
23:47 < sanket1729> I thought it only applied to the PR description
23:47 < sanket1729> But turns out that maintainers can also modify the branch
23:53 < dr-orlovsky> andytoshi: TapScript PR https://github.com/rust-bitcoin/rust-bitcoin/pull/644 needs your re-review after fix
23:53 < dr-orlovsky> so it is 4 Taproot PRs which are completed except pending your review
--- Log closed Tue Sep 14 00:00:07 2021