--- Log opened Mon Sep 20 00:00:13 2021
04:30 -!- tibo_ [~tibo@2400:4050:2a82:1000:4879:7a17:701e:f4ef] has joined #bitcoin-rust
05:24 -!- tibo_ [~tibo@2400:4050:2a82:1000:4879:7a17:701e:f4ef] has quit [Remote host closed the connection]
06:01 -!- tibo_ [~tibo@2400:4050:2a82:1000:4879:7a17:701e:f4ef] has joined #bitcoin-rust
06:05 -!- tibo_ [~tibo@2400:4050:2a82:1000:4879:7a17:701e:f4ef] has quit [Ping timeout: 246 seconds]
06:54 < sanket1729> andytoshi: https://github.com/rust-bitcoin/rust-bitcoin/pull/658#issuecomment-922947836 
06:57 < andytoshi> sanket1729: are you asking me to do a backport? sure
06:57 < sanket1729> Yeah
06:58 < sanket1729> Actually KixUnil is asking for a backport point release, and I support it :) 
07:06 < andytoshi> kk one sec
07:12 < andytoshi> ok opneed backport PR https://github.com/rust-bitcoin/rust-bitcoin/pull/661
07:15 < sanket1729> We could have asked KixUnil to open a backport, so we could get 2 ACKs
07:17 < andytoshi> well, i needed to create/push the rust-bitcoin-0.27 branch before he could've
07:18 < andytoshi> but yeah, good point
07:18 < andytoshi> if you acked it and i affirmed that it was literally a cherry-pick of the original PR (which i will ack in a couple minutes), i think we could count that as two acks ;)
07:18 < sanket1729> Looks like I can merge without 2 approvals
07:18 < andytoshi> ah yeah there is no branch protection outside of master
07:18 < andytoshi> but pls let me merge it
07:18 < sanket1729> Because the rule is only for master
07:18 < andytoshi> yep
07:19 < sanket1729> Cool
07:25 < andytoshi> ok, will let CI finish then i will cut a release
07:25 < andytoshi> meanwhile i mergede 658
07:26 < andytoshi> ok merged. pubishing
07:26 < andytoshi> published and tagged.
10:07 < BlueMatt> andytoshi: hmmm, sanket1729 says at https://github.com/rust-bitcoin/rust-bitcoin/pull/658#pullrequestreview-758634269 that there's other panics in that function, so I don't think we should consider the issue "fixed" and cut a release
10:08 < andytoshi> BlueMatt: we can do a proper fix (which would involve writing a fuzztest first i think) and do another release
10:08 < andytoshi> point releases are quick/easy to do (at least, off of 0.27 which has no other changes right now)
10:09 < andytoshi> and at least we've fixed the crash on the current state of the blockchain
10:09 < andytoshi> but agreed
10:09 < andytoshi> we should not consider this "fixed"
10:09 < BlueMatt> yea, I guess, it just feels gross to ship a release that doesn't really fix the issue
10:09 < BlueMatt> I didnt review the rest of the function, which i should have, but i wouldn't have acked if i had :p
10:09 < BlueMatt> not that it matters, the diff itself was fine
10:10 < andytoshi> agreed, it feels gross
10:11 < BlueMatt> we also need to run the fuzzers on i686
10:11 < BlueMatt> which may require some effort, though hopefully it, too, "just works"
10:19 < andytoshi> ah good point
10:19 < andytoshi> maybe there's a rustcfg option to just make all the types 32-bit sized
10:19 < andytoshi> i guess compiling for i686 is essentially just that
10:19 < BlueMatt> yea
10:20 < BlueMatt> and you should generally be able to "just run" an i686 thing on x86_64
10:20 < BlueMatt> just a question of if the deps for fuzzing can be installed cross-host
10:29 -!- valwal7 [~valwal@70.107.207.192] has joined #bitcoin-rust
10:29 -!- valwal [~valwal@70.107.207.192] has quit [Ping timeout: 260 seconds]
10:29 -!- valwal7 is now known as valwal
11:58 -!- dunxen [~dunxen@gateway/tor-sasl/dunxen] has joined #bitcoin-rust
16:56 < ariard> BlueMatt: pushed latest 997, though that's weird i don't get more failures for the 2 first new hotspots adviced
16:57 < ariard> i'll check tmrw as first thing, happy if we can make it done tmrw or wed
16:57 < ariard> one less thing on my todos :)
16:59 < BlueMatt> alright, sounds good, thanks!
16:59 < BlueMatt> will review this evening
17:11 -!- tibo_ [~tibo@2400:4050:2a82:1000:1d73:804:9461:da2] has joined #bitcoin-rust
17:15 < BlueMatt> ariard: you pushed to upstream branch 2021-07-add-chan-closed again :p
17:15 < BlueMatt> just deleted (it matched the pr branch)
18:17 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 268 seconds]
18:29 -!- belcher [~belcher@user/belcher] has joined #bitcoin-rust
--- Log closed Tue Sep 21 00:00:13 2021