--- Log opened Tue Sep 21 00:00:13 2021
03:26 -!- h4sh3d [~h4sh3d@user/h4sh3d] has quit [Remote host closed the connection]
03:30 -!- h4sh3d [~h4sh3d@user/h4sh3d] has joined #bitcoin-rust
05:23 -!- tibo_ [~tibo@2400:4050:2a82:1000:1d73:804:9461:da2] has quit [Remote host closed the connection]
07:09 -!- plsm__ [~plsm@host86-153-59-250.range86-153.btcentralplus.com] has joined #bitcoin-rust
07:12 -!- plsm_ [~plsm@host86-153-59-250.range86-153.btcentralplus.com] has quit [Ping timeout: 252 seconds]
07:12 -!- darosior1 [~darosior@194.36.189.246] has joined #bitcoin-rust
07:12 -!- darosior [~darosior@194.36.189.246] has quit [Ping timeout: 252 seconds]
07:12 -!- darosior1 is now known as darosior
09:22 -!- plsm__ [~plsm@host86-153-59-250.range86-153.btcentralplus.com] has quit [Quit: leaving]
09:33 < devrandom> in case anybody is interested, I made this: https://crates.io/crates/serde_bolt
09:47 < ariard> that sounds sweet, maybe the dlc folks hacking in rust, as we _try_ to rely on bolts
09:47 < ariard> BlueMatt: just pushed 997, with your fixes, tests are good
09:48 < ariard> though note the 2 first new hotspots don't have test coverage
09:51 < sebx2a> devrandom: I'm a bit out of the loop with LN these days, is this the same encoding BOLT11 uses or doe it just concern p2p messages or is it something completely different?
09:52 < sebx2a> thinking about the potential to simplify lightning-invoice's encoding, especially with a need to migrate to BOLT12 at some point which probably means writing a lot of new encoding boilerplate code
09:53 < devrandom> it's actually BOLT1 - the payload section - https://github.com/lightningnetwork/lightning-rfc/blob/master/01-messaging.md#lightning-message-format
09:56 < sebx2a> ah, right, BOLT11 has a different definition for TLV fields etc. due to targeting bech32 and thus 5bit wide chars. just sounded so familiar :D
10:07 < BlueMatt> ariard: no you didnt, you pushed to upstream
10:07 < BlueMatt> ariard:  * [new branch]        2021-07-add-chan-closed -> upstream/2021-07-add-chan-closed
10:17 < BlueMatt> ariard: on your branch: "s/incompatible features which our counterparty, or we require./ncompatible features which our counterparty, or we, require./
10:17 < BlueMatt> note second comma
10:17 < BlueMatt> ariard: otherwise ack that branch, just push it to the pr :p
10:26 < ariard> BlueMatt: is it good now ? just renamed my local origin to github-nopush-stupid to avoid that in the future
10:26 < ariard> BlueMatt: let me correct the comma
10:27 < BlueMatt> ariard: ci says you're missing docs
10:27 < BlueMatt> at   --> lightning/src/util/events.rs:99:3
10:27 < BlueMatt> but yea otherwise good, I think
10:27 < BlueMatt> I'll give it another pass and nag valwal as well tho
10:27 < ariard> awesome :)
10:28 < ariard> BlueMatt: no need to mark te string 99:3 as must-be-sanitized? it's coming from us
10:28 < BlueMatt> no, i think its fine
10:29 < BlueMatt> so, yes, no need to mark it lol
10:31 < ariard> BlueMatt: just updated, staying around if you see other fixes :)
10:32 < BlueMatt> ariard: you missed the comma fix
10:33 < BlueMatt> ariard: also, for docs on ProcessingError::err, maybe "A developer-readable error message which we generated"
10:34 < BlueMatt> instead of "which we're generating internally", which is confusing to me - if its internal, why is it exposed in an event
10:34 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 246 seconds]
10:45 < BlueMatt> ariard: also https://github.com/rust-bitcoin/rust-lightning/pull/997/files#r713277069
10:47 -!- belcher [~belcher@user/belcher] has joined #bitcoin-rust
10:55 < ariard> BlueMatt: fixing all rn
11:08 < ariard> BlueMatt: ping!
11:08 < BlueMatt> sup
11:08 < BlueMatt> oh, you pushed, k, sec
11:08 < BlueMatt> I know valwal's looking at it too
11:15 < BlueMatt> ariard: looks like you didnt update the read side to also read inside the tlv
11:15 < BlueMatt> so the Event::ChannelClosed write/read are out of sync
11:16 < ariard> BlueMatt: ah sorry for that!
11:17 < ariard> BlueMatt: i didn't get a compilation error, do you think we could get one if write/read are out of sync?
11:18 < BlueMatt> no
11:18 < BlueMatt> I'm not sure how we'd do that?
11:18 < BlueMatt> for many places we have a single macro that does both read and write side, but some places need specific code, including event, there
11:19 < BlueMatt> now the fact that it didnt get a test error is sad, assuming it actually didn't get a test error?
11:19 < BlueMatt> ariard: also note that you have a bad intra-doc-link 87 |     /// Closure generated from [`ChannelManager::force_close_channel`], called by the user.
11:19 < BlueMatt> you need to add [`ChannelManager::force_close_channel`]: ln::channelmanager::ChannelManager::force_close_channel
11:19 < BlueMatt> at the end of that doc comment
11:31 < ariard> BlueMatt: hmmm we don't have a ser_macro to read a MaybeReadable field ? in this case ClosureReason
11:32 < BlueMatt> ariard: you want the type string "ignorable"
11:32 < BlueMatt> instead of "option"
11:32 < ariard> gotcha
11:37 < ariard> BlueMatt: updated, staying available if you have more comments
11:37 < BlueMatt> ariard: sorry one more lol
11:37 < BlueMatt> channelmanager L4105 should be CooperativeClosure
11:37 < BlueMatt> not HolderForceClosed
11:38 < BlueMatt> ariard: note above the broken intra-doc link that CI is failing on as well
11:38 < ariard> yeah i saw that correcting
11:41 < BlueMatt> ariard: valwal also left a review, mostly just comment nits
11:42 < ariard> BlueMatt: oky grabbing
12:02 < BlueMatt> ariard: ah, val found another one, pretty minor tho - https://github.com/rust-bitcoin/rust-lightning/pull/997#discussion_r713328319
12:17 < ariard> BlueMatt: lmk if good :)
12:18 < BlueMatt> lol you also renamed MonitorEvent::CommitmentTxBroadcasted. I think thats good, tho lol
12:19 < ariard> oh zut
12:20 < BlueMatt> i mean val's point applies there too :shrug:
12:20 < ariard> yeah i agree
12:21 < ariard> wanna me to take it in a new commit for log clarity ?
12:21 < BlueMatt> that would be ideal
12:21 < ariard> doing
12:27 < BlueMatt> ariard: did you see my two doc tweak suggestions?
12:28 < ariard> BlueMatt: just saw them, let me take it
12:28 < ariard> see the new commit
12:28 < BlueMatt> thanks.
12:38 < ariard> BlueMatt: happy :) ?
12:40 < BlueMatt> ariard: ugh, cargo doc is still failing
12:40 < BlueMatt> let me send a patch, sec
12:42 < BlueMatt> ariard: https://github.com/rust-bitcoin/rust-lightning/pull/997#issuecomment-924327209
12:42 < BlueMatt> then ack from me and val :)
12:42 < ariard> ah don't run it yet systematically, now we have real docs
12:42 < BlueMatt> yea, ci runs it tho so you'll see it :p
12:43 < ariard> yeah correcting
12:48 < ariard> sounds we're pending on CI
12:49 < BlueMatt> yea, ci tends to get a bit backed up, need to look into paying github to get more runners
12:54 < ariard> or we quit github and run CI each of us on dedicated hardware :D ?
12:55 < BlueMatt> lol or that, but that takes work
12:58 < ariard> BlueMatt: one day, gonna gym feel free to take 997 if needed, you want to tag 0.0.101 today ?
12:58 < BlueMatt> ariard: yep, just waiting on ci, I think there's a few things that will land in the next hour or two
12:58 < BlueMatt> ariard: will hopefully tag 101 today, but depends on how long ci takes lol
12:59 < ariard> okay, if they're still there when I'm back I can review
12:59 < BlueMatt> i think everything that should land has been reviewed, outside of release notes which arent done yet anyway
13:04 < BlueMatt> ariard: lol one test failed
13:06 < BlueMatt> oh, dont think its related to your pr tho
13:27 < BlueMatt> oh yes it is
15:19 < ariard> BlueMatt: back let me check 1091
15:24 < ariard> BlueMatt: lol target_os = windows, now I understand
15:25 < ariard> well that's the reason we have a CI :)
15:25 < BlueMatt> yea lol
15:27 < ariard> checking 1085 quickly
15:29 < ariard> BlueMatt: one thing we could start to do for the next one is tagging the release contributors :)
15:29 < BlueMatt> yea, i was thinking either that or "new contributors"
15:29 < BlueMatt> problem is the list is usually quite short lol
15:30 < ariard> come on, we start to have more contributors
15:30 < BlueMatt> true
15:30 < ariard> one day, we'll be a real FOSS project :p
15:30 < BlueMatt> alright, well I'm finishing the release notes now anyway, I'll include a contributor list
15:31 < ariard> well i'm fine waiting for 0.0.102 really up to you!
15:34 < BlueMatt> nah, I'll do it
15:38 < BlueMatt> ariard: 12 commit authors this release :)
15:40 < ariard> BlueMatt: yallah!!!
15:40 < BlueMatt> up from 6 last release
15:40 < ariard> maybe mention 1072, i think it's missing
15:40 < BlueMatt> though 4 only did one commit
15:40 < ariard> well it all start by one commit
15:41 < BlueMatt> ariard: huh, I figured 1072 didnt merit mentioning
15:41 < BlueMatt> its not a functional diff aside from code eclair *plans to* ship?
15:41 < BlueMatt> afaik you cant see it in the wild today
15:41 < ariard> let me read again the PR
15:42 < ariard> yeah agree really low odds you can see that in wild
15:43 < BlueMatt> (plus we currently cannot connect to eclair nodes cause we ask for dust below what they accept anyway lol)
15:43 < ariard> right, that's a bigger issue!
15:44 < BlueMatt> we'll get that in soon lol
15:44 < BlueMatt> 102 next week......if we can get there lol
15:45 < BlueMatt> and 0.1 next month lets gooooooo
15:46 < ariard> yeah i'll be happy #1054/#1065 
15:46 < ariard> i should have time to get 1054 done next week
15:47 < BlueMatt> nice
15:55 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 252 seconds]
16:07 -!- belcher [~belcher@user/belcher] has joined #bitcoin-rust
16:14 < ariard> BlueMatt: cut-off sgtm, just squash?
16:14 < BlueMatt> yep will do. may need to sneak in one quick pr to help the bindings build before tag, though
16:16 < BlueMatt> ariard: can you comment on the pr to that effect? :)
16:17 < ariard> BlueMatt: good
16:17 < BlueMatt> thanks!
17:06 -!- tibo_ [~tibo@2400:4050:2a82:1000:a8b6:5e10:8db:63cb] has joined #bitcoin-rust
--- Log closed Wed Sep 22 00:00:15 2021