--- Log opened Fri Oct 01 00:00:23 2021 00:25 -!- stevenro- [~steven@irc.roose.io] has joined #bitcoin-rust 00:27 -!- stevenroose [~steven@irc.roose.io] has quit [Ping timeout: 252 seconds] 00:32 -!- MatrixBot1234514 [~matrixbot@51.15.54.153] has joined #bitcoin-rust 00:34 -!- MatrixBot1234516 [~matrixbot@51.15.54.153] has quit [Ping timeout: 252 seconds] 01:28 -!- mycroft- [mycroft@abused.minithins.net] has joined #bitcoin-rust 01:28 -!- mycroft [mycroft@abused.minithins.net] has quit [Ping timeout: 252 seconds] 01:40 -!- stick [sid403625@user/prusnak] has quit [Ping timeout: 252 seconds] 01:40 -!- valwal [~valwal@70.107.207.192] has quit [Read error: Connection reset by peer] 01:40 -!- stick_ [sid403625@user/prusnak] has joined #bitcoin-rust 01:41 -!- valwal [~valwal@70.107.207.192] has joined #bitcoin-rust 01:42 -!- moneyball_ [sid299869@2a03:5180:f:1::4:935d] has quit [Ping timeout: 252 seconds] 01:42 -!- greypw2 [~greypw2@grey.pw] has quit [Ping timeout: 252 seconds] 01:42 -!- moneyball_ [sid299869@id-299869.helmsley.irccloud.com] has joined #bitcoin-rust 01:42 -!- greypw2 [~greypw2@grey.pw] has joined #bitcoin-rust 02:07 -!- valwal3 [~valwal@70.107.207.192] has joined #bitcoin-rust 02:09 -!- MatrixBot1234510 [~matrixbot@51.15.54.153] has joined #bitcoin-rust 02:10 -!- mycroft [mycroft@abused.minithins.net] has joined #bitcoin-rust 02:14 -!- valwal [~valwal@70.107.207.192] has quit [Ping timeout: 252 seconds] 02:14 -!- MatrixBot1234514 [~matrixbot@51.15.54.153] has quit [Ping timeout: 252 seconds] 02:14 -!- mycroft- [mycroft@abused.minithins.net] has quit [Ping timeout: 252 seconds] 02:14 -!- valwal3 is now known as valwal 05:47 < ariard> BlueMatt: yeah I'll finish 1054 asap, though for more review bandwidth on 102, really unlikely, travel next week :/ 09:10 -!- stick_ is now known as stick 10:00 < BlueMatt> ariard: all good. I think we've got enough reviewers on the few things left for now :) 12:30 < ariard> BlueMatt: re: 1054: currently, i'm checking the sanity of our update_fee with commit_tx_fee(), though we have also next_local_commit_tx_fee_msat() which is a bit more restrictive at pending_outbound evaluation 12:30 < ariard> though that the utility we use to add fee_spikes_buffer 12:32 < BlueMatt> hmm, we should be looking at the next *remote* commitment tx fee 12:32 < BlueMatt> (well, *and* next local) 12:32 < BlueMatt> but basically everything where we're doing local checks should have a fee spike buffer 12:32 < BlueMatt> though obviously not remote message-receipt checks 12:33 < ariard> yeah i'm not doing checks on remote commitmen tx fee rn 12:33 < ariard> how much buffer we should give ? 1 HTLC or more 12:33 < BlueMatt> :shrug: 12:33 < ariard> okay one 12:33 < BlueMatt> maybe 2? I dunno, 2 seems like a good round number 12:33 < ariard> yes it's not relevant to do check on *current* commitment 12:34 < BlueMatt> right 12:37 < ariard> BlueMatt: though note we use commit_tx_fee_msat in commitment_signed, which sounds to me the symmetry of the new check in `send_update_fee` ? 12:41 < ariard> right, it's a different fee buffer than FEE_SPIKE_BUFFER_FEE_INCREASE_MULTIPLE, which is about doubling the feerate, here we just want 1 or 2 more in case remote send us more 13:36 < BlueMatt> right, its more "a few extra htlcs" not "a bit extra fee increase" 16:21 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 252 seconds] 16:33 -!- belcher [~belcher@user/belcher] has joined #bitcoin-rust --- Log closed Sat Oct 02 00:00:24 2021