--- Log opened Fri Nov 12 00:00:30 2021 00:50 -!- b10c [uid500648@ilkley.irccloud.com] has joined #bitcoin-rust 04:10 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has quit [Quit: Bridge terminating on SIGTERM] 04:10 -!- stick[m] [~stickmatr@2001:470:69fc:105::98c] has quit [Quit: Bridge terminating on SIGTERM] 04:10 -!- thomaseizinger [~thomaseiz@2001:470:69fc:105::16b2] has quit [Quit: Bridge terminating on SIGTERM] 04:10 -!- dpc[m] [~dpcmatrix@2001:470:69fc:105::1:2020] has quit [Quit: Bridge terminating on SIGTERM] 04:10 -!- RCasatta[m] [~rcasattam@2001:470:69fc:105::c85] has quit [Quit: Bridge terminating on SIGTERM] 04:27 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #bitcoin-rust 04:35 -!- stick[m] [~stickmatr@2001:470:69fc:105::98c] has joined #bitcoin-rust 04:35 -!- thomaseizinger [~thomaseiz@2001:470:69fc:105::16b2] has joined #bitcoin-rust 04:35 -!- RCasatta[m] [~rcasattam@2001:470:69fc:105::c85] has joined #bitcoin-rust 04:35 -!- dpc[m] [~dpcmatrix@2001:470:69fc:105::1:2020] has joined #bitcoin-rust 04:51 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has quit [Quit: Client limit exceeded: 20000] 04:51 -!- stick[m] [~stickmatr@2001:470:69fc:105::98c] has quit [Quit: Client limit exceeded: 20000] 04:52 -!- thomaseizinger [~thomaseiz@2001:470:69fc:105::16b2] has quit [Quit: Client limit exceeded: 20000] 07:33 < andytoshi> https://github.com/rust-bitcoin/rust-bitcoin/pull/677 needs another ack from a maintainer 07:33 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #bitcoin-rust 07:33 -!- thomaseizinger [~thomaseiz@2001:470:69fc:105::16b2] has joined #bitcoin-rust 07:33 -!- stick[m] [~stickmatr@2001:470:69fc:105::98c] has joined #bitcoin-rust 08:04 < sanket1729_> dr-orlovsky had acked it, but it's dismissed now since I updated the PR 08:31 -!- rish-singhal [~rish-sing@27.57.115.137] has joined #bitcoin-rust 08:32 -!- rish-singhal [~rish-sing@27.57.115.137] has quit [Client Quit] 10:29 -!- b10c [uid500648@ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity] 10:41 < BlueMatt> ariard: if you have 30 seconds, can you re-ack https://github.com/rust-bitcoin/rust-lightning/pull/1131#pullrequestreview-805118181 11:22 < dr-orlovsky> sanket1729_: re-ACKing in a moment 11:25 < sanket1729_> Thanks 11:25 < sanket1729_> I am looking to add the newly added test vectors from bip341. Is there is any convention in rust on where to place test data json files? 11:42 < dr-orlovsky> hm, I am not aware of it. May be test dir next to src? But it is usually used for integration tests 11:43 < dr-orlovsky> sanket1729_: can you pls re-ACK my old https://github.com/rust-bitcoin/rust-bitcoin/pull/654 - you already ACKed it a long time ago, but I had to re-base. It already have apoelstra ACK and we can merge it once you re-view such that Taproot PSBT structures can be done on top of this refactoring 11:43 < sanket1729_> dr-orlovsky: Looking at it 11:45 < andytoshi> dr-orlovsky: thanks for merging https://github.com/rust-bitcoin/rust-bitcoin/pull/637#event-5611647271 .. but in future can you pls use the bitcoin merge script https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/github-merge.py which signs the merge commits (and does a couple sanity checks) 11:46 < andytoshi> same to sanket1729_ with https://github.com/rust-bitcoin/rust-miniscript/pull/265#event-5611543733 .. though i feel less strongly about rust-miniscript :) 11:46 < dr-orlovsky> andytoshi: of course, I didn't know about that! Will use that in the future 11:48 < andytoshi> thanks! 11:48 < andytoshi> i have only recently started using it for rust-bitcoin crates 11:48 < andytoshi> but it is used (by policy) in bitcoin core and secp256k1 11:49 -!- enick_103 [~afilini-m@2001:bc8:1828:245::2] has quit [Quit: Bridge terminating on SIGTERM] 11:50 -!- enick_60 [~afilini-m@51.15.93.184] has joined #bitcoin-rust 11:51 < sanket1729_> Works like a charm 11:51 < sanket1729_> https://github.com/rust-bitcoin/rust-bitcoin/commit/abc242dfe14d389addd3ded8f386e6fe40916168 11:53 < andytoshi> awesome, thanks 11:54 < andytoshi> you can see it has a richer PR commit message, has a gpg signature, has a sha512 commit of the contents, and also when you use it it will list the ACKs (and checks that they are ACKs on the correct tip commit) 11:55 < dr-orlovsky> yep, I now understood that all those merge commit messages were not produced by hands (I was always thinking that it's a lot of work! :D 11:55 -!- AlienTrooper [~IZH@user/alientrooper] has joined #bitcoin-rust 11:55 < andytoshi> lol :) 11:55 < AlienTrooper> loool 11:57 < AlienTrooper> What is this? 11:57 < AlienTrooper> The rust of bitcoin? 11:57 < AlienTrooper> WTF 11:58 < AlienTrooper> Ohh hell, got it 12:09 < BlueMatt> pending discussion in the ldk meeting tomorrow, it looks like we may move rust-lightning to the lightningdevkit org on github. because we have the lightningdevkit.org website and the language bindings repos over there, it just seems to make more sense to put it all in an org. 12:09 < BlueMatt> unless someone here feels strongly otherwise we'll probably move forward on monday. 13:21 < dr-orlovsky> sanket1729_: thank you for the quick review & merge! 13:22 < sanket1729_> dr-orlovsky, Thanks for your work today! We made good progress. I am working on adding test vectors from bip341. and the psbt PR 13:23 < sanket1729_> I think we are close, will take a tracker issue and see what needs to be done to get a release 13:23 < dr-orlovsky> seems like we are really close to have taproot in rust bitcoin soon :) 13:23 < sanket1729_> Yeah 13:23 < dr-orlovsky> just updated the tracking issue 13:33 < andytoshi> BlueMatt: no complaints from me 14:25 -!- jeremyrubin [~jeremyrub@ec2-44-199-24-18.compute-1.amazonaws.com] has joined #bitcoin-rust 15:19 < ariard> BlueMatt: done, sgtm 15:30 < BlueMatt> ariard: thanks. lmk when you want me to re-review the update_fee limits. my understanding is you were still digging some 17:14 -!- elsirion [~quassel@gateway/tor-sasl/elsirion] has quit [Ping timeout: 276 seconds] 17:14 -!- elsirion_ [~quassel@gateway/tor-sasl/elsirion] has joined #bitcoin-rust 23:53 -!- kallewoof [~quassel@user/kallewoof] has quit [Ping timeout: 268 seconds] --- Log closed Sat Nov 13 00:00:31 2021