--- Log opened Thu Nov 18 00:00:39 2021
00:57 -!- b10c [uid500648@ilkley.irccloud.com] has joined #bitcoin-rust
05:43 -!- aitorjs [~biteskola@188.76.76.184] has joined #bitcoin-rust
05:50 < aitorjs> Hello! I'm preparing a PR to add custom signet as new Network. As custom signet has not a default network magic, I'm adding it as envirotment variable. ¿Could be ok? ¿Another way to do it? Thanks!
07:36 < BlueMatt> ariard: I'm not sure why it would be *bad* that we fail to send if we're trimmed to dust? Like, we shouldn't have gotten there to begin with, so failing to send in that case seems fine?
07:36 < BlueMatt> ariard: sorry just now in front of my computer
07:58 < BlueMatt> ariard: yea, I'm okay with pushing some followups, we do need to land it, but I'm really afraid that the current state here is just pretty bad, and this pr does make it a good chunk worse with more return values from build_commitment_transaction
07:59 < BlueMatt> so I'm okay with pushing some changes to a followup but I'd ideally like to get more things right in this pr if we can
08:24 -!- johncantrell97[m [~johncantr@2001:470:69fc:105::1:3780] has quit [K-Lined]
08:24 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has quit [K-Lined]
08:24 -!- thomaseizinger [~thomaseiz@2001:470:69fc:105::16b2] has quit [K-Lined]
08:24 -!- dpc[m] [~dpcmatrix@2001:470:69fc:105::1:2020] has quit [K-Lined]
08:24 -!- stick[m] [~stickmatr@2001:470:69fc:105::98c] has quit [K-Lined]
08:24 -!- RCasatta[m] [~rcasattam@2001:470:69fc:105::c85] has quit [K-Lined]
08:34 -!- RubenSomsen [sid301948@user/rubensomsen] has quit [Ping timeout: 265 seconds]
08:34 -!- RubenSomsen [sid301948@user/rubensomsen] has joined #bitcoin-rust
08:35 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #bitcoin-rust
08:36 -!- elichai2 [sid212594@hampstead.irccloud.com] has quit [Ping timeout: 264 seconds]
08:36 -!- notmandatory_ [~notmandat@shindig.notmandatory.org] has quit [Ping timeout: 264 seconds]
08:38 -!- notmandatory [~notmandat@shindig.notmandatory.org] has joined #bitcoin-rust
08:39 -!- moneyball_ [sid299869@helmsley.irccloud.com] has quit [Ping timeout: 256 seconds]
08:39 -!- arik [sid402902@lymington.irccloud.com] has quit [Ping timeout: 268 seconds]
08:39 -!- stick [sid403625@user/prusnak] has quit [Ping timeout: 250 seconds]
08:39 -!- jkczyz [sid419941@lymington.irccloud.com] has quit [Read error: Connection reset by peer]
08:39 -!- fjahr [sid374480@uxbridge.irccloud.com] has quit [Read error: Connection reset by peer]
08:39 -!- sebx2a [sid356034@uxbridge.irccloud.com] has quit [Read error: Connection reset by peer]
08:39 -!- blkncd [sid505676@helmsley.irccloud.com] has quit [Read error: Connection reset by peer]
08:39 -!- b10c [uid500648@ilkley.irccloud.com] has quit [Read error: Connection reset by peer]
08:40 -!- FelixWeis [sid154231@hampstead.irccloud.com] has quit [Read error: Connection reset by peer]
08:41 -!- blkncd [sid505676@helmsley.irccloud.com] has joined #bitcoin-rust
08:42 -!- arik [sid402902@lymington.irccloud.com] has joined #bitcoin-rust
08:43 -!- elichai2 [sid212594@hampstead.irccloud.com] has joined #bitcoin-rust
08:43 -!- FelixWeis [sid154231@hampstead.irccloud.com] has joined #bitcoin-rust
08:43 -!- thomaseizinger [~thomaseiz@2001:470:69fc:105::16b2] has joined #bitcoin-rust
08:43 -!- stick[m] [~stickmatr@2001:470:69fc:105::98c] has joined #bitcoin-rust
08:43 -!- RCasatta[m] [~rcasattam@2001:470:69fc:105::c85] has joined #bitcoin-rust
08:43 -!- moneyball_ [sid299869@helmsley.irccloud.com] has joined #bitcoin-rust
08:43 -!- b10c [uid500648@ilkley.irccloud.com] has joined #bitcoin-rust
08:43 -!- fjahr [sid374480@uxbridge.irccloud.com] has joined #bitcoin-rust
08:43 -!- johncantrell97[m [~johncantr@2001:470:69fc:105::1:3780] has joined #bitcoin-rust
08:43 -!- dpc[m] [~dpcmatrix@2001:470:69fc:105::1:2020] has joined #bitcoin-rust
08:44 -!- stick [sid403625@user/prusnak] has joined #bitcoin-rust
08:44 -!- jkczyz [sid419941@lymington.irccloud.com] has joined #bitcoin-rust
08:44 -!- sebx2a [sid356034@uxbridge.irccloud.com] has joined #bitcoin-rust
08:49 < BlueMatt> ariard: also if you dont have time to focus on the pr I'm more than happy to take it over and push it through. there's now at least 2-3 prs waiting on it to land
09:00 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has quit [Quit: Client limit exceeded: 20000]
09:00 -!- stick[m] [~stickmatr@2001:470:69fc:105::98c] has quit [Quit: Client limit exceeded: 20000]
09:01 -!- aitorjs [~biteskola@188.76.76.184] has quit [Ping timeout: 264 seconds]
09:01 -!- thomaseizinger [~thomaseiz@2001:470:69fc:105::16b2] has quit [Quit: Client limit exceeded: 20000]
16:09 < ariard> BlueMatt: https://github.com/rust-bitcoin/rust-lightning/pull/1054#discussion_r752378608 yeah i think it's missing my point that returning trimmed-to-dust change which check we fail, though will fail anyway on the chan_reserve one
16:10 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #bitcoin-rust
16:10 -!- thomaseizinger [~thomaseiz@2001:470:69fc:105::16b2] has joined #bitcoin-rust
16:10 -!- stick[m] [~stickmatr@2001:470:69fc:105::98c] has joined #bitcoin-rust
16:10 < ariard> BlueMatt: yeah okay modifying build_commitment_transaction to return balance post-fee, post-dust and constifying the whole 
16:11 < ariard> BlueMatt: hope we're good after that, though if you feel it's stucking to much stuff on top, feel free to take it!
16:36 < BlueMatt> ariard: nope, I think after that I'll probably be happy
16:36 < BlueMatt> I still need to spend more time with it
16:36 < BlueMatt> so no promises
16:36 < BlueMatt> but I think I'll be happy. my comment about timing is only because there's stuff waiting on it now, not neccessarily that I'm super duper pressed for time
16:36 < BlueMatt> and a goal I have right now is reducing outstanding pr count, cause we've let the count grow
16:43 < ariard> yeah i know we have also more contributors for still the same number of review bandiwdth, even less with me being less active
17:59 -!- b10c [uid500648@ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity]
17:59 -!- elsirion [~quassel@gateway/tor-sasl/elsirion] has quit [Remote host closed the connection]
18:00 -!- elsirion [~quassel@gateway/tor-sasl/elsirion] has joined #bitcoin-rust
18:55 < ariard> BlueMatt: introduced a CommitmentStats, should be a bit more lovely, lmk what you think whenever you have time
18:56 < ariard> BlueMatt: eager to do a last round to try to merge our get_inbound/outbound_htlcs and HTLCStats in build_commitment_tx, though dunno if we want to swallow the perf hit of the latter?
18:56 < ariard> like sorting htlc and memalloc of transaction building aren't nice
18:57 < BlueMatt> hmm, yea, ideally we'd slip the function into two parts and just use what we need, but I'm okay with pushing that to next pr, up to you
19:07 < ariard> yeah, i've tried doing that on an old branch a while back, happy to do it with the next pr :)
19:07 < ariard> we could just have a new arg do-not-build-the-commitment-transaction, just the stats
19:10 < BlueMatt> hmm, probably simpler to split the function in two if possible
19:21 -!- aitorjs [~biteskola@184.76.76.188.dynamic.jazztel.es] has joined #bitcoin-rust
19:27 -!- aitorjs [~biteskola@184.76.76.188.dynamic.jazztel.es] has quit [Ping timeout: 256 seconds]
19:48 < BlueMatt> ariard: okay! looks pretty good
19:48 < BlueMatt> left two pretty trivial comments, one just asking for a doc comment.
19:48 < BlueMatt> hopefully we can land when valwal gets a chance to look at it again tomorrow morning 🎉
--- Log closed Fri Nov 19 00:00:37 2021