--- Log opened Mon Nov 22 00:00:40 2021
01:28 -!- blkncd [sid505676@id-505676.helmsley.irccloud.com] has quit [Ping timeout: 268 seconds]
01:28 -!- arik [sid402902@id-402902.lymington.irccloud.com] has quit [Ping timeout: 268 seconds]
01:28 -!- sebx2a [sid356034@id-356034.uxbridge.irccloud.com] has quit [Ping timeout: 250 seconds]
01:28 -!- stick [sid403625@user/prusnak] has quit [Ping timeout: 264 seconds]
01:28 -!- RubenSomsen [sid301948@user/rubensomsen] has quit [Ping timeout: 264 seconds]
01:28 -!- fjahr [sid374480@id-374480.uxbridge.irccloud.com] has quit [Ping timeout: 245 seconds]
01:28 -!- elichai2 [sid212594@id-212594.hampstead.irccloud.com] has quit [Ping timeout: 268 seconds]
01:29 -!- fjahr [sid374480@uxbridge.irccloud.com] has joined #bitcoin-rust
01:29 -!- jkczyz [sid419941@id-419941.lymington.irccloud.com] has quit [Ping timeout: 265 seconds]
01:29 -!- moneyball_ [sid299869@id-299869.helmsley.irccloud.com] has quit [Ping timeout: 265 seconds]
01:29 -!- FelixWeis [sid154231@id-154231.hampstead.irccloud.com] has quit [Ping timeout: 268 seconds]
01:31 -!- jkczyz [sid419941@lymington.irccloud.com] has joined #bitcoin-rust
01:32 -!- elichai2 [sid212594@hampstead.irccloud.com] has joined #bitcoin-rust
01:33 -!- RubenSomsen [sid301948@user/rubensomsen] has joined #bitcoin-rust
01:33 -!- stick [sid403625@user/prusnak] has joined #bitcoin-rust
01:33 -!- FelixWeis [sid154231@hampstead.irccloud.com] has joined #bitcoin-rust
01:40 -!- moneyball_ [sid299869@id-299869.helmsley.irccloud.com] has joined #bitcoin-rust
01:42 -!- blkncd [sid505676@id-505676.helmsley.irccloud.com] has joined #bitcoin-rust
01:42 -!- arik [sid402902@id-402902.lymington.irccloud.com] has joined #bitcoin-rust
01:43 -!- sebx2a [sid356034@id-356034.uxbridge.irccloud.com] has joined #bitcoin-rust
02:24 -!- b10c [uid500648@id-500648.ilkley.irccloud.com] has joined #bitcoin-rust
08:42 -!- sanket_cell [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has joined #bitcoin-rust
08:54 < BlueMatt> ariard: wait, why is that a bug?
10:37 < sanket1729> looking for reviewers for PRs with milestone 0.28.0 taproot release
11:01 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 256 seconds]
11:52 -!- Netsplit *.net <-> *.split quits: kcalvinalvin
11:52 -!- Netsplit over, joins: kcalvinalvin
11:59 -!- belcher [~belcher@user/belcher] has joined #bitcoin-rust
13:02 < ariard> BlueMatt: ah sorry I misinterpreted this check, it doesn't aim to prevent hyper-inflation of the feerate ? like unexpected jumps by *4 or *8 ?
13:02 < ariard> iirc the inbound update_fee check enforces an upper bound on the new proposed feerate
13:03 < ariard> i though the check aim a < b or a *2 > b, and have the second altnerative to reject as an upper bound
13:06 < ariard> BlueMatt: so if our fee-estimator is buggy or compromised, we can propose unbounded, crazy feerate to our counterparty, correct ?
13:08 < BlueMatt> ah, yea, no, that check just prevents fee-updates every seconed
13:08 < BlueMatt> indeed, we do not do any bounds checks on the user fee estimator at all
13:08 < BlueMatt> we'll happily send the counterparty insanely high feerates, or ones under 253, violating spec
13:11 < ariard> ah not good, do we have issue opened bookmarking that?
13:12 < ariard> like your fee-estimator might be crap, not really robust against mempool manipulation like core
13:14 < BlueMatt> i think we do have an issue for it, but also there's ~nothing we can do. if the user fee estimator is garbage, we can only panic and abort
13:14 < BlueMatt> we can't really do anything to fix it, cause we *need* a fee estimator
13:14 < BlueMatt> we kinda just rely on user fee estimation being good, cause we cant do a lot better
13:15 < BlueMatt> hmm, dont see an issue for it now
13:15 < ariard> yea dont'see neither, opening
13:15 < ariard> we can verify fee bounds sanity ? but if it's halting or dysfunctional agree we're fucked
13:16 < BlueMatt> sure, i mean we can just panic, dont see why not, but that's about it
13:19 < ariard> yeah in that kind of situations, might be better to panic and send an alarm to the nice human operator
13:23 < BlueMatt> yea
13:29 -!- tibo [~tibo@240d:1a:afa:1d00:d59d:f4a1:63f8:739a] has quit [Read error: Connection reset by peer]
13:29 -!- tibo [~tibo@240d:1a:afa:1d00:d59d:f4a1:63f8:739a] has joined #bitcoin-rust
13:33 < ariard> BlueMatt: addressed your comment on 1054, there was a benchmark failure in ci though to the best of my understanding not related
13:34 < BlueMatt> yes, the benchmark ci failure is a rustc nightly regression
13:34 < BlueMatt> they're working on it
13:34 < ariard> oh we have a new "blocked on dependent pr" label
13:34 < BlueMatt> yea, trying to add some new labels to help people prioritize review
13:34 < BlueMatt> without me having to nag people with specific prs
13:35 < BlueMatt> gonna test it out and see how it works
13:36 < ariard> yeah i think the tagging with milestones work not that bad
13:36 < ariard> and tagging by sub-systems like Core we're def too early, even if I feel we start to specialize by code areas (at least speaking for myself)
13:38 < BlueMatt> yea, one issue is we don't generally have a lot of milestone-specific prs. like, we have a ton of "well, it'd be nice if this landed soon, but if it doesn't land asap that's okay, it can slip" so I've found it hard to tag milestones
14:32 < BlueMatt> https://github.com/rust-lang/team/pull/671 ouchie
15:01 < ariard> well somehow there is a quantum of solace seeing that foss drama isn't a pure bitcoiny thing :shrug:
15:07 < BlueMatt> lol
17:06 -!- b10c [uid500648@id-500648.ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity]
17:27 -!- greypw254 [~greypw2@grey.pw] has quit [Quit: I'll be back!]
17:28 -!- greypw254 [~greypw2@grey.pw] has joined #bitcoin-rust
18:09 -!- notmandatory [~notmandat@shindig.notmandatory.org] has quit [Ping timeout: 246 seconds]
18:09 -!- notmandatory_ [notmandato@2600:3c00::f03c:92ff:fe8e:dce6] has joined #bitcoin-rust
18:10 -!- elsirion [~quassel@gateway/tor-sasl/elsirion] has joined #bitcoin-rust
18:11 -!- elsirion_ [~quassel@gateway/tor-sasl/elsirion] has quit [Remote host closed the connection]
19:22 < ariard> yallah 1054 merged! shaking myself to not be as long on 1056 :p
23:44 < darosior> Has there previously been discussions around a feerate type in rust-bitcoin?
--- Log closed Tue Nov 23 00:00:41 2021